Commit graph

2402 commits

Author SHA1 Message Date
gregoirenovel
6afaf42e6a The "through" relation used in a HasManyThrough must be declared first 2018-01-30 16:40:04 +01:00
gregoirenovel
25aef60354 Use string interpolation 2018-01-30 15:50:52 +01:00
gregoirenovel
c9a79b4f08 Use map when possible 2018-01-30 15:50:52 +01:00
gregoirenovel
5b62bc4f12 Use transform_keys when possible 2018-01-30 15:45:32 +01:00
gregoirenovel
db8c3030e3 Use transform_values when possible 2018-01-30 15:45:32 +01:00
gregoirenovel
b2fe1b856c Use #sum instead of #inject when possible 2018-01-30 15:45:32 +01:00
Frederic Merizen
c15e1a6942 [Fix #1374] Add missing parameter
Dossier pagination was only working for dossiers en construction.
2018-01-30 15:04:21 +01:00
Frederic Merizen
0ce26055d8 [#1374] Revert "Merge pull request #1373 from betagouv/fix_pagination"
This reverts commit 5a56fe0182, reversing
changes made to 31aabcd6b6.
2018-01-30 15:04:21 +01:00
Mathieu Magnin
50abb36c81 [Fix #1309] Format datetime before save 2018-01-30 13:49:16 +01:00
Mathieu Magnin
dcb38d79a3 [Fix #1309] Datetime value should be print with yyyy-mm-dd format 2018-01-30 13:49:16 +01:00
Paul Chavard
fdd6cedeb8 Remove data_provide and data_date_format attributes 2018-01-30 13:49:16 +01:00
simon lehericey
691b12688d Revert "[#1360] Upgrade SmartListing to fork of 1.2.1"
This reverts commit 506a505477.
2018-01-29 17:43:30 +01:00
Mathieu Magnin
ce5ce78eff [Fix #1291] Add CGU link to invite_admin mail template 2018-01-29 11:08:20 +01:00
Mathieu Magnin
11dbc595c7 Store in constant CGU url 2018-01-29 11:08:19 +01:00
Frederic Merizen
506a505477 [#1360] Upgrade SmartListing to fork of 1.2.1 2018-01-25 17:47:10 +01:00
gregoirenovel
1c78d77c30 Bump default gems
- haml-rails
- jquery-rails
- unicorn
- openid_connect
- omniauth-github (dependencies)
- fog
- mailjet
- smart_listing
- spreadsheet_architect
- apipie-rails
- maruku
- openstack
- browser
- skylight
- simple_form
- scenic
- daemons
- sentry-raven
- administrate (dependencies)
- logstasher
- chartkick
- font-awesome-rails
2018-01-23 16:26:56 +01:00
gregoirenovel
d2f7c655d7 Bump development gems
- brakeman
- web-console
- xray-rails
- haml-lint
- scss_lint
2018-01-23 16:26:56 +01:00
Mathieu Magnin
469aca999b Revert "Remove data_provide and data_date_format attributes"
This reverts commit 273b3f2faf.
2018-01-19 13:20:53 +01:00
Mathieu Magnin
e9ec9e410f [Fix #1304] If procedure has no path do not crash when hiding it 2018-01-18 18:52:54 +01:00
Frederic Merizen
9b4ce1517c Use lambda instead of send for etablissement tag 2018-01-18 18:35:07 +01:00
Frederic Merizen
8f41ab89cf [#1203] Do not include champs privés in accusé de réception 2018-01-18 18:26:14 +01:00
Frederic Merizen
a21dee680d [#1203] Define tags in constants rather than methods 2018-01-18 18:26:14 +01:00
Frederic Merizen
db5bf39e32 [#1203] No implicit available_for_states, make it explicit 2018-01-18 18:26:14 +01:00
Frederic Merizen
21ad13cf74 [#1203] Make all tags multi-line 2018-01-18 18:26:14 +01:00
Frederic Merizen
943fef3160 [#1203] Move all tag definitions to mail template concern
Even the one that is mail-specific, because it is too easy to overlook
it when refactoring otherwise
2018-01-18 18:26:14 +01:00
Frederic Merizen
eebab14954 [Fix #1203] No début d’instruction tag in accusé de réception mails
Doesn’t make sense functionnally
2018-01-18 18:26:14 +01:00
Frederic Merizen
9f7ffddb31 [#1203] Allow filtering tags based on an arbitray status 2018-01-18 18:26:14 +01:00
Paul Chavard
26b1de5883 [Closes #1170] Put tps-dev (staging) environement behind a BasicAuth 2018-01-18 18:09:46 +01:00
gregoirenovel
5723c4c894 Remove any reference to the SGMAP 2018-01-18 17:39:56 +01:00
Mathieu Magnin
d945001e0a [Fix #1302] sanitize_url can deal with nil values 2018-01-18 17:35:19 +01:00
Paul Chavard
e42626c588 Add user info to LogStasher 2018-01-18 17:14:42 +01:00
Paul Chavard
273b3f2faf Remove data_provide and data_date_format attributes 2018-01-18 15:13:48 +01:00
gregoirenovel
f6c0edc5a3 [Fix #1292] Link to avis, not dossier for expert search results 2018-01-18 11:22:08 +01:00
gregoirenovel
813844f9db Enable the Layout/TrailingWhitespace cop 2018-01-18 10:55:08 +01:00
gregoirenovel
d30ea70c08 Enable the Layout/SpaceInsideParens cop 2018-01-18 10:53:35 +01:00
gregoirenovel
b138dcd876 Enable the Layout/SpaceInsideHashLiteralBraces cop 2018-01-18 10:53:35 +01:00
gregoirenovel
897a30da0c Enable the Layout/SpaceInsideBlockBraces cop 2018-01-18 10:53:34 +01:00
gregoirenovel
9ea1106503 Enable the Layout/SpaceInLambdaLiteral cop 2018-01-18 10:53:34 +01:00
gregoirenovel
3e93bd3615 Enable the Layout/SpaceBeforeComma cop 2018-01-18 10:53:34 +01:00
gregoirenovel
2814fcf27e Enable the Layout/SpaceAroundKeyword cop 2018-01-18 10:53:34 +01:00
gregoirenovel
278a662350 Enable the Layout/SpaceAroundEqualsInParameterDefault cop 2018-01-18 10:53:34 +01:00
Mathieu Magnin
307d7338e5 Remove unreachable code 2018-01-18 10:32:39 +01:00
Mathieu Magnin
11b055e07c Rename reinvite action in controller 2018-01-18 10:04:34 +01:00
Mathieu Magnin
14b8ac614f Redirect to sign_in if not logged in 2018-01-17 18:04:24 +01:00
Mathieu Magnin
ae1498d786 Add some attributes in Administrateur dashboard 2018-01-17 18:04:24 +01:00
Mathieu Magnin
d9feb4be06 Move sign_in behind /manager (not in namespace due to Administrate resources autoloading) 2018-01-17 18:04:23 +01:00
Mathieu Magnin
d5c036362b Remove old controller and templates 2018-01-17 18:04:23 +01:00
Mathieu Magnin
a5aeaf988a Add delayed_job link in sidebar 2018-01-17 18:04:23 +01:00
Mathieu Magnin
3aa6357d66 Show 20 procedures in administrateur#show (default was 5) 2018-01-17 18:04:22 +01:00
Mathieu Magnin
ef0907db93 Add flash when resending invitation 2018-01-17 18:04:22 +01:00
Mathieu Magnin
4f756975c7 Move administrateur#update in Administrate 2018-01-17 18:04:21 +01:00
Mathieu Magnin
a6be13ac5e Redirect if success, else render form with errors (https://github.com/thoughtbot/administrate/blob/master/app/controllers/administrate/application_controller.rb#L43) 2018-01-17 18:04:21 +01:00
Mathieu Magnin
67f89d5f86 Move administrateur creation in Administrate 2018-01-17 18:04:21 +01:00
Mathieu Magnin
0396db9e5f Clean Administrate templates and controllers 2018-01-17 18:04:20 +01:00
Simon Lehericey
1b91641f9a FC ParticulierController: remove exotic route 2018-01-17 16:37:26 +01:00
Simon Lehericey
d70b6f4af0 FC ParticulierController: cleaner update attribute 2018-01-17 16:37:26 +01:00
simon lehericey
4f86b6305b FC ParticulierControllerSpec: callback handle empty string 2018-01-17 16:37:26 +01:00
simon lehericey
02dd1e209c FC ParticulierController: implement auto reconciliation based on user email 2018-01-17 16:37:26 +01:00
simon lehericey
ecfb0f4ec2 FC ParticulierController: move defense logic to before_action 2018-01-17 16:37:26 +01:00
Simon Lehericey
4afc41bca2 FC ParticulierController: inline fci.user 2018-01-17 16:37:26 +01:00
simon lehericey
d348e5fde0 FC ParticulierController: smaller variable 2018-01-17 16:37:26 +01:00
simon lehericey
c6c4dd7c7e FC ParticulierController: use find or tap 2018-01-17 16:37:26 +01:00
simon lehericey
7cbd6ed067 FC ParticulierController: create is private
yep, I know this is strange
2018-01-17 16:37:26 +01:00
Paul Chavard
6a43248cb3 Fix CSS injection 2018-01-16 14:02:10 +01:00
gregoirenovel
7c93b2a0c2 .map -> .pluck when possible 2018-01-16 13:23:29 +01:00
gregoirenovel
80ed589a17 Use string interpolation 2018-01-16 11:08:57 +01:00
gregoirenovel
83be054884 .map.flatten -> .flat_map 2018-01-16 11:08:56 +01:00
gregoirenovel
c3754a173f Use map instead of inject 2018-01-16 11:08:56 +01:00
gregoirenovel
16254899e1 [Fix #1199] Make id search work for experts 2018-01-16 11:03:53 +01:00
gregoirenovel
d33d488db7 Avoid EOL if statements 2018-01-16 11:01:52 +01:00
gregoirenovel
a050bc20de Add a dossiers_from_avis relation to Gestionnaire 2018-01-16 11:01:52 +01:00
Paul Chavard
bbf55ab85e Create administrateurs with invitation link and no password 2018-01-16 10:49:07 +01:00
Paul Chavard
0cf40f4f18 Add invitation related methods to administrateur model 2018-01-16 10:49:07 +01:00
Paul Chavard
5a984a3637 Add admin invitation mailer 2018-01-16 10:49:07 +01:00
gregoirenovel
73dd58b6cd Enable the Layout/MultilineMethodCallIndentation cop 2018-01-15 22:33:13 +01:00
gregoirenovel
b77837bfd1 Enable the Layout/MultilineMethodCallBraceLayout cop 2018-01-15 22:33:13 +01:00
gregoirenovel
9d75526460 Enable the Layout/MultilineAssignmentLayout cop 2018-01-15 22:33:13 +01:00
gregoirenovel
14c1747645 Enable the Layout/MultilineArrayBraceLayout cop 2018-01-15 22:33:13 +01:00
gregoirenovel
345b892956 Enable the Layout/LeadingCommentSpace cop 2018-01-15 22:33:13 +01:00
gregoirenovel
1e71188d4d Enable the Layout/IndentationConsistency cop 2018-01-15 22:33:13 +01:00
gregoirenovel
0be657c0d7 Enable the Layout/IndentHash cop 2018-01-15 22:33:12 +01:00
gregoirenovel
3363e21427 Enable the Layout/IndentAssignment cop 2018-01-15 22:33:12 +01:00
gregoirenovel
9e0e553f80 Enable the Layout/IndentArray cop 2018-01-15 22:33:12 +01:00
gregoirenovel
5125cf8396 Enable the Layout/FirstParameterIndentation cop 2018-01-15 22:14:39 +01:00
gregoirenovel
9f855afdfe Enable the Layout/FirstHashElementLineBreak cop 2018-01-15 22:14:38 +01:00
gregoirenovel
08ed400ec2 Enable the Layout/FirstArrayElementLineBreak cop 2018-01-15 22:14:38 +01:00
simon lehericey
d086b82d44 FC ParticulierController: remove one return 2018-01-15 17:14:12 +01:00
simon lehericey
34bd3a11e9 FC ParticulierController: remove superfluous if 2018-01-15 17:14:12 +01:00
simon lehericey
02395e732c FC service: return domain info 2018-01-15 17:14:12 +01:00
simon lehericey
7024e14d1c FC information: remove funny find_by 2018-01-15 17:14:12 +01:00
simon lehericey
8e26a50f16 FC service: clean syntax 2018-01-15 17:14:12 +01:00
simon lehericey
e68fc0811f FC ParticulierController: callback syntax cleaning 2018-01-15 17:14:12 +01:00
simon lehericey
9dc242d907 FC Particulier Controller: simplier login 2018-01-15 17:14:12 +01:00
simon lehericey
fc4ce4460c FC Particulier Controller: do not parse an URI into URI 2018-01-15 17:14:12 +01:00
simon lehericey
f8519c5345 FC initializers: remove Hashie 2018-01-15 17:08:38 +01:00
simon lehericey
ec69be0f7b FC ParticulierClient: simplier initializer 2018-01-15 17:00:26 +01:00
Simon Lehericey
0d46f92795 FC: move FC constants under particulier namespace 2018-01-15 16:59:50 +01:00
simon lehericey
4c2da46dd8 FC ParticulierClient: simplier initialize 2018-01-15 16:59:48 +01:00
Simon Lehericey
8c487c65a9 FC: remove unused code 2018-01-15 11:27:56 +01:00
gregoirenovel
1368cd4b03 [Fix #1120] Delete the old accompagnateur UI 2018-01-15 10:02:10 +01:00
gregoirenovel
3593adbe66 !foo.empty? -> foo.present? 2018-01-12 11:32:43 +01:00
gregoirenovel
aedafbaf2e !foo.blank? -> foo.present? 2018-01-12 11:32:43 +01:00
gregoirenovel
bbaebe0602 !foo.nil? -> foo.present? 2018-01-12 11:32:43 +01:00
gregoirenovel
7c34807f46 Don’t use unless 2018-01-12 11:32:43 +01:00
Mathieu Magnin
e3ec8643db In manager display libelles with line breaks 2018-01-11 11:03:34 +01:00
Frederic Merizen
32be8213da [#1209] Make sure date de dépôt is available before sending mail 2018-01-10 18:31:55 +01:00
Mathieu Magnin
f772adc582 Add flash when procedure is whitelisted 2018-01-10 18:17:05 +01:00
Mathieu Magnin
1ebaab51de Show procedure.whitelisted_at in administrate 2018-01-10 18:17:05 +01:00
Mathieu Magnin
4c0592d631 Rails-ish route 2018-01-10 18:17:05 +01:00
gregoirenovel
608a8eaf67 Abstract the Procedure whitelisting 2018-01-10 17:58:10 +01:00
gregoirenovel
289461d708 Handle the GitHub org rename: sgmap -> betagouv 2018-01-10 17:26:25 +01:00
Simon Lehericey
6f0c3ebc11 Whitelist: send the alert mail to equipe 2018-01-10 17:18:44 +01:00
simon lehericey
53687bf84a Whitelist: add whitelist button in admin 2018-01-10 17:18:44 +01:00
Simon Lehericey
202d0489a1 Whitelist: links from mail to admin 2018-01-10 17:18:44 +01:00
Mathieu Magnin
440c2b5dd1 [Fix #1098] add administrate custom layout to add logout link 2018-01-10 13:44:02 +01:00
Mathieu Magnin
d8d2ecf515 [Fix #1098] Administrateur dashboard 2018-01-10 13:44:02 +01:00
Mathieu Magnin
c7b3bb0733 [Fix #1098] Custom TypesDePieceJustificativeField for Administrate 2018-01-10 13:44:01 +01:00
Mathieu Magnin
51b94e2f53 [Fix #1098] Custom TypesDeChampCollectionField for Administrate 2018-01-10 13:44:01 +01:00
Mathieu Magnin
65f0859357 [Fix #1098] Using custom views to remove edit and delete button from index
This can be reverted when Administrate gem will include this fix : https://github.com/thoughtbot/administrate/pull/597 (>=0.5.0)
2018-01-10 13:44:00 +01:00
Mathieu Magnin
d0de9b9ae2 [Fix #1098] Add procedures dashboard 2018-01-10 13:44:00 +01:00
Simon Lehericey
1473577131 [fix #1033] Procedure Edition: add position field to order the champs 2018-01-10 13:27:22 +01:00
Frederic Merizen
56749769d6 [Fix #1186] Rename object to subject for mail templates 2018-01-09 16:00:31 +01:00
Frederic Merizen
7f040a5cf8 [Fix #1037] Add date tags to mail / attestation templates
- date de dépôt
- date de passage en instruction
2018-01-09 11:30:54 +01:00
Frederic Merizen
935a38bde0 [#1037] Introduce format-date function 2018-01-09 11:30:54 +01:00
gregoirenovel
fdf240cf31 Improve the wording on the “New from existing” page 2018-01-09 11:07:26 +01:00
gregoirenovel
c77558aeed Correctly handle errors when cloning someone else’s procedure 2018-01-09 11:07:26 +01:00
gregoirenovel
a1275af55f Use the path helper in the new procedure template 2018-01-09 11:05:19 +01:00
gregoirenovel
093d853ecc Fix some buggy error handling code in Admin::ProcedureController#clone 2018-01-09 11:05:19 +01:00
Frederic Merizen
63ca52792b [#1110] Remove legacy tags 2018-01-09 10:39:10 +01:00
simon lehericey
2bc61f9f3f [fix #1097] Accent insensitive search 2018-01-09 10:29:54 +01:00
simon lehericey
6a2b575027 [fix #1097] Add whitelist mechanisme to procedure 2018-01-09 10:29:54 +01:00
simon lehericey
f1b7a03b63 [fix #1097] Add job to monitor procedures 2018-01-09 10:29:54 +01:00
simon lehericey
d7d5d7eff4 Rename new_admin_mailer to administration_mailer 2018-01-09 10:29:54 +01:00
gregoirenovel
3f2876faf6 [Fix #1129] Simplify the terms checkbox message 2018-01-08 17:14:51 +01:00
gregoirenovel
301eb411cd Remove two opensimplif-related files
They seem unused
2018-01-08 17:03:41 +01:00
Mathieu Magnin
04e9f7be3e [Fix #1149] Move avis actions to new gestionnaire controller 2018-01-08 16:50:15 +01:00
gregoirenovel
bf5e21d6de [Fix #1182] Add a “create new procedure from an existing one” feature 2018-01-08 14:55:07 +01:00
gregoirenovel
27a8aba53e Allow the cloning of another admininistrateur’s procedure 2018-01-08 14:55:07 +01:00
gregoirenovel
ec5b9c86ce Add the admin argument to Procedure#clone 2018-01-08 14:55:07 +01:00
Frederic Merizen
75a3d0f3db [#1110] use modern rather than legacy tags in default mail templates 2018-01-05 17:42:25 +01:00
Frederic Merizen
deea23139f [#1110] Use TagsSubstitutionConcern as engine for mail template tags 2018-01-05 17:42:25 +01:00
Frederic Merizen
ab63f80080 [#1110] Motivation and date de décision are only tags for terminé dossiers 2018-01-05 16:35:29 +01:00
Frederic Merizen
e985439416 [#1110] Use tags method rather than ALLOWED_TAGS class constant 2018-01-05 12:48:07 +01:00
Frederic Merizen
b9a1f707f5 [#1110] name => libelle in mail templates
to match attestation templates
2018-01-05 12:48:07 +01:00
Frederic Merizen
8d77cd58c6 [#1110] Make linked procedure available to mail model 2018-01-05 12:48:07 +01:00
Frederic Merizen
ad0462f7ff [#1110] Port libellé procédure tag from mail templates 2018-01-05 11:51:08 +01:00
Frederic Merizen
ee109b24e3 [#1110] Port date de décision tag from mail templates 2018-01-05 11:51:08 +01:00
Frederic Merizen
6a85094e1a [#1110] Make processed_at date available for attestation generation 2018-01-05 11:51:08 +01:00
Frederic Merizen
3dfc37826a [#1110] Extract document template concern from attestation template class 2018-01-05 10:57:27 +01:00
Frederic Merizen
b603af1ec7 [#1110] Simplification: directly use symbols 2018-01-04 16:20:08 +01:00