Pierre de La Morinerie
8d89ae366b
specs: minor cleanups
2021-11-23 08:07:07 +01:00
Pierre de La Morinerie
09ca70eef0
specs: improve search controller specs
2021-11-23 08:07:07 +01:00
Paul Chavard
e934d6ea30
Merge pull request #6657 from betagouv/sentry-ignore-parse-errors
...
GraphQL : affiche la cause des erreurs de syntaxe des requêtes
2021-11-22 17:05:24 +03:00
Pierre de La Morinerie
859a147c49
api: return error cause on parse error
...
Currently, when a query can't be parsed, the error is:
- logged to Sentry (which is useless to us),
- returned as a generic 'Internal Server Error' (which is useless to the
user who made the query).
With this commit, the error is instead ignored from our logs (because it
is a user error), but the parse error details are returned to the user,
with the following format:
> {'errors': [{'message': 'Parse error on ")" (RPAREN) at [3, 23]'}]}
2021-11-19 15:15:10 +01:00
Paul Chavard
2e4635c786
Merge pull request #6650 from tchak/fix-champ-commune
...
fix(champs): save departement info on champ commune
2021-11-17 17:00:51 +03:00
Paul Chavard
ae09b37e72
fix(champs): save departement info on champ commune
2021-11-17 14:52:47 +03:00
LeSim
333a4029af
Merge pull request #6639 from betagouv/bump_js_dep
...
bump all the js
2021-11-17 09:31:52 +01:00
simon lehericey
f1855e4be1
bump all the js
2021-11-17 09:28:00 +01:00
mfo
31089440db
Merge pull request #6636 from betagouv/6624/etq-instructeur-je-souhaite-supprimer-des-messages-envoyes-par-erreur
...
6624/etq-instructeur-je-souhaite-supprimer-des-messages-envoyes-par-erreur 🚀
2021-11-17 05:52:35 +01:00
mfo
82b23b92c0
Merge branch 'main' into 6624/etq-instructeur-je-souhaite-supprimer-des-messages-envoyes-par-erreur
2021-11-17 05:41:56 +01:00
Paul Chavard
deaf26341d
Merge pull request #6644 from tchak/fix-renew-token
...
fix(profile): prevent crashing on renew token action
2021-11-16 20:06:23 +03:00
Paul Chavard
716a859c93
fix(profile): prevent crashing on renew token action
2021-11-16 20:01:56 +03:00
Paul Chavard
ea15c94e2d
Merge pull request #6630 from tchak/feat-allow-admin-to-change-duree_conservation_dossiers_dans_ds
...
fix(procedure): allow to modify duree_conservation_dossiers_dans_ds after publication
2021-11-16 19:59:50 +03:00
Paul Chavard
e74d599042
feat(procedure): remove duree_conservation_dossiers_hors_ds
2021-11-16 19:55:56 +03:00
Paul Chavard
65e59b8dcd
fix(procedure): allow to modify duree_conservation_dossiers_dans_ds after publication
2021-11-16 19:55:56 +03:00
Paul Chavard
a859726686
Merge pull request #6635 from tchak/fix-dossier-traitements
...
Corriger l'affichage des traitements d'un dossier
2021-11-16 19:09:58 +03:00
Paul Chavard
406c5a61cc
fix(dossier): fix dossier traitements display
2021-11-16 19:00:20 +03:00
Paul Chavard
04e67ea20a
fix(dossier): add instructeur email to traitements when available
2021-11-16 19:00:20 +03:00
Paul Chavard
3b82ea0632
Merge pull request #6645 from tchak/fix-attach-piece-justificative
...
fix(champs): attach piece justificative
2021-11-16 18:52:35 +03:00
mfo
1d174df2ec
Merge branch 'main' into 6624/etq-instructeur-je-souhaite-supprimer-des-messages-envoyes-par-erreur
2021-11-16 16:37:15 +01:00
Martin
c24bc45137
clean(trads): remove unused i18n
2021-11-16 16:25:32 +01:00
Martin
f0950b592b
clean(CommentaireService): extract soft delete within controller. returning an instance with an error[:base] is not persisted with validation : avoid poluting stuff
2021-11-16 16:13:11 +01:00
Paul Chavard
3400c4c628
fix(champs): attach piece justificative
2021-11-16 17:57:41 +03:00
Martin
8bbd77f89f
refactor(mail.delay): use simplier implementation using after_action to prevent email delivery with delay
2021-11-16 15:12:05 +01:00
Paul Chavard
d118577564
Merge pull request #6632 from tchak/feat-admin-can-disable-routage
...
feat(routage): administrateur can disable routage
2021-11-16 17:11:15 +03:00
Martin
e48b6e0c1f
tech(lint): rubocop
2021-11-16 14:30:06 +01:00
Martin
0aecc301c9
refactor(Commentarie.soft_delete): use discard
2021-11-16 14:28:38 +01:00
Paul Chavard
7914775809
feat(routage): administrateur can disable routage
...
fix #6627
2021-11-16 11:49:51 +03:00
Martin
988fe34d0a
fix(spec): add missing double
2021-11-16 03:42:31 +01:00
Paul Chavard
a46dd59f3f
Merge pull request #6642 from betagouv/fix_merge_pb
...
Merge des comptes avec des fichiers cachés
2021-11-16 01:32:34 +03:00
simon lehericey
e3c1e19424
include hidden dossier in merge
2021-11-15 23:14:41 +01:00
mfo
08350f394e
feat(mails): send it on mailer queue
2021-11-15 16:19:46 +01:00
Martin
ddabed0c7e
fix(refactor): continue to revert to past implementation. now use a job instead of calling deliver_later(wait: 5.minutes) [was not a satisfying implementation]
2021-11-15 15:45:48 +01:00
Martin
5534c3fbd6
fix(refactor): forgot to cleanup former implementation
2021-11-15 15:43:51 +01:00
Martin
5b6bb5171c
tech(lint): rubocopify
2021-11-15 15:42:20 +01:00
LeSim
c9b154929f
Merge pull request #6637 from betagouv/fix_profil_bug
...
small fix on profil
2021-11-15 15:40:38 +01:00
Martin
c68fa2d7f3
feat(Commentaire.notify_user): wait 5 minutes before sending email to user when instructor write a commentaire. leaving some space for instructor to destroy his message
2021-11-15 15:38:57 +01:00
Martin
f8783c9f00
fix(spec): stop doing time comparisson, ensure it is not more nil
2021-11-15 15:23:57 +01:00
Martin
46fc956de3
fix(refactor): forgot to pass var, classy
2021-11-15 15:01:56 +01:00
Martin
a74ca8ad39
fix(spec): scope out time as reference for time comparission, hope not a matter of precision
2021-11-15 14:55:35 +01:00
Martin
f1293814a3
fix(spec): apparently we do store time with zone
2021-11-15 14:35:43 +01:00
Martin
4042d51d1a
tech(lint): rubocopify
2021-11-15 14:17:57 +01:00
Martin
d4c74b5621
feat(rc.1): refine with better translations, better design
2021-11-15 14:15:05 +01:00
Martin
3b78a9d81a
feat(rc): first stable
2021-11-15 13:53:32 +01:00
simon lehericey
15d4c4c7b0
small fix on profil
2021-11-15 13:51:26 +01:00
Martin
8b931a57d4
feat(CommentairesController#destroy): implement destroy endpoint using CommentaireService
2021-11-15 13:18:10 +01:00
Martin
9d666b32bc
fix(missing_file): add missing migration
2021-11-15 13:17:11 +01:00
Martin
c7bfd1af04
feat(CommentaireService.soft_delete): ensure it purge piece_jointe later
2021-11-15 12:59:38 +01:00
Martin
9a8ec1087c
feat(commentaire.soft_delete): wrap deletion behaviour in service
2021-11-15 12:43:53 +01:00
Martin
5b72bdec7e
fix(Commentaire.sent_by?): &.email compared to nil could sent by true when nil==nil, avoid this one
2021-11-15 12:01:56 +01:00
