Commit graph

10511 commits

Author SHA1 Message Date
Christophe Robillard
f5d77a528c refactor(attestation_template): make code more readable
Co-Authored-By: simon lehericey <mail@simon.lehericey.net>
2023-09-29 15:37:24 +02:00
Colin Darie
eb3878b288
style(form): add spacing above label when scrolling to anchor 2023-09-29 15:20:14 +02:00
krichtof
1ef9ea0a96
Merge pull request #9524 from demarches-simplifiees/9502-contact-admin-sans-siret
Notifier par mail les admin de services sans siret
2023-09-29 12:11:42 +00:00
mfo
af6fd9d14c
Merge pull request #9531 from colinux/fix-form-markup
ETQ usager le formulaire est aéré grâce au bon markup du DSFR
2023-09-29 12:04:59 +00:00
Colin Darie
04071073e5 refactor(instructeurs): faster procedures listing 2023-09-29 13:09:54 +02:00
Christophe Robillard
20d70d2b1c notify admin with service without siret 2023-09-29 11:37:34 +02:00
Colin Darie
8ad87de461
Merge pull request #9539 from colinux/fix-admin-publish-order-buttons
ETQ admin le bouton de publication des modifications passe à gauche
2023-09-29 08:16:37 +00:00
Colin Darie
f942610d32
Merge pull request #9473 from demarches-simplifiees/create-export-page-V2-ldu
[Export] Créer une page d'export et sortir les liens des dropdowns
2023-09-28 17:15:31 +00:00
mfo
e1fe1188de
Merge pull request #9491 from mfo/US/better-error-summary
amelioration(usagers.dossiers.erreurs): ETQ usager, lorsque je soumets un dossier avec des erreurs, le format des erreurs est au format du DSFR
2023-09-28 17:01:09 +00:00
Colin Darie
a835990f74 fix(admin): publish button of new version must be aligned before reset 2023-09-28 18:38:03 +02:00
Colin Darie
95ceee38c7
chore(form): don't try to put invalid group classes for non fillable inputs 2023-09-28 18:33:28 +02:00
Colin Darie
60882e0844
chore(form): respect dsfr fr-fieldset and elements expected markup 2023-09-28 18:33:26 +02:00
Martin
d8220395c8 amelioration(usagers.dossiers.erreurs): ETQ usager, lorsque je soumets un dossier avec des erreurs, le format des erreurs est au format du DSFR
Update app/components/dossiers/errors_full_messages.rb
Update app/components/dossiers/errors_full_messages/errors_full_messages.html.haml

Co-authored-by: Colin Darie <colin@darie.eu>
2023-09-28 17:50:47 +02:00
Colin Darie
0920b97e4d fix(admin/archives): fix markup axe issue 2023-09-28 15:34:09 +02:00
Colin Darie
75bf30bed2
feat(champ-numbers): format value in input to a backend compatible value 2023-09-28 15:26:35 +02:00
Colin Darie
123114be81
fix(conditional): don't .to_i/to_f => 0 an invalid number 2023-09-28 15:26:34 +02:00
Colin Darie
aac7de208f
chore(champs-number): render as text input to validate them when invalid
Les input=number n'ont pas de value lorsque la valeur saisie n'est pas un
nombre. Par conséquent dans ces cas là, nous ne pouvions faire remonter
au backend pour validation / enregistrement, et il n'y avait aucun
feedback signalement l'erreur à l'usager.

On les convertit en inputs texte, avec les adaptations nécessaires
pour montrer le pavé numérique sur mobile, et un style correct.
2023-09-28 15:26:33 +02:00
Colin Darie
d4198869fb
chore(exports): dropdown menu re-uses the same pending export or create a fresh one
Pour permettre d'avoir des données fraiches dans un export tout
en conservant l'historique des exports,
la demande d'export depuis le menu créé toujours un nouvel export sauf:
- si un autre export identique est déjà en préparation
- si un autre export identique s'est terminé il y a moins de 5 minutes

Co-Authored-By: Lisa Durand <lisa.c.durand@gmail.com>
2023-09-28 15:23:31 +02:00
Colin Darie
d9687f7418
chore(exports): minor wording improvements and clarifications 2023-09-28 12:35:26 +02:00
Colin Darie
ec46faf690
fix(exports): don't duplicate exports when belonging to multiple groupe instructeurs 2023-09-28 12:35:24 +02:00
mfo
00a6d02d21
fix(exports): block exports page to super admins so they can't download exports 2023-09-28 12:35:23 +02:00
Colin Darie
2283c7eba7
test(exports): minimal coverage for ExportLinkComponent 2023-09-28 12:35:22 +02:00
Colin Darie
daa8eac9cc
style(exports): download link instead of button 2023-09-28 12:35:21 +02:00
Colin Darie
307ba68970
feat(exports): humanize status name 2023-09-28 12:35:20 +02:00
Colin Darie
3af93735a3
feat(exports): turbo poll for pending exports 2023-09-28 12:35:19 +02:00
Colin Darie
ed057737a5
feat(exports): name the dossiers count 2023-09-28 12:35:18 +02:00
Lisa Durand
c7cd5d2189
improve UX for export page 2023-09-28 12:35:16 +02:00
Lisa Durand
58a143b2c7
improve wording and display for export page 2023-09-28 12:35:15 +02:00
Lisa Durand
282df1b44b
add link to export page in flash message for instructeur 2023-09-28 12:35:14 +02:00
Colin Darie
a867c9a998
feat(instructeurs): notification badge when a new export has been generated
Co-Authored-By: Lisa Durand <lisa.c.durand@gmail.com>
2023-09-28 12:35:13 +02:00
Colin Darie
99f5b39dbb
fix(exports): force regenerate export with same statut filter
Co-Authored-By: Lisa Durand <lisa.c.durand@gmail.com>
2023-09-28 12:35:12 +02:00
Colin Darie
edb030bb4c
refactor(exports): regenerating exports redirect (back) to exports page
Co-Authored-By: Lisa Durand <lisa.c.durand@gmail.com>
2023-09-28 12:35:11 +02:00
Colin Darie
ca0b5c9cb9
refactor(exports): destroy errorable on force to ensure we have fresh export
Il semblerait que le destroy échoue parfois silencieusement pour une raison
inconnue, ce qui empêche le create_or_find_export de se dérouler
à cause de la contrainte d'unicité (il rollback), ce qui conduit ensuite
à un comportement inattendu: re-téléchargement de l'ancienne archive
alors qu'on voulait la regénérer.

Co-Authored-By: Lisa Durand <lisa.c.durand@gmail.com>
2023-09-28 12:35:09 +02:00
Colin Darie
fc66f4b05d
refactor(exports): drop useless exports relation dependency for exports dropdown
Since the dropdown does not list download links anymore,
we don't have to pass them a dynamic exports list.

Co-Authored-By: Lisa Durand <lisa.c.durand@gmail.com>
2023-09-28 12:35:08 +02:00
Colin Darie
82dd05c189
chore(exports): finders by groupe instructeurs compatible across exports components
Co-Authored-By: Lisa Durand <lisa.c.durand@gmail.com>
2023-09-28 12:35:07 +02:00
Lisa Durand
5a571a3535
create export page to list all the exports and remove links from the dropdown 2023-09-28 12:35:04 +02:00
Lisa Durand
a559bf54eb
Merge pull request #9517 from demarches-simplifiees/change-tabs-for-instructeur-dashboard-ldu
[instructeur] Mettre en avant les démarches closes avec des dossiers à traiter
2023-09-28 07:32:07 +00:00
Lisa Durand
db4c8619a9
Update app/views/instructeurs/procedures/index.html.haml
Co-authored-by: LeSim <mail@simon.lehericey.net>
2023-09-27 16:51:44 +02:00
Lisa Durand
91018d8f8f
Update app/controllers/instructeurs/procedures_controller.rb
Co-authored-by: LeSim <mail@simon.lehericey.net>
2023-09-27 16:51:07 +02:00
Lisa Durand
46e492496e
Update app/controllers/instructeurs/procedures_controller.rb
Co-authored-by: LeSim <mail@simon.lehericey.net>
2023-09-27 16:50:55 +02:00
Colin Darie
2cc2c9f77d
Merge pull request #9520 from demarches-simplifiees/filter-instructeur-exclude-en-attente-ldu
[instructeur] je veux pouvoir filtrer les dossiers "en construction" sans avoir ceux "en attente de corrections"
2023-09-27 11:57:35 +00:00
krichtof
63ca98b5b6
Merge pull request #9529 from demarches-simplifiees/fix-contact-information
Fix contact information
2023-09-27 11:33:41 +00:00
Christophe Robillard
2a39cfead7 fix: display contact info on footer of notif mail 2023-09-27 12:49:24 +02:00
Christophe Robillard
6035a16ecc fix: can display contact_info nom on footer 2023-09-27 12:09:00 +02:00
Eric Leroy-Terquem
774e375f44 feat(conditional): can condition on departement champ value 2023-09-27 10:22:12 +02:00
Lisa Durand
129230af88 exclude dossiers with pending correction when instructeur filters on 'en_construction' 2023-09-26 16:36:39 +02:00
krichtof
da62a5ec79
Merge pull request #9518 from demarches-simplifiees/9497-description-champs
ETQ usager, je suis aidé à la saisie par une description des champs
2023-09-26 13:58:02 +00:00
Christophe Robillard
abad463bb1 remove placeholder for decimal number component 2023-09-25 18:17:04 +02:00
Christophe Robillard
168616b8c6 remove placeholder for phone component 2023-09-25 18:17:04 +02:00
Christophe Robillard
18e5c32363 remove placehoder for rna component 2023-09-25 18:17:04 +02:00
Christophe Robillard
8bacb30e36 remove placeholder for iban component 2023-09-25 18:17:04 +02:00
Christophe Robillard
bd3f7eeb38 remove placeholder for siret component 2023-09-25 18:17:04 +02:00
Christophe Robillard
ae08f044ed remove placeholder for email component 2023-09-25 18:17:04 +02:00
Christophe Robillard
3ff7bc7234 display max size and format as hint 2023-09-25 18:17:04 +02:00
Christophe Robillard
e972514ec6 remove useless blank line 2023-09-25 18:17:04 +02:00
Christophe Robillard
9c2c378588 use model locales for titre identite hint 2023-09-25 18:17:04 +02:00
Lisa Durand
a4c79e953b change 'published' tabs by 'en cours' to highlight closed procedure with 'en cours' files 2023-09-25 15:34:37 +02:00
krichtof
f019f1e316
Merge pull request #9345 from adullact/feature-ouidou/existing_procedure_hidden_as_template
ETQ superadmin, je peux masquer une démarche de la liste des démarches proposées à la création
2023-09-25 08:46:31 +00:00
Eric Leroy-Terquem
1060aadff7
Merge pull request #9504 from demarches-simplifiees/do-not-route-cloned-procedures-if-admin-is-different
Correction : désactive le routage des procédures clonées si l'admin n'est pas aussi admin de la procédure parente
2023-09-22 09:10:42 +00:00
Colin Darie
da06295191 chore(attestation): improve groupe instructeurs signature wording
Co-Authored-By: Christophe Robillard <christophe.robillard@beta.gouv.fr>
2023-09-22 10:24:16 +02:00
Colin Darie
d231ec35f4 refactor(attestation): groupe instructeur add signature shared
Co-Authored-By: Christophe Robillard <christophe.robillard@beta.gouv.fr>
2023-09-22 10:24:16 +02:00
Colin Darie
4c7664d61c fix(admin): missing siret & service alert don't override action alert
Co-Authored-By: Christophe Robillard <christophe.robillard@beta.gouv.fr>
2023-09-22 10:24:16 +02:00
Colin Darie
934e86a465 refactor(attestation): groupe instructeur signature shared
Co-Authored-By: Christophe Robillard <christophe.robillard@beta.gouv.fr>
2023-09-22 10:24:16 +02:00
Christophe Robillard
c02e6f2a77 feat(groupe-instructeur): instructeur can add signature in attestation 2023-09-22 10:24:16 +02:00
Colin Darie
ad10335888 feat(groupe-instructeur): admin can preview signature in attestation
Co-Authored-By: Christophe Robillard <christophe.robillard@beta.gouv.fr>
2023-09-22 10:24:16 +02:00
Colin Darie
3e1678c17a chore(attachments): always render allowed formats when list is short
Co-Authored-By: Christophe Robillard <christophe.robillard@beta.gouv.fr>
2023-09-22 10:24:16 +02:00
Colin Darie
44578ba65c fix(attachment): keep direct_upload behavior in poll url
Co-Authored-By: Christophe Robillard <christophe.robillard@beta.gouv.fr>
2023-09-22 10:24:16 +02:00
Christophe Robillard
c121a8b2dc admin can add groupe_instructeur signature 2023-09-22 10:24:16 +02:00
Christophe Robillard
5482863eea add signature to groupe_instructeur 2023-09-22 10:24:16 +02:00
Christophe Robillard
7529294845 fix: uninterlace only interlaced png 2023-09-22 10:24:16 +02:00
Christophe Robillard
46edaed6bc extract uninterlace_png method 2023-09-22 10:24:16 +02:00
seb-by-ouidou
d29bbf6d4f
Merge branch 'main' into feature-ouidou/existing_procedure_hidden_as_template 2023-09-21 15:53:38 +02:00
seb-by-ouidou
5b9423bab3 fix: remove hidden_at_as_template from filter 2023-09-21 13:50:23 +00:00
Eric Leroy-Terquem
70cc8dac4c fix(procedure): do not route cloned procedures from different admin 2023-09-21 15:24:17 +02:00
Eric Leroy-Terquem
5e4d96654f fix(dossier clone): always rebase cloned dossiers 2023-09-21 13:50:40 +02:00
Martin
04fe3ad2b6 correctif(repetition.commune): ETQ usager, lorsque j'ai plus d'une repetition ayant un champ commune, les ids des options des input[type=radio] des communes partageant le meme code postal ne sont pas uniques, on boucle sur la 1ere repetition 2023-09-20 17:56:17 +02:00
simon lehericey
4a17dec87b refactor procedure_controller 2023-09-20 14:11:10 +02:00
simon lehericey
40a15b9be4 refactor dossier_controller 2023-09-20 14:11:10 +02:00
simon lehericey
c248f96f31 fixup base controller 2023-09-20 14:11:10 +02:00
simon lehericey
118242dbd2 refactor api_controller 2023-09-20 14:11:09 +02:00
simon lehericey
2664c3671f api_tokens_controller: only use turbo 2023-09-20 14:11:09 +02:00
simon lehericey
954c5334ef use new procedure in view 2023-09-20 14:11:09 +02:00
simon lehericey
9047c2a7de api_tokens_controller: extract become full_access 2023-09-20 14:11:09 +02:00
simon lehericey
9b440b6c44 api_tokens_controller: extract disallow_procedure 2023-09-20 14:11:09 +02:00
simon lehericey
2a109d3aa4 api_tokens_controller: use before_action set_api_token 2023-09-20 14:11:09 +02:00
simon lehericey
01efae960b fix component 2023-09-20 14:11:09 +02:00
simon lehericey
05a8fd8ee1 refactor of api_token 2023-09-20 14:11:09 +02:00
simon lehericey
24fd12ed70 explicit about different contexts 2023-09-20 14:11:09 +02:00
simon lehericey
f434c6a6ad refactor: try base controller 2023-09-20 14:11:09 +02:00
simon lehericey
40ed59a231 rename find_and_verify => authenticate 2023-09-20 14:11:09 +02:00
simon lehericey
87933d3567 introduce token bearer 2023-09-20 14:11:09 +02:00
simon lehericey
0b03ba4d68 remove v1/v2 api token logic 2023-09-20 14:11:09 +02:00
Lisa Durand
83957a41cd add min height for table with max 2 files to display dropdown 2023-09-19 17:50:38 +02:00
seb-by-ouidou
0d2cd0fe5d feat(procedure): hide as template 2023-09-19 11:21:27 +00:00
Paul Chavard
b1dc376d1d fix(champs-editor): add dsfr classes to select elements 2023-09-19 11:09:29 +02:00
Paul Chavard
cf3a35724c fix(champs-editor): remove unnecessary background color 2023-09-19 11:09:09 +02:00
LeSim
e6f8400cfd
Merge pull request #9477 from demarches-simplifiees/can-route-from-epci-champ
ETQ admin je peux router par département depuis le champ EPCI
2023-09-19 08:21:26 +00:00
LeSim
29c52d191e
Merge pull request #9487 from mfo/US/fix-expert-invitation
correctif(expert.invite-autre-expert): ETQ expert, je ne pouvais pas demander d'autres avis d'expert
2023-09-19 08:16:53 +00:00
LeSim
3f9f7d59a2
Merge pull request #9489 from colinux/form-identity-siret-dsfr
ETQ usager le form pour renseigner son SIRET passe au DSFR et est dispo en anglais
2023-09-19 08:14:03 +00:00
Colin Darie
bccad19e13
chore(siret): translate identity siret form 2023-09-18 19:11:27 +02:00