DGNum/demarches-normaliennes
14
1
Fork 0
Code Issues 1 Pull requests Projects Releases Packages Wiki Activity

refactor(exports): destroy errorable on force to ensure we have fresh export

Browse source 
Il semblerait que le destroy échoue parfois silencieusement pour une raison
inconnue, ce qui empêche le create_or_find_export de se dérouler
à cause de la contrainte d'unicité (il rollback), ce qui conduit ensuite
à un comportement inattendu: re-téléchargement de l'ancienne archive
alors qu'on voulait la regénérer.

Co-Authored-By: Lisa Durand <lisa.c.durand@gmail.com>
This commit is contained in:
Colin Darie 2023-09-13 13:05:24 +02:00
parent fc66f4b05d
commit ca0b5c9cb9
No known key found for this signature in database
GPG key ID: 8C76CADD40253590
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
app/models/export.rb
View file

@ -81,7 +81,7 @@ class Export < ApplicationRecord
export = create_or_find_export(format, groupe_instructeurs, time_span_type: time_span_type, statut: statut, procedure_presentation: procedure_presentation)
if export.available? && export.old? && force
export.destroy
export.destroy!
create_or_find_export(format, groupe_instructeurs, time_span_type: time_span_type, statut: statut, procedure_presentation: procedure_presentation)
else
export