DGNum/demarches-normaliennes
15
1
Fork 0
Code Issues 1 Pull requests Projects Releases Packages Wiki Activity
9077 commits 250 branches 1166 tags 78 MiB
Commit graph

9077 commits

This branch
This branch
All branches
Author SHA1 Message Date
Pierre de La Morinerie
7ba76c6658 dossier: add a notice when some attachments of the dossier were lost 
On the 22/01/2020, a technical error on the demarches-simplifees.fr
instance made us delete some files attached to some dossiers.

This PR adds a warning when browsing a dossier containing attachments
that were deleted.
 2020-02-12 11:49:33 +01:00
Pierre de La Morinerie
7c60b9dfa8
Merge pull request #4748 from tchak/avis-invitations-fix 
Instructeur : corrige le fonctionnement de la case "Inviter les experts aussi sur les dossiers liés"
 2020-02-11 18:34:38 +01:00
Paul Chavard
7afeae1408 remove dossier.linked_dossiers 2020-02-11 17:49:22 +01:00
Paul Chavard
0d55743d9f linked_dossiers_for should include dossiers_from_avis 2020-02-11 17:38:58 +01:00
Pierre de La Morinerie
5d0a8b567f specs: improve description of Avis creation test cases 2020-02-11 17:38:58 +01:00
Paul Chavard
f0ea96772d Only invite experts to dossiers instructeur have access to 2020-02-11 17:38:57 +01:00
Paul Chavard
8a514e0713 Fix avis linked dossiers invitation checkbox 
fix #4678
 2020-02-11 17:38:57 +01:00
Pierre de La Morinerie
d5fcaf7073
Merge pull request #4762 from betagouv/form-stylesheet 
Usager : amélioration de la clarté et de l'accessibilité des formulaires
 2020-02-11 17:38:26 +01:00
Pierre de La Morinerie
c517d22369 form: avoid outlining disabled controls on click 2020-02-11 17:36:50 +01:00
Pierre de La Morinerie
1531b69f5a form: make the radio button larger and hoverable 
As a bonus, the implementation of vertical radio buttons is now closer
from the default horizontal one.
 2020-02-11 17:36:50 +01:00
Pierre de La Morinerie
f42977e40a form: add number to section headers 2020-02-11 17:36:50 +01:00
Pierre de La Morinerie
2b47013798 form: improve the appearance of the repetitions header 2020-02-11 17:36:50 +01:00
Pierre de La Morinerie
005ff4bed5 form: fix the bottom margin of the siret element 2020-02-11 17:36:50 +01:00
Pierre de La Morinerie
8693ca3e3a form: increase the font size of labels and notices 2020-02-11 17:36:50 +01:00
Pierre de La Morinerie
00b1eaff41 form: increase spacing between fields 2020-02-11 17:36:50 +01:00
Pierre de La Morinerie
58b4c2e53b form: add a $default-fields-spacer constant 2020-02-11 17:36:50 +01:00
Pierre de La Morinerie
2532091302 form: improve wording of repetition blocks controls 2020-02-11 17:36:50 +01:00
Pierre de La Morinerie
469f4dc6f7 form: remove dead code 2020-02-11 17:36:50 +01:00
Pierre de La Morinerie
44e3a70db5 form: increase section title visibility 2020-02-11 17:36:50 +01:00
Pierre de La Morinerie
c4e78be77e form: increase hr visibility 2020-02-11 17:36:50 +01:00
Paul Chavard
14f1bd2bc7
Merge pull request #4764 from betagouv/support-suggest-feature-upvote 
support: hint about the suggestions board on feature-upvote
 2020-02-11 16:03:30 +01:00
Pierre de La Morinerie
7b57a806e9 support: hint about the suggestions board on feature-upvote 2020-02-11 15:35:42 +01:00
Pierre de La Morinerie
fbdbf997e4
Merge pull request #4754 from betagouv/show_repetable_champ_in_manager_procedure 
Manager : permet de visualiser le contenu d'un type de champ répétable
 2020-02-11 15:16:54 +01:00
simon lehericey
90113f1a22 Remove Rempli column for type de champ 2020-02-11 13:35:55 +00:00
simon lehericey
4f317e84d1 Iterate over type_de_champ in repetition type_de_champ 2020-02-11 13:35:55 +00:00
simon lehericey
a62e9fe6d2 Extract type de champ line 2020-02-11 13:35:55 +00:00
Pierre de La Morinerie
fe1833e1cd
Merge pull request #4757 from betagouv/dinum 
Remplacement des dernières références restants à la DINSIC par DINUM
 2020-02-10 18:54:49 +01:00
Pierre de La Morinerie
52ea019ba9 app: replace remaining references of DINSIC by DINUM 
Fix #4488
 2020-02-10 17:46:20 +00:00
krichtof
6941e7d964
Merge pull request #4755 from betagouv/ajoute-un-test-pour-les-demandes 
https://github.com/betagouv/demarches-simplifiees.fr/pull/4755 technique: ajoute un test à la consultation des demandes en attente
 2020-02-10 15:07:55 +01:00
Christophe Robillard
967e5e910f test pending demandes 2020-02-10 14:59:03 +01:00
Pierre de La Morinerie
2e041b9d22
Merge pull request #4759 from betagouv/remove_fog_conf_for_carrierewave 
Supprime de vielles clés de configuration de fog qui n’étaient utilisées que par CarrierWave
 2020-02-10 14:20:09 +01:00
simon lehericey
3d652ffaf8 Remove unused key 2020-02-10 13:59:15 +01:00
simon lehericey
6de55f44b4 Remove Fog conf for carrierewave 
The conf now is config/storage.yaml
 2020-02-10 13:56:45 +01:00
Pierre de La Morinerie
319b996af6 Merge pull request #4747 from betagouv/remove-password-placeholder-for-sign-in 
sign_in: remove the hint about password length
 2020-02-10 12:13:11 +01:00
Pierre de La Morinerie
123819f5d2 sign_in: remove the hint about password length 2020-02-10 11:07:08 +00:00
Kara Diaby
63800170ab Merge pull request #4753 from betagouv/feat/4501-instructors-thousand-separator 
feat/4501 - add thousand separators to numbers (instructors page and pdf file)
 2020-02-10 10:16:21 +01:00
kara Diaby
805da59b99 add thousand separators to numbers (instructors page and pdf file) 2020-02-10 09:32:37 +01:00
Pierre de La Morinerie
9214476fc0
Merge pull request #4749 from betagouv/fix-pending-demandes 
fix pending demandes
 2020-02-05 18:31:16 +01:00
Christophe Robillard
9fe005e4d7 fix pending demandes 2020-02-05 18:19:05 +01:00
Keirua
a8dd3888c1
Merge pull request #4745 from betagouv/do-not-throw-away-emails 
#4705 - investigation des problèmes de mail
 2020-02-05 14:31:24 +01:00
clemkeirua
415cc2c2f1 openly fail when not delivering mail 2020-02-05 10:46:01 +01:00
Pierre de La Morinerie
40a90ca4b7
Merge pull request #4743 from betagouv/fix-nbsp-in-emails 
Usager : corrige quelques espaces disgracieux dans les emails
 2020-02-04 17:11:35 +01:00
Pierre de La Morinerie
c16409819b mailers: fix some missing unbreakable space in emails 2020-02-04 17:09:25 +01:00
krichtof
4954f798a5
Merge pull request #4742 from betagouv/4532-supprime-email-column-de-la-table-admin 
#4532 supprime la colonne email de la table admin
 2020-02-04 16:47:44 +01:00
Christophe Robillard
50fcd24b46 admin: fix pending demandes 
fetch email with map
 2020-02-04 16:21:42 +01:00
Christophe Robillard
53f420c748 admin: fix sql column ambiguity 
administrateurs_instructeurs and users (loaded by
Administrateur.default_scope) have administrateur_id column with same
name. This commit indicates which column to use for GROUP query.
 2020-02-04 16:21:42 +01:00
Christophe Robillard
cef776ff9e admin: fix add administrateur to a procedure 2020-02-04 16:21:42 +01:00
Christophe Robillard
f8309c45a6 admin: order by user email 2020-02-04 16:21:42 +01:00
Christophe Robillard
91f1722088 admin: always eager load the user relationship 
Now that `Administrateur.email` is merely an alias to
`administrateur.user.email`,
and we changed every occurence of `administrateurs.pluck(:email)` to
`administrateurs.map(&:email)`, the new version using `map` may cause N+1
queries if the users have not been preloaded.

  It makes sense to always preload the user when fetching an
  Administrateur:

  - Administrateur and User have a strongly coupled relationship
  - It avoids N+1 queries everywhere in the app

  Of course fetching an administrateur without needing its user will now do
  an unecessary fetch of the associated user. But it seems better than
  leaving a risk of N+1 queries in many places.
 2020-02-04 16:21:42 +01:00
Christophe Robillard
4a1980e95a admin: disable the email column 2020-02-04 16:21:42 +01:00