Commit graph

2154 commits

Author SHA1 Message Date
mfo
5dda05d710
Merge pull request #10100 from mfo/US/cleanup-champs-after-passer-en-construction
fix(email_validation): allow email with specific format
2024-03-12 17:09:39 +01:00
Colin Darie
fc1c6bb412
Merge pull request #10103 from tchak/dossier-vide-from-procedure
refactor(dossier_vide): use types_de_champ instead of empty dossier
2024-03-12 15:29:24 +00:00
Colin Darie
ee92668611
Merge pull request #9930 from demarches-simplifiees/add-external-link-to-procedure
ETQ admin lorsque je clos une démarche je peux alerter les usagers et je crée une page de fermeture si la démarche n'est pas redirigée dans DS
2024-03-12 15:03:30 +00:00
Paul Chavard
aa0aea1543 refactor(dossier_vide): use types_de_champ instead of empty dossier 2024-03-12 14:23:07 +01:00
Martin
2468d528fd fix(email_validation): use truemail regexp 2024-03-12 11:29:31 +01:00
simon lehericey
2bec15b78f fix multiple error message on regexp 2024-03-11 11:41:31 +01:00
Paul Chavard
6ec7a87bcb
Merge pull request #10080 from demarches-simplifiees/add-dependent-destroy-on-contact-information
Correctif : supprime l'information de contact à la suppression du groupe instructeur
2024-03-08 12:15:27 +00:00
mfo
0013528deb
Merge pull request #10065 from mfo/US/secu-email
fix(email.validation): some nasty tests
2024-03-08 09:05:03 +00:00
Martin
9425f2cc58 fix(user.france_connect_informations): has_many, not has_one 2024-03-08 09:44:21 +01:00
Eric Leroy-Terquem
6651b36fe4 db(migration): add closing_reason and closing_details to procedure 2024-03-07 19:00:46 +01:00
Eric Leroy-Terquem
877e1f79cc fix(groupe instructeur): add a dependent destroy on contact information 2024-03-07 16:33:17 +01:00
Martin
0ea90e036e fix(email.validation): some nasty tests 2024-03-05 16:27:07 +01:00
Martin
b468da9964 bug(user.fcis): users using more than one FranceConnect identity provider can not be destroyed 2024-03-05 14:03:02 +01:00
Paul Chavard
f3a97876bd fix(champ): champs are not ordered anymore 2024-03-04 10:59:11 +01:00
Paul Chavard
8687d73a73 refactor(dossier): clone only current revision champs 2024-03-04 10:59:11 +01:00
Paul Chavard
deb19177f7 refactor(test): update tests 2024-03-04 10:59:11 +01:00
Colin Darie
dbf04c63a4
fix(flipper): don't clone features globally enabled 2024-03-03 00:13:01 +01:00
Paul Chavard
178f1a0c26 fix(test): fail on last month day 2024-02-29 15:44:42 +01:00
Colin Darie
f04420812b
fix(export): typo tier => tiers 2024-02-22 15:58:29 +01:00
Colin Darie
7143c7e8e2
Merge pull request #9995 from colinux/attestation-v2-improvements
ETQ admin, quelques améliorations sur l'éditeur v2
2024-02-22 11:30:41 +00:00
Colin Darie
3c22f4ea48
fix(attestation): always return v1 template when exists, otherwise it's a v2 2024-02-22 12:19:07 +01:00
Martin
31168f9602 perf(spec): build not create some variables, & fix specs 2024-02-21 14:44:49 +01:00
Martin
c2675dfb4d feat(export.user): add when user passthru FranceConnect or not 2024-02-21 14:44:49 +01:00
Martin
c9235c8a3d feat(export.for_tier): add to export 2024-02-21 14:44:49 +01:00
Paul Chavard
702b9dd8b3 fix(champ): do not reset data on champs without fetch_external_data 2024-02-21 08:54:08 +01:00
Colin Darie
560d50f52d fix(dropdown-multiple): a valid option starting by [ may not be a JSON value 2024-02-20 17:41:53 +01:00
Martin
ba3fda1928 bug(monavisvalidator): what any domain could be used ?! 2024-02-20 11:51:00 +01:00
Martin
8dc3103ac1 fix(champs.email): allow nil 2024-02-19 15:13:20 +01:00
Martin
1a424beb6f fix(tags): libelle with double dash, becomes double underscore. no worries it was already broken 2024-02-16 14:00:18 +01:00
Martin
0fbbe4d97c bug(tags): libelle with double dash, double dash also known as tag delimiter 2024-02-16 14:00:18 +01:00
Martin
56ed901703 tech(clean): remove dead code 2024-02-16 11:23:39 +01:00
Martin
72a3f6e89c refactor(export/archives): holds user profile asking for the archive or export 2024-02-16 11:23:38 +01:00
Martin
8488e74bbb review(suggestion): better code with reviews, normalize Champs::EmailChamp.value, simplier default strict validation activation
Co-authored-by: Colin Darie <colin@darie.eu>
2024-02-15 16:41:00 +01:00
Martin
5f77c0cd06 feat(email.validation): expand email validation to Avis, ContactInformation, Invite, DossierTransfert 2024-02-15 16:41:00 +01:00
Martin
05193e1d1e feat(User.validation): validates email when env var is present 2024-02-15 16:41:00 +01:00
Martin
25f92a7760 feat(email.validator): define a strict email validator, validates Champs::EmailChamp.value only on validation context
Co-authored-by: Paul Chavard <github@paul.chavard.net>
2024-02-15 16:41:00 +01:00
Colin Darie
a650114671
test: fix flaky match_array test 2024-02-15 11:00:53 +01:00
Colin Darie
bd3c2c070a
Merge pull request #9957 from demarches-simplifiees/finalize-rna-rnf-ldu
ETQ instructeur et consommateur API, la vue du champ RNA est harmonisée avec le champ RNF
2024-02-14 15:30:54 +00:00
Paul Chavard
93635b3516 refactor(logic): compute sub champ values 2024-02-13 11:57:31 +01:00
Lisa Durand
f09ab62620
add rna type de champ to harmonize api with rnf 2024-02-12 17:20:07 +01:00
Colin Darie
ea89c2e8dd
fix(attestation): tag commune_name from address 2024-02-12 15:08:05 +01:00
Paul Chavard
23592087ae refactor(instructeur): use precomputed timestamps 2024-02-08 18:36:04 +01:00
Colin Darie
70e92f7c6b
Merge pull request #9903 from colinux/attestation-ux
ETQ admin, je peux tester l'attestation v2
2024-02-06 08:09:53 +00:00
seb-by-ouidou
c2c54083e8
feat: display tree structure of a group 2024-02-05 09:30:24 +01:00
Colin Darie
f7484eb0e5
feat(attestation): list tags errors and substitute missing tag by libelle 2024-02-02 13:05:09 +01:00
seb-by-ouidou
46c19014f9 feat: notify administrateur and gestionnaire by email when new commentaire + for administrateur highlight card and commentaires if any unread 2024-02-02 12:52:36 +01:00
Colin Darie
443e41a6ed
style(attestation): group tags by section 2024-02-01 18:55:52 +01:00
Colin Darie
40353fee04
feat(attestation): replace tags in preview for v2 2024-02-01 18:55:50 +01:00
seb-by-ouidou
f3cba9331d fix: improvement after review 2024-01-29 18:23:39 +01:00
seb-by-ouidou
6cd8b6d2df feat: for gestionnaire highlight card and commentaires if any unread 2024-01-29 18:23:39 +01:00
Eric Leroy-Terquem
6203b1fd05
Merge pull request #9879 from demarches-simplifiees/cleaning-conditional-and-routing-code
Tech : nettoyage du code conditionnel et routage
2024-01-29 13:43:52 +00:00
mfo
77ca3dd28a
Merge pull request #9922 from mfo/US/nplus_one_in_summary
perf(TypeDeChampEditor): faster
2024-01-29 10:58:05 +00:00
Martin
01752bc2e8 perf(ProcedureRevisionPreloader): preload revision quickly 2024-01-26 14:47:44 +01:00
Martin
ecc83edf4f wip 2024-01-26 13:43:10 +01:00
simon lehericey
d909e2c8ea add various expiring scopes to APIToken 2024-01-26 10:15:37 +01:00
Martin
0e5768ec5b fixup! perf(editor): better perf to add, destroy, update, move up, move down and move with number 2024-01-26 09:45:59 +01:00
simon lehericey
49f0caba7e fix(spec): flaky test 2024-01-25 11:17:44 +01:00
simon lehericey
6e5678d1c2 feature(api): add forbidden_network? to api_token 2024-01-25 10:51:58 +01:00
Martin
2952987ad8 refactor(spec): stop using procedure type de champs traits as :with_datetime, :with_xxx in favor of :types_de_champ_public which keeps position in check 2024-01-23 17:30:22 +01:00
Colin Darie
716e4bbe5d
Merge pull request #9645 from adullact/feature-ouidou/admin_creation_delegation_gestionnaire_answer_administrateur
Feature ouidou/admin creation delegation gestionnaire answer administrateur
2024-01-22 15:45:58 +00:00
Martin
0f194a5e8e refactor(procedure_revision): without renumber, use types_de_champ_public factory for ordered champs 2024-01-22 14:57:04 +01:00
Martin
434cd77030 poc(spec): renumber only at one point 2024-01-22 14:57:04 +01:00
Martin
a9c0d3e7e9 tech(clean): avoid useless indirection, cleanup some code complexity, rubocopify 2024-01-22 14:57:04 +01:00
Martin
4d97c5bc8a feat(move_type_de_champ): stop renumbering all procedure_revision_type_de_champ on move_type_de_champ 2024-01-22 14:57:04 +01:00
Martin
4b57ed871a feat(add_type_de_champ): stop renumbering all procedure_revision_type_de_champ 2024-01-22 14:57:04 +01:00
seb-by-ouidou
a6ca4b668e feat: answer message to administrateur as gestionnaire 2024-01-22 14:36:38 +01:00
seb-by-ouidou
c45e2eaccc feat: write message to gestionnaires as administrateur 2024-01-09 13:25:04 +01:00
mfo
a0248bf08b
Merge pull request #9888 from mfo/US/validate-epci-by-code
Correctif: Le noms des EPCIs changent, ce qui bloque la validation et ou demande a resaisir le champs
2024-01-08 09:56:09 +00:00
Martin
fa07c21ec3 fix(champs.epci): epci names change over time. remap when it occurs 2024-01-04 07:17:15 +01:00
Eric Leroy-Terquem
547a4d95b7 chore(logic): commune and epci champs are always compute with compute_value_json 2023-12-22 10:57:53 +01:00
Colin Darie
6f7d786783
Merge pull request #9880 from demarches-simplifiees/api_token_store_last_used_ips
API: stocke les ips utilisées pour accéder à l'API
2023-12-21 16:18:00 +00:00
Eric Leroy-Terquem
4c82f2c9d7 fix(champ value): fix compute_value_json on departement champ 2023-12-21 16:21:08 +01:00
simon lehericey
afb6eacf57 feature(api): store any ip used 2023-12-21 16:02:11 +01:00
Colin Darie
9bdf525ff1
Merge pull request #9863 from colinux/fix-message-html-injection
Tech: échappe les tags de données utilisateur dans les modèles pour email
2023-12-21 08:50:21 +00:00
Colin Darie
29df9ad09d
Merge pull request #9751 from tchak/departement-tags
feat(champs): expose more tags and api fields on rnf, address and commune
2023-12-21 08:45:01 +00:00
Eric Leroy-Terquem
954facdaff
Merge pull request #9798 from demarches-simplifiees/add-new-operators-to-conditional
Etq admin je peux conditionner/router avec les opérateurs "est dans mon département",  "n'est pas dans mon département",  "est dans ma région" et   "n'est pas dans ma région".
2023-12-19 16:10:59 +00:00
Colin Darie
1a56fe620e feat(correction): make pending corrections blocking by feature flag only 2023-12-18 14:12:45 +01:00
Colin Darie
fa37c6c62b
fix(tags): escape user data tags for emails 2023-12-15 14:05:11 +01:00
Lisa Durand
569d4af6f7
Merge pull request #9706 from demarches-simplifiees/feat/9678
ETQ usager passant par un mandataire, je suis notifié des changements d'état de mon dossier par email
2023-12-14 16:57:07 +00:00
Eric Leroy-Terquem
e40d1107ac chore(conditional): add not_in_departement and not_in_region operators 2023-12-14 17:48:14 +01:00
Eric Leroy-Terquem
c9676020b4 chore(conditional): add in_departement and in_region operators 2023-12-14 17:48:13 +01:00
Kara Diaby
303230dd1d Add new testss 2023-12-12 22:35:11 +00:00
Colin Darie
7c38cbcab3
test: fix random failing test 2023-12-12 15:05:48 +01:00
Colin Darie
c0771ad903
fix(dossier): passe en instruction with auto-archive even with pending correction 2023-12-12 15:05:46 +01:00
Colin Darie
c26b59722d
feat(instructeur): pending correction blocks passer en instruction
Closes #9731
2023-12-12 15:05:44 +01:00
Colin Darie
f9c4846fde
Merge pull request #9571 from adullact/feature-ouidou/admin_creation_delegation_gestionnaire_page_group_administrateur_management
Feature ouidou/admin creation delegation gestionnaire page group administrateur management
2023-12-12 10:41:28 +00:00
Martin
f26a4bc041 amelioration(delai.traitement): revoie l'affichage du delais d'instruction
Co-authored-by: Colin Darie <colin@darie.eu>
2023-12-07 09:19:52 +01:00
Martin
474fde3380 amelioration(procedure.usual_traitement_time_for_recent_dossiers): divise en 3 groupe l'estimation de la duree de traitement 2023-12-07 09:19:52 +01:00
seb-by-ouidou
e34307b50c fix: fixes after review 2023-12-06 14:47:39 +01:00
seb-by-ouidou
564c3c04fa feat: US4.3.8 administrateur management 2023-12-06 14:47:39 +01:00
Christophe Robillard
961c7c5be4 fix format for motivation in notification mail 2023-12-05 18:50:50 +01:00
mfo
d90c55c29e
Merge pull request #9762 from tchak/fix-email-template
fix(email_template): less magic - less bugs !
2023-12-05 09:56:53 +00:00
mfo
dbfbaf4cea
Merge pull request #9757 from mfo/US/fix-extends-duree-conservation-dossier
correctif(expiration): etends la durée de conservation des dossiers quand la duree de conservation d'une procedure change
2023-12-04 09:18:45 +00:00
Colin Darie
42ea9ed2f3 perf(preloader): fix N+1 on non mandatory repetition blocks
We have to tell repetition.champs association has been loaded
even when it's empty.
2023-11-30 14:10:33 +01:00
Paul Chavard
3de0367ed9 fix(email_template): less magic - less bugs ! 2023-11-29 20:36:44 +00:00
Martin
57d7b385ec correctif(expiration): etends la durée de conservation des dossiers quand la duree de conservation d'une procedure change 2023-11-28 16:59:41 +01:00
Colin Darie
64400b512c
Merge pull request #9677 from govpf/feature-ouidou/clone_procedure_with_feature_flags
ETQ admin, les procédures clonées conservent les features flags
2023-11-28 08:21:02 +00:00
Paul Chavard
bfc809f96f feat(champs): expose more tags and api fields on rnf, address and commune 2023-11-27 15:33:05 +00:00
seb-by-ouidou
c4ca381bed feat: enable features on cloned procedure 2023-11-27 12:00:27 +01:00
Colin Darie
3b9285a00b
perf(procedure): description view caching 2023-11-27 11:29:20 +01:00
Colin Darie
5d747ba0c2
fix(procedure): list piece justificative in repetitions 2023-11-27 11:08:39 +01:00
mfo
78f9a2aa1e
Merge pull request #9737 from demarches-simplifiees/9670-export-rnf
En tant qu'instructeur, je peux exporter les données RNF des dossiers
2023-11-23 08:19:00 +00:00
Eric Leroy-Terquem
d92155a96a
Merge pull request #9714 from demarches-simplifiees/add-not-include-operator
ETQ admin je peux conditionner / router à partir d'un champ de type choix multiple avec l'opérateur "Ne contient pas"
2023-11-22 16:29:24 +00:00
Eric Leroy-Terquem
a54d55486c chore(routing): update routing_rule validation 2023-11-22 13:01:44 +01:00
Christophe Robillard
daa4c28af7 add data from rnf field to export 2023-11-22 12:20:05 +01:00
Paul Chavard
4842fc4d94 feat(tags): all tags should have ids 2023-11-21 13:55:25 +01:00
Colin Darie
f972d36f2f test: fix when using timestamps not yet limited by postgresql precision
Sur des colonnes dont le schema ne connait pas le niveau de précision
(créées avant rails 7), rails créé un timestamp avec la précision système
(par exemple 9 décimales sur linux) alors que pg va l'arrondir
a posteriori à 6.

Ce n'est généralement pas un problème en production,
mais se révèle dans les tests typiquement avec des objets crées
par des factories: si un test dépend de ces timestamps,
il faut récupérer la valeur limitée par pg (d'où le reload),
plutôt que celle directement issue de Time.now à la création de l'objet.

Une alternative aurait été de créer une migration pour ces colonnes pour
forcer la précision à 6 et que le schema en aurait pris connaissance:
rails limiterait la précision de lui même dès la création de l'objet.
2023-11-20 11:22:28 +01:00
Martin
520863d814 amelioration(user.expiration): ajoute une raison specifique a la suppression d'un dossier : user_expired 2023-11-17 11:33:14 +01:00
Martin
66cf41b6d2 amelioration(procedure.duree_conservation_dossiers_dans_ds_changes): reset les flag d'expirations lorsqu'on change la date de conservation des dosseirs d'une procedure 2023-11-17 11:33:14 +01:00
Martin
3186b0aa68 tech(refactor): centralise/documente les constantes de duree de retentions dans le ns dedié à l'expiration 2023-11-17 11:33:14 +01:00
krichtof
39bdb5f145
Merge pull request #9701 from demarches-simplifiees/carte
Afficher une carte de déploiement de DS par département
2023-11-16 13:18:16 +00:00
Christophe Robillard
ba876f5085 show france map with stats for each departement 2023-11-16 13:27:12 +01:00
Eric Leroy-Terquem
f945c02c3c feat(conditional): add exclude operator 2023-11-16 10:27:03 +01:00
Paul Chavard
8aab0cdfed
Merge pull request #9707 from demarches-simplifiees/remove-routing-feature-flags
Tech : supprime des features flags liés au routage
2023-11-15 09:23:00 +00:00
Paul Chavard
a2ed35d44e spec(dossier): improuve dossier with state factories 2023-11-14 23:59:45 +01:00
Eric Leroy-Terquem
754e4c206b chore(feature flag): remove routing_rules flag call 2023-11-14 17:02:39 +01:00
Martin
fd1f33b6e5 bug(filtres): les filtres par type de champs select ne fonctionnent pas 2023-11-14 09:46:29 +01:00
mfo
7fca13d02c
Merge pull request #9696 from colinux/procedure-visible-by-user-faster
Perf: accélération du chargement des dossiers visibles
2023-11-14 08:22:31 +00:00
Colin Darie
fb318620aa
Merge pull request #9692 from colinux/fix-deprecation-warnings
Tech: fix multiple deprecation warnings
2023-11-13 10:16:06 +00:00
Colin Darie
154a993794 chore(perf): improve perf of Dossier#visible_by_user up to 32% 2023-11-10 15:51:24 +01:00
Colin Darie
8326cf080e
fix: typo in method name extention => extension 2023-11-10 14:20:00 +01:00
Kara Diaby
c53d35401e Tests 2023-11-10 08:54:27 +00:00
Colin Darie
edb47d94f7 test: fix not_to raise_error(SpecificErrorClass) false positive risk 2023-11-09 17:27:55 +01:00
mfo
87c3615774 review(tech): utilise un code unique pr les elements de l'autocomplete, corrections de typos, amelioration du code
Co-authored-by: LeSim <mail@simon.lehericey.net>
2023-11-09 11:10:17 +01:00
Martin
0428853f4d amelioration(Champs::EngagementJuridiqueChamp): valide le format 2023-11-09 10:09:14 +01:00
simon lehericey
52752c95ec tech: add api_token_id to graphql logs 2023-11-08 16:50:10 +01:00
krichtof
a6ea607e7a
Merge pull request #9566 from adullact/feature-ouidou/admin_creation_delegation_gestionnaire_page_children_management
Feature ouidou/admin creation delegation gestionnaire page children management
2023-11-08 15:13:10 +00:00
Eric Leroy-Terquem
0968f02a26
Merge pull request #9648 from demarches-simplifiees/add-rnf-service
Ajout d'un nouveau référentiel : le Répertoire National des Fondations (RNF)
2023-11-08 09:06:47 +00:00
Paul Chavard
34a76d8afd feat(dossier): commune champ is an autocomplete now 2023-11-07 20:58:39 +01:00
Eric Leroy-Terquem
694cbcd0a2 feat(rnf): add rnf type_de_champ 2023-11-07 14:21:28 +01:00
Paul Chavard
026885ebcf feat(conditional): annotations can be conditioned by champs 2023-11-03 10:45:07 +00:00
Paul Chavard
869d83dda9 feat(dossier): validate on change and revalidate on input 2023-10-31 17:52:00 +00:00
krichtof
4a698f8264
Merge pull request #9616 from demarches-simplifiees/9525-remove-admin-from-manager
ETQ superadmin, je peux supprimer un admin depuis le manager
2023-10-27 12:21:23 +00:00
seb-by-ouidou
528c51cb5e feat: US4.3.9 children management 2023-10-26 10:46:18 +00:00
mfo
ebea269f79
Merge pull request #9420 from mfo/US/chorus-tile
amelioration(tuile.chorus): ETQ admin, je peux saisir le cadre budgetaire d'une demarche de subvention pour faciliter le rapprochement d'un export DS a un export Chorus
2023-10-24 12:57:26 +00:00
Kara Diaby
60fcb51533 affiche le message d'erreur entré par l'administrateur 2023-10-20 08:59:12 +00:00
Christophe Robillard
0b7d4452fd remove admin from manager 2023-10-19 09:14:44 +02:00
Martin
857c1f0c21 amelioration(ChorusComponent): ameliore le rendu de la tuile si celle ci n'est que partiellement rempli 2023-10-19 07:31:14 +02:00
Martin
ecb3909e99 chorus(autocomplete): autocomplete sur le centre de cout, domaine fonctionnel, referentiel de programmation 2023-10-19 07:14:27 +02:00
Martin
86b44cd0a4 iamelioration(champ.expression_reguliere): empeche le rebase lorsqu'il y a un changement sur un type de champ expression reguliere.
Plus quelques adaptation de style cf: pas besoin d'executer la validation du champs expression reguliere dans controller, le validateur le fait sur le champ au moment de sauver le dossier avec le bon context
2023-10-16 11:52:05 +00:00
Martin
30bc4aa5d3 amelioration(champ.expression_reguliere): pas besoin d'executer la validation du champs expression reguliere dans controller, le validateur le fait sur le champ au moment de sauver le dossier avec le bon context 2023-10-16 08:53:52 +00:00
Kara Diaby
a26df43577 User : Ajoute le type de champ Expression régulière coté utilisateur 2023-10-16 08:53:52 +00:00
Kara Diaby
9bf1c65dec Procedure Revision and tests 2023-10-16 08:53:52 +00:00
Kara Diaby
3b5bbb0779 Add new type de champ expression_reguliere with tests 2023-10-16 08:53:52 +00:00
seb-by-ouidou
8b1a14e16a feat: add test for GroupeGestionnaire#remove 2023-10-11 13:13:23 +00:00
Colin Darie
5314af52f2
Merge pull request #9575 from colinux/exports-fix-dossiers-count
ETQ instructeur: corrige le décompte du nombre de dossiers exportés une fois l'export généré
2023-10-09 12:40:36 +00:00
Colin Darie
428b869181
fix(exports): display exact number of dossiers count at time generation 2023-10-09 11:23:16 +02:00
Colin Darie
640f729413
feat(exports): persist instructeur requestor & dossiers count 2023-10-09 11:23:15 +02:00
simon lehericey
564939e83a fix: allow conditional on first child of bloc based on the first champ
The upper_coordinates were wrong in administrateur/type_de_champ_controller. The upper coordinates outside the bloc where missing.

with the following tdc:
- number
- bloc
  - text # this text can be conditioned by the number
2023-10-03 15:17:50 +02:00
seb-by-ouidou
9b26bf911c fix: fixes after tchak s review 2023-10-03 13:51:57 +02:00
seb-by-ouidou
44b4b5d0ab feat: rename admins_group_manager to gestionnaire 2023-10-03 13:51:57 +02:00
seb-by-ouidou
e2f792b44b FEAT: init admins group 2023-10-03 13:51:57 +02:00
krichtof
428ae4a45a
Merge pull request #9507 from demarches-simplifiees/9449-signature-groupe-instructeur
9449 ETQ instructeur ou admin, je peux apposer sur une attestation un tampon dédié à un groupe instructeur
2023-09-29 14:20:46 +00:00
Colin Darie
f942610d32
Merge pull request #9473 from demarches-simplifiees/create-export-page-V2-ldu
[Export] Créer une page d'export et sortir les liens des dropdowns
2023-09-28 17:15:31 +00:00
Colin Darie
123114be81
fix(conditional): don't .to_i/to_f => 0 an invalid number 2023-09-28 15:26:34 +02:00
Colin Darie
d4198869fb
chore(exports): dropdown menu re-uses the same pending export or create a fresh one
Pour permettre d'avoir des données fraiches dans un export tout
en conservant l'historique des exports,
la demande d'export depuis le menu créé toujours un nouvel export sauf:
- si un autre export identique est déjà en préparation
- si un autre export identique s'est terminé il y a moins de 5 minutes

Co-Authored-By: Lisa Durand <lisa.c.durand@gmail.com>
2023-09-28 15:23:31 +02:00
Colin Darie
ec46faf690
fix(exports): don't duplicate exports when belonging to multiple groupe instructeurs 2023-09-28 12:35:24 +02:00
Colin Darie
82dd05c189
chore(exports): finders by groupe instructeurs compatible across exports components
Co-Authored-By: Lisa Durand <lisa.c.durand@gmail.com>
2023-09-28 12:35:07 +02:00
Colin Darie
2cc2c9f77d
Merge pull request #9520 from demarches-simplifiees/filter-instructeur-exclude-en-attente-ldu
[instructeur] je veux pouvoir filtrer les dossiers "en construction" sans avoir ceux "en attente de corrections"
2023-09-27 11:57:35 +00:00
Eric Leroy-Terquem
774e375f44 feat(conditional): can condition on departement champ value 2023-09-27 10:22:12 +02:00
Lisa Durand
129230af88 exclude dossiers with pending correction when instructeur filters on 'en_construction' 2023-09-26 16:36:39 +02:00
Eric Leroy-Terquem
1060aadff7
Merge pull request #9504 from demarches-simplifiees/do-not-route-cloned-procedures-if-admin-is-different
Correction : désactive le routage des procédures clonées si l'admin n'est pas aussi admin de la procédure parente
2023-09-22 09:10:42 +00:00
Christophe Robillard
5482863eea add signature to groupe_instructeur 2023-09-22 10:24:16 +02:00
Eric Leroy-Terquem
70cc8dac4c fix(procedure): do not route cloned procedures from different admin 2023-09-21 15:24:17 +02:00
Eric Leroy-Terquem
5e4d96654f fix(dossier clone): always rebase cloned dossiers 2023-09-21 13:50:40 +02:00
simon lehericey
05a8fd8ee1 refactor of api_token 2023-09-20 14:11:09 +02:00
simon lehericey
40ed59a231 rename find_and_verify => authenticate 2023-09-20 14:11:09 +02:00
simon lehericey
c7afad2a88 refacto: spec 2023-09-20 14:11:09 +02:00
LeSim
e6f8400cfd
Merge pull request #9477 from demarches-simplifiees/can-route-from-epci-champ
ETQ admin je peux router par département depuis le champ EPCI
2023-09-19 08:21:26 +00:00
Colin Darie
8358fec884
fix(prefill): don't create Individual for non-individual procedures
Closes #9486
2023-09-18 16:45:02 +02:00
Eric Leroy-Terquem
0aa0b27810 test(champ value): test compute of champ value for epci tdc 2023-09-18 09:35:27 +02:00
Eric Leroy-Terquem
967139ec88 feat(routing): make routing engine work with epci champ 2023-09-18 09:32:07 +02:00
Eric Leroy-Terquem
cf7c7d9761 feat(routing): add epci to routable_types_de_champ 2023-09-18 09:32:07 +02:00
Eric Leroy-Terquem
0454d2066e
Merge pull request #9474 from demarches-simplifiees/can-route-from-commune-champ
ETQ admin je peux router par département depuis un type de champ communes
2023-09-15 08:18:24 +00:00
Colin Darie
f28739d648
Merge pull request #9372 from colinux/svr
Admin: permet l'activation du SVR
2023-09-13 12:08:39 +00:00
Colin Darie
680919a68f
feat(svr): instructor filters with svr wording specific 2023-09-13 13:50:26 +02:00
Colin Darie
e8000adecf
feat(svr): refuses automatically a dossier 2023-09-13 13:50:23 +02:00
Eric Leroy-Terquem
cdeddc6e1e test(champ value): test compute of champ value for communes tdc 2023-09-13 10:53:52 +02:00
Eric Leroy-Terquem
46ff36c2bc feat(routing): make routing engine work with commune champ 2023-09-13 10:45:21 +02:00
Eric Leroy-Terquem
50d0587a81 feat(routing): add communes to routable_types_de_champ 2023-09-13 10:45:20 +02:00
Eric Leroy-Terquem
345729a159 test(champ value): test compute of champ value for regions tdc 2023-09-13 10:22:01 +02:00
Eric Leroy-Terquem
d37fb90b2f feat(routing): make routing engine work with region champ 2023-09-13 10:22:00 +02:00
Eric Leroy-Terquem
5afaa458e2 feat(routing): add regions to routable_type_de_champ 2023-09-13 10:22:00 +02:00
krichtof
5aabce488b
Merge pull request #9425 from demarches-simplifiees/9356-service-gi
ETQ Usager, je veux voir dans mon dossier les informations de contact de mon groupe instructeur
2023-09-11 07:38:34 +00:00
Christophe Robillard
587960cfd9 clone groupe instructeur service
if admin owns original procedure
2023-09-11 08:58:04 +02:00
Christophe Robillard
46dec40543 add contact information model 2023-09-08 11:04:06 +02:00
simon lehericey
d319385d17 Add tests for prefill identity 2023-09-07 10:17:19 +02:00
simon lehericey
4cbb8e91f2 Workable draft prefill identity (no link or query help) 2023-09-07 10:17:19 +02:00
LeSim
d69636c411
Merge pull request #9230 from colinux/log-destroyed-dossiers
Tech: log technique de la destruction de dossiers
2023-09-06 14:17:57 +00:00
Colin Darie
20c7921abe
chore(log): log destroyed dossiers 2023-09-06 16:07:18 +02:00
Eric Leroy-Terquem
32b446deee refactor(groupe instructeur): add valid_rule? method
Co-authored-by: LeSim <mail@simon.lehericey.net>
2023-09-05 15:59:11 +02:00
Eric Leroy-Terquem
0cab4d9807 test(routing): test routing priorities 2023-09-05 15:59:11 +02:00
Eric Leroy-Terquem
e1ab65e62a feat(routing): can route from not_eq routing rules 2023-09-05 15:57:31 +02:00
Colin Darie
b5e2c9b860
fix(sva): improvements when a dossier has already been terminated 2023-09-04 16:09:01 +02:00
simon lehericey
fdf51b5ea1 fix: a expert merge transfers hidden procedures 2023-08-31 14:26:45 +02:00
Christian Lautier
db278e83ed add a constant for the most used test password 2023-08-31 13:40:05 +02:00
LeSim
3e193675aa
Merge pull request #9392 from demarches-simplifiees/move-groupe-instructeur-validation-to-model
Tech : déplace une validation sur le groupe d'instructeurs défaut du controleur au modèle
2023-08-31 09:45:03 +00:00
Colin Darie
c4a54fc576
Merge pull request #9426 from colinux/fix-avis-answer-sort
ETQ instructeur: fix flaky test et tri des dossiers par avis
2023-08-30 09:34:44 +00:00
Colin Darie
cf87419a19
fix(avis): table is only sortable by question_answer, answer is not exposed 2023-08-29 18:01:14 +02:00
Eric Leroy-Terquem
ca25788f07 feat(routing): use only department codes in routing rules 2023-08-29 15:50:42 +02:00
Eric Leroy-Terquem
7e3fc68c53 feat(routing): make routing engine work with departement champ 2023-08-29 15:50:42 +02:00
Eric Leroy-Terquem
ac823c1b25 feat(routing): add departements to routable_type_de_champ 2023-08-29 15:50:42 +02:00
Eric Leroy-Terquem
fc2c196cfa chore(groupe instructeur): move closed validation for defaut groupe to model 2023-08-21 16:31:54 +02:00
Martin
05687e63ca amelioration(dossier.routage): assigne le groupe d'instructeur au moment de passer_en_construction! un dossier et ignore ce concept de pre-setter le groupe d'instructeur sur tout le reste de l'app 2023-08-14 10:17:23 +02:00
Christian Lautier
5ce42afe28 Fix datetime_champ validation with negative time zone 2023-08-02 14:40:47 +02:00
Paul Chavard
e9cb50d09c feat(api): add last_authenticated_at timestamp to api requests 2023-08-02 13:22:18 +02:00
Colin Darie
fb470c1504
fix(fork): dossier forkable when associated objects to champs are not valid 2023-07-26 12:18:49 +02:00
Paul Chavard
d669e0fb45 fix flaky spec 2023-07-25 12:49:13 +02:00
seb-by-ouidou
243b8c239a feat(administrateur): add environment variable for Administrateur::UNUSED_ADMIN_THRESHOLD 2023-07-24 15:55:33 +00:00
Paul Chavard
4bc8b23a19 fix(dossier): purge motivation after repasser en instruction 2023-07-24 09:52:12 +02:00
Colin Darie
5998cfe31f refactor(correction): rename kind => reason with default correction => incorrect 2023-07-21 16:45:47 +02:00
krichtof
753731cc53
Merge pull request #9259 from demarches-simplifiees/9189-merge-api-tokens
ajoute les jetons api lors de la fusion d'un compte administrateur
2023-07-19 12:04:19 +00:00
Paul Chavard
4f4e68719a
Merge pull request #9275 from tchak/validate-geo-json
ETQ Instructeur, je veux que les GeoJSON déposés par les utilisateurs soient valides
2023-07-19 08:01:01 +00:00
Paul Chavard
47dc2cba9c
Merge pull request #9325 from tchak/fix-dpo-lien-validation
fix(procedure): accept dpo emails with accents
2023-07-18 16:27:49 +00:00
Paul Chavard
04b3a70108 feat(champ): validate GeoJSON 2023-07-18 18:01:29 +02:00
Paul Chavard
1882f652d5 fix(dossier): do not create groupe instructeur assignements on brouillons 2023-07-18 16:54:00 +02:00
Eric Leroy-Terquem
0e58e10b82 refactor(DossierAssignment): move create_assignment to assign_to_groupe_instructeur 2023-07-18 16:54:00 +02:00
Eric Leroy-Terquem
c09655a07f feat(DossierAssignment): create assignment from routing engine 2023-07-18 16:54:00 +02:00
Paul Chavard
08f0184700 fix(procedure): accept dpo emails with accents 2023-07-18 15:16:31 +02:00
Christophe Robillard
18f5c2a9ad merge only v3 api tokens 2023-07-17 16:35:07 +02:00
Christophe Robillard
67b9bb264a build raison sociale from nom and nom 2023-07-14 16:19:44 +02:00
Martin
ce9dbed663 amelioration(NotificationMailer): sort la creation des commentaire sur la messagerie du mailer [trop de prob possible sinon: au retry on dupliquait les commenaitres, si le mail foirait, on commentait pas etc...] 2023-07-11 15:11:40 +02:00
Colin Darie
07432503a7
Merge pull request #9291 from colinux/stats
Stats: ignore aperçus, brouillons en construction & dossiers des démarches en brouillon
2023-07-11 08:36:12 +00:00
Colin Darie
0d106cdf4b
Merge pull request #9104 from colinux/sva
ETQ admin je peux configurer ma démarche en SVA/SVR
2023-07-11 08:21:46 +00:00
Colin Darie
73a28d2eca
fix(sva): don't process dossiers submitted before sva was enabled 2023-07-11 10:02:47 +02:00
Colin Darie
7225f1b023
fix(sva): not compatible with declarative procedure 2023-07-11 10:02:47 +02:00
Colin Darie
4c46a2f8da
feat(sva): date in pdf 2023-07-11 10:02:47 +02:00
Colin Darie
8c49dcf21e
feat(sva): exports include SVA devision date 2023-07-11 10:02:47 +02:00
Colin Darie
f369775d5b
fix(sva): compute decision date from the day after deposit or resolution 2023-07-11 10:01:49 +02:00
Colin Darie
b4e6c20bbd
feat(sva): log operation when instructeur requests a correction 2023-07-11 10:01:49 +02:00
Colin Darie
6ce8428ac6
feat(sva): instructeur can flag a dossier as incomplete 2023-07-11 10:01:48 +02:00
Colin Darie
168189c3ac
feat(sva): instructeurs can filter by sva/svr decision before a date 2023-07-11 10:01:48 +02:00
Colin Darie
d70278a534
refactor(sva): dossier can't repasser en construction without pending correction 2023-07-11 10:01:47 +02:00
Colin Darie
3612eddf79
feat(sva): accepte automatiquement 2023-07-11 10:01:46 +02:00
Colin Darie
eb7f1f199a
feat(sva): block configuration changes when procedure is published 2023-07-11 10:01:46 +02:00
Colin Darie
afe373c6b4
feat(sva): transition to en_instruction when (re-)submitting a dossier 2023-07-11 10:01:46 +02:00
Colin Darie
8c210e6fc7
feat(admin): config sva/svr 2023-07-11 10:01:45 +02:00
Paul Chavard
95f7ca0f44 fix(cojo): invalid accreditation should result in a blank champ 2023-07-10 19:15:39 +02:00
Colin Darie
aa8bef48b0 fix(stat): ignore forks, previews & dossiers from draft procedures 2023-07-10 15:16:56 +02:00
Paul Chavard
d5820277c0 feat(cojo): add cojo type de champ 2023-07-10 14:57:34 +02:00
Colin Darie
6fa7ed1c1f
Merge pull request #9279 from colinux/fix-email-default-template
Correctif: utilise le template d'email de notification par défaut quand la démarche n'a pas personnalisé le sien
2023-07-06 09:30:04 +00:00
Colin Darie
edc790be8f test: remove false positive warning about expect.not_to raise(SpecificError) syntax 2023-07-06 10:56:01 +02:00
Paul Chavard
9cfbc75f25 spec(procedure): test url validator 2023-07-06 10:27:43 +02:00
Colin Darie
c83cc048c6
Merge pull request #9269 from mfo/US/text-merge-fork-with-revision-removing-repetition
Test: merge_fork d'un dossier étant sur une revision passée avec une répétition qui a été supprimée
2023-07-04 12:21:31 +00:00
Eric Leroy-Terquem
f959450477
Merge pull request #9244 from demarches-simplifiees/refactor-routing-update
Tech : mise à jour du routage sans callback
2023-07-04 09:39:00 +00:00
Eric Leroy-Terquem
7fe4ec67c3 update previous routing system tests 2023-07-03 14:58:45 +02:00
Eric Leroy-Terquem
7598b0a513 remove previous routing sytem code 2023-07-03 14:58:45 +02:00
Eric Leroy-Terquem
a2c636d784 fix(tests): create groupe instructeurs with factory 2023-07-03 14:47:56 +02:00
Martin
5c9101d15f bug(merge_fork): un dossier etant sur une revision passee avec une repetition qui a ete supprime ne peut merge_fork 2023-06-30 14:25:23 +02:00
Christophe Robillard
faecefe405 merge admin api tokens 2023-06-28 13:37:33 +02:00
Paul Chavard
f7e81965b1 fix(instructeur): filter by departement or region should use code instead of name 2023-06-28 10:14:34 +02:00
Paul Chavard
02dcead04a fix(commune): add fallbacks to commune name resolution 2023-06-28 09:44:21 +02:00
Colin Darie
8501fbadbb fix(dossier): can merge fork after rebase adding a champ in repetition 2023-06-23 00:22:32 +02:00
Colin Darie
33617a4c44 test: ensure travel_back is automatically called at the right time 2023-06-20 00:04:55 +02:00
Paul Chavard
c1afc985e4 fix(prefill): allow private annotations prefill 2023-06-15 10:07:25 +01:00
Paul Chavard
6723bdcd9d fix(carto): no crash on points with elevation 2023-06-12 14:56:52 +02:00
Colin Darie
75b2685230 fix(instructeurs): human format a filtered date 2023-06-08 19:01:23 +02:00
Paul Chavard
c4432b1b47 perf(carto): use json schema to validate geojson instead of rgeo 2023-06-06 15:43:56 +02:00
Colin Darie
66dc8f251f
Merge pull request #9128 from colinux/fix-procedure-presentation-show-avis
ETQ instructeur je veux pouvoir afficher sans erreur la colonne "avis"
2023-06-05 08:53:39 +00:00
Colin Darie
7e567d5080
fix(instructeurs): don't crash when displaying "avis" column 2023-06-02 17:07:02 +02:00
Colin Darie
734d88d80d
fix(pending-correction): wording alignement 2023-06-02 16:16:14 +02:00
Colin Darie
62cc9d30d8
chore(correction): passing en_instruction resolve pending corrections 2023-06-02 16:16:14 +02:00
Colin Darie
5ab44fc7a9
chore: rename dossier_resolution => dossier_correction 2023-06-02 16:16:14 +02:00
Colin Darie
ca3b127942
feat(instructeur): can flag a dossier as "pending corrections" 2023-06-02 16:16:12 +02:00
Colin Darie
d73b96ea40
feat(dossier): pending resolution state 2023-06-02 16:13:16 +02:00
Colin Darie
2c79ca94f5
chore(schema): create dossier_corrections 2023-06-02 16:13:15 +02:00
Colin Darie
ec244f1a94
fix(procedure): auto_archive_on must be in future 2023-06-01 16:49:52 +02:00
mfo
c2f2b4ef2a
Merge pull request #9106 from mfo/api-entreprise.etablissement_adapter
API Entreprise: migration "Etablissement"
2023-06-01 11:45:47 +00:00
mfo
1a6dc10548
Merge pull request #9102 from demarches-simplifiees/8472-migrate-rna
API Entreprise: migration RNA (associations)
2023-06-01 11:37:57 +00:00
Martin
c90175f121 tech(api-entreprise.etablissement): passage du endpoint ETABLISSEMENT_RESOURCE_NAME en v3 2023-06-01 09:06:36 +02:00
Martin
0d3deb01be tech(rna_controller#show): corrige les specs et recupère uniquement les informations utilisé par l'app 2023-05-31 16:11:12 +02:00
Eric Leroy-Terquem
e8d687f5e7 fix(routing): routing engine works even with unconfigured groups 2023-05-31 11:38:16 +02:00
krichtof
0051face93
Merge pull request #9014 from demarches-simplifiees/8859-default_zones
Etq admin, lors de la création ou modification d'une démarche, des zones par défaut me sont suggérées
2023-05-26 17:25:21 +00:00
Christophe Robillard
ba281d53cf migrate entreprise adapter to v3 2023-05-26 13:37:20 +02:00
Colin Darie
795e0ca471
fix(fork): can fork a dossier having invalid champs so it can be fixed in brouillon 2023-05-24 12:15:43 +02:00
Paul Chavard
cf13b942e7
Merge pull request #9076 from colinux/fix-instructeurs-filter-avis
ETQ instructeur je peux filtrer les dossiers par avis
2023-05-24 08:05:07 +00:00
Colin Darie
ff8fba3725
fix(instructeur): can filter by avis answer 2023-05-23 09:40:21 +02:00
Colin Darie
d16b81e09c fix(rebase): don't fail on force rebased when procedure is still in draft 2023-05-22 13:50:58 +02:00
Christophe Robillard
3705dc2553 determine default zones according to tchap hs 2023-05-16 09:40:53 +02:00
Colin Darie
0d21450f8a
fix(fork): don't let active storage override our champ#updated_at after a transaction 2023-05-15 11:08:07 +02:00
Colin Darie
9b52f0902d
test(clone): move dossier#clone spec into appropriate concern 2023-05-15 11:08:06 +02:00
Paul Chavard
b4a299c326 fix(user): always rebase original dossier before merge 2023-05-12 20:42:02 +02:00
simon lehericey
6148f24387 Revert "Merge pull request #9002 from tchak/feat-procedure-clone-preview-published"
This reverts commit 7a6f46a8ad, reversing
changes made to 4513c52213.
2023-05-12 11:29:11 +02:00
Colin Darie
79f450a422
Merge pull request #9021 from colinux/feat-en-construction-fork
ETQ usager, je modifie et soumets à nouveau mon dossier “en construction"
2023-05-10 19:46:40 +00:00
Colin Darie
218c7d08c2
feat(fork): mark a fork as stale for future deletion, so it can't be reused 2023-05-09 18:49:53 +02:00
Colin Darie
f6ebfe0e47
fix(dossier): sync search_terms after merge
Use a job instead of a lot of reloads
2023-05-09 18:49:52 +02:00
LeSim
d0bb759d3d
Merge pull request #8997 from demarches-simplifiees/add_defaut_procedure_for_new_admin
ETQ admin, je veux avoir une première démarche pré remplie lorsque j'arrive sur ds
2023-05-09 16:38:55 +00:00
Paul Chavard
71cfe094aa
fix(groupe_instructeur): always use assign_to_groupe_instructeur method 2023-05-09 17:23:23 +02:00
Paul Chavard
025bd5beaf
feat(dossier): dossier can be forked for editing 2023-05-09 15:34:10 +02:00
mfo
2374ced5d2
Merge pull request #8987 from mfo/US/link-to-errored-champs
amelioration(dossier#submit_brouillon): ETQ usager, je souhaite pouvoir acceder aux champs en erreur facilement
2023-05-09 07:06:36 +00:00
Paul Chavard
7a6f46a8ad
Merge pull request #9002 from tchak/feat-procedure-clone-preview-published
ETQ Administrateur, je veux cloner la version publiée des démarches en production
2023-05-05 14:36:03 +00:00
Martin
2135985583 correctif(procedure.clone): ET admin, je souhaite pouvoir cloner une procedure ayant deux groupes d'instructeur ayant le dernier fermé 2023-05-05 11:09:06 +02:00
Paul Chavard
11065946ce fix(instructeur): fix dossiers suivis filter (merge behavior change in rails 7) 2023-05-04 18:24:18 +02:00
Paul Chavard
616188bfe3 feat(administrateur): when clone or preview procedure should use published revision if not the owned 2023-05-04 16:15:55 +02:00
simon lehericey
9c8020b05c feat(admin): add initiation procedure for a new admin 2023-05-03 15:08:21 +02:00
Colin Darie
eabc9069f8 test(super-admin): more explicit disable otp test 2023-05-03 11:37:28 +02:00
Nicolas Cavigneaux
06296e933a
fix: super admin test where attribute was not reloaded 2023-05-03 11:35:28 +02:00
Martin
c8ab1e8e03 amelioration(dossier#submit_brouillon): ETQ usager, je souhaite pouvoir acceder aux champs en erreur facilement 2023-05-03 07:36:42 +02:00
Paul Chavard
f2c1c071b4 Revert "Merge pull request #8899 from demarches-simplifiees/8738-validate-adresse-electronique"
This reverts commit d3eda28f35, reversing
changes made to 6394996e7f.
2023-04-28 16:10:20 +02:00
Paul Chavard
a41713c837
Merge pull request #8968 from demarches-simplifiees/fix_defaut_groupe_instructeur_again
Correctif: definit le groupe instructeur par defaut pour certaines procedure clonées
2023-04-26 17:59:13 +00:00