Commit graph

11251 commits

Author SHA1 Message Date
Martin
aae26a863a perf(admin#dashboard): skip validation of PJ 2024-01-25 17:29:39 +01:00
Martin
271ac14fad perf(draft_changed?): do not try to compare revisoin if they are not loaded 2024-01-25 17:20:30 +01:00
Martin
60800b6113 perf(editor): better perf to add, destroy, update, move up, move down and move with number 2024-01-25 15:49:44 +01:00
Martin
4f0e247883 perf(types_de_champs_controller): avoid n+1 query in select_champ_template_position_component 2024-01-25 14:19:55 +01:00
Martin
50d148d412 perf(types_de_champs_controller): preload procedure to avoid n+1 query in champs_summary 2024-01-25 14:19:55 +01:00
Colin Darie
50b9813b4d
Merge pull request #9932 from colinux/lock-submit-fork
Correctif: ETQ usager, je ne peux pas soumettre 2x mes modifications en parallèle
2024-01-25 11:37:56 +00:00
Colin Darie
4aa1306536
feat(transfer): make it silent in case dossier had been destroyed between queuing and processing
Co-authored-by: mfo <mfo@users.noreply.github.com>
2024-01-25 11:31:12 +01:00
simon lehericey
588e58195c move api_tokens to admin module 2024-01-25 11:27:15 +01:00
simon lehericey
3ded9a2a57 feat(api): add some turbo when possible 2024-01-25 11:17:44 +01:00
simon lehericey
9a0dd45385 feat(api): add invalid ip addr error 2024-01-25 11:17:44 +01:00
simon lehericey
eae07cab8c refactor(api): use the new api token creation wizard 2024-01-25 11:17:44 +01:00
simon lehericey
852eedbc50 refactor(api): create api_token with validity and network filtering 2024-01-25 11:17:44 +01:00
simon lehericey
943368c68f feature(api): setup securite 2024-01-25 11:17:44 +01:00
simon lehericey
8a9e5754a1 feature(api): setup autorizations 2024-01-25 11:17:44 +01:00
simon lehericey
1d7b6a6a54 feature(api): setup name 2024-01-25 11:17:44 +01:00
simon lehericey
47076063bb feature(api): remove update 2024-01-25 11:17:44 +01:00
simon lehericey
b635c940ae refactor(UI api token): add more information to api token list
- network filtering
- validity
- last used

remove creation logic
2024-01-25 11:17:43 +01:00
Colin Darie
27cfae8c6a
chore(dossier): warn user that deletion also means transfer cancellation 2024-01-25 11:03:54 +01:00
simon lehericey
a23eb80d22 fix(profil): use fr-container 2024-01-25 10:51:58 +01:00
simon lehericey
7e8555923f feature(api): add ensure_token_is_not_expired to api_controller v1 and v2 2024-01-25 10:51:58 +01:00
simon lehericey
d8bc38bc69 feature(api): add ensure_authorized_network for api_controller v1 and v2 2024-01-25 10:51:58 +01:00
simon lehericey
6e5678d1c2 feature(api): add forbidden_network? to api_token 2024-01-25 10:51:58 +01:00
simon lehericey
4c94eca7c0 clean(ui): remove useless warning 2024-01-25 10:51:58 +01:00
Colin Darie
8e6a1c58b2 feat(correction): badge Corrigé when a correction has been resolved
Closes #9928
2024-01-24 17:26:34 +01:00
Kara Diaby
261932b56f
Merge pull request #9890 from demarches-simplifiees/feat/9725
ETQ expert, je souhaite être notifié des nouveaux messages
2024-01-24 13:17:57 +00:00
Colin Darie
520a7c4402
fix(exports): don't try to link to an export when file is not yet attached 2024-01-24 13:36:25 +01:00
Raphaël Dubigny
7584c17342
Remove user_email input autofocus on agent page
This avoid automatic scroll on page load so the AgentConnect button is visible.
2024-01-24 12:00:32 +01:00
Kara Diaby
ac29cfbfdb Envoie un email à l'expert en cas de nouveau commentaire de l'usager dans la messagerie 2024-01-24 10:48:17 +00:00
Colin Darie
56f8b61866
feat(dossiers): lock submit en construction to avoid merge collisions with double submits 2024-01-24 10:58:40 +01:00
Martin
2952987ad8 refactor(spec): stop using procedure type de champs traits as :with_datetime, :with_xxx in favor of :types_de_champ_public which keeps position in check 2024-01-23 17:30:22 +01:00
Colin Darie
716e4bbe5d
Merge pull request #9645 from adullact/feature-ouidou/admin_creation_delegation_gestionnaire_answer_administrateur
Feature ouidou/admin creation delegation gestionnaire answer administrateur
2024-01-22 15:45:58 +00:00
Martin
0f194a5e8e refactor(procedure_revision): without renumber, use types_de_champ_public factory for ordered champs 2024-01-22 14:57:04 +01:00
mfo
89d2c57cb2 review(sim): some review suggestions
Co-authored-by: LeSim <mail@simon.lehericey.net>
2024-01-22 14:57:04 +01:00
Martin
5c049a1c0f feat(update_draft_revision_type_de_champs_task): force to use real position otherwise have to process parent_coordinates... 2024-01-22 14:57:04 +01:00
Martin
434cd77030 poc(spec): renumber only at one point 2024-01-22 14:57:04 +01:00
Martin
a9c0d3e7e9 tech(clean): avoid useless indirection, cleanup some code complexity, rubocopify 2024-01-22 14:57:04 +01:00
Martin
a78a6b6f34 feat(remove_type_de_champ): stop renumbering all procedure_revision_type_de_champ on remove_type_de_champ 2024-01-22 14:57:04 +01:00
Martin
4d97c5bc8a feat(move_type_de_champ): stop renumbering all procedure_revision_type_de_champ on move_type_de_champ 2024-01-22 14:57:04 +01:00
Martin
4b57ed871a feat(add_type_de_champ): stop renumbering all procedure_revision_type_de_champ 2024-01-22 14:57:04 +01:00
seb-by-ouidou
0bb189d027 feat: replace fail by flast alert 2024-01-22 14:36:38 +01:00
seb-by-ouidou
a6ca4b668e feat: answer message to administrateur as gestionnaire 2024-01-22 14:36:38 +01:00
seb-by-ouidou
b19413643c feat: write message to gestionnaires as administrateur 2024-01-22 14:36:38 +01:00
seb-by-ouidou
9ff1e57feb feat: US5.1 US5.2 administrateur in admin 2024-01-22 14:36:38 +01:00
seb-by-ouidou
e6474f0d14 feat: US4.3.9 children management 2024-01-22 14:36:38 +01:00
seb-by-ouidou
96dd6bec52 feat: US4.3 update and delete groupe gestionnaire 2024-01-22 14:36:38 +01:00
Colin Darie
2f53a017b4
Merge pull request #9886 from colinux/export-ff-active-revision-first
Tech exports: feature flat pour trier les colonnes par révision récente puis position plutôt que mélanger les révisions entre elles
2024-01-22 12:21:32 +00:00
Colin Darie
58c00b2d4e
feat(export): can sort by revision first, instead of mixing revisions 2024-01-22 12:03:30 +01:00
Colin Darie
7892b54aa6 fix(discarded-dossiers): don't crash whole job when a single dossier causes an error 2024-01-17 13:15:42 +01:00
Colin Darie
1a8f839a7e
Merge pull request #9915 from colinux/fix-admin-memory-leak
Perf: remplace les `OpenStruct` par des objets plus performants
2024-01-17 08:59:01 +00:00
Colin Darie
a4db911585
perf(admin): remove 2 useless zones queries on each admin page due to navigation 2024-01-16 19:43:58 +01:00
Colin Darie
e1102ed993
perf(admin): fix N+1 on procedures zones on every admin page 2024-01-16 19:43:56 +01:00
Colin Darie
4408f0f4fb
perf(zone): replace OpenStruct by a Struct label model 2024-01-16 19:43:25 +01:00
Colin Darie
e807752a78
perf(type-de-champ): replace stable_self OpenStruct by Struct model 2024-01-16 19:43:23 +01:00
Colin Darie
fa74cdb4c7
perf(null-zone): replace open struct by struct 2024-01-16 19:43:22 +01:00
Colin Darie
461e311d3d
perf(admin): replace ProcedureDetail open struct with proper struct 2024-01-16 19:43:19 +01:00
Lisa Durand
42d91c1eee correction from PR reviews 2024-01-16 11:23:17 +01:00
Lisa Durand
6773843d52 add clickable summary in champ editor view for admin 2024-01-16 11:23:14 +01:00
Lisa Durand
d9b75ce0a2
Merge pull request #9882 from demarches-simplifiees/add-dossier-reference-in-transfer-email
Je veux que le numéro du dossier apparaisse dans l'email de demande de transfert
2024-01-15 15:39:09 +00:00
mfo
0328446bee
Merge pull request #9861 from demarches-simplifiees/US/move-type-de-champ-with-select
ETQ administrateur, je peux deplacer un champ via un select
2024-01-15 13:09:56 +00:00
Martin
68e9d3513d tech(clean): drop drag and drop champs in editor, ux not ok 2024-01-12 11:00:29 +01:00
Martin
69346ad41f tech(review): implement some pair review suggestions 2024-01-12 11:00:29 +01:00
Colin Darie
8a83fd2ce0
fix(recherche): show notification indicator for instructeurs 2024-01-12 10:09:34 +01:00
Martin
e7eee7ba72 spec(move_and_morph): add some spec and lint with rubocop/haml/eslint 2024-01-11 16:12:09 +01:00
Martin
857a1fc496 fix(select_champ_position): rewire for more robust and easier implementation which work with repetition avoiding double submit 2024-01-11 16:01:24 +01:00
Martin
b4d32e656f feat(ChampComponent): add procedure_revision_type_de_champ.position to ui 2024-01-11 16:01:24 +01:00
Martin
dce06f22a0 feat(type_de_champ_editor): add SelectChampTemplatePosition which feeds SelectChampPositionComponent options 2024-01-11 16:01:24 +01:00
Martin
11de4bdfb6 feat(types_de_champ_editor.ts): wires move_and_morph with type de champs editor [for now, the select is empty and will be synced] 2024-01-11 16:01:24 +01:00
simon lehericey
586e4ed613 to be sure, delete possible email_merge_token if correct password merge 2024-01-11 11:33:38 +01:00
simon lehericey
e12dbe7aad use email_merge_token in email merge 2024-01-11 11:33:38 +01:00
simon lehericey
ca08b80c3e use email_merge_token in mailer 2024-01-11 11:33:38 +01:00
simon lehericey
fca28a3ebd use email_merge_token in mail_merge_with_existing_account route 2024-01-11 11:33:38 +01:00
simon lehericey
90f145e17a add email_merge_token to france connect information 2024-01-11 11:33:38 +01:00
simon lehericey
4c7b494c9d be consistent in france_connect_email sanitation 2024-01-11 11:33:38 +01:00
simon lehericey
6bad272825 style 2024-01-11 11:33:38 +01:00
Colin Darie
0dd3b16d10
Merge pull request #9637 from adullact/feature-ouidou/admin_creation_delegation_administrateur_contact_gestionnaire
Delégation de compte admin: ETQ admin je peux contacter mon/mes gestionnaires de groupe
2024-01-11 09:04:34 +00:00
mfo
e2cb833a51
Merge pull request #9896 from mfo/US/fix-combobox-with-not-trimmed-option
fix(combobox): some old procedure still have options with trailing white spaces. ensure to trim selected value as well as options.value for better comparison
2024-01-11 08:40:11 +00:00
seb-by-ouidou
c45e2eaccc feat: write message to gestionnaires as administrateur 2024-01-09 13:25:04 +01:00
seb-by-ouidou
07dd7a1283 feat: US4.3.8 administrateur management 2024-01-09 13:25:04 +01:00
Colin Darie
103e39159b style(admin): fix alignement in editor with type de champ used by routing 2024-01-08 18:13:33 +01:00
Colin Darie
bdff9a6064 style(admin): improve dark theme on editor section titles & borders 2024-01-08 18:03:07 +01:00
simon lehericey
560c2d763c fix(view_component): use new slot name 2024-01-08 11:57:47 +01:00
mfo
a0248bf08b
Merge pull request #9888 from mfo/US/validate-epci-by-code
Correctif: Le noms des EPCIs changent, ce qui bloque la validation et ou demande a resaisir le champs
2024-01-08 09:56:09 +00:00
Martin
6c5f6dd6f6 fix(combobox): some old procedure still have options with trailing white spaces. ensure to trim selected value as well as options.value for better comparison 2024-01-08 10:29:43 +01:00
Martin
fa07c21ec3 fix(champs.epci): epci names change over time. remap when it occurs 2024-01-04 07:17:15 +01:00
mfo
9df978f6fa
Merge pull request #9887 from mfo/US/fix-fci-missing-device-callback
Correctif: ETQ usager invité, lorsque je crée mon compte via FC, je ne retrouve pas mes invitations
2024-01-04 06:15:14 +00:00
Martin
4073804b00 feat(administrateurs/types_de_champ_controller#move_and_morph): add action to move and morph fields between two coordinates 2024-01-03 11:08:53 +01:00
mfo
e076de2f12
Merge pull request #9889 from mfo/US/allow-dossier-link-in-repetitions
amelioration: ETQ admin je peux utiliser les champs de type dossier dans les répétitions
2024-01-02 08:47:55 +00:00
mfo
002a14188d
Merge pull request #9875 from mfo/US/hint-regexp
ETQ admin, quand je configure un type de champ regexp, j'ai une petite mention sur le bornage de celle ci
2023-12-27 09:43:05 +00:00
Martin
7c5a297bc7 feat(repetitions): allow dossiers links in repetitions 2023-12-26 17:39:01 +01:00
Martin
92730e266b fix(FranceConnect): missing after_confirmation callback, leading to invalites invitations when user france connect 2023-12-26 15:00:15 +01:00
LeSim
d4b4274d26
Merge pull request #9885 from demarches-simplifiees/fix-a-few-typos
Corrections de typos
2023-12-22 22:48:11 +00:00
Eric Leroy-Terquem
a56fa60c78 fix typos 2023-12-22 11:39:09 +01:00
mfo
d69dc6e2c9
Merge pull request #9884 from mfo/US/fix-missing-trad-on-new-commencer
correctif: ETQ usager naviguant sur le site en anglais, j'aimerais que le bloc pour choisir si je depose le dossier pour moi ou qqun d'autre soit traduit
2023-12-22 10:09:00 +00:00
Eric Leroy-Terquem
24563a3c18 fix(personnes impliquees): display reaffectations block only if procedure is routed 2023-12-22 10:57:53 +01:00
Eric Leroy-Terquem
cf97af0d7e chore(groupe_instructeurs): remove dead code replaced by routing rules
component
2023-12-22 10:57:53 +01:00
Eric Leroy-Terquem
547a4d95b7 chore(logic): commune and epci champs are always compute with compute_value_json 2023-12-22 10:57:53 +01:00
Martin
ff09130180 fix(i18n): add missing i18n on /commencer 2023-12-22 10:48:10 +01:00
Colin Darie
deab400057
Merge pull request #9578 from adullact/feature-ouidou/admin_creation_delegation_administrateur_pages
Feature ouidou/admin creation delegation administrateur pages
2023-12-22 09:06:58 +00:00
Martin
cc02618bfe feat(TypeDeChampEditor.regexp): add hint regarding regexp begin/finish
Co-authored-by: LeSim <mail@simon.lehericey.net>
Co-authored-by: Colin Darie <colin@darie.eu>
2023-12-22 09:47:04 +01:00
mfo
c4adee6278
Merge pull request #9878 from mfo/US/fix-not-type-ej-in-api
API: cast le type de champ EJ
2023-12-22 07:20:13 +00:00
seb-by-ouidou
e79de57fb5 fix: few fixes after review 2023-12-21 18:40:36 +01:00
seb-by-ouidou
c253e7dd65 feat: US5.1 US5.2 administrateur in admin 2023-12-21 18:40:36 +01:00
seb-by-ouidou
91602ee1c1 feat: US1.10 administrateur in manager 2023-12-21 18:40:36 +01:00
Colin Darie
6f7d786783
Merge pull request #9880 from demarches-simplifiees/api_token_store_last_used_ips
API: stocke les ips utilisées pour accéder à l'API
2023-12-21 16:18:00 +00:00
Lisa Durand
ff284a1c96 add more info in notify transfer email 2023-12-21 16:58:33 +01:00
Martin
989a7ba787 feat(API): cast type de champ EJ in a dedicated graphql type 2023-12-21 16:21:31 +01:00
Eric Leroy-Terquem
4c82f2c9d7 fix(champ value): fix compute_value_json on departement champ 2023-12-21 16:21:08 +01:00
simon lehericey
afb6eacf57 feature(api): store any ip used 2023-12-21 16:02:11 +01:00
Colin Darie
9bdf525ff1
Merge pull request #9863 from colinux/fix-message-html-injection
Tech: échappe les tags de données utilisateur dans les modèles pour email
2023-12-21 08:50:21 +00:00
Colin Darie
29df9ad09d
Merge pull request #9751 from tchak/departement-tags
feat(champs): expose more tags and api fields on rnf, address and commune
2023-12-21 08:45:01 +00:00
Colin Darie
e17c3bd046
Merge pull request #9839 from mfo/US/fix-filter-focus-out-with-not-selected-filter
correctif : ETQ instructeurs, lorsque je sors du composant de filtrage sans choisir une option, le site renvoie une erreur
2023-12-21 08:42:12 +00:00
Colin Darie
535a54ce97
Merge pull request #9874 from demarches-simplifiees/add-email-for-tiers-when-repasser-en-instruction-ldu
[Co-construction] Envoyer un mail au bénéficiaire si le dossier repasse en instruction
2023-12-21 08:32:10 +00:00
Lisa Durand
c311d6dc46 add url for civil code reference 2023-12-20 11:51:33 +01:00
Lisa Durand
3e872c5246 add email for tiers when repasser en instruction 2023-12-20 11:51:02 +01:00
Lisa Durand
e52bd9d6bf
Merge pull request #9855 from demarches-simplifiees/display-last-export-in-same-page-ldu
ETQ instructeur, j'ai besoin d'un accès très facile à mondernier export
2023-12-20 10:02:08 +00:00
Eric Leroy-Terquem
882d72d139 data(conditional): add a maintenance task to update conditions based on commune or epci champ 2023-12-19 17:39:40 +01:00
Eric Leroy-Terquem
e4632214fb data(conditional): add a maintenance task to update routing rules based on commune or epci champ 2023-12-19 17:39:39 +01:00
Eric Leroy-Terquem
954facdaff
Merge pull request #9798 from demarches-simplifiees/add-new-operators-to-conditional
Etq admin je peux conditionner/router avec les opérateurs "est dans mon département",  "n'est pas dans mon département",  "est dans ma région" et   "n'est pas dans ma région".
2023-12-19 16:10:59 +00:00
Lisa Durand
e6a4459633 refacto 2023-12-19 16:54:23 +01:00
Lisa Durand
f553f3c408
Merge pull request #9872 from demarches-simplifiees/add-badge-for-role-ldu
ETQ utilisateur avec plusieurs rôles, je m'y retrouve plus facilement
2023-12-19 11:01:28 +00:00
mfo
e75c4456e8
Merge pull request #9871 from mfo/US/add-pj-to-explication
ETQ administrateur, je peux ajouter une notice explicative a un champs explication
2023-12-19 10:44:03 +00:00
Lisa Durand
c767164e28 add expert in current_account and mode badge to the right 2023-12-19 11:33:48 +01:00
Martin
6f01a10846 tech(clean): move from custom spacer classes to dsfr spacer classes 2023-12-19 11:31:55 +01:00
Martin
4bc8eaa192 ui(ChampComponent): move TypeDeChamp.explication options in the right column of the editor 2023-12-19 11:31:28 +01:00
Lisa Durand
1541da9d39 add specific routes and action for polling 2023-12-19 11:10:03 +01:00
Martin
e43c2f1407 feat(procedure_revision.compate): track and show diff for TypeDeChamp.explication between draft and published revisions 2023-12-19 10:51:06 +01:00
Lisa Durand
0286d2b6fb add profiles in flash after sign-in if multiple profile 2023-12-19 10:33:26 +01:00
Martin
f7feca5fd1 feat(editable_champ.explication): show downloadable AttachedOne 2023-12-19 09:53:27 +01:00
Martin
37e8772eab feat(type_de_champ_editor.explication): add a Attached::One to TypeDeChamp.explication, named notice_explicative [cf, cerfa wording] 2023-12-19 09:52:27 +01:00
Lisa Durand
dfc09648d8 add badge with role in user dropdown in header 2023-12-18 14:39:27 +01:00
Colin Darie
e9ee405954
Merge pull request #9868 from colinux/blocking-pending-correction-ff
ETQ instructeur je peux de nouveau passer en correction un dossier avec corrections en attente
2023-12-18 13:29:39 +00:00
Colin Darie
1a56fe620e feat(correction): make pending corrections blocking by feature flag only 2023-12-18 14:12:45 +01:00
Lisa Durand
53f9f3cbdb add trad if export failed 2023-12-18 14:09:47 +01:00
Lisa Durand
a9ab1daf3a display alert only for instructeur who generated the export and if recent 2023-12-18 11:25:52 +01:00
Martin
7dd9e0d255 amelioration(editeur-de-champ): ETQ admin, une alert DSFR m'informe de la difference entre un champ PJ classique et un champ titre d'identité 2023-12-18 10:26:21 +01:00
simon lehericey
9bb89f7e3e fix(print): missing dossier var 2023-12-18 09:51:41 +01:00
Colin Darie
fa37c6c62b
fix(tags): escape user data tags for emails 2023-12-15 14:05:11 +01:00
Colin Darie
c0b444d747
Merge pull request #9847 from colinux/fix-style
Style: plusieurs améliorations mineures / thème sombre
2023-12-15 12:00:53 +00:00
mfo
b539fe1b65 amelioration(review): tech review
Co-authored-by: Colin Darie <colin@darie.eu>
2023-12-15 11:23:25 +01:00
Martin
0caacdaf59 amelioration(combobox): utilise une loupe plutot qu'un chevron bas pour les combobox en mode autocomplete 2023-12-15 11:23:25 +01:00
Martin
95fd6c2a69 tech(combobox): propage le changement de signature dans le reste de la codebase 2023-12-15 11:23:25 +01:00
Martin
d27e4fc693 amelioration(combobox): permet de passer des options au input[type=hidden], utilise cette option pour autosubmit uniquement un input [dans notre cas, ne soumet pas a l'input du combobox, mais a l'input hidden une fois le combobox selectionné] 2023-12-15 11:23:25 +01:00
Colin Darie
7ba13507ff
Merge pull request #9808 from colinux/remove-usager-antivirus
ETQ usager, je ne vois plus le statut "antivirus en cours" lorsque j'envoie un PJ
2023-12-14 19:53:34 +00:00
Colin Darie
9a5d908851
Merge pull request #9853 from mfo/US/fix-expert-link-to-dossiers
ETQ expert: lorsque je me connecte, je suis redirigé vers la page des avis, non pas vers la page de mes dossiers
2023-12-14 19:52:32 +00:00
Colin Darie
3b0e4e59d5
Merge pull request #9858 from colinux/fix-invite-html-injection
Tech: sanitize les messages utilisateurs dans les emails
2023-12-14 17:27:28 +00:00
Lisa Durand
569d4af6f7
Merge pull request #9706 from demarches-simplifiees/feat/9678
ETQ usager passant par un mandataire, je suis notifié des changements d'état de mon dossier par email
2023-12-14 16:57:07 +00:00
Eric Leroy-Terquem
2e547cd46f chore(routing): cannot create simple_routing with champs communes or epcis 2023-12-14 17:48:14 +01:00
Eric Leroy-Terquem
e40d1107ac chore(conditional): add not_in_departement and not_in_region operators 2023-12-14 17:48:14 +01:00
Eric Leroy-Terquem
3db21b633c chore(conditional): update champs to use in_region operators 2023-12-14 17:48:13 +01:00
Eric Leroy-Terquem
c9676020b4 chore(conditional): add in_departement and in_region operators 2023-12-14 17:48:13 +01:00