Commit graph

3460 commits

Author SHA1 Message Date
simon lehericey
c0fe06ceb7
refactor: simplify ZxcvbnService 2024-09-18 12:57:58 +02:00
Colin Darie
39ebaadf03
Merge pull request #10811 from colinux/fix-stats-nav-bar
ETQ usager, pas d'erreur sur la page stats quand je viens de la page commencer (à cause de la navbar)
2024-09-17 16:05:24 +00:00
Colin Darie
79a1d9b99d
fix(navbar): never fail request on broken navbar logic 2024-09-17 16:18:16 +02:00
Colin Darie
b68b340d81
fix(stats): nav bar profile logic when fallbacking on referer context without request 2024-09-17 15:59:24 +02:00
Eric Leroy-Terquem
969706163b
Merge pull request #10641 from demarches-simplifiees/move-image-treatment-to-jobs
Technique : déplace les traitements d‘images côté jobs
2024-09-17 13:43:51 +00:00
Paul Chavard
54926db89b
refactor(champ): more concistent champ_for_update usage 2024-09-17 10:29:34 +02:00
Paul Chavard
df83322f0c
refactor(apiv1): use dossier preloader on api v1 2024-09-17 10:29:34 +02:00
mfo
7bbf04b9b5
Merge pull request #10774 from mfo/US/fix-PG-NumericValueOutOfRange
correctif: ETQ instructeur, si j'ai essayé de filtrer mes dossiers par numéro et que j'ai saisi un numero superieur à 2147483647, ma page ne doit pas planter
2024-09-16 14:43:59 +00:00
mfo
6af07dd721
data(fix): backfill invalid procedure presentation filters having a value greater than pg max integer 2024-09-16 16:36:02 +02:00
Paul Chavard
e9009025f6
Merge pull request #10736 from demarches-simplifiees/fix-notif-to-instructeurs-when-import
Correctif: lors de l‘import en masse d'instructeurs, les nouveaux instructeurs reçoivent un lien pour vérifier leur email
2024-09-16 13:31:33 +00:00
Lisa Durand
22e06bc5eb
change password complexity library and setup 2024-09-16 15:28:14 +02:00
Colin Darie
58037f21cd
Merge pull request #10778 from colinux/sharerd-controller-nav-bar-profile
UX: améliore la détection du type de profile utilisé pour la nav bar
2024-09-16 08:01:03 +00:00
Paul Chavard
f00ba04fb9
graphql(playground): fix acl 2024-09-13 14:28:13 +02:00
Colin Darie
d566186954
fix: coherent nav bar profile for super admins 2024-09-12 10:00:19 +02:00
Colin Darie
16e1daac9b
fix(recherche): respects nav bar profile context 2024-09-12 10:00:18 +02:00
Colin Darie
0309e0f6b2
refactor(profile): generalize profile from referrer or for user 2024-09-12 10:00:18 +02:00
Mathieu Magnin
a99fae168c
[#10751] Allow sending a new invitation if the user's previous one has expired 2024-09-11 18:45:15 +02:00
Mathieu Magnin
790177c758
[#10751] Only send the first invitation mail to the instructeur if email is not verified (from admin controller) 2024-09-11 18:45:15 +02:00
Mathieu Magnin
d7811fca40
[#10751] Only send the first invitation mail to the instructeur if email is not verified 2024-09-11 18:45:15 +02:00
Colin Darie
b987688d19
refactor: disable auto hide instructeurs toggle by admin 2024-09-11 17:20:57 +02:00
Colin Darie
6e9fb7f247
Merge pull request #10740 from colinux/debug-email-verified
ETQ tech et super-admin, je veux voir rapidement si un user a son email verifié
2024-09-09 07:23:32 +00:00
Colin Darie
1515e67651
Merge pull request #10760 from demarches-simplifiees/fix_unverified_admin_email
ETQ Administrateur, je peux recevoir des mails lorsque je valide mon compte depuis le mail d'invitation
2024-09-09 07:07:26 +00:00
Mathieu Magnin
71d43078ee
Merge pull request #10743 from demarches-simplifiees/fix-10742
ETQ instructeur mon adresse email est automatiquement vérifiée quand je me connecte par AgentConnect
2024-09-06 14:26:54 +00:00
Mathieu Magnin
628be7c703
update => update! 2024-09-06 16:18:25 +02:00
Mathieu Magnin
22473adec7
[#10742] Set email as verified when instructeur signs in with Agent Connect 2024-09-06 16:18:11 +02:00
Mathieu Magnin
8d68bebaed
Merge pull request #10761 from demarches-simplifiees/fix-10754
ETQ Instructeur, si je n'ai pas vérifié mon email je dois quand même recevoir un email avec login token
2024-09-06 14:14:54 +00:00
LeSim
723ea310ba
Merge pull request #10758 from demarches-simplifiees/fix-10752
ETQ Instructeur je veux avoir mon email vérifié si je reset mon mdp
2024-09-06 13:36:29 +00:00
Mathieu Magnin
d1749c2baf
[#10754] verify email when using login token 2024-09-06 14:56:44 +02:00
simon lehericey
277c1a17c6
set verified_email when admin set its password from email link 2024-09-06 14:51:48 +02:00
mfo
915779c9b0
Merge pull request #10749 from mfo/US/commune-without-insee
correctif: ETQ administrateur/instructeur, je souhaite que les champs de type commune aient tjr un code insee afin de router de maniere fiable
2024-09-06 11:44:00 +00:00
Mathieu Magnin
9e843a3df4
[#10752] set email verified after password reset 2024-09-06 12:06:05 +02:00
Eric Leroy-Terquem
7dc853ad1c
refactor(instructeurs import): extract notify_instructeurs method 2024-09-06 10:00:17 +02:00
Eric Leroy-Terquem
d361ce2e38
fix(instructeurs import): send confirmation link if new instructeurs 2024-09-06 10:00:17 +02:00
mfo
ace2f4382f
tech(refactor): DataSources::CommuneController, move request methods to fetch and format commune searched by postal_code or name 2024-09-06 08:37:08 +02:00
LeSim
9fd53b182a
Merge pull request #10570 from demarches-simplifiees/feat/10425
ETQ Usager se connectant par FC, je dois confirmer mon mail
2024-09-05 08:07:23 +00:00
Kara Diaby
c86ad15b8c
Ajoute hide_instructeurs_identity sur Procedures et dans l'interface admin 2024-09-04 15:00:03 +00:00
simon lehericey
eaef5c7e39
readapt name and logic 2024-09-04 08:08:01 +00:00
mfo
c0970693f3
fix(associate_user.with_existing_one): does not leak existing email when trying to choose an alternative email with france connect 2024-09-04 08:05:54 +00:00
Kara Diaby
b6d0502f39
modifications après dernière review 2024-09-04 08:05:54 +00:00
mfo
88a4619dcb
feat(particulier#associate_user): catch email already taken and redirect to reset password 2024-09-04 08:05:53 +00:00
Kara Diaby
fb5968bf25
France connect particulier controller : permet de gérer le cas ou le mail n'est pas connu de DS
Signed-off-by: Kara Diaby <kdiaby.pro@gmail.com>
2024-09-04 08:05:51 +00:00
Colin Darie
d29cf3d222
refactor(activation): more readable condition 2024-09-03 16:51:00 +02:00
Colin Darie
e7443c2308
Revert "Champ related cleanups and refactoring" 2024-08-30 16:43:30 +02:00
Eric Leroy-Terquem
4d0961d3ec
chore: remove uninterlacing from web machines 2024-08-30 14:28:43 +02:00
Eric Leroy-Terquem
00c905a615
chore: generate variant for procedure logo in background 2024-08-30 14:28:42 +02:00
simon lehericey
6677f31652
use path_rewrite in commencer controller 2024-08-29 17:01:40 +02:00
Paul Chavard
1aee7ab1d2
refactor(champ): more concistent champ_for_update usage 2024-08-26 14:53:56 +02:00
Paul Chavard
8ccf2bed4c
refactor(apiv1): use dossier preloader on api v1 2024-08-26 14:53:56 +02:00
Eric Leroy-Terquem
fade633828
feat(routing): can create simple routing with address tdc 2024-08-26 11:16:47 +02:00
Lisa Durand
8e7e8d9624
Merge pull request #10705 from demarches-simplifiees/email-expert-need-confirmation-ldu
ETQ expert, je dois confirmer mon mail
2024-08-22 12:53:52 +00:00
Colin Darie
77fb0553fc
chore: enable freeze string literals by comment 2024-08-22 09:26:48 +02:00
Lisa Durand
3cf3dc4623
make email confirmation more generic 2024-08-21 16:23:56 +02:00
Lisa Durand
ea354d46c4
Create new invitation email if expert not confirm 2024-08-21 16:19:51 +02:00
Colin Darie
c1f4bd0ba3
Merge pull request #10700 from colinux/fix-persisting-pp-error
ETQ instructeur, n'affiche pas 2 fois le message de réinitialisation du tableau de dossiers
2024-08-21 07:23:15 +00:00
Colin Darie
8c6a7a8528
fix(instructeur): don't display twice pp error on get requests 2024-08-20 18:30:20 +02:00
Lisa Durand
066a2bea85
use main navigation to display deleted dossier for user 2024-08-20 15:26:14 +02:00
Lisa Durand
a0a9270a61
remove deleted dossier from filter and search 2024-08-20 15:26:14 +02:00
Lisa Durand
30df5aa89a
add page link and page to access deleted dossier historique 2024-08-20 15:26:14 +02:00
Lisa Durand
ab483a8959
simplifie tabs supprimes and reduce to one 2024-08-20 15:26:09 +02:00
mfo
bc7264ee08
Merge pull request #10625 from demarches-simplifiees/US/cleanup-procedure-presentation
ETQ tech, je souhaite isoler le concept des colonnes extractable/cherchable/affichable d'une demarche
2024-08-20 09:04:23 +00:00
Paul Chavard
ba92216504
Merge pull request #10614 from tchak/graphql-only-allow-saved-queries-without-token
secu(graphql): without a token, only saved queries are allowed
2024-08-20 08:11:48 +00:00
mfo
dba6f9b3aa
refactor(Facet): to column 🚀 2024-08-19 15:46:14 +02:00
mfo
b6464c1963
tech: use facet_id to sort fields 2024-08-19 15:30:08 +02:00
mfo
60c6c86d70
ProcedurePresentation.displayable_fields_for_select -> InstructeurFacetPickerComponent.displayable_fields_for_select 2024-08-19 15:29:59 +02:00
simon lehericey
379c9fb812
procedure should provide its facets 2024-08-19 15:29:59 +02:00
simon lehericey
14c5c26bb6
rubocop 2024-08-19 15:29:59 +02:00
simon lehericey
73293b0d06
give facet object instead of field_id to instructeur_filter_component 2024-08-19 15:28:36 +02:00
Colin Darie
e415c79ade
refactor(contact): builtin piece jointe attachment 2024-07-31 17:08:02 +02:00
Colin Darie
4b6d3ee16d
refactor(contact): support => contact 2024-07-31 17:08:02 +02:00
Colin Darie
e71c1781a9
fix(contact): add missing notices locales 2024-07-31 17:08:02 +02:00
Colin Darie
5af32b46f4
refactor(contact): form is persisted in db before pushed to HS 2024-07-31 17:08:01 +02:00
Colin Darie
ff62e99e7b
refactor(contact): suggest email correction, strict email validation, fix admin form 2024-07-31 11:23:17 +02:00
Colin Darie
90e6c8a6f6
Merge pull request #10603 from demarches-simplifiees/bug-input-pj-apres-suppression
ETQ Admin (bug), je veux pouvoir modifier des PJ sans recharger la page
2024-07-30 12:14:11 +00:00
Colin Darie
e467be1dbc
fix(dossier): can download an expired dossier 2024-07-30 14:06:43 +02:00
Paul Chavard
9d7d7da85a
Merge pull request #10572 from demarches-simplifiees/add-pj-from-messagerie-to-gallery
ETQ instructeur je peux voir les pjs envoyées par la messagerie dans l‘onglet "pièces jointes"
2024-07-30 09:35:14 +00:00
Paul Chavard
337eaff3f0
Merge pull request #10602 from demarches-simplifiees/fix-routing-fields-list
Correctif : ouvre l‘assistant de routage à tous les types de champ conditionnables
2024-07-30 09:01:24 +00:00
Paul Chavard
9aa86031cc
Merge pull request #10660 from colinux/fix-attestation-draft
ETQ admin sur une démarche en brouillon, l'attestation v2 est créé en brouillon si on a déjà une v1 active
2024-07-30 08:12:55 +00:00
Paul Chavard
12c11c563f
Merge pull request #10656 from colinux/fix-when-removing-all-displayed-fields
ETQ instructeur, pas d'erreur quand on veut enlever la dernière colonne affichée dans le tableau
2024-07-30 08:11:02 +00:00
Colin Darie
2689bc6721
fix(attestation): build v2 draft on draft procedure when a v1 is published 2024-07-29 17:06:54 +02:00
Colin Darie
a6554aa7bf
fix(users): don't expose email of accounts already confirmed 2024-07-29 12:07:02 +02:00
Colin Darie
6a6e643771
fix(instructeurs): don't fail when removing all displayed fields 2024-07-26 15:55:02 +02:00
simon lehericey
c4403bffeb
work on controller 2024-07-26 13:34:50 +02:00
Lisa Durand
e93ea356ab
Merge pull request #10488 from demarches-simplifiees/improve-mails-for-deleted-dossiers-ldu
[usager] Laisser un délai avant suppression des dossiers expirés
2024-07-25 15:14:30 +00:00
Lisa Durand
4f7b0c93d0
fix multiple errors from creation of dedicated method to restore and extend 2024-07-25 16:55:00 +02:00
Lisa Durand
b820577461
create a method to extend and restore 2024-07-24 17:07:48 +02:00
Lisa Durand
0dcdcb5643
add column hidden_by_expired_at 2024-07-24 17:07:41 +02:00
Lisa Durand
9346020889
dont use depreciated column hidden_at 2024-07-24 17:06:30 +02:00
Lisa Durand
8b88fafc25
add correct action for instructeur 2024-07-24 17:06:30 +02:00
Lisa Durand
c2abceaa72
hide expired dossiers instead of delete them 2024-07-24 17:06:30 +02:00
Paul Chavard
5aee51d5ac
refactor(routing_roules): simplify refresh conditions 2024-07-24 12:53:26 +02:00
Eric Leroy-Terquem
e413c0881e
chore(routing): update turbo stream only if champ used by routing rules has been updated 2024-07-23 10:23:54 +02:00
Eric Leroy-Terquem
f860745629
feat(routing): route when autosave of champ used by routing rules 2024-07-23 10:23:53 +02:00
Paul Chavard
229483d16c
refactor(champ): remove type_de_champ_id and champ factories 2024-07-22 13:53:45 +02:00
Paul Chavard
d6f9e57e77
secu(graphql): without a token, only persisted queries are allowed 2024-07-22 11:39:32 +02:00
Paul Chavard
c31321d695
chore(graphql): API::V2::DossiersController is not using tokens 2024-07-22 11:38:11 +02:00
Paul Chavard
38243434d2
refactor(graphql): add graphql_error helper 2024-07-22 11:38:11 +02:00
simon lehericey
bb6c43cbb9
do not give bad advice 2024-07-22 11:15:27 +02:00
Eric Leroy-Terquem
3bbcda9c04
refactor(dossier): refactor pieces jointes 2024-07-22 10:07:39 +02:00
Paul Chavard
888be8df89
feat(champs): use new combobox for champs selection multiple 2024-07-16 15:10:45 +02:00
Benoit Queyron
79ba52317a
limitation des params selon le type de PJ 2024-07-16 10:59:57 +02:00
Benoit Queyron
ec24ce3dad
ajustement test PJ dossier en construction 2024-07-16 10:51:17 +02:00
Lisa Durand
7630cc39fa
Merge pull request #10595 from demarches-simplifiees/email-mandant-need-confirmation-ldu
ETQ Mandant, je dois confirmer mon mail avant de recevoir des notifs
2024-07-15 14:00:38 +00:00
Lisa Durand
e9f5389f83
resent email if link too old and better style email 2024-07-15 12:00:03 +02:00
Lisa Durand
3eabcb0736
add tests 2024-07-15 11:56:18 +02:00
Benoit Queyron
dbacbd8ae2
ajustement pour PJ attestation 2024-07-12 18:08:51 +02:00
mfo
d5c8b7464c
fix(users.update_email): optimistic 2024-07-12 15:42:50 +02:00
Benoit Queyron
3e4aa0cde3
disabled input with PJ and insert input when PJ is deleted 2024-07-11 17:33:52 +02:00
Eric Leroy-Terquem
f31f70e9b9
feat(routing): configurate routage custom if no simple_routable_types_de_champ 2024-07-11 14:55:03 +02:00
Eric Leroy-Terquem
70d9d72a59
refactor(routing): extract configurate_routage_custom method 2024-07-11 12:17:46 +02:00
Eric Leroy-Terquem
60ff785009
refactor(type de champ): rename routable_types in simple_routable_types 2024-07-11 12:17:46 +02:00
Lisa Durand
7539d2ddea
fix specs 2024-07-10 16:11:38 +02:00
Lisa Durand
42633c0012
Merge branch 'main' of github.com:betagouv/demarches-simplifiees.fr into instructeur-invitation-include-typo-suggestion-ldu 2024-07-10 14:58:55 +02:00
Lisa Durand
3b138d5bb7
add confirmation for tiers email 2024-07-10 10:57:26 +02:00
Benoit Queyron
ebea9e3818
find champ by dossier stable_id row_id 2024-07-08 16:09:29 +02:00
Benoit Queyron
4bee40caa4
suppresion de la logique hidden 2024-07-08 16:09:23 +02:00
Benoit Queyron
70c1d30fe4
disabled attribut on input 2024-07-08 16:09:21 +02:00
Colin Darie
3e9cb6f388
Merge pull request #10576 from colinux/secure-cookies
Tech: cookies avec flag `secure` et `httponly`
2024-07-08 09:33:30 +00:00
Paul Chavard
c17351e50a
refactor(combo): use new multicombobox 2024-07-05 09:36:33 +02:00
Paul Chavard
8d6dc625f3
refactor(dossier): instructeur filter 2024-07-05 09:36:33 +02:00
Paul Chavard
cb01f15570
refactor(champ): update champ commune 2024-07-05 09:36:33 +02:00
Paul Chavard
f1f1af4e61
refactor(champ): update champ annuaire education 2024-07-05 09:36:33 +02:00
Lisa Durand
8ff2bbbaab
fix specs 2024-07-04 14:41:37 +02:00
Lisa Durand
67be27e18f
add typo detection and suggestion for instructeur adding instructeur 2024-07-04 13:56:02 +02:00
Lisa Durand
f163c04da6
add typo detection and suggestion for admin adding instructeurs 2024-07-03 16:53:23 +02:00
Lisa Durand
c8906d20b8
add reusable code in concern for typo detection email 2024-07-03 16:09:34 +02:00
Colin Darie
990dfbcf9e
chore(cookies): cookies http only 2024-07-03 11:54:10 +02:00
Colin Darie
1eb0bdb4ae
chore: cookies with "secure" flag (only transmitted through https) 2024-07-03 11:18:16 +02:00
Colin Darie
a53fc0fac9
fix(admin): invitation for experts not having an account 2024-07-02 16:15:24 +02:00
Colin Darie
5e25547b7b
fix(attestation): don't delete v1 published when building a v2 2024-07-02 14:10:23 +02:00
Paul Chavard
1bc714a81a
feat(manager): export administrators and instructeurs list 2024-07-02 11:07:39 +02:00
Eric Leroy-Terquem
2b0c53cd82
Merge pull request #10565 from demarches-simplifiees/add-demarches-publiees-page-in-manager
ETQ superadmin, je peux accéder aux informations essentielles des dernières démarches publiées
2024-07-02 07:46:30 +00:00
mfo
896ee76d74
Merge pull request #10524 from mfo/US/expert-invitation-by-admin
ETQ administrateur, lorsque je gère ma liste d'expert invités sur une démarche, je suis guidé pour eviter les typos
2024-07-01 09:59:15 +00:00
mfo
77bf93dfc2
feat(experts_procedures#create): link to typo errors 2024-07-01 11:01:38 +02:00
mfo
e6a3f210d4
fix(experts_procedures#create): ensure to reload expert list after addition 2024-07-01 10:46:06 +02:00
Lisa Durand
159cc942f6
Merge pull request #10549 from demarches-simplifiees/new-instructeur-need-mail-confirmation-ldu
ETQ nouvel instructeur, je dois confirmer mon mail
2024-07-01 08:45:57 +00:00
mfo
ced634295e
clean(tech): EmailChecker, use class method, not instance 2024-07-01 10:40:55 +02:00
Eric Leroy-Terquem
0a70c6b90f
manager: add a page for demarches publiees 2024-06-28 18:20:05 +02:00
Lisa Durand
b43b06cf3e
send correct mail if invitation from instructeur 2024-06-27 17:30:36 +02:00
Lisa Durand
d7893b9102
instructeur need to confirm mail after invitation 2024-06-25 15:14:26 +02:00
mfo
f83c565297
fix(expert_procedure): flash once 2024-06-25 14:42:00 +02:00
mfo
afa9821edb
perf(InvitationWithTypoComponent): check email once from controller, forward actuel/suggestion email from ctrl to view 2024-06-25 14:37:54 +02:00
mfo
2bb7584246
feat(administrateurs/experts_procedures#create): avoid typo on expert
list management
2024-06-25 14:04:01 +02:00
Colin Darie
417cac5b83
feat(faq): dynamic substitutions support
Ce code avait été initalement codé, mais le contenu de la FAQ n'en a à
ce stade plus besoin. On le garde sous le coude car c'est peu touchy
et ça pourrait bientôt resservir.
2024-06-24 16:29:32 +02:00
Colin Darie
a1edbd08a2
Merge pull request #10496 from tchak/fix-graphql-allow-requests-with-no-token
fix(graphql): use null_session forgery protection on graphql controller to allow open data requests
2024-06-24 10:11:35 +00:00
Colin Darie
ccf5b255ed
Merge pull request #10465 from colinux/attestations-v2-prod
ETQ admin je peux activer la délivrance des attestations v2 (sous feature flag)
2024-06-24 08:56:31 +00:00
Colin Darie
5ac2315b5a
Merge pull request #10535 from mfo/US/page-procedure-show
Améliroation, ETQ instructeur le nombre de dossier par page passe de 25 a 100
2024-06-24 08:14:56 +00:00
mfo
4e67255405
feat(instructeurs/procedure#show): increase dossier page size but keep request count same 2024-06-21 16:50:08 +02:00
mfo
4caeecadff
Merge pull request #10534 from mfo/US/fix-ineligibilite-rules-check-without-rules
Correctif: ETQ admin, je ne peux pas activer l'inéligibilité des dossiers sans règles d'inéligibilité
2024-06-21 09:47:43 +00:00
mfo
24d7b0b014
fix(ineligibilite_rules): prevent admin to enable ineligibilite rules without rules 2024-06-20 15:35:36 +02:00
mfo
9adb1bcf49
fix(ineligibilite_rules): cache bust champs.visible after checking for ineligibilite rules
Update app/models/dossier.rb

Co-authored-by: Paul Chavard <github@paul.chavard.net>
2024-06-20 15:20:32 +02:00