Nicolas Cavigneaux
7e0fbcf672
fix: ensure procedure used in remove_instructeur spec has routing_enabled set to true
2023-05-03 11:35:29 +02:00
Martin
c8ab1e8e03
amelioration(dossier#submit_brouillon): ETQ usager, je souhaite pouvoir acceder aux champs en erreur facilement
2023-05-03 07:36:42 +02:00
Paul Chavard
99abdf45e7
fix(api-entreprise): use new status endpoint
2023-04-27 22:39:44 +02:00
Paul Chavard
cb752d1857
fix(dossier): do not bypass depositaire check on modifier path
2023-04-27 09:52:10 +02:00
LeSim
4c5e903673
Merge pull request #8887 from demarches-simplifiees/8839-filter-by-siret
...
Filtrer les démarches par service
2023-04-26 19:44:08 +00:00
Martin
6a2d2ae0a7
bug(instructeurs/avis_controller#remind): ETQ instructeur, je peux relancer une demande d'avis meme si celui ci contient une question
2023-04-26 07:46:21 +02:00
Lisa Durand
26ff82dbe4
Merge branch 'main' of github.com:betagouv/demarches-simplifiees.fr into user-dashboard/add-alert-WIP-last-dossier
2023-04-25 13:01:40 +02:00
Martin
6739bfc665
bug(instructeurs.annotations): ETQ instructeurs, lorsque je saisie une autre valeur dans un champ de type choix simple, celle ci n'est pas sauvegardé
2023-04-21 09:35:16 +02:00
Paul Chavard
586286cb08
Merge pull request #8916 from demarches-simplifiees/can-update-defaut-groupe-instructeur-2
...
feat(routage): permet de changer le groupe par défaut
2023-04-20 08:28:46 +00:00
Paul Chavard
418d3b55d0
feat(stats): give access to stats on closed procedures
2023-04-19 18:31:58 +02:00
Colin Darie
9728493bda
Merge pull request #8924 from colinux/rubocop-upgrades
...
Tech: update rubocop, active nouveaux cops Rails/*
2023-04-19 13:37:10 +00:00
Eric Leroy-Terquem
aecd7559d2
feat(groupe instructeur): cannot disable default groupe instructeur
2023-04-19 13:52:42 +02:00
Eric Leroy-Terquem
09b05550ab
feat(groupe instructeur): cannot delete defaut_groupe_instructeur
2023-04-19 13:52:42 +02:00
simon lehericey
b38470368b
feat(routing): can change defaut groupe
2023-04-19 13:52:41 +02:00
Colin Darie
999f06075b
chore(rubocop): fix Rails/ResponseParsedBody
2023-04-19 12:55:13 +02:00
Colin Darie
b273e7b67e
chore(rubocop): fix Rails/RootPathnameMethods and assimiled cops
2023-04-19 12:55:13 +02:00
Paul Chavard
05cfb4055d
fix(dossier): improuve dossier state display
2023-04-19 12:27:16 +02:00
github-merge-queue[bot]
a286af8a70
Merge pull request #8918 from tchak/graphql-add-error-codes
...
ETQ intégrateur API, je voudrais avoir des codes d'erreur plus précis
2023-04-19 09:00:32 +00:00
Paul Chavard
ae1ec87397
feat(graphql): add code to timeout errors
2023-04-18 15:22:11 +02:00
Paul Chavard
f70532a844
feat(graphql): global not found error handling
2023-04-18 15:22:11 +02:00
Paul Chavard
fbae6d941d
feat(graphql): add error codes to graphql errors
2023-04-18 15:22:11 +02:00
Lisa Durand
c565ed415b
change scope and alert location after UI modification
2023-04-18 12:03:10 +02:00
Paul Chavard
bf6cc25063
feat(graphql): expose pendingDeletedDossiers on groupe instructeur
2023-04-17 18:43:00 +02:00
LeSim
c252748833
Merge pull request #8836 from demarches-simplifiees/improve-routing-rules-ux
...
feat(routing): nicer and safer ?
2023-04-17 08:23:15 +00:00
Paul Chavard
5abb6a8f12
chore(spec): remove memory store cache from tests
2023-04-13 13:10:23 +02:00
simon lehericey
c02319aa56
feat(routing): reset value if target as changed
2023-04-13 10:28:53 +02:00
simon lehericey
8b832396a3
feat(routing): server side: prevent changing tdc type if used for routing
2023-04-13 10:28:52 +02:00
simon lehericey
c1f67499aa
feat(routing): server side: prevent tdc deletion if used for routing
2023-04-13 10:28:52 +02:00
krichtof
78938b5a07
filter demarches by siret service
2023-04-12 18:53:57 +02:00
Lisa Durand
bc3e67ab94
add alert on user dashboard to edit last editable dossier
2023-04-11 15:50:17 +02:00
Paul Chavard
0b95a912c6
Merge pull request #8858 from tchak/feat-refactor-dossier-link-champ
...
feat(dossier): use turbo to select linked dossier
2023-04-07 08:49:11 +00:00
Paul Chavard
a2f7d1df72
fix(graphql): pendingDeletedSince should not crash
2023-04-06 15:07:48 +02:00
Paul Chavard
a5733002ed
feat(graphql): improuve logs
2023-04-05 13:56:26 +02:00
Paul Chavard
52c8b0b297
feat(dossier): use turbo to select linked dossier
2023-04-05 11:40:03 +02:00
Paul Chavard
dee0952b2a
fix(graphql): demandeur personne morale can be in degraded mode
2023-04-05 11:20:18 +02:00
Paul Chavard
a778e1083b
fix(graphql): return better errors when dossiers cannot change state
2023-04-04 17:24:30 +02:00
Paul Chavard
2a48228552
fix(dossier): improuve commune champ rendering in pdf
2023-04-04 16:01:16 +02:00
Paul Chavard
12f0c03bac
Merge pull request #8847 from tchak/feat-improuve-dossier-remove
...
fix(dossier): an invited user can remove (leave) a dossier
2023-04-04 13:10:18 +00:00
Paul Chavard
0864666d0a
fix(dossier): an invited user can remove (leave) a dossier
2023-04-03 20:10:44 +02:00
Paul Chavard
fce78bbf30
feat(dossier): multiselect without react
2023-04-03 16:54:50 +02:00
simon lehericey
b93e3776c4
feat(routing): add controller
2023-03-30 10:51:20 +02:00
mfo
60d41029de
Merge pull request #8817 from mfo/US/fix-expert-export
...
correctif(export.pdf): ETQ expert, lorsque j'exporte un dossier au format PDF, celui ci contenient les avis non confidentiels ainsi que mes avis
2023-03-29 12:00:14 +00:00
Martin
c6e9674de2
correctif(export.pdf): ETQ expert, lorsque j'exporte un dossier au format PDF, celui ci contenient les avis non confidentiels ainsi que mes avis
2023-03-28 17:16:34 +02:00
Martin
4f9c45c489
bug(export.pdf): ETQ expert, lorsque j'exporte un dossier, celui ci devrait contenir les avis non confidentiels ainsi que mes avis
2023-03-28 16:55:12 +02:00
Kara Diaby
4a13c64b38
tests
2023-03-27 14:14:18 +02:00
Lisa Durand
d079f3ac98
Merge pull request #8770 from demarches-simplifiees/ask-question-in-avis-ux-part
...
[UX] améliorer UX de la demande d'avis
2023-03-24 10:50:33 +00:00
Paul Chavard
275150d727
feat(graphql): expose pendingDeletedDossiers
...
fix #8785
2023-03-22 19:40:43 +01:00
Lisa Durand
4a2982dc37
fix tests and linter
2023-03-22 09:30:26 +01:00
Colin Darie
954652fcf5
fix(champ): may fix pg deadlocks: autosave already saves value at the same time
2023-03-20 14:32:14 +01:00
Lisa Durand
ee2f795dec
pr feedbacks - add validation for yes/no answer - improve locales use
2023-03-16 11:32:05 +01:00
Lisa Durand
eddd7a2192
add flash alert if email field empty
2023-03-16 11:32:05 +01:00
Lisa Durand
01afa998b6
add specs
2023-03-16 11:32:05 +01:00
Paul Chavard
8ee13f1719
feat(api_token): add allowed_procedure_ids and write_access
2023-03-15 19:09:49 +01:00
Paul Chavard
cbaa77fca7
feat(annotations): activate autosave
2023-03-14 15:22:13 +01:00
Lisa Durand
6ba47b731b
refacto destroy action and add spec for unauthorized user
2023-03-09 14:58:47 +01:00
Lisa Durand
3d5bf40c0f
allow transfer sender to revoke a transfer
2023-03-09 14:57:59 +01:00
Eric Leroy-Terquem
72b6dacfbd
fix(API): remove notification to group when instructeurs removed
2023-03-08 11:59:58 +01:00
Eric Leroy-Terquem
a150aa33ef
feat(GroupeInstructeurSupprimerInstructeurs): add notification for removed instructeurs via API
2023-03-08 11:59:58 +01:00
Eric Leroy-Terquem
ac0d7a67a1
feat(GroupeInstructeurAjouterInstructeurs): add notification for added instructeurs via API
2023-03-08 11:59:58 +01:00
Eric Leroy-Terquem
b2f3a7af4c
feat(GroupeInstructeurSupprimerInstructeurs): enable emailing for unrouted procedures
2023-03-08 11:59:55 +01:00
Eric Leroy-Terquem
9e0753a710
fix(groupe instructeur mailer): do not notify if no added instructeurs
2023-03-08 11:03:33 +01:00
Eric Leroy-Terquem
f317f28ff5
test(groupe instructeurs): use right data (a routed procedure has at
...
least two active groups)
2023-03-08 10:48:02 +01:00
Eric Leroy-Terquem
e1906febcc
feat(groupe instructeur): can enable routing from import
2023-03-08 10:48:02 +01:00
Eric Leroy-Terquem
9f0f5b0dc5
feat(groupe instructeur): allow import of many groups when procedure is not routed yet
2023-03-08 10:48:02 +01:00
Kara Diaby
4ea7bb2f1c
tests
2023-03-03 11:50:47 +01:00
Damien Le Thiec
687c05e6d1
Merge pull request #8622 from demarches-simplifiees/fix/stored_query_issue
...
Dossier prefill get without stored queries
2023-03-02 14:01:04 +00:00
Lisa Durand
54f17ad3c7
Merge pull request #8630 from demarches-simplifiees/harmonize-actions-for-instructeurs
...
[instructeurs] Uniformiser les actions pour les instructeurs sur la page tableau et dossier
2023-03-02 13:28:23 +00:00
Damien Le Thiec
8a7cb3f1fe
Merge branch 'main' into fix/stored_query_issue
2023-03-01 10:22:40 +01:00
Damien Le Thiec
01f142183e
Add and correct tests
2023-03-01 10:21:22 +01:00
Paul Chavard
d8ee4cb360
fix(test): dossiers_controller_spec
2023-02-28 17:28:17 +01:00
Paul Chavard
294a5135ce
feat(public/api): add dossier state api
2023-02-28 16:35:25 +01:00
Colin Darie
7e13d58db2
Merge pull request #8703 from govpf/feature/fix-dossier-controller-spec
...
Fix dossier controller spec
2023-02-28 12:11:30 +00:00
krichtof
dee499d386
Merge pull request #8706 from demarches-simplifiees/all_demarches_even_without_zones
...
liste toutes les démarches, même celles non associées à des zones
2023-02-28 10:58:07 +00:00
Paul Chavard
7076d6d99e
fix(turbo): rerender only top part of the header
2023-02-27 16:06:11 +01:00
sebastiencarceles
39545671f3
refacto: better error management
2023-02-27 14:35:11 +01:00
sebastiencarceles
33fa40eda2
don't clean the rna champ value
...
Cleaning the value is useless, when fetching the association,
as the value will be re-written by the dossier update, when the user
fills in the dossier.
Furthermore we need the value to persist when prefilling the champ.
2023-02-27 14:35:11 +01:00
Lisa Durand
636e6aa6cb
fix broken tabs with turbostream
2023-02-27 14:30:10 +01:00
sebastiencarceles
becf4da70a
fix raison social fetch
2023-02-27 13:54:35 +01:00
sebastiencarceles
30eef3e128
review: detailled error message
2023-02-27 13:45:16 +01:00
Sébastien Carceles
df2eaa9542
don't clean the siret champ value
...
Cleaning the value is useless, when fetching the etablissement,
as the value will be re-written by the dossier update, when the user
fills in the dossier.
2023-02-27 13:45:16 +01:00
Damien Le Thiec
67bbacbb05
Merge pull request #8513 from demarches-simplifiees/feature/prefill_repetible
...
Prefill repeatable
2023-02-27 09:58:53 +00:00
Christian Lautier
704dbf94db
Fix dossier controller spec
2023-02-25 08:32:21 -10:00
Lisa Durand
6487e2c27e
implement turbostream back for state change in dossier view
2023-02-24 17:54:53 +01:00
Christophe Robillard
1d6c2fd7eb
display procedures without zones
2023-02-24 17:27:28 +01:00
Eric Leroy-Terquem
4ea1d7d33b
feat(groupe instructeurs import): notify added instructeurs
2023-02-23 10:56:55 +01:00
Eric Leroy-Terquem
a6e01d98ea
feat(instructeurs import): notify added instructeurs
2023-02-23 10:56:55 +01:00
Damien Le Thiec
731cd56594
Merge branch 'main' into feature/prefill_repetible
2023-02-22 19:49:06 +01:00
Damien Le Thiec
fbe4fe251a
Fix format prefill repetition
2023-02-22 19:32:25 +01:00
Lisa Durand
fddcce8b7b
fix specs
2023-02-22 18:17:06 +01:00
Eric Leroy-Terquem
25df48f255
feat(groupe_instructeurs): import instructeurs in unrouted procedure with a proper CSV
2023-02-22 09:49:26 +01:00
Eric Leroy-Terquem
3aa7793ed3
fix(groupe_instructeurs): can parse a monocolumn csv file
2023-02-22 09:49:26 +01:00
Paul Chavard
e56d51e0f6
fix(graphql): fix demarcheUrl
2023-02-21 10:57:43 +01:00
Eric Leroy-Terquem
343cb5fce6
feat(groupe instructeur mailer): add emailing to added instructeurs
2023-02-20 15:41:19 +01:00
Damien Le Thiec
deb51e3880
Manage GET prefill by creating a dossier
2023-02-20 15:35:14 +01:00
Damien Le Thiec
dce4c84f9a
Merge branch 'main' into feature/prefill_repetible
2023-02-16 17:08:30 +01:00
Colin Darie
4f7839039d
refactor(password-complexity): as component for better form integration
2023-02-16 16:15:40 +01:00
sebastiencarceles
d5ffd61ab6
validate values inclusion
2023-02-16 10:49:15 +01:00
Eric Leroy-Terquem
a46faf8cdf
feat(groupe instructeur mailer): make two kind of notifications for removed instructeur
2023-02-16 10:37:04 +01:00
Eric Leroy-Terquem
5be58c8223
refactor(groupe instructeur mailer): rename mailer methods
2023-02-16 10:37:04 +01:00
Eric Leroy-Terquem
cbf072961c
feat(groupe instructeur mailer): add emailing to removed instructeurs
2023-02-16 10:37:04 +01:00
Damien Le Thiec
2533ca50d4
Merge branch 'main' into feature/prefill_repetible
2023-02-15 11:07:56 +01:00
sebastiencarceles
0159a10969
🐛 make possible_values_list method public
2023-02-14 11:41:35 +01:00
Sébastien Carceles
12abf9045b
add external_id and value validation
2023-02-14 09:23:11 +01:00
Damien Le Thiec
802a23057b
Microtest dossier prefill get without stored queries
2023-02-13 18:15:24 +01:00
Sébastien Carceles
1a72b80f8f
fix: "remove" a champ to prefill ( #8612 )
...
* fix: "remove" a champ to prefill
Removing a champ to prefill on /preremplir used to fail, because of a
collusion (having the same form multiple times on un page looks like a
bad idea, when it comes to multiple input fields).
* fix specs
2023-02-13 08:17:22 +00:00
Damien Le Thiec
dbb92e7fd3
Merge branch 'main' into feature/prefill_repetible
2023-02-11 22:40:56 +01:00
Damien Le Thiec
4b0e6ea382
Convert datetime field to datetime_local ( #8572 )
...
* Convert datetime field to datetime_local
* Fix tests
* Add value formatting view datetime component
* Add helper datetime component value
2023-02-09 15:18:38 +01:00
sebastiencarceles
6c5b82ebbf
filter out locale from stored query params
...
As 'locale' isn't a param we want to prefill a dossier, we ignore it
and remove it from the stored query params.
2023-02-09 13:51:52 +01:00
sebastiencarceles
e212055ef8
tell when query params have been stored
2023-02-09 13:51:52 +01:00
Colin Darie
e626eb69ce
feat(admin): import groupe instructeurs csv when procedure is closed
2023-02-09 11:17:13 +01:00
Paul Chavard
f22cc8812b
secu(graphql): log full queries and variables
2023-02-08 15:10:27 +01:00
Eric Leroy-Terquem
6cbc514d56
feat(groupe instructeurs): remove mailing when add instructeurs
2023-02-08 10:36:42 +01:00
Damien Le Thiec
a51ed0094b
Fix tests
2023-02-07 00:28:21 +01:00
Paul Chavard
6924b8e46d
feat(dossier): optional repetition champ should not add first row
2023-02-06 11:53:32 +01:00
Eric Leroy-Terquem
ff5fecef25
fix(dossiers_transfers): can destroy dossiers_transfers
2023-02-03 13:48:39 +01:00
Eric Leroy-Terquem
b306dea5cf
refactor(avis): rename revive by remind
2023-02-01 09:55:46 +01:00
Eric Leroy-Terquem
004bf5be38
feat(avis): add remind_by! method
2023-02-01 09:55:46 +01:00
Damien Le Thiec
d7b01255fe
Merge branch 'main' into feature/prefill_repetible
2023-01-31 16:39:00 +01:00
Martin
88553eec9b
correctif(dossier_transfer): le transfer de dossier vers un email contenant des majuscule ne fonctionnait pas
2023-01-31 14:52:57 +01:00
Colin Darie
36d5569114
fix(instructeurs): pdf in exports include info administration
2023-01-30 18:38:54 +01:00
Paul Chavard
5b9e534b3f
chore(turbo): morph all the things
2023-01-25 13:45:26 +01:00
Sébastien Carceles
49ce255e29
feat(dossier): prefill region champ ( #8442 )
...
* make regions champ prefillable
* add possible and example value
* add external_id and value validation
2023-01-24 11:25:17 +00:00
mfo
84a667b8bd
Merge pull request #8454 from tchak/feat-epci
...
feat(types de champ): add EPCI champ
2023-01-23 16:56:18 +01:00
mfo
1926aa283d
Merge pull request #8425 from adullact/fix/procedure-custom-retention
...
Fix du support d'une durée personnalisée de conservation des dossiers
2023-01-23 12:11:29 +01:00
Damien Le Thiec
962016e32e
Schema graph_ql ( #8406 )
...
* First draft schema graph_ql
* Add tests for json schema procedures
2023-01-23 11:31:06 +01:00
Sébastien Carceles
68ddae7382
feat(demarche): prefilling stats ( #8436 )
...
* force json content type for POST / PATCH / PUT
* add specs about stats dossiers funnel
* new endpoint to render stats about a procedure
2023-01-20 13:28:02 +00:00
Paul Chavard
a4cbbe721e
feat(types de champ): add EPCI champ
2023-01-20 11:32:36 +01:00
Paul Chavard
8f1ae99413
fix(graphql): remove deprecated options from introspection query
2023-01-20 09:54:50 +01:00
Martin
52380d5249
fix(api): on fixe avec avec des tests le prob de token
2023-01-19 17:40:19 +01:00
Martin
7206f1b298
bug(api): token, not checked
2023-01-19 17:33:19 +01:00
simon lehericey
84d08d4d24
fix(expert_export): an expert export excludes annotation and avis
2023-01-19 12:09:16 +01:00
Martin
f59354f787
tech(champs/repetitions#remove): ajout d'un test pour s'assurer que l'action de suppression d'un bloc repetable fonctionne
2023-01-19 10:38:30 +01:00
Martin
3dc26efc61
infra(monitoring): ajoute le webhook pour les notifier des incidents cote sib
2023-01-19 09:50:25 +01:00
Kara Diaby
063059d6f0
tests
2023-01-18 18:46:42 +01:00
Paul Chavard
b5dc71e975
fix(graphql): demarche with pj should return schema
2023-01-18 18:06:10 +01:00
Paul Chavard
cdb3ce65cb
feat(graphql): expose more information on demarche descriptor
2023-01-18 13:46:40 +01:00
Sébastien Carceles
5c7b2ba1f3
feat(dossier): prefill drop down list champ ( #8361 )
...
* feat(dossier): prefill drop down list champ
* decorate the types de champ to avoid if / else
In order to avoid doing if this a drop down ? / else at several places,
we decorate the types de champ and let the decorator give the possible
and example values.
* show all possible values when there are too many
* allow to prefill 'other' option
* review: remove duplicate
* review: refactor for readability
* validate that value is in options
* review: exclude disabled options
2023-01-18 09:47:22 +01:00
simon lehericey
8e75b6ff77
fix(send_dossier): avoid leaking instructeur emails
2023-01-17 16:57:56 +01:00
Damien Le Thiec
5e26acb0e1
Make date and datetime prefillable ( #8304 )
...
* Make date and datetime prefillable
* Format in ISO8601 format
2023-01-12 17:42:02 +01:00
François Vantomme
e794d4f77b
fix(procedure): deal nicely with custom NEW_MAX_DUREE_CONSERVATION
2023-01-12 14:37:54 +01:00
Paul Chavard
b663939674
feat(graphql): add demarcheCloner mutation
2023-01-11 23:38:12 +01:00
Paul Chavard
afc1f12028
feat(graphql): implement add/remove instructeurs via API
2023-01-10 20:33:35 +01:00
Sébastien Carceles
177dec2bdb
feat(dossier): add dossier id to prefill response ( #8382 )
2023-01-06 13:46:27 +00:00
Martin
3918757dc9
correctif(test): desormais l'association batch_operations.groupe_instructeurs passe par le dossier. Mise a jour des tests
2023-01-05 16:20:18 +01:00
Sébastien Carceles
1de969915a
rename file to match controller name ( #8371 )
2023-01-05 14:38:56 +01:00
Sébastien Carceles
456be420fa
feat(demarche): describe dossier prefilling with POST ( #8298 )
...
* feat(demarche): describe dossier prefilling with POST
* show response example
2023-01-04 07:31:31 +00:00
Martin
a4d6692bc6
accessibilite(pages-authentification): evolutions des pages de connexion/creation de compte pour respecter le DSFR et supporter une meilleure accessibilite
...
Update app/components/dsfr/input_component/input_component.html.haml
Co-authored-by: Colin Darie <colin@darie.eu>
2023-01-03 16:26:05 +01:00
Sébastien Carceles
20136b7ac8
feat(demarche): create and prefill a dossier with POST request ( #8233 )
...
* add base controller for public api
* add dossiers controller with basic checks
* create the dossier
* ensure content-type is json
* prefill dossier with given values
* mark a dossier as prefilled
When a dossier is prefilled, it's allowed not to have a user.
Plus, we add a secure token to the dossier, which we will need later to set a
user after sign in / sign up.
* set user as owner of an orphan prefilled dossier
When a visitor comes from the dossier_url answered by the public api,
the dossier is orphan:
- when the user is already authenticated: they become the owner
- when the user is not authenticated: they can sign in / sign up / france_connect
and then they become the owner
So here is the procedure:
- allow to sign in / sign up / france connect when user is unauthenticated
- set dossier ownership when the dossier is orphan
- check dossier ownership when the dossier is not
- redirect to brouillon path when user is signed in and owner
* mark the dossier as prefilled when it's prefilled
(even with a GET request, because it will be useful later on, for
exmample in order to cleanup the unused prefilled dossiers)
* system spec: prefilling dossier with post request
2023-01-03 14:46:10 +01:00
Martin
186d4e6539
correctif(ChampDepartement): gere les departement a 3 codes
2022-12-27 14:55:57 +01:00
Martin
48c80e9387
correctif(api/v1): ajoute la methode manquante for_api sur le type de champs departement
2022-12-27 11:45:43 +01:00