Commit graph

4919 commits

Author SHA1 Message Date
Nicolas Cavigneaux
7e0fbcf672
fix: ensure procedure used in remove_instructeur spec has routing_enabled set to true 2023-05-03 11:35:29 +02:00
Nicolas Cavigneaux
06296e933a
fix: super admin test where attribute was not reloaded 2023-05-03 11:35:28 +02:00
Nicolas Cavigneaux
faad8abaf6
fix: add missing file content type in fixture blob creation 2023-05-03 11:35:28 +02:00
Lisa Durand
1ab3dbb864 fix spec adding click on dropdown 2023-05-03 11:04:15 +02:00
Nicolas Cavigneaux
b478168e23
fix: remove hardcoded .pdf.prawn from describe calls since it no longer works 2023-05-03 10:10:38 +02:00
Nicolas Cavigneaux
e483bfbc76
fix: remove hardcoded .html.haml from render calls since it no longer works 2023-05-03 10:10:38 +02:00
Nicolas Cavigneaux
7e245c0b70
fix: add required argument for SMTP errors instanciation in application_mailer_spec 2023-05-03 10:10:38 +02:00
Martin
c8ab1e8e03 amelioration(dossier#submit_brouillon): ETQ usager, je souhaite pouvoir acceder aux champs en erreur facilement 2023-05-03 07:36:42 +02:00
Lisa Durand
cfce0075ce fix view spec adding fake params 2023-05-02 19:24:30 +02:00
Lisa Durand
6113c0b75e improve/add translations 2023-05-02 15:10:36 +02:00
Lisa Durand
24eca40f66 add from_depose_at filter 2023-05-02 10:32:38 +02:00
Lisa Durand
21ed6abcad add from_created_at filter 2023-05-02 09:37:03 +02:00
Paul Chavard
46f9148fa4
Merge pull request #8984 from tchak/fix-api-entreprise-status
ETQ usager, je veux être avertie si l'API entreprise est HS
2023-04-28 14:25:02 +00:00
Paul Chavard
f2c1c071b4 Revert "Merge pull request #8899 from demarches-simplifiees/8738-validate-adresse-electronique"
This reverts commit d3eda28f35, reversing
changes made to 6394996e7f.
2023-04-28 16:10:20 +02:00
Lisa Durand
39f534b3d7 add states filter for usager 2023-04-28 15:28:04 +02:00
simon lehericey
47bae606f1 spec: remove weird now obsolete spec which pollute global namespace with logic helper
and make spread_architect tests fail
2023-04-28 10:42:09 +02:00
Paul Chavard
99abdf45e7 fix(api-entreprise): use new status endpoint 2023-04-27 22:39:44 +02:00
Lisa Durand
aac1cc7161
Merge pull request #8971 from demarches-simplifiees/add-filter-for-usagers
[fix] Pagination interface usager - onglets disparaissent si pas sur la page 1
2023-04-27 13:46:15 +00:00
Lisa Durand
b76c0a36e8 fix specs 2023-04-27 15:26:10 +02:00
Paul Chavard
1d10e59e63 fix(commune): fix ‘undefined’ departement codes 2023-04-27 12:07:43 +02:00
Paul Chavard
cb752d1857 fix(dossier): do not bypass depositaire check on modifier path 2023-04-27 09:52:10 +02:00
simon lehericey
86e0538425 keep test active_storage service 2023-04-26 22:46:16 +02:00
LeSim
4c5e903673
Merge pull request #8887 from demarches-simplifiees/8839-filter-by-siret
Filtrer les démarches par service
2023-04-26 19:44:08 +00:00
Paul Chavard
a41713c837
Merge pull request #8968 from demarches-simplifiees/fix_defaut_groupe_instructeur_again
Correctif: definit le groupe instructeur par defaut pour certaines procedure clonées
2023-04-26 17:59:13 +00:00
Paul Chavard
d3eda28f35
Merge pull request #8899 from demarches-simplifiees/8738-validate-adresse-electronique
ETQ usager, je veux que les champs de type adresse électronique soit validé
2023-04-26 16:52:02 +00:00
simon lehericey
fcb11e49e1 spec: fix flaky test 2023-04-26 16:51:10 +02:00
Lisa Durand
e393132fd8
Merge pull request #8936 from demarches-simplifiees/add-yes-no-column-for-instructeurs
[instructeur] ajout du nb de réponses oui/non aux avis dans le tableau d'une procedure
2023-04-26 09:05:58 +00:00
simon lehericey
0934a672fe fix: defaut_groupe_instructeur for a cloned procedure from another admin without a group with default label 2023-04-26 10:52:31 +02:00
simon lehericey
dce2bf3209 spec: move procedure.clone in subject, to enable future before 2023-04-26 10:47:51 +02:00
LeSim
1a704f0479
Merge pull request #8966 from mfo/US/fix-avis-remind-with-question
ETQ instructeur, je peux relancer une demande d'avis meme si celui ci contient une question
2023-04-26 08:09:41 +00:00
LeSim
c8ed0532ed
Merge pull request #8948 from colinux/fix-geoarea-geometry-blank
ETQ Usager, champ carte: ne permet pas d'enregistrer une geometry null pour ne pas casser les exports
2023-04-26 10:15:25 +02:00
Colin Darie
21a829ec1e fix(conditionel): error when using operator eq/not_eq with a multi dropdown 2023-04-26 09:58:00 +02:00
simon lehericey
f1bcb84832 fix: replace ds_eq operator by ds_include when targeted_champ is a multiple_drop_down_list 2023-04-26 09:37:03 +02:00
Martin
6a2d2ae0a7 bug(instructeurs/avis_controller#remind): ETQ instructeur, je peux relancer une demande d'avis meme si celui ci contient une question 2023-04-26 07:46:21 +02:00
Lisa Durand
26ff82dbe4 Merge branch 'main' of github.com:betagouv/demarches-simplifiees.fr into user-dashboard/add-alert-WIP-last-dossier 2023-04-25 13:01:40 +02:00
simon lehericey
ae1fd3f30b linter 2023-04-24 10:59:42 +02:00
Martin
8c78008b4d correctif(usager.depot-dossier): ETQ usager, les titres de section conditionnés etait visible meme si la condition n'etait pas remplie 2023-04-24 10:47:20 +02:00
simon lehericey
c189115757 fix defaut_groupe_instructeur for mismatching label 2023-04-24 10:16:09 +02:00
simon lehericey
995858e124 fix defaut_groupe_instructeur_id for (hidden) procedure with an (hidden) parent 2023-04-24 10:16:09 +02:00
Colin Darie
f7880352f0
Merge pull request #8941 from mfo/US/fixed-dossier-stalled-auto-processing
correctif(procedure.declarative): ETQ administrateur d'une procedure declarative, certains de mes dossiers restent en construction [ex: l'object storage est down, le dossier reste bloqué]
2023-04-22 16:13:01 +00:00
Colin Darie
25956c5141
fix(geoarea): geometry must not be nil 2023-04-22 16:23:39 +02:00
Martin
9dec6f1611 correctif(procedure.declarative): ETQ administrateur d'une procedure declarative, certains de mes dossiers restent en construction [ex: l'object storage est down, le dossier reste bloqué] 2023-04-21 15:45:45 +02:00
Colin Darie
925ebef551
Merge pull request #8934 from colinux/fix-markdown-in-url
ETQ utilisateur je ne veux pas perdre les _ au sein d'urls dans mes messages
2023-04-21 13:28:56 +00:00
Colin Darie
2775158052
Merge pull request #8943 from tchak/fix-dossier-can-create-new-dossiers
ETQ usager, je peux créer de nouveaux dossiers sur la démarche qui remplace la démarche fermée
2023-04-21 13:18:43 +00:00
simon lehericey
439447b343 fix defaut_groupe_instructeur_id and change dossier.groupe_instructeur_id 2023-04-21 15:08:07 +02:00
Colin Darie
fb54ca1469 fix(markdown): don't convert underscore within urls or emails 2023-04-21 14:07:10 +02:00
simon lehericey
a202a57988 fix: defaut_groupe_instructeur_id for a cloned procedure 2023-04-21 12:20:50 +02:00
Paul Chavard
52d63a1b02 fix(dossier): user can create new dossiers when closed procedure is replaced 2023-04-21 11:18:27 +01:00
Lisa Durand
b52a2ca972 fix spec 2023-04-21 10:21:54 +02:00
Martin
6739bfc665 bug(instructeurs.annotations): ETQ instructeurs, lorsque je saisie une autre valeur dans un champ de type choix simple, celle ci n'est pas sauvegardé 2023-04-21 09:35:16 +02:00
krichtof
c2461f230c validate value for email champ 2023-04-20 18:27:02 +02:00
Paul Chavard
88f680a265
Merge pull request #8930 from tchak/fix-champ-commune-spaces
ETQ usager, je voudrai pouvoir remplir un code postal avec des espaces
2023-04-20 08:40:38 +00:00
Paul Chavard
586286cb08
Merge pull request #8916 from demarches-simplifiees/can-update-defaut-groupe-instructeur-2
feat(routage): permet de changer le groupe par défaut
2023-04-20 08:28:46 +00:00
Paul Chavard
4a2e499679 fix(commune): should accept postal codes with spaces 2023-04-20 10:16:48 +02:00
simon lehericey
e64ac79f05 tech(refactor): much nicer code, thx LeSim
root -> rooted_tree

depth_cach -> walk

smal refactor

comment

remove form for header_section

remove seen_at from header section

header_section: champ -> header_section

champ_subree: remove if not

remove root_depth use header_section_level_value instead

remove unused include

remove ChampTreeComponent

rename ChampsSubtreeComponent to SectionComponent

use TreeableConcern only in section component

remove fields_for_champ_component

champs -> tail

add split_section_champ helper

refactor(editable_champ::header_section): keep same interface everywhere

fix(repetition): add spec for SectionComponent on repetitions
2023-04-20 08:22:02 +02:00
Martin
cc2c856ec2 amelioration(bloc-repetable): wrap les blocs repetatable dans des fieldsets 2023-04-20 08:22:02 +02:00
Martin
88abefb370 tech(remaniement): isole la logique de rendu au champs_subtree_component 2023-04-20 08:22:02 +02:00
Martin
3b5d1bd55b tech(remaniement): extraction du passage d'une liste de champs a un simili arbre 2023-04-20 08:22:02 +02:00
Martin
ad77b9321b amelioration(formulaire-usager): groupes les champs suivant un titre de section dans une balise html de type <fieldset> de sorte a améliorer l'accessibilite de la plateforme 2023-04-20 08:22:02 +02:00
Martin
b9faa26560 amelioration(editeur-de-champs): permet de choisir un niveau de titre (de 1 à 3) pour les champs de type Champs::HeaderSectionChamp. Gère les erreurs dans le cas ou un administrateur supprimerait un HeaderSection qui casserait l'ordre des titre [ex: titre 1,2,3. et l'admin supprime le titre 1 et il reste que 2,3]. 2023-04-20 08:22:02 +02:00
Paul Chavard
418d3b55d0 feat(stats): give access to stats on closed procedures 2023-04-19 18:31:58 +02:00
Colin Darie
9728493bda
Merge pull request #8924 from colinux/rubocop-upgrades
Tech: update rubocop, active nouveaux cops Rails/*
2023-04-19 13:37:10 +00:00
Eric Leroy-Terquem
aecd7559d2 feat(groupe instructeur): cannot disable default groupe instructeur 2023-04-19 13:52:42 +02:00
Eric Leroy-Terquem
09b05550ab feat(groupe instructeur): cannot delete defaut_groupe_instructeur 2023-04-19 13:52:42 +02:00
simon lehericey
79131cc294 fix spec 2023-04-19 13:52:42 +02:00
simon lehericey
b38470368b feat(routing): can change defaut groupe 2023-04-19 13:52:41 +02:00
mfo
73184c6dac
Merge pull request #8907 from mfo/US/dolist-silence-some-errors
amelioration(dolist): ne log erreurs pas les erreurs dans sentry lorsque le contact chez dolist est injoingable ou hardbounce
2023-04-19 11:49:01 +00:00
Colin Darie
516ffc68ba
chore(rubocop): fix Rails/I18nLocaleAssignment 2023-04-19 12:55:14 +02:00
Colin Darie
7aba5ccc3e
chore(rubocop): fix Rails/DurationArithmetic 2023-04-19 12:55:13 +02:00
Colin Darie
999f06075b
chore(rubocop): fix Rails/ResponseParsedBody 2023-04-19 12:55:13 +02:00
Colin Darie
b273e7b67e
chore(rubocop): fix Rails/RootPathnameMethods and assimiled cops 2023-04-19 12:55:13 +02:00
Paul Chavard
05cfb4055d fix(dossier): improuve dossier state display 2023-04-19 12:27:16 +02:00
Paul Chavard
7bf31c6278
Merge pull request #8850 from tchak/feat-refactor-drop-downs
Simplifie l'implémentation des champs "liste d'options" et "listes d'options liées"
2023-04-19 09:59:10 +00:00
Martin
8fa2bbb67d amelioration(dolist): ne log erreurs pas les erreurs dans sentry lorsque le contact chez dolist est injoingable ou hardbounce 2023-04-19 11:22:13 +02:00
github-merge-queue[bot]
a286af8a70
Merge pull request #8918 from tchak/graphql-add-error-codes
ETQ intégrateur API, je voudrais avoir des codes d'erreur plus précis
2023-04-19 09:00:32 +00:00
Paul Chavard
0912a30eb0 feat(dossier): use turbo on select with other 2023-04-18 15:24:23 +02:00
Paul Chavard
ae1ec87397 feat(graphql): add code to timeout errors 2023-04-18 15:22:11 +02:00
Paul Chavard
f70532a844 feat(graphql): global not found error handling 2023-04-18 15:22:11 +02:00
Paul Chavard
fbae6d941d feat(graphql): add error codes to graphql errors 2023-04-18 15:22:11 +02:00
Paul Chavard
2a09f1d505 fix(graphql): return empty arrays from loaders when loading collections 2023-04-18 15:20:43 +02:00
Lisa Durand
c565ed415b change scope and alert location after UI modification 2023-04-18 12:03:10 +02:00
Paul Chavard
bf6cc25063 feat(graphql): expose pendingDeletedDossiers on groupe instructeur 2023-04-17 18:43:00 +02:00
LeSim
c252748833
Merge pull request #8836 from demarches-simplifiees/improve-routing-rules-ux
feat(routing): nicer and safer ?
2023-04-17 08:23:15 +00:00
Paul Chavard
5abb6a8f12 chore(spec): remove memory store cache from tests 2023-04-13 13:10:23 +02:00
Paul Chavard
98caf41a36 fix(dossier): find communes outside of departement 2023-04-13 13:09:56 +02:00
Paul Chavard
21b548d32b fix(dossier): delete all champs starting with children 2023-04-13 11:08:10 +02:00
simon lehericey
a5200a569f feat(routing): task to backfill procedure.defaut_groupe_instructeur_id 2023-04-13 10:44:06 +02:00
simon lehericey
f6948cfd5e feat(routing): record first groupe as default_groupe_instructeur 2023-04-13 10:36:42 +02:00
simon lehericey
c02319aa56 feat(routing): reset value if target as changed 2023-04-13 10:28:53 +02:00
simon lehericey
8b832396a3 feat(routing): server side: prevent changing tdc type if used for routing 2023-04-13 10:28:52 +02:00
Eric Leroy-Terquem
9ea75a5bd1 feat(routing): ui side: prevent changing tdc type if used for routing 2023-04-13 10:28:52 +02:00
simon lehericey
c1f67499aa feat(routing): server side: prevent tdc deletion if used for routing 2023-04-13 10:28:52 +02:00
simon lehericey
213d463ff4 feat(routing): small UI polish 2023-04-13 10:28:52 +02:00
Eric Leroy-Terquem
c4d64d9775 feat(routing): add message if no type de champs routable 2023-04-13 10:28:52 +02:00
simon lehericey
80b5f6bc1d feat(champ_component): add errors banner 2023-04-13 10:28:52 +02:00
simon lehericey
362c220587 fix(champ_component): enable preview 2023-04-13 10:28:52 +02:00
krichtof
78938b5a07 filter demarches by siret service 2023-04-12 18:53:57 +02:00
Lisa Durand
bc3e67ab94 add alert on user dashboard to edit last editable dossier 2023-04-11 15:50:17 +02:00
Paul Chavard
def32a3615 chore(dossier): remove fallback from commune champ 2023-04-11 10:49:01 +02:00
Colin Darie
54c9690289
Merge pull request #8886 from colinux/fix-delete-admin-without-published-procedure
fix(admin): peut supprimer un admin sans démarche publiée, sans service
2023-04-11 07:17:54 +00:00
Colin Darie
a413d2fa9c fix(admin): can delete an admin without published procedure 2023-04-07 16:10:10 +02:00
Paul Chavard
a6e3ea4839 fix(dossier): normalize champs commune data 2023-04-07 16:02:13 +02:00
Paul Chavard
0d1aa5cf96
Merge pull request #8867 from tchak/feat-graphql-commune-type
feat(graphql): expose commune and departement information on address
2023-04-07 10:35:32 +00:00
Paul Chavard
aaae3f461d feat(graphql): expose commune and departement information on address 2023-04-07 12:13:41 +02:00
Paul Chavard
207ce21327 fix(dossier): instructeur actions should be buttons and not links 2023-04-07 12:12:15 +02:00
Paul Chavard
0b95a912c6
Merge pull request #8858 from tchak/feat-refactor-dossier-link-champ
feat(dossier): use turbo to select linked dossier
2023-04-07 08:49:11 +00:00
Paul Chavard
79fee39888
Merge pull request #8872 from tchak/fix-champ-multiselect
fix(dossier): selecting blank option should not empty selection
2023-04-06 14:32:35 +00:00
Paul Chavard
ffb332159f fix(dossier): selecting blank option should not empty selection 2023-04-06 15:24:52 +02:00
Paul Chavard
a2f7d1df72 fix(graphql): pendingDeletedSince should not crash 2023-04-06 15:07:48 +02:00
Paul Chavard
6511836f2d
Merge pull request #8865 from tchak/graphql-improuve-logs
feat(graphql): improuve logs
2023-04-05 12:34:36 +00:00
Paul Chavard
a5733002ed feat(graphql): improuve logs 2023-04-05 13:56:26 +02:00
Paul Chavard
b8f639721e
Merge pull request #8864 from colinux/fix-date-not-parseable
fix(date): ne crash pas lorsqu'un champ date n'as pas une date standard
2023-04-05 11:48:48 +00:00
Colin Darie
5e62aa7d21 fix(date): don't crash when date value is not parseable 2023-04-05 12:42:28 +02:00
Paul Chavard
52c8b0b297 feat(dossier): use turbo to select linked dossier 2023-04-05 11:40:03 +02:00
Paul Chavard
dee0952b2a fix(graphql): demandeur personne morale can be in degraded mode 2023-04-05 11:20:18 +02:00
Paul Chavard
a778e1083b fix(graphql): return better errors when dossiers cannot change state 2023-04-04 17:24:30 +02:00
Martin
6039539727 bug(administrateur.merge): la fusion de compte entre admin devrait aussi dissocier les services des procedures supprimées 2023-04-04 16:29:24 +02:00
Paul Chavard
2a48228552 fix(dossier): improuve commune champ rendering in pdf 2023-04-04 16:01:16 +02:00
Paul Chavard
12f0c03bac
Merge pull request #8847 from tchak/feat-improuve-dossier-remove
fix(dossier): an invited user can remove (leave) a dossier
2023-04-04 13:10:18 +00:00
mfo
2c32e38383
Merge pull request #8851 from demarches-simplifiees/fix_condtion_check_on_children
fix(condition_check_on_children): give proper upper tdc to child cond…
2023-04-04 08:48:02 +00:00
simon lehericey
fd927fd116 fix(condition_check_on_children): give proper upper tdc to child condition check 2023-04-04 10:24:11 +02:00
Lisa Durand
dde64415ae
Merge pull request #8845 from demarches-simplifiees/remove-dossiers-termines-from-avis-views
[bug] retirer les notifications + compteur des avis pour les dossiers terminés
2023-04-04 08:20:48 +00:00
Paul Chavard
0864666d0a fix(dossier): an invited user can remove (leave) a dossier 2023-04-03 20:10:44 +02:00
Lisa Durand
2f012578eb remove dossier termine from avis views 2023-04-03 18:20:17 +02:00
Paul Chavard
fce78bbf30 feat(dossier): multiselect without react 2023-04-03 16:54:50 +02:00
Paul Chavard
b3f58a24cb fix(dossier): add value_json to dossier projection 2023-04-03 16:25:32 +02:00
Paul Chavard
8945777b56
Merge pull request #8835 from tchak/fix-champ-commune
fix(commune): improuve label and error message
2023-04-03 09:56:57 +00:00
Paul Chavard
b0673c0127
Merge pull request #8837 from demarches-simplifiees/bug-special-character-in-email
[fix] bug dans le sujet des mails de notification si le libelle de la procedure contient un apostrophe
2023-04-03 09:39:13 +00:00
Paul Chavard
ed62d171ce fix(commune): improuve label and error message 2023-04-03 11:24:32 +02:00
mfo
4336184fc8
Merge pull request #8833 from mfo/US/fix-valid-conditions-on-repetition
correctif(revision.validation-des-conditions): les conditions dans un bloc répétable ne remontenpt pas dans le composant ErrorsSummary
2023-03-31 15:03:12 +00:00
Lisa Durand
e1260a3df8 fix wrong encoding of special character in email notification subject 2023-03-31 16:58:41 +02:00
mfo
54d88e7dd0
Merge pull request #8699 from mfo/US/8661
a11y(bloc-repetable): amélioration des interactions avec les répétitions d'un bloc répétable
2023-03-31 14:39:23 +00:00
LeSim
b003fd8be8
Merge pull request #8774 from E-L-T/add-routing-to-groupe-instructeurs
Add routing rules to groupe instructeurs
2023-03-31 10:16:51 +00:00
Martin
92f5e7663e bug(validation-des-conditions): les conditions dans un bloc repetable ne remontent pas dans la liste des erreurs de la page formulaire ou sur les changements du formulaire 2023-03-31 10:31:34 +02:00
Martin
a3f1e1926a a11y(bloc-repetable): ETQ usager qui navigue au clavier, lorsque j'ajoute un champs repetable, le focus vient sur le 1er champs du bloc repetable 2023-03-31 08:51:39 +02:00
Lisa Durand
630742ee94 fix test 2023-03-30 17:54:14 +02:00
Colin Darie
e36dc19cc4 fix(explication): render collapsible text into collapse element 2023-03-30 12:46:31 +02:00
simon lehericey
41cb62b5c7 add full system spec 2023-03-30 12:31:48 +02:00
Eric Leroy-Terquem
6f6bbd6ca1 feat(routing): put routing logic behind a feature flag 2023-03-30 10:52:53 +02:00
Eric Leroy-Terquem
6dfe54479d test(routing): can route from a dropdown list 2023-03-30 10:51:48 +02:00
simon lehericey
3cede55d41 feat(routing): add routing engine 2023-03-30 10:51:20 +02:00
simon lehericey
b93e3776c4 feat(routing): add controller 2023-03-30 10:51:20 +02:00
simon lehericey
f6738be454 fix(spec): small refactor 2023-03-30 10:51:20 +02:00
Paul Chavard
01602101f1 spec(commune): improuve spec 2023-03-29 15:42:33 +02:00
Paul Chavard
00fc2f519f chore(spec): fix commune spec 2023-03-29 15:42:33 +02:00
Colin Darie
f274748acd Merge pull request #8820 from colinux/fix-autolink-renderer
Fix: autolink manuellement les liens qui ne sont pas des urls
2023-03-29 15:42:33 +02:00
mfo
8efd191e0f Merge pull request #8817 from mfo/US/fix-expert-export
correctif(export.pdf): ETQ expert, lorsque j'exporte un dossier au format PDF, celui ci contenient les avis non confidentiels ainsi que mes avis
2023-03-29 15:42:33 +02:00
Colin Darie
49e016ba58 fix: handle all autolinks manually
On ne peut pas appeler super() qui est en méthode en C, pas en ruby.
Donc on doit gérer manuellement les cas possibles.
2023-03-29 15:42:33 +02:00
Colin Darie
6ddbda34a2 fix(avis): don't list question_answer radios on empty question 2023-03-29 15:42:33 +02:00
Martin
c6e9674de2 correctif(export.pdf): ETQ expert, lorsque j'exporte un dossier au format PDF, celui ci contenient les avis non confidentiels ainsi que mes avis 2023-03-28 17:16:34 +02:00