Commit graph

20213 commits

Author SHA1 Message Date
Colin Darie
8678986808 chore(benchmark): tooling for benchmarking controller action 2023-09-29 15:11:50 +02:00
krichtof
1ef9ea0a96
Merge pull request #9524 from demarches-simplifiees/9502-contact-admin-sans-siret
Notifier par mail les admin de services sans siret
2023-09-29 12:11:42 +00:00
mfo
af6fd9d14c
Merge pull request #9531 from colinux/fix-form-markup
ETQ usager le formulaire est aéré grâce au bon markup du DSFR
2023-09-29 12:04:59 +00:00
Colin Darie
04071073e5 refactor(instructeurs): faster procedures listing 2023-09-29 13:09:54 +02:00
Christophe Robillard
20d70d2b1c notify admin with service without siret 2023-09-29 11:37:34 +02:00
Colin Darie
8ad87de461
Merge pull request #9539 from colinux/fix-admin-publish-order-buttons
ETQ admin le bouton de publication des modifications passe à gauche
2023-09-29 08:16:37 +00:00
Colin Darie
6ba4f901c7
Merge pull request #9534 from demarches-simplifiees/unroute-cloned-procedures-from-different-admin
Correction (2e essai) : désactive le routage de procédures clonées ou l'admin n'était pas aussi admin de la procédure parente
2023-09-28 18:07:35 +00:00
Colin Darie
f942610d32
Merge pull request #9473 from demarches-simplifiees/create-export-page-V2-ldu
[Export] Créer une page d'export et sortir les liens des dropdowns
2023-09-28 17:15:31 +00:00
mfo
e1fe1188de
Merge pull request #9491 from mfo/US/better-error-summary
amelioration(usagers.dossiers.erreurs): ETQ usager, lorsque je soumets un dossier avec des erreurs, le format des erreurs est au format du DSFR
2023-09-28 17:01:09 +00:00
Colin Darie
a835990f74 fix(admin): publish button of new version must be aligned before reset 2023-09-28 18:38:03 +02:00
Colin Darie
95ceee38c7
chore(form): don't try to put invalid group classes for non fillable inputs 2023-09-28 18:33:28 +02:00
Colin Darie
60882e0844
chore(form): respect dsfr fr-fieldset and elements expected markup 2023-09-28 18:33:26 +02:00
Eric Leroy-Terquem
12eac64572 fix(procedure): do not route cloned procedures from different admin retry 2023-09-28 18:10:59 +02:00
Martin
d8220395c8 amelioration(usagers.dossiers.erreurs): ETQ usager, lorsque je soumets un dossier avec des erreurs, le format des erreurs est au format du DSFR
Update app/components/dossiers/errors_full_messages.rb
Update app/components/dossiers/errors_full_messages/errors_full_messages.html.haml

Co-authored-by: Colin Darie <colin@darie.eu>
2023-09-28 17:50:47 +02:00
Colin Darie
2cec44109d
Merge pull request #9516 from colinux/fix-invalid-facultative-evaporation
ETQ usager je ne veux pas pouvoir saisir un nombre invalide sans feedback
2023-09-28 13:50:08 +00:00
Colin Darie
0920b97e4d fix(admin/archives): fix markup axe issue 2023-09-28 15:34:09 +02:00
Colin Darie
e492c8a3ad fix(decimal number): description with 3 digits 2023-09-28 15:27:42 +02:00
Colin Darie
75bf30bed2
feat(champ-numbers): format value in input to a backend compatible value 2023-09-28 15:26:35 +02:00
Colin Darie
123114be81
fix(conditional): don't .to_i/to_f => 0 an invalid number 2023-09-28 15:26:34 +02:00
Colin Darie
aac7de208f
chore(champs-number): render as text input to validate them when invalid
Les input=number n'ont pas de value lorsque la valeur saisie n'est pas un
nombre. Par conséquent dans ces cas là, nous ne pouvions faire remonter
au backend pour validation / enregistrement, et il n'y avait aucun
feedback signalement l'erreur à l'usager.

On les convertit en inputs texte, avec les adaptations nécessaires
pour montrer le pavé numérique sur mobile, et un style correct.
2023-09-28 15:26:33 +02:00
Colin Darie
d4198869fb
chore(exports): dropdown menu re-uses the same pending export or create a fresh one
Pour permettre d'avoir des données fraiches dans un export tout
en conservant l'historique des exports,
la demande d'export depuis le menu créé toujours un nouvel export sauf:
- si un autre export identique est déjà en préparation
- si un autre export identique s'est terminé il y a moins de 5 minutes

Co-Authored-By: Lisa Durand <lisa.c.durand@gmail.com>
2023-09-28 15:23:31 +02:00
Colin Darie
de7d60e18e
chore(schema): remove exports unicity constraint
Co-Authored-By: Lisa Durand <lisa.c.durand@gmail.com>
2023-09-28 15:23:28 +02:00
LeSim
11865ef68c
Merge pull request #9533 from demarches-simplifiees/fix_flaky
spec: use match_array
2023-09-28 13:12:50 +00:00
Colin Darie
d9687f7418
chore(exports): minor wording improvements and clarifications 2023-09-28 12:35:26 +02:00
Colin Darie
ec46faf690
fix(exports): don't duplicate exports when belonging to multiple groupe instructeurs 2023-09-28 12:35:24 +02:00
mfo
00a6d02d21
fix(exports): block exports page to super admins so they can't download exports 2023-09-28 12:35:23 +02:00
Colin Darie
2283c7eba7
test(exports): minimal coverage for ExportLinkComponent 2023-09-28 12:35:22 +02:00
Colin Darie
daa8eac9cc
style(exports): download link instead of button 2023-09-28 12:35:21 +02:00
Colin Darie
307ba68970
feat(exports): humanize status name 2023-09-28 12:35:20 +02:00
Colin Darie
3af93735a3
feat(exports): turbo poll for pending exports 2023-09-28 12:35:19 +02:00
Colin Darie
ed057737a5
feat(exports): name the dossiers count 2023-09-28 12:35:18 +02:00
Lisa Durand
c7cd5d2189
improve UX for export page 2023-09-28 12:35:16 +02:00
Lisa Durand
58a143b2c7
improve wording and display for export page 2023-09-28 12:35:15 +02:00
Lisa Durand
282df1b44b
add link to export page in flash message for instructeur 2023-09-28 12:35:14 +02:00
Colin Darie
a867c9a998
feat(instructeurs): notification badge when a new export has been generated
Co-Authored-By: Lisa Durand <lisa.c.durand@gmail.com>
2023-09-28 12:35:13 +02:00
Colin Darie
99f5b39dbb
fix(exports): force regenerate export with same statut filter
Co-Authored-By: Lisa Durand <lisa.c.durand@gmail.com>
2023-09-28 12:35:12 +02:00
Colin Darie
edb030bb4c
refactor(exports): regenerating exports redirect (back) to exports page
Co-Authored-By: Lisa Durand <lisa.c.durand@gmail.com>
2023-09-28 12:35:11 +02:00
Colin Darie
ca0b5c9cb9
refactor(exports): destroy errorable on force to ensure we have fresh export
Il semblerait que le destroy échoue parfois silencieusement pour une raison
inconnue, ce qui empêche le create_or_find_export de se dérouler
à cause de la contrainte d'unicité (il rollback), ce qui conduit ensuite
à un comportement inattendu: re-téléchargement de l'ancienne archive
alors qu'on voulait la regénérer.

Co-Authored-By: Lisa Durand <lisa.c.durand@gmail.com>
2023-09-28 12:35:09 +02:00
Colin Darie
fc66f4b05d
refactor(exports): drop useless exports relation dependency for exports dropdown
Since the dropdown does not list download links anymore,
we don't have to pass them a dynamic exports list.

Co-Authored-By: Lisa Durand <lisa.c.durand@gmail.com>
2023-09-28 12:35:08 +02:00
Colin Darie
82dd05c189
chore(exports): finders by groupe instructeurs compatible across exports components
Co-Authored-By: Lisa Durand <lisa.c.durand@gmail.com>
2023-09-28 12:35:07 +02:00
Lisa Durand
78802712f4
add controller specs 2023-09-28 12:35:06 +02:00
Lisa Durand
79669dba37
fix spec 2023-09-28 12:35:05 +02:00
Lisa Durand
5a571a3535
create export page to list all the exports and remove links from the dropdown 2023-09-28 12:35:04 +02:00
LeSim
eb0af90ea9
Merge pull request #9532 from demarches-simplifiees/dependabot/npm_and_yarn/get-func-name-2.0.2
chore(deps): bump get-func-name from 2.0.0 to 2.0.2
2023-09-28 09:27:59 +00:00
simon lehericey
a3a46d3bba spec: use match_array 2023-09-28 11:19:06 +02:00
dependabot[bot]
ef735ffb40 chore(deps): bump get-func-name from 2.0.0 to 2.0.2
Bumps [get-func-name](https://github.com/chaijs/get-func-name) from 2.0.0 to 2.0.2.
- [Release notes](https://github.com/chaijs/get-func-name/releases)
- [Commits](https://github.com/chaijs/get-func-name/commits/v2.0.2)

---
updated-dependencies:
- dependency-name: get-func-name
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
2023-09-28 10:42:28 +02:00
simon lehericey
23b68fa5aa pj_migration: destroy blob if not found 2023-09-28 10:41:33 +02:00
Lisa Durand
a559bf54eb
Merge pull request #9517 from demarches-simplifiees/change-tabs-for-instructeur-dashboard-ldu
[instructeur] Mettre en avant les démarches closes avec des dossiers à traiter
2023-09-28 07:32:07 +00:00
Lisa Durand
db4c8619a9
Update app/views/instructeurs/procedures/index.html.haml
Co-authored-by: LeSim <mail@simon.lehericey.net>
2023-09-27 16:51:44 +02:00
Lisa Durand
91018d8f8f
Update app/controllers/instructeurs/procedures_controller.rb
Co-authored-by: LeSim <mail@simon.lehericey.net>
2023-09-27 16:51:07 +02:00