Commit graph

14201 commits

Author SHA1 Message Date
Pierre de La Morinerie
27edc6676d db: add foreign key contraint to AdministrateursProcedure
In production there are around 20 000 AdministrateursProcedure
records that reference a deleted Procedure.
2022-03-08 14:48:17 +01:00
Pierre de La Morinerie
a4108c7787 db: backport delete_orphans in recent migrations
Recent migrations used ActiveRecord when removing invalid data. This may
break if the ActiveRecord model later changes.

To ensure these migrations will run correctly, even when the code will
have changed, let's use an SQL-based helper instead of ActiveRecord.
2022-03-08 14:48:17 +01:00
Pierre de La Morinerie
3a16235868 db: Add a delete_orphans db helper 2022-03-08 14:47:43 +01:00
Pierre de La Morinerie
a645c5781d models: delete AdministrateursProcedure when destroying Procedure 2022-03-08 09:20:34 +01:00
mfo
c2eab85a90
Merge pull request #7008 from benoit-bernier/patch-1
Typo correction
2022-03-03 17:04:43 +01:00
mfo
62351153a1
Merge branch 'main' into patch-1 2022-03-03 17:01:16 +01:00
mfo
eb470b8cb7
Merge pull request #7009 from benoit-bernier/patch-2
Typo correction
2022-03-03 17:00:56 +01:00
Benoît Bernier
8ee6c5fe1b
Typo correction 2022-03-03 16:48:26 +01:00
Benoît Bernier
02661b5ec7
Typo correction 2022-03-03 16:46:02 +01:00
LeSim
3bd91d6ae3
Merge pull request #7004 from betagouv/agent_connect_is_beautiful
Rend la page de connexion visible en entier en 1280
2022-03-03 09:52:54 +01:00
simon lehericey
a01e523f08 more compression 2022-03-03 09:30:15 +01:00
simon lehericey
4c432b2ce8 wording 2022-03-03 09:30:15 +01:00
simon lehericey
ebd4d6a067 update FC/AG images 2022-03-03 09:30:15 +01:00
Paul Chavard
d8b445f39b
Merge pull request #7003 from tchak/fix-routage-toggle
fix(dossier): ensure submitted dossiers always have groupe instructeur
2022-03-02 17:01:34 +00:00
Paul Chavard
91caef0bfe fix(dossier): ensure submitted dossiers always have groupe instructeur 2022-03-02 16:57:12 +00:00
Paul Chavard
0a4d87abdb
Merge pull request #7002 from tchak/feat-admin-dossiers-count
feat(administrateur): dossiers count should only include relevant dossiers
2022-03-02 15:42:09 +00:00
Paul Chavard
ac6e219074 feat(administrateur): dossiers count should only include relevant dossiers 2022-03-02 15:37:42 +00:00
Pierre de La Morinerie
49853440f0
Merge pull request #7001 from betagouv/add-instructeur-constraint
Suppression des AdministrateursInstructeur quand un Instructeur est supprimé
2022-03-02 14:14:27 +01:00
Pierre de La Morinerie
13dfa577bd db: add missing part of schema.rb 2022-03-02 14:09:43 +01:00
Pierre de La Morinerie
5eee6b161f db: add foreign key contraints to AdministrateursInstructeur 2022-03-02 14:09:23 +01:00
Pierre de La Morinerie
087e438eb6 models: delete AdministrateursInstructeur when destroying Instructeur
By default, `has_and_belongs_to_many` properly deletes the record in
the join table.

However, as the association is declared manually with a
`has_many / through`, it doesn't delete the joined record automatically.

As we also lack a foreign-key contraint on the join table, that means
a dangling record remains in the join table.

To fix this, let's declare it a proper `has_and_belongs_to_many`
association, which will let the join record be deleted automatically
on destroy.
2022-03-02 11:26:53 +01:00
Paul Chavard
92e79027c4
Merge pull request #6997 from betagouv/fix-drom-phones-formatting
Correction de l'affichage des numéros de téléphone des DROM
2022-03-02 10:05:53 +00:00
Pierre de La Morinerie
e32c9a9f94 models: don't attempt to format invalid phone numbers
This is a defensive-programming measure, because formatting an
invalid phone number may truncate some leading numbers.
2022-03-02 09:57:03 +00:00
Pierre de La Morinerie
f35d18cd5c models: stop truncating DROM phone numbers
Fix #6996
2022-03-02 09:57:03 +00:00
Pierre de La Morinerie
5150e33212 models: ensure DROM phone numbers are valid
They were accepted before, because they were 'possible' – but now
they are explicitely considered as valid.
2022-03-02 09:57:03 +00:00
Paul Chavard
cb5561978a
Merge pull request #6999 from tchak/fix-multi-select
fix(multi-select): fix labels on multi select component
2022-03-02 09:56:07 +00:00
Paul Chavard
b8a22ae8b2 fix(multi-select): fix labels on multi select component 2022-03-02 09:48:54 +00:00
Paul Chavard
963bc90c94
Merge pull request #6998 from betagouv/dependabot/bundler/image_processing-1.12.2
chore(deps): bump image_processing from 1.12.1 to 1.12.2
2022-03-02 09:10:57 +00:00
dependabot[bot]
19cde3140e
chore(deps): bump image_processing from 1.12.1 to 1.12.2
Bumps [image_processing](https://github.com/janko/image_processing) from 1.12.1 to 1.12.2.
- [Release notes](https://github.com/janko/image_processing/releases)
- [Changelog](https://github.com/janko/image_processing/blob/master/CHANGELOG.md)
- [Commits](https://github.com/janko/image_processing/compare/v1.12.1...v1.12.2)

---
updated-dependencies:
- dependency-name: image_processing
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-03-01 23:35:43 +00:00
Pierre de La Morinerie
371d141fcd
Merge pull request #6971 from mfaure/Ajout_doc_deploiement
Ajout de documentation pour le déploiement
2022-03-01 17:09:30 +01:00
Pierre de La Morinerie
64a28cc8bd doc: move the ADR to their own directory 2022-03-01 17:05:06 +01:00
Pierre de La Morinerie
bbc45f25ef doc: add deployment notes 2022-03-01 17:05:05 +01:00
Matthieu FAURE
4fd9312fc9 DOC Ajout doc déploiement, avec montée de version et migration de données (afterparty) 2022-03-01 17:05:05 +01:00
Pierre de La Morinerie
98d087ab4d
Merge pull request #6992 from betagouv/admin-deletion
Suppression des AdministrateursProcedure quand un Administrateur est supprimé
2022-03-01 17:04:00 +01:00
Pierre de La Morinerie
3fde7021e7 db: add foreign key contraint to AdministrateursProcedure 2022-03-01 16:58:04 +01:00
Pierre de La Morinerie
71e1b6c973 models: delete AdministrateursProcedure when destroying Administrateur
By default, `has_and_belongs_to_many` properly deletes the record in
the join table.

However, as the association is declared manually with a
`has_many / through`, it doesn't delete the joined record automatically.

As we also lack a foreign-key contraint on the join table, that means
a dangling record remains in the join table.

To fix this, let's declare it a proper `has_and_belongs_to_many`
association, which will let the join record be deleted automatically
on destroy.
2022-03-01 16:58:04 +01:00
Paul Chavard
9bd1d128d4
Merge pull request #6987 from tchak/fix-map-spec
fix(carto): show map UI before loading map styles
2022-03-01 11:13:32 +00:00
Paul Chavard
2a42690388 fix(carto): show map UI before loading map styles 2022-03-01 11:08:07 +00:00
Pierre de La Morinerie
022fb04e2b
Merge pull request #6993 from betagouv/dependabot/bundler/nokogiri-1.13.3 2022-03-01 11:33:14 +01:00
simon lehericey
30a7fb25a7 update nokogiri 2022-03-01 10:01:33 +01:00
mfo
b7da406fe4
Merge pull request #6990 from betagouv/US/fix-avis
fix(avis_controller#*): missing ACL
2022-02-28 15:12:53 +01:00
mfo
4346775169
Merge branch 'main' into US/fix-avis 2022-02-28 15:08:25 +01:00
Martin
48612028f4 fix(avis_controller#*): missing ACL 2022-02-28 14:24:41 +01:00
mfo
43f8bbfb11
Merge pull request #6913 from betagouv/US/redirect-after-dossier-submitted
Possibilité de rediriger l'usager vers un site externe après dépôt de son dossier
2022-02-25 14:05:27 +01:00
Martin
b808b4db00 fix(relation): avoid double association between procedure/procedure_revision/dossier_submitted_message 2022-02-25 14:01:18 +01:00
Martin
35b9487897 feat(data.integrity): add foreign key to prevent orphan data 2022-02-25 14:01:18 +01:00
Martin
567d01478e fix(brakeman): prune absolete and ad a new one [surprise] 2022-02-25 14:01:18 +01:00
Martin
85a588541b feat(dossier_submitted_message): add a new system to customize the standby page (/merci) after an user created his folder. this is a basic feature that will come with more options asap
wip(dossier_created_hook): add tile to administrateurs/procedure#show in order to crud dossier_created_hook

refactor(css.utilities): remove merge helpers.scss within utils.scss (same purpose). use scss each for spacer modifiers

refactor(dossiers/_merci.html): extract partial _merci so we can re-use it in preview of dossier_created_hook.

feat(wip): current progress
2022-02-25 14:01:18 +01:00
LeSim
7c45589ae6
Merge pull request #6986 from betagouv/fc-agent-2
Relooking agent connect v2
2022-02-25 10:42:48 +01:00
simon lehericey
83d2e44cd7 do not show connect button on agentconnect page 2022-02-24 12:23:12 +01:00