DGNum/demarches-normaliennes
14
1
Fork 0
Code Issues 1 Pull requests Projects Releases Packages Wiki Activity
21980 commits 4 branches 1166 tags 84 MiB
Commit graph

1980 commits

Author SHA1 Message Date
Colin Darie
f28739d648
Merge pull request #9372 from colinux/svr 
Admin: permet l'activation du SVR
 2023-09-13 12:08:39 +00:00
Colin Darie
680919a68f
feat(svr): instructor filters with svr wording specific 2023-09-13 13:50:26 +02:00
Colin Darie
e8000adecf
feat(svr): refuses automatically a dossier 2023-09-13 13:50:23 +02:00
Eric Leroy-Terquem
cdeddc6e1e test(champ value): test compute of champ value for communes tdc 2023-09-13 10:53:52 +02:00
Eric Leroy-Terquem
46ff36c2bc feat(routing): make routing engine work with commune champ 2023-09-13 10:45:21 +02:00
Eric Leroy-Terquem
50d0587a81 feat(routing): add communes to routable_types_de_champ 2023-09-13 10:45:20 +02:00
Eric Leroy-Terquem
345729a159 test(champ value): test compute of champ value for regions tdc 2023-09-13 10:22:01 +02:00
Eric Leroy-Terquem
d37fb90b2f feat(routing): make routing engine work with region champ 2023-09-13 10:22:00 +02:00
Eric Leroy-Terquem
5afaa458e2 feat(routing): add regions to routable_type_de_champ 2023-09-13 10:22:00 +02:00
krichtof
5aabce488b
Merge pull request #9425 from demarches-simplifiees/9356-service-gi 
ETQ Usager, je veux voir dans mon dossier les informations de contact de mon groupe instructeur
 2023-09-11 07:38:34 +00:00
Christophe Robillard
587960cfd9 clone groupe instructeur service 
if admin owns original procedure
 2023-09-11 08:58:04 +02:00
Christophe Robillard
46dec40543 add contact information model 2023-09-08 11:04:06 +02:00
simon lehericey
d319385d17 Add tests for prefill identity 2023-09-07 10:17:19 +02:00
simon lehericey
4cbb8e91f2 Workable draft prefill identity (no link or query help) 2023-09-07 10:17:19 +02:00
LeSim
d69636c411
Merge pull request #9230 from colinux/log-destroyed-dossiers 
Tech: log technique de la destruction de dossiers
 2023-09-06 14:17:57 +00:00
Colin Darie
20c7921abe
chore(log): log destroyed dossiers 2023-09-06 16:07:18 +02:00
Eric Leroy-Terquem
32b446deee refactor(groupe instructeur): add valid_rule? method 
Co-authored-by: LeSim <mail@simon.lehericey.net>
 2023-09-05 15:59:11 +02:00
Eric Leroy-Terquem
0cab4d9807 test(routing): test routing priorities 2023-09-05 15:59:11 +02:00
Eric Leroy-Terquem
e1ab65e62a feat(routing): can route from not_eq routing rules 2023-09-05 15:57:31 +02:00
Colin Darie
b5e2c9b860
fix(sva): improvements when a dossier has already been terminated 2023-09-04 16:09:01 +02:00
simon lehericey
fdf51b5ea1 fix: a expert merge transfers hidden procedures 2023-08-31 14:26:45 +02:00
Christian Lautier
db278e83ed add a constant for the most used test password 2023-08-31 13:40:05 +02:00
LeSim
3e193675aa
Merge pull request #9392 from demarches-simplifiees/move-groupe-instructeur-validation-to-model 
Tech : déplace une validation sur le groupe d'instructeurs défaut du controleur au modèle
 2023-08-31 09:45:03 +00:00
Colin Darie
c4a54fc576
Merge pull request #9426 from colinux/fix-avis-answer-sort 
ETQ instructeur: fix flaky test et tri des dossiers par avis
 2023-08-30 09:34:44 +00:00
Colin Darie
cf87419a19
fix(avis): table is only sortable by question_answer, answer is not exposed 2023-08-29 18:01:14 +02:00
Eric Leroy-Terquem
ca25788f07 feat(routing): use only department codes in routing rules 2023-08-29 15:50:42 +02:00
Eric Leroy-Terquem
7e3fc68c53 feat(routing): make routing engine work with departement champ 2023-08-29 15:50:42 +02:00
Eric Leroy-Terquem
ac823c1b25 feat(routing): add departements to routable_type_de_champ 2023-08-29 15:50:42 +02:00
Eric Leroy-Terquem
fc2c196cfa chore(groupe instructeur): move closed validation for defaut groupe to model 2023-08-21 16:31:54 +02:00
Martin
05687e63ca amelioration(dossier.routage): assigne le groupe d'instructeur au moment de passer_en_construction! un dossier et ignore ce concept de pre-setter le groupe d'instructeur sur tout le reste de l'app 2023-08-14 10:17:23 +02:00
Christian Lautier
5ce42afe28 Fix datetime_champ validation with negative time zone 2023-08-02 14:40:47 +02:00
Paul Chavard
e9cb50d09c feat(api): add last_authenticated_at timestamp to api requests 2023-08-02 13:22:18 +02:00
Colin Darie
fb470c1504
fix(fork): dossier forkable when associated objects to champs are not valid 2023-07-26 12:18:49 +02:00
Paul Chavard
d669e0fb45 fix flaky spec 2023-07-25 12:49:13 +02:00
seb-by-ouidou
243b8c239a feat(administrateur): add environment variable for Administrateur::UNUSED_ADMIN_THRESHOLD 2023-07-24 15:55:33 +00:00
Paul Chavard
4bc8b23a19 fix(dossier): purge motivation after repasser en instruction 2023-07-24 09:52:12 +02:00
Colin Darie
5998cfe31f refactor(correction): rename kind => reason with default correction => incorrect 2023-07-21 16:45:47 +02:00
krichtof
753731cc53
Merge pull request #9259 from demarches-simplifiees/9189-merge-api-tokens 
ajoute les jetons api lors de la fusion d'un compte administrateur
 2023-07-19 12:04:19 +00:00
Paul Chavard
4f4e68719a
Merge pull request #9275 from tchak/validate-geo-json 
ETQ Instructeur, je veux que les GeoJSON déposés par les utilisateurs soient valides
 2023-07-19 08:01:01 +00:00
Paul Chavard
47dc2cba9c
Merge pull request #9325 from tchak/fix-dpo-lien-validation 
fix(procedure): accept dpo emails with accents
 2023-07-18 16:27:49 +00:00
Paul Chavard
04b3a70108 feat(champ): validate GeoJSON 2023-07-18 18:01:29 +02:00
Paul Chavard
1882f652d5 fix(dossier): do not create groupe instructeur assignements on brouillons 2023-07-18 16:54:00 +02:00
Eric Leroy-Terquem
0e58e10b82 refactor(DossierAssignment): move create_assignment to assign_to_groupe_instructeur 2023-07-18 16:54:00 +02:00
Eric Leroy-Terquem
c09655a07f feat(DossierAssignment): create assignment from routing engine 2023-07-18 16:54:00 +02:00
Paul Chavard
08f0184700 fix(procedure): accept dpo emails with accents 2023-07-18 15:16:31 +02:00
Christophe Robillard
18f5c2a9ad merge only v3 api tokens 2023-07-17 16:35:07 +02:00
Christophe Robillard
67b9bb264a build raison sociale from nom and nom 2023-07-14 16:19:44 +02:00
Martin
ce9dbed663 amelioration(NotificationMailer): sort la creation des commentaire sur la messagerie du mailer [trop de prob possible sinon: au retry on dupliquait les commenaitres, si le mail foirait, on commentait pas etc...] 2023-07-11 15:11:40 +02:00
Colin Darie
07432503a7
Merge pull request #9291 from colinux/stats 
Stats: ignore aperçus, brouillons en construction & dossiers des démarches en brouillon
 2023-07-11 08:36:12 +00:00
Colin Darie
0d106cdf4b
Merge pull request #9104 from colinux/sva 
ETQ admin je peux configurer ma démarche en SVA/SVR
 2023-07-11 08:21:46 +00:00
Colin Darie
73a28d2eca
fix(sva): don't process dossiers submitted before sva was enabled 2023-07-11 10:02:47 +02:00
Colin Darie
7225f1b023
fix(sva): not compatible with declarative procedure 2023-07-11 10:02:47 +02:00
Colin Darie
4c46a2f8da
feat(sva): date in pdf 2023-07-11 10:02:47 +02:00
Colin Darie
8c49dcf21e
feat(sva): exports include SVA devision date 2023-07-11 10:02:47 +02:00
Colin Darie
f369775d5b
fix(sva): compute decision date from the day after deposit or resolution 2023-07-11 10:01:49 +02:00
Colin Darie
b4e6c20bbd
feat(sva): log operation when instructeur requests a correction 2023-07-11 10:01:49 +02:00
Colin Darie
6ce8428ac6
feat(sva): instructeur can flag a dossier as incomplete 2023-07-11 10:01:48 +02:00
Colin Darie
168189c3ac
feat(sva): instructeurs can filter by sva/svr decision before a date 2023-07-11 10:01:48 +02:00
Colin Darie
d70278a534
refactor(sva): dossier can't repasser en construction without pending correction 2023-07-11 10:01:47 +02:00
Colin Darie
3612eddf79
feat(sva): accepte automatiquement 2023-07-11 10:01:46 +02:00
Colin Darie
eb7f1f199a
feat(sva): block configuration changes when procedure is published 2023-07-11 10:01:46 +02:00
Colin Darie
afe373c6b4
feat(sva): transition to en_instruction when (re-)submitting a dossier 2023-07-11 10:01:46 +02:00
Colin Darie
8c210e6fc7
feat(admin): config sva/svr 2023-07-11 10:01:45 +02:00
Paul Chavard
95f7ca0f44 fix(cojo): invalid accreditation should result in a blank champ 2023-07-10 19:15:39 +02:00
Colin Darie
aa8bef48b0 fix(stat): ignore forks, previews & dossiers from draft procedures 2023-07-10 15:16:56 +02:00
Paul Chavard
d5820277c0 feat(cojo): add cojo type de champ 2023-07-10 14:57:34 +02:00
Colin Darie
6fa7ed1c1f
Merge pull request #9279 from colinux/fix-email-default-template 
Correctif: utilise le template d'email de notification par défaut quand la démarche n'a pas personnalisé le sien
 2023-07-06 09:30:04 +00:00
Colin Darie
edc790be8f test: remove false positive warning about expect.not_to raise(SpecificError) syntax 2023-07-06 10:56:01 +02:00
Paul Chavard
9cfbc75f25 spec(procedure): test url validator 2023-07-06 10:27:43 +02:00
Colin Darie
c83cc048c6
Merge pull request #9269 from mfo/US/text-merge-fork-with-revision-removing-repetition 
Test: merge_fork d'un dossier étant sur une revision passée avec une répétition qui a été supprimée
 2023-07-04 12:21:31 +00:00
Eric Leroy-Terquem
f959450477
Merge pull request #9244 from demarches-simplifiees/refactor-routing-update 
Tech : mise à jour du routage sans callback
 2023-07-04 09:39:00 +00:00
Eric Leroy-Terquem
7fe4ec67c3 update previous routing system tests 2023-07-03 14:58:45 +02:00
Eric Leroy-Terquem
7598b0a513 remove previous routing sytem code 2023-07-03 14:58:45 +02:00
Eric Leroy-Terquem
a2c636d784 fix(tests): create groupe instructeurs with factory 2023-07-03 14:47:56 +02:00
Martin
5c9101d15f bug(merge_fork): un dossier etant sur une revision passee avec une repetition qui a ete supprime ne peut merge_fork 2023-06-30 14:25:23 +02:00
Christophe Robillard
faecefe405 merge admin api tokens 2023-06-28 13:37:33 +02:00
Paul Chavard
f7e81965b1 fix(instructeur): filter by departement or region should use code instead of name 2023-06-28 10:14:34 +02:00
Paul Chavard
02dcead04a fix(commune): add fallbacks to commune name resolution 2023-06-28 09:44:21 +02:00
Colin Darie
8501fbadbb fix(dossier): can merge fork after rebase adding a champ in repetition 2023-06-23 00:22:32 +02:00
Colin Darie
33617a4c44 test: ensure travel_back is automatically called at the right time 2023-06-20 00:04:55 +02:00
Paul Chavard
c1afc985e4 fix(prefill): allow private annotations prefill 2023-06-15 10:07:25 +01:00
Paul Chavard
6723bdcd9d fix(carto): no crash on points with elevation 2023-06-12 14:56:52 +02:00
Colin Darie
75b2685230 fix(instructeurs): human format a filtered date 2023-06-08 19:01:23 +02:00
Paul Chavard
c4432b1b47 perf(carto): use json schema to validate geojson instead of rgeo 2023-06-06 15:43:56 +02:00
Colin Darie
66dc8f251f
Merge pull request #9128 from colinux/fix-procedure-presentation-show-avis 
ETQ instructeur je veux pouvoir afficher sans erreur la colonne "avis"
 2023-06-05 08:53:39 +00:00
Colin Darie
7e567d5080
fix(instructeurs): don't crash when displaying "avis" column 2023-06-02 17:07:02 +02:00
Colin Darie
734d88d80d
fix(pending-correction): wording alignement 2023-06-02 16:16:14 +02:00
Colin Darie
62cc9d30d8
chore(correction): passing en_instruction resolve pending corrections 2023-06-02 16:16:14 +02:00
Colin Darie
5ab44fc7a9
chore: rename dossier_resolution => dossier_correction 2023-06-02 16:16:14 +02:00
Colin Darie
ca3b127942
feat(instructeur): can flag a dossier as "pending corrections" 2023-06-02 16:16:12 +02:00
Colin Darie
d73b96ea40
feat(dossier): pending resolution state 2023-06-02 16:13:16 +02:00
Colin Darie
2c79ca94f5
chore(schema): create dossier_corrections 2023-06-02 16:13:15 +02:00
Colin Darie
ec244f1a94
fix(procedure): auto_archive_on must be in future 2023-06-01 16:49:52 +02:00
mfo
c2f2b4ef2a
Merge pull request #9106 from mfo/api-entreprise.etablissement_adapter 
API Entreprise: migration "Etablissement"
 2023-06-01 11:45:47 +00:00
mfo
1a6dc10548
Merge pull request #9102 from demarches-simplifiees/8472-migrate-rna 
API Entreprise: migration RNA (associations)
 2023-06-01 11:37:57 +00:00
Martin
c90175f121 tech(api-entreprise.etablissement): passage du endpoint ETABLISSEMENT_RESOURCE_NAME en v3 2023-06-01 09:06:36 +02:00
Martin
0d3deb01be tech(rna_controller#show): corrige les specs et recupère uniquement les informations utilisé par l'app 2023-05-31 16:11:12 +02:00
Eric Leroy-Terquem
e8d687f5e7 fix(routing): routing engine works even with unconfigured groups 2023-05-31 11:38:16 +02:00
krichtof
0051face93
Merge pull request #9014 from demarches-simplifiees/8859-default_zones 
Etq admin, lors de la création ou modification d'une démarche, des zones par défaut me sont suggérées
 2023-05-26 17:25:21 +00:00
Christophe Robillard
ba281d53cf migrate entreprise adapter to v3 2023-05-26 13:37:20 +02:00
Colin Darie
795e0ca471
fix(fork): can fork a dossier having invalid champs so it can be fixed in brouillon 2023-05-24 12:15:43 +02:00
Paul Chavard
cf13b942e7
Merge pull request #9076 from colinux/fix-instructeurs-filter-avis 
ETQ instructeur je peux filtrer les dossiers par avis
 2023-05-24 08:05:07 +00:00
Colin Darie
ff8fba3725
fix(instructeur): can filter by avis answer 2023-05-23 09:40:21 +02:00
Colin Darie
d16b81e09c fix(rebase): don't fail on force rebased when procedure is still in draft 2023-05-22 13:50:58 +02:00
Christophe Robillard
3705dc2553 determine default zones according to tchap hs 2023-05-16 09:40:53 +02:00
Colin Darie
0d21450f8a
fix(fork): don't let active storage override our champ#updated_at after a transaction 2023-05-15 11:08:07 +02:00
Colin Darie
9b52f0902d
test(clone): move dossier#clone spec into appropriate concern 2023-05-15 11:08:06 +02:00
Paul Chavard
b4a299c326 fix(user): always rebase original dossier before merge 2023-05-12 20:42:02 +02:00
simon lehericey
6148f24387 Revert "Merge pull request #9002 from tchak/feat-procedure-clone-preview-published" 
This reverts commit 7a6f46a8ad, reversing
changes made to 4513c52213.
 2023-05-12 11:29:11 +02:00
Colin Darie
79f450a422
Merge pull request #9021 from colinux/feat-en-construction-fork 
ETQ usager, je modifie et soumets à nouveau mon dossier “en construction"
 2023-05-10 19:46:40 +00:00
Colin Darie
218c7d08c2
feat(fork): mark a fork as stale for future deletion, so it can't be reused 2023-05-09 18:49:53 +02:00
Colin Darie
f6ebfe0e47
fix(dossier): sync search_terms after merge 
Use a job instead of a lot of reloads
 2023-05-09 18:49:52 +02:00
LeSim
d0bb759d3d
Merge pull request #8997 from demarches-simplifiees/add_defaut_procedure_for_new_admin 
ETQ admin, je veux avoir une première démarche pré remplie lorsque j'arrive sur ds
 2023-05-09 16:38:55 +00:00
Paul Chavard
71cfe094aa
fix(groupe_instructeur): always use assign_to_groupe_instructeur method 2023-05-09 17:23:23 +02:00
Paul Chavard
025bd5beaf
feat(dossier): dossier can be forked for editing 2023-05-09 15:34:10 +02:00
mfo
2374ced5d2
Merge pull request #8987 from mfo/US/link-to-errored-champs 
amelioration(dossier#submit_brouillon): ETQ usager, je souhaite pouvoir acceder aux champs en erreur facilement
 2023-05-09 07:06:36 +00:00
Paul Chavard
7a6f46a8ad
Merge pull request #9002 from tchak/feat-procedure-clone-preview-published 
ETQ Administrateur, je veux cloner la version publiée des démarches en production
 2023-05-05 14:36:03 +00:00
Martin
2135985583 correctif(procedure.clone): ET admin, je souhaite pouvoir cloner une procedure ayant deux groupes d'instructeur ayant le dernier fermé 2023-05-05 11:09:06 +02:00
Paul Chavard
11065946ce fix(instructeur): fix dossiers suivis filter (merge behavior change in rails 7) 2023-05-04 18:24:18 +02:00
Paul Chavard
616188bfe3 feat(administrateur): when clone or preview procedure should use published revision if not the owned 2023-05-04 16:15:55 +02:00
simon lehericey
9c8020b05c feat(admin): add initiation procedure for a new admin 2023-05-03 15:08:21 +02:00
Colin Darie
eabc9069f8 test(super-admin): more explicit disable otp test 2023-05-03 11:37:28 +02:00
Nicolas Cavigneaux
06296e933a
fix: super admin test where attribute was not reloaded 2023-05-03 11:35:28 +02:00
Martin
c8ab1e8e03 amelioration(dossier#submit_brouillon): ETQ usager, je souhaite pouvoir acceder aux champs en erreur facilement 2023-05-03 07:36:42 +02:00
Paul Chavard
f2c1c071b4 Revert "Merge pull request #8899 from demarches-simplifiees/8738-validate-adresse-electronique" 
This reverts commit d3eda28f35, reversing
changes made to 6394996e7f.
 2023-04-28 16:10:20 +02:00
Paul Chavard
a41713c837
Merge pull request #8968 from demarches-simplifiees/fix_defaut_groupe_instructeur_again 
Correctif: definit le groupe instructeur par defaut pour certaines procedure clonées
 2023-04-26 17:59:13 +00:00
Paul Chavard
d3eda28f35
Merge pull request #8899 from demarches-simplifiees/8738-validate-adresse-electronique 
ETQ usager, je veux que les champs de type adresse électronique soit validé
 2023-04-26 16:52:02 +00:00
Lisa Durand
e393132fd8
Merge pull request #8936 from demarches-simplifiees/add-yes-no-column-for-instructeurs 
[instructeur] ajout du nb de réponses oui/non aux avis dans le tableau d'une procedure
 2023-04-26 09:05:58 +00:00
simon lehericey
0934a672fe fix: defaut_groupe_instructeur for a cloned procedure from another admin without a group with default label 2023-04-26 10:52:31 +02:00
simon lehericey
dce2bf3209 spec: move procedure.clone in subject, to enable future before 2023-04-26 10:47:51 +02:00
LeSim
c8ed0532ed
Merge pull request #8948 from colinux/fix-geoarea-geometry-blank 
ETQ Usager, champ carte: ne permet pas d'enregistrer une geometry null pour ne pas casser les exports
 2023-04-26 10:15:25 +02:00
Colin Darie
21a829ec1e fix(conditionel): error when using operator eq/not_eq with a multi dropdown 2023-04-26 09:58:00 +02:00
Lisa Durand
26ff82dbe4 Merge branch 'main' of github.com:betagouv/demarches-simplifiees.fr into user-dashboard/add-alert-WIP-last-dossier 2023-04-25 13:01:40 +02:00
Colin Darie
25956c5141
fix(geoarea): geometry must not be nil 2023-04-22 16:23:39 +02:00
simon lehericey
a202a57988 fix: defaut_groupe_instructeur_id for a cloned procedure 2023-04-21 12:20:50 +02:00
Lisa Durand
b52a2ca972 fix spec 2023-04-21 10:21:54 +02:00
krichtof
c2461f230c validate value for email champ 2023-04-20 18:27:02 +02:00
Paul Chavard
88f680a265
Merge pull request #8930 from tchak/fix-champ-commune-spaces 
ETQ usager, je voudrai pouvoir remplir un code postal avec des espaces
 2023-04-20 08:40:38 +00:00
Paul Chavard
586286cb08
Merge pull request #8916 from demarches-simplifiees/can-update-defaut-groupe-instructeur-2 
feat(routage): permet de changer le groupe par défaut
 2023-04-20 08:28:46 +00:00
Paul Chavard
4a2e499679 fix(commune): should accept postal codes with spaces 2023-04-20 10:16:48 +02:00
simon lehericey
e64ac79f05 tech(refactor): much nicer code, thx LeSim 
root -> rooted_tree

depth_cach -> walk

smal refactor

comment

remove form for header_section

remove seen_at from header section

header_section: champ -> header_section

champ_subree: remove if not

remove root_depth use header_section_level_value instead

remove unused include

remove ChampTreeComponent

rename ChampsSubtreeComponent to SectionComponent

use TreeableConcern only in section component

remove fields_for_champ_component

champs -> tail

add split_section_champ helper

refactor(editable_champ::header_section): keep same interface everywhere

fix(repetition): add spec for SectionComponent on repetitions
 2023-04-20 08:22:02 +02:00
Martin
88abefb370 tech(remaniement): isole la logique de rendu au champs_subtree_component 2023-04-20 08:22:02 +02:00
Martin
3b5d1bd55b tech(remaniement): extraction du passage d'une liste de champs a un simili arbre 2023-04-20 08:22:02 +02:00
Martin
b9faa26560 amelioration(editeur-de-champs): permet de choisir un niveau de titre (de 1 à 3) pour les champs de type Champs::HeaderSectionChamp. Gère les erreurs dans le cas ou un administrateur supprimerait un HeaderSection qui casserait l'ordre des titre [ex: titre 1,2,3. et l'admin supprime le titre 1 et il reste que 2,3]. 2023-04-20 08:22:02 +02:00
Colin Darie
9728493bda
Merge pull request #8924 from colinux/rubocop-upgrades 
Tech: update rubocop, active nouveaux cops Rails/*
 2023-04-19 13:37:10 +00:00
simon lehericey
79131cc294 fix spec 2023-04-19 13:52:42 +02:00
Colin Darie
7aba5ccc3e
chore(rubocop): fix Rails/DurationArithmetic 2023-04-19 12:55:13 +02:00
Paul Chavard
05cfb4055d fix(dossier): improuve dossier state display 2023-04-19 12:27:16 +02:00
Lisa Durand
c565ed415b change scope and alert location after UI modification 2023-04-18 12:03:10 +02:00
LeSim
c252748833
Merge pull request #8836 from demarches-simplifiees/improve-routing-rules-ux 
feat(routing): nicer and safer ?
 2023-04-17 08:23:15 +00:00
Paul Chavard
5abb6a8f12 chore(spec): remove memory store cache from tests 2023-04-13 13:10:23 +02:00
Paul Chavard
21b548d32b fix(dossier): delete all champs starting with children 2023-04-13 11:08:10 +02:00
simon lehericey
f6948cfd5e feat(routing): record first groupe as default_groupe_instructeur 2023-04-13 10:36:42 +02:00
Lisa Durand
bc3e67ab94 add alert on user dashboard to edit last editable dossier 2023-04-11 15:50:17 +02:00
Paul Chavard
def32a3615 chore(dossier): remove fallback from commune champ 2023-04-11 10:49:01 +02:00
Colin Darie
a413d2fa9c fix(admin): can delete an admin without published procedure 2023-04-07 16:10:10 +02:00
Paul Chavard
aaae3f461d feat(graphql): expose commune and departement information on address 2023-04-07 12:13:41 +02:00
Paul Chavard
ffb332159f fix(dossier): selecting blank option should not empty selection 2023-04-06 15:24:52 +02:00
Paul Chavard
b8f639721e
Merge pull request #8864 from colinux/fix-date-not-parseable 
fix(date): ne crash pas lorsqu'un champ date n'as pas une date standard
 2023-04-05 11:48:48 +00:00
Colin Darie
5e62aa7d21 fix(date): don't crash when date value is not parseable 2023-04-05 12:42:28 +02:00
Martin
6039539727 bug(administrateur.merge): la fusion de compte entre admin devrait aussi dissocier les services des procedures supprimées 2023-04-04 16:29:24 +02:00
Paul Chavard
2a48228552 fix(dossier): improuve commune champ rendering in pdf 2023-04-04 16:01:16 +02:00
Paul Chavard
12f0c03bac
Merge pull request #8847 from tchak/feat-improuve-dossier-remove 
fix(dossier): an invited user can remove (leave) a dossier
 2023-04-04 13:10:18 +00:00
simon lehericey
fd927fd116 fix(condition_check_on_children): give proper upper tdc to child condition check 2023-04-04 10:24:11 +02:00
Paul Chavard
0864666d0a fix(dossier): an invited user can remove (leave) a dossier 2023-04-03 20:10:44 +02:00
Paul Chavard
fce78bbf30 feat(dossier): multiselect without react 2023-04-03 16:54:50 +02:00
mfo
4336184fc8
Merge pull request #8833 from mfo/US/fix-valid-conditions-on-repetition 
correctif(revision.validation-des-conditions): les conditions dans un bloc répétable ne remontenpt pas dans le composant ErrorsSummary
 2023-03-31 15:03:12 +00:00
Martin
92f5e7663e bug(validation-des-conditions): les conditions dans un bloc repetable ne remontent pas dans la liste des erreurs de la page formulaire ou sur les changements du formulaire 2023-03-31 10:31:34 +02:00
simon lehericey
3cede55d41 feat(routing): add routing engine 2023-03-30 10:51:20 +02:00
simon lehericey
f6738be454 fix(spec): small refactor 2023-03-30 10:51:20 +02:00
Paul Chavard
01602101f1 spec(commune): improuve spec 2023-03-29 15:42:33 +02:00
Paul Chavard
00fc2f519f chore(spec): fix commune spec 2023-03-29 15:42:33 +02:00
Colin Darie
6ddbda34a2 fix(avis): don't list question_answer radios on empty question 2023-03-29 15:42:33 +02:00
Paul Chavard
76da68c3fb feat(commune): prefill by postal code and insee 2023-03-28 16:34:19 +02:00
Paul Chavard
6b8f7a0c73
Merge pull request #8795 from tchak/fix-flaky-test 
fix(api_token): improuve flaky test
 2023-03-22 11:01:25 +00:00
Paul Chavard
ee1df3f05f fix(dossier): fix rebasing submitted dossiers private champs type changes 2023-03-22 11:43:08 +01:00
Paul Chavard
48733a1d15 fix(api_token): improuve flaky test 2023-03-22 11:18:49 +01:00
Colin Darie
954652fcf5
fix(champ): may fix pg deadlocks: autosave already saves value at the same time 2023-03-20 14:32:14 +01:00
Paul Chavard
8ee13f1719 feat(api_token): add allowed_procedure_ids and write_access 2023-03-15 19:09:49 +01:00
Colin Darie
6a2a7fa2d0
Merge pull request #8753 from colinux/fix-auto-numering-in-repetition 
Fix(dossier): ne numérote pas automatiquement les titres de section dans les répétitions
 2023-03-09 15:41:57 +00:00
Colin Darie
f33d192142 fix(dossier): don't auto-number header sections in repetitions 2023-03-09 16:15:56 +01:00
Colin Darie
d6887f8aa4 fix(procedure): clone reset estimated_dossiers_count 2023-03-07 19:11:30 +01:00
Martin
401ead47f0 bug(dossier.export.pdf): l'export au format pdf d'un dossier ayant un champ de type repetition contenant un titre est bizarre 2023-03-07 07:00:28 +01:00
Colin Darie
8722ee028d
Merge pull request #8729 from colinux/fix-groupe-instructeur-wrongly-invalid 
fix(groupe-instructeur): un groupe instructeur inactif est valide tant qu'il reste un groupe actif
 2023-03-06 10:13:16 +00:00
Colin Darie
20d4a8153d
fix(groupe-instructeur): a closed groupe with an active groupe is a valid record 2023-03-02 16:34:18 +01:00
sebastiencarceles
00fa8dc895 transform value to also populate external id 2023-03-01 14:03:54 +01:00
sebastiencarceles
a7b21fcd7c let address champ be prefillable 2023-03-01 14:03:54 +01:00
krichtof
5840c8c7f9
Merge pull request #8711 from demarches-simplifiees/8708-demarches-publiques 
Ne pas publier le descriptif de toutes les procedures sur datagouv
 2023-03-01 10:09:47 +00:00
Christophe Robillard
9ff88db48c publish only some opendata procedures for datagouv 
- only published or closed procedures
- only procedures with flag opendata
- only procedures with 4 or more dossiers
- only procedures without word "mail" in lien_site_web
- only procedures without word "intra" in lien_site_web
 2023-02-28 17:02:08 +01:00
sebastiencarceles
f52554b5a3 review: update value with async fetch 
1 - spec cover the job which fetches external data

2 - refactor the job with guard clauses

3 - delegate update operation to the champ itself

4 - annuaire education: override the update operation
to let the value be populated by the fetched data

5 - prefilling: don't fetch data synchronously
 2023-02-28 14:53:08 +01:00
sebastiencarceles
447ea1b9a8 don't prefill with an incorrect value 2023-02-28 14:23:38 +01:00
sebastiencarceles
d7bfb9dc18 enrich value from education api 2023-02-28 14:23:38 +01:00
sebastiencarceles
71f1e785ab let annuaire education champ be prefillable 2023-02-28 13:26:35 +01:00
sebastiencarceles
a08bb1bddc fix epci: all possible values 2023-02-28 08:37:52 +01:00
sebastiencarceles
2ae2d99e93 fix communes: all possible values 2023-02-28 08:36:43 +01:00
Colin Darie
ae93d3927e refactor(dossier): extract sections logic in a concern 2023-02-27 17:29:22 +01:00
Colin Darie
1981bfc88e feat(tdc): strip libelle so header section titles always start with something 2023-02-27 17:29:22 +01:00
Colin Darie
d7880f7e58 feat(dossier/pdf): header sections numbering 2023-02-27 17:29:22 +01:00
Colin Darie
3de089d6c7 fix(conditional): dynamic title counters using css 
Closes #8086
 2023-02-27 17:29:22 +01:00
sebastiencarceles
35f4874b69 allow integers only 2023-02-27 15:16:40 +01:00
sebastiencarceles
13229158bd let dossier link champ be prefillable 2023-02-27 15:14:39 +01:00
sebastiencarceles
39545671f3 refacto: better error management 2023-02-27 14:35:11 +01:00
sebastiencarceles
33fa40eda2 don't clean the rna champ value 
Cleaning the value is useless, when fetching the association,
as the value will be re-written by the dossier update, when the user
fills in the dossier.

Furthermore we need the value to persist when prefilling the champ.
 2023-02-27 14:35:11 +01:00
Sébastien Carceles
7e55aca107 allow rna prefill 2023-02-27 14:35:11 +01:00
sebastiencarceles
7d65a34bc6 rna champ can fetch it's own association 2023-02-27 14:31:58 +01:00
sebastiencarceles
becf4da70a fix raison social fetch 2023-02-27 13:54:35 +01:00
sebastiencarceles
5dce401a14 review: add missing spec 2023-02-27 13:47:56 +01:00
sebastiencarceles
30eef3e128 review: detailled error message 2023-02-27 13:45:16 +01:00
Sébastien Carceles
2ad4e4c01f refacto: better error management 2023-02-27 13:45:16 +01:00
Sébastien Carceles
b6c74b0e83 fetch etablissement when editing the dossier 2023-02-27 13:45:16 +01:00
Sébastien Carceles
df2eaa9542 don't clean the siret champ value 
Cleaning the value is useless, when fetching the etablissement,
as the value will be re-written by the dossier update, when the user
fills in the dossier.
 2023-02-27 13:45:16 +01:00
Sébastien Carceles
3eb76d8a43 allow siret prefilling 2023-02-27 13:45:16 +01:00
Sébastien Carceles
5876dab096 siret champ can fetch it's own etablissement 2023-02-27 13:39:31 +01:00
sebastiencarceles
da6ce0f528 add example 2023-02-27 12:20:11 +01:00
sebastiencarceles
76c9d1ada5 add possible values 2023-02-27 11:53:25 +01:00
sebastiencarceles
40b7ea3af2 transform the input value to assignable attributes 2023-02-27 11:51:24 +01:00
sebastiencarceles
46091cb6b4 let communes champ be prefillable 2023-02-27 11:50:25 +01:00
Damien Le Thiec
67bbacbb05
Merge pull request #8513 from demarches-simplifiees/feature/prefill_repetible 
Prefill repeatable
 2023-02-27 09:58:53 +00:00
Paul Chavard
21f47dcb01 feat(procedure): include deleted dossiers in stats 2023-02-23 17:14:25 +01:00
Paul Chavard
eb3039aeca fix(demarche): exclude preview and deleted dossiers from stats 2023-02-23 16:38:40 +01:00
Damien Le Thiec
731cd56594 Merge branch 'main' into feature/prefill_repetible 2023-02-22 19:49:06 +01:00
Damien Le Thiec
ca29079c27 Fix rubocop 2023-02-22 19:40:52 +01:00
Damien Le Thiec
fbe4fe251a Fix format prefill repetition 2023-02-22 19:32:25 +01:00
Sébastien Carceles
28c6fd8cfc
Improve EPCI specs (#8634) 
* fix nonsense spec

* refactor spec
 2023-02-22 09:16:58 +00:00
Damien Le Thiec
cc2ec995d6 Fix tests 2023-02-21 17:32:24 +01:00
Damien Le Thiec
2052bc7840 Remove dependency type_de_champ -> procedure 2023-02-21 16:00:58 +01:00
Christophe Robillard
c5acd82e6e update dossiers count when passing to construction 2023-02-21 10:06:07 +01:00
Christophe Robillard
bd92291f8a cache dossiers count 2023-02-21 10:06:07 +01:00
Damien Le Thiec
d2452980fe Fix merge conflict spec 2023-02-16 20:17:05 +01:00
Damien Le Thiec
dce4c84f9a Merge branch 'main' into feature/prefill_repetible 2023-02-16 17:08:30 +01:00
Damien Le Thiec
6231c75e07 Fix tests conflicts 2023-02-16 16:58:55 +01:00
Paul Chavard
c0ad7853cb fix(administrateur): procedure page n+1 2023-02-16 11:29:21 +01:00
sebastiencarceles
d5ffd61ab6 validate values inclusion 2023-02-16 10:49:15 +01:00
sebastiencarceles
d648ac31c2 add prefill decorator for multiple drop down list 2023-02-16 10:49:15 +01:00
sebastiencarceles
cbe2dc9c2d let the multiple drop down list be prefillable 2023-02-16 10:49:15 +01:00
Damien Le Thiec
96b9ec3f42 First fix tests 2023-02-15 18:13:16 +01:00
Damien Le Thiec
539b9e4f10 Merge branch 'main' into feature/prefill_repetible 2023-02-15 17:53:06 +01:00
Damien Le Thiec
4876d583b6 Merge branch 'main' into feature/prefill_repetible 2023-02-15 17:39:19 +01:00
Damien Le Thiec
4b3d403d7e fix spec 2023-02-15 17:14:29 +01:00
Damien Le Thiec
5a89a2dbe4 Use Stable ID for repetitions prefill 2023-02-15 12:15:34 +01:00
sebastiencarceles
8aa31522b6 cover feature with specs 2023-02-15 12:14:11 +01:00
sebastiencarceles
07b5a3b4b5 manage types de champ with multiple example values 2023-02-15 12:14:11 +01:00
sebastiencarceles
edf90a77f3 validate epci to reject incorrect prefill values 2023-02-15 12:14:11 +01:00
sebastiencarceles
5ac80f968a add possible and example values 2023-02-15 12:14:11 +01:00
sebastiencarceles
f836f57e98 transform the input value to assignable attributes 
Use the prefill decorator to transform the input value (for example
['01', '200042935']) into assignables attributes (for example
{ code_departement: '01', value: '200042935' }), in order to let the
champ be prefilled successfully.
 2023-02-15 12:14:11 +01:00
sebastiencarceles
0f483668cf let epci champ be prefillable 2023-02-15 12:14:11 +01:00
Paul Chavard
8b74a6f39b fix(geometry): implement our own bbox to replace rgeo 2023-02-15 11:58:59 +01:00
Damien Le Thiec
2533ca50d4 Merge branch 'main' into feature/prefill_repetible 2023-02-15 11:07:56 +01:00
sebastiencarceles
681e1cf518 ♻️ refactor possible_values impl for clarity 2023-02-14 13:45:30 +01:00
sebastiencarceles
67ef3a16fa review: put example values in translation yamls 2023-02-14 09:23:52 +01:00
Sébastien Carceles
12abf9045b add external_id and value validation 2023-02-14 09:23:11 +01:00
Sébastien Carceles
a235829ddd add possible and example values 2023-02-14 09:19:55 +01:00
Sébastien Carceles
cd3a72ddce make departements champ prefillable 2023-02-14 09:19:19 +01:00
Damien Le Thiec
899c8a6589 Add documentation json parse rescue repetition 2023-02-13 14:17:53 +01:00
Sébastien Carceles
1a72b80f8f
fix: "remove" a champ to prefill (#8612) 
* fix: "remove" a champ to prefill

Removing a champ to prefill on /preremplir used to fail, because of a
collusion (having the same form multiple times on un page looks like a
bad idea, when it comes to multiple input fields).

* fix specs
 2023-02-13 08:17:22 +00:00
Damien Le Thiec
ea126612a1 Refacto to_assignable_attributes for prefill_repetition 2023-02-12 13:02:30 +01:00
Damien Le Thiec
fc94aaaa21 Use "to_assignable_attributes" 2023-02-12 11:55:28 +01:00
Damien Le Thiec
dbb92e7fd3 Merge branch 'main' into feature/prefill_repetible 2023-02-11 22:40:56 +01:00
Damien Le Thiec
2a3ba28343 Fix tests possible value prefill 2023-02-11 22:27:16 +01:00
Damien Le Thiec
a4d707f942 Improve format prefill possible_values (tests missing) 2023-02-09 18:08:51 +01:00
Damien Le Thiec
c5f1f80d25 Add prefill params tests repetition 2023-02-08 17:38:51 +01:00
Paul Chavard
dc9a455d22 fix(dossier): prevent crash in rebase 2023-02-08 11:11:14 +01:00
Damien Le Thiec
a51ed0094b Fix tests 2023-02-07 00:28:21 +01:00
Damien Le Thiec
b9c2d1251b Add missing tests repetition prefill 2023-02-06 17:38:59 +01:00
Paul Chavard
6924b8e46d feat(dossier): optional repetition champ should not add first row 2023-02-06 11:53:32 +01:00
Damien Le Thiec
63e7c17fda First tests for prefill repetition 2023-02-03 12:14:18 +01:00
Paul Chavard
2971100081 fix(dossier): do not try to rebase if procedure is not published 2023-02-02 10:11:46 +01:00
Paul Chavard
fc31ef6da3 chore(dossier): move concern spec to concern folder 2023-02-02 10:11:29 +01:00
Lisa Durand
120fbb0ef7 Overload the finished_at 2023-02-01 17:06:04 +01:00
Lisa Durand
d0a131dc55 change the way we set the finished_at on batch operation job to fix alert display bug 2023-02-01 17:06:04 +01:00
Damien Le Thiec
e7c78321d9 Fix new failing tests 2023-02-01 13:35:32 +01:00
Damien Le Thiec
a4645855d3 Fix tests prefillable repetition 2023-02-01 12:02:09 +01:00
Paul Chavard
9c83939431 fix(dossier): fix adding repetition in a new revision 2023-02-01 10:36:46 +01:00
Damien Le Thiec
d7b01255fe Merge branch 'main' into feature/prefill_repetible 2023-01-31 16:39:00 +01:00
Colin Darie
5cddb1c74e fix(procedure_presentation): options groupe_instructeur for that procedure only 2023-01-31 13:55:06 +01:00
Paul Chavard
dcbe16603a fix(dossier): fix parser with dashes 2023-01-31 10:40:48 +01:00
Paul Chavard
ca05fb753b fix(only_present_on_draft?): broken when type_de_champ is removed from later revisions 2023-01-31 09:26:50 +01:00
Martin
dbe64cf0c8 correctif(date_champ): renforce la validation avec le parsing de la date plutot qu'une approche par regexp 2023-01-30 13:01:24 +01:00
Martin
78f9910fd0 bug(date): la validation est trop lache 2023-01-30 13:01:24 +01:00
Paul Chavard
2f4e85f163 fix(dossier): set rebased_at only on changed champs 2023-01-30 12:01:11 +01:00
Paul Chavard
298721f90d fix(dossier): fix clone with data 2023-01-30 10:58:26 +01:00
Colin Darie
923ee59e92 refactor(instructeurs/perf): don't load anymore geo areas for each champ because of header 
Economise 1 requête par champ sur chaque page instructeur d'un dossier
à cause du header juste pour savoir s'il faut afficher
le bouton d'export GeoJSON.
 2023-01-26 14:57:45 +01:00
Colin Darie
51c1736d00 refactor(conditional): extract in a ChampConditionalConcern with tests 2023-01-26 09:06:30 +01:00
Colin Darie
81f00774af feat(logic): operators sources 2023-01-26 09:06:30 +01:00
Sébastien Carceles
49ce255e29
feat(dossier): prefill region champ (#8442) 
* make regions champ prefillable

* add possible and example value

* add external_id and value validation
 2023-01-24 11:25:17 +00:00
mfo
84a667b8bd
Merge pull request #8454 from tchak/feat-epci 
feat(types de champ): add EPCI champ
 2023-01-23 16:56:18 +01:00
Sébastien Carceles
92c769de4f
fix(prefill): code pays display (#8477) 
* show translated text AND possible values

* show less possible values

* show countries possible values
 2023-01-23 14:08:20 +00:00
Sébastien Carceles
68ddae7382
feat(demarche): prefilling stats (#8436) 
* force json content type for POST / PATCH / PUT

* add specs about stats dossiers funnel

* new endpoint to render stats about a procedure
 2023-01-20 13:28:02 +00:00
Paul Chavard
a4cbbe721e feat(types de champ): add EPCI champ 2023-01-20 11:32:36 +01:00
Sébastien Carceles
0046338e6a
fix(prefill): don't mark the dossier as prefilled when it's not (#8464) 
A dossier should not be marked as prefilled when it's not, meaning
when no prefill params are given.
 2023-01-19 10:51:56 +00:00
Colin Darie
428dd9bf1a fix(dossier): we can't terminer any dossier having etablissements in degraded mode 
Closes #8449
 2023-01-18 19:23:25 +01:00
Damien Le Thiec
3a8a50a216
Allow prefill pays type de champs (#8344) 
* Allow prefill pays type de champs

* Avoid conditional prefil params for pays champ

* Clean pays data with batch update

* Fix bug and add test batch update pays value

* Improve performance batch_update_pays

* Fix associated country code problem

* Fix after party task name

* Format country name if needed in batch update
 2023-01-18 12:52:38 +01:00
Sébastien Carceles
5c7b2ba1f3
feat(dossier): prefill drop down list champ (#8361) 
* feat(dossier): prefill drop down list champ

* decorate the types de champ to avoid if / else

In order to avoid doing if this a drop down ? / else at several places,
we decorate the types de champ and let the decorator give the possible
and example values.

* show all possible values when there are too many

* allow to prefill 'other' option

* review: remove duplicate

* review: refactor for readability

* validate that value is in options

* review: exclude disabled options
 2023-01-18 09:47:22 +01:00
Paul Chavard
44488c7014 feat(dossier): use select in filters bygroupe instructeur 2023-01-16 14:00:08 +01:00
Damien Le Thiec
5e26acb0e1
Make date and datetime prefillable (#8304) 
* Make date and datetime prefillable

* Format in ISO8601 format
 2023-01-12 17:42:02 +01:00
simon lehericey
528b2c2b88 fix(procedure): valid juridique on create and publication 2023-01-11 14:05:17 +01:00
Paul Chavard
af33d5d65c refactor(repetition): use row_id instead of row 2023-01-10 19:31:41 +01:00
Colin Darie
d58e6a2f9c refactor(email): remove pseudonymization, it will be done at dump-time 2023-01-10 16:07:35 +01:00
Colin Darie
6cb2389eef chore(email): add an observer which log the emails dispatched 2023-01-10 16:07:35 +01:00
Paul Chavard
5a4cefc5c5 fix(dossier): fix rebase with drop down options 2023-01-06 14:15:46 +01:00