DGNum/demarches-normaliennes
14
1
Fork 0
Code Issues 1 Pull requests Projects Releases Packages Wiki Activity
1814 commits 4 branches 1166 tags 84 MiB
Commit graph

1328 commits

Author SHA1 Message Date
gregoirenovel
d8cc41140b Remove an unexpected blank line 2017-04-20 10:35:53 +02:00
gregoirenovel
5d4dcf8ec7 Don't use line blocks 2017-04-20 10:35:53 +02:00
gregoirenovel
c10c2fc31b Selectors must be written in lowercase with hyphens 2017-04-20 10:35:53 +02:00
gregoirenovel
73caee0ff3 Remove unused declarations 2017-04-20 10:05:59 +02:00
gregoirenovel
c32a2432c7 Don’t use vendor prefixes 2017-04-20 10:05:59 +02:00
gregoirenovel
e2bd606e49 Declarations must be terminated by a semicolon 2017-04-20 10:05:58 +02:00
gregoirenovel
0316bac137 Use double-quoted strings 2017-04-20 10:05:58 +02:00
gregoirenovel
11e5943989 Only one selector per line 2017-04-20 10:05:56 +02:00
gregoirenovel
5e1c99d642 Opening curly braces must be preceded by one single space 2017-04-19 17:05:57 +02:00
gregoirenovel
8cad7361cf An operator must be surrounded by single spaces 2017-04-19 17:05:57 +02:00
gregoirenovel
0789cfd311 Colons must be followed by a single space 2017-04-19 17:05:57 +02:00
gregoirenovel
8906801d6c Comment literals must be followed by a space 2017-04-19 17:05:57 +02:00
gregoirenovel
4b575bd386 Commas are followed by a space 2017-04-19 17:05:57 +02:00
gregoirenovel
4f0de677ab Begin pseudo elements with double colons 2017-04-19 17:05:57 +02:00
gregoirenovel
4b39e76c8a Use extend only with placeholders 2017-04-19 17:05:57 +02:00
gregoirenovel
f3ec7f1d42 Indent with two spaces 2017-04-19 17:05:57 +02:00
gregoirenovel
af7b611dd0 < 1 numbers must all have a leading zero 2017-04-19 17:05:57 +02:00
gregoirenovel
c9ff601b28 Hex colors must be written with uppercase letters 2017-04-19 17:05:57 +02:00
gregoirenovel
f519896e54 Hex colors must be 6 characters long 2017-04-19 17:05:57 +02:00
gregoirenovel
2cae8e751e Blocks must be separated by an empty line 2017-04-19 17:05:57 +02:00
gregoirenovel
0d5dd9d492 Remove empty rules 2017-04-19 17:05:57 +02:00
gregoirenovel
6a13e481fd Fix the declaration order 2017-04-19 17:05:57 +02:00
gregoirenovel
0ed13c9fe7 Remove duplicated properties 2017-04-19 17:05:56 +02:00
gregoirenovel
c5fc77b606 Change the comments style 2017-04-19 17:05:56 +02:00
gregoirenovel
bb02339183 Use border: none instead of border: 0 2017-04-19 17:05:56 +02:00
gregoirenovel
db331447e1 Use hex codes for colors 2017-04-19 17:05:55 +02:00
Simon Lehericey
ce4a23ec7f MandatoryAttachment: show * near mandatory attachment 2017-04-19 15:45:45 +02:00
Simon Lehericey
2b969ef575 MandatoryAttachment: group missing errors logic together 
and show errors only if not draft
 2017-04-19 15:45:45 +02:00
gregoirenovel
b00eb914da Use case statements instead of if statements where appropriated 2017-04-19 11:57:49 +02:00
gregoirenovel
9071656b55 Use #each instead of #map where appropriated 2017-04-19 11:57:49 +02:00
gregoirenovel
ddf02ccd6d Use a non-breaking space after the “numéro” contraction 2017-04-19 11:19:53 +02:00
gregoirenovel
aa41349f0c Lowercase the “n” of “numéro” contraction where needed 2017-04-19 11:19:53 +02:00
gregoirenovel
ba4ee68019 Use masculine ordinal indicator instead of the degree sign 
It’s the right way to contract “numéro”

We should use the superscript lowercase o but
it’s hard to do in places where only raw text is
available
 2017-04-19 11:19:53 +02:00
Simon Lehericey
4cd21580fb DescriptionController: move html_safe to the view 
html_safe could not work upon redirection as stated here :
https://groups.google.com/forum/#!topic/rubyonrails-core/z52zgDgUmbs
 2017-04-19 10:52:04 +02:00
Simon Lehericey
eb3bb63a8f DescriptionController: remove useless @champs 2017-04-19 10:52:04 +02:00
Simon Lehericey
866a54085c DescriptionController: cosmetic 2017-04-19 10:52:04 +02:00
Simon Lehericey
157d1818b2 DescriptionController: move instance var to local var 2017-04-19 10:52:04 +02:00
Simon Lehericey
71542f6a3a PiecesJustificativesService: more explicit selection of content 2017-04-19 10:24:08 +02:00
Simon Lehericey
21d7a96062 PiecesJustificativesService: less violent error message in case of virus 2017-04-19 10:22:30 +02:00
Simon Lehericey
395c9d5bb1 PiecesJustificativesService: improve error message when the file cannot be saved 2017-04-19 10:20:32 +02:00
Simon Lehericey
e0828dda13 PiecesJustificativesService: save_pj returns nil if no errors 2017-04-19 10:16:30 +02:00
Simon Lehericey
8e7e7a8ab4 Stats Index: remove useless locale 2017-04-19 10:06:22 +02:00
Simon Lehericey
4c74b04a91 Commentaire: use fr local to display date 2017-04-19 10:06:22 +02:00
Simon Lehericey
367b7c6ae1 DescriptionController: use common system to redirect with errors 2017-04-18 17:48:03 +02:00
Simon Lehericey
591ed2037e PiecesJustificativesServices: refactor upload_one! 2017-04-18 17:48:03 +02:00
Simon Lehericey
03e9cd523e PiecesJustificativesService: mandatory pj check and add test 2017-04-18 17:48:03 +02:00
Simon Lehericey
e49ea2d0e0 PiecesJustificative: add field to set it mandatory 
small css to align the fields
 2017-04-18 17:48:03 +02:00
gregoirenovel
3abbb0bdcd Use french formatting for numbers on the Stats page 2017-04-18 14:34:56 +02:00
gregoirenovel
21ff863dab [Fix #112] Add favicons 2017-04-17 19:32:26 +02:00
Mathieu Magnin
1612b60126 Remove useless code 2017-04-13 16:54:00 +02:00
Mathieu Magnin
320d5da40f Add individual infos to flat table export serializer 2017-04-13 16:54:00 +02:00
gregoirenovel
d531b02bc5 Order types_de_piece_justificative on Procedure 
So that /spec/controllers/api/v1/
dossiers_controller_spec.rb#L163-L179 (on commit
8852431 for example) does not randomly fail due
to unordered types_de_piece_justificative
 2017-04-13 14:48:18 +02:00
Mathieu Magnin
080c7c3d04 Fix csv export with no dossiers 2017-04-12 18:19:37 +02:00
gregoirenovel
f4ff778a5c Add a missing newline before the end of the controller 
Same spacing rules at the top and at the bottom
of the file
 2017-04-11 16:58:27 +02:00
gregoirenovel
913735554c Improve StatsController#thirty_days_flow and #clean_hash 2017-04-11 16:58:27 +02:00
gregoirenovel
11015787bf Add new total numbers to the Stats page 2017-04-11 16:51:38 +02:00
gregoirenovel
52ea4a1b8d Add new charts and a segmented control to the Stats page 2017-04-11 16:51:38 +02:00
gregoirenovel
9dc4901294 Change the template and style of the Stats page 2017-04-11 15:29:19 +02:00
gregoirenovel
e370c4e393 Exclude draft Dossiers and unpublished Procedures from Stats 2017-04-11 15:29:19 +02:00
gregoirenovel
2074ac93ba Add StatsController#thirty_days_flow_hash 2017-04-11 15:29:19 +02:00
gregoirenovel
e192038045 Rename the variables in StatsController#index 2017-04-11 15:29:19 +02:00
gregoirenovel
c4c6095abd Only show the last 30 days of data in Stats 2017-04-11 15:29:19 +02:00
gregoirenovel
de01914fa7 Fix the where clause in Stats 
Now properly show the last 90 days of data instead
of strict quarters.

With the previous code, on the
1st of january, april, july and october, only one
day of data would be shown.
 2017-04-11 15:29:18 +02:00
gregoirenovel
664d821dc0 Add a link to the Stats page in the footer 2017-04-11 15:29:18 +02:00
gregoirenovel
f84cd7f11b Make Stats a public page 2017-04-11 15:29:18 +02:00
Simon Lehericey
4a16fb2ce2 DescriptionController: refacto 2017-04-11 14:45:30 +02:00
gregoirenovel
dd1fd419c7 Require mandatory fields on the frontend side 2017-04-11 14:25:49 +02:00
Simon Lehericey
a324a22ba2 DossierLink: add show template 2017-04-11 13:54:33 +02:00
Simon Lehericey
3228737a87 DossierLink: add edition template 2017-04-11 13:54:33 +02:00
Simon Lehericey
785219c956 DossierLink: add type de champ 2017-04-11 13:54:33 +02:00
Simon Lehericey
ed36897337 DossiersController: add get procedure libelle 2017-04-11 13:54:33 +02:00
Simon Lehericey
ccf956ec01 DescriptionController: refactor redirection for draft 2017-04-11 12:11:10 +02:00
Simon Lehericey
d14a75c24a DescriptionController: refactor check_mandatory_fields 2017-04-11 12:11:10 +02:00
Simon Lehericey
191b29aff5 DescriptionController: simplify update logic 2017-04-11 12:11:10 +02:00
Simon Lehericey
3a9065e4c1 DescriptionController: remove useless code 2017-04-11 12:11:10 +02:00
Simon Lehericey
c4e128a506 DescriptionController: rename variable 2017-04-11 12:11:09 +02:00
Simon Lehericey
4df03fc28e ChampsService: add tests and refactor 2017-04-11 12:11:09 +02:00
gregoirenovel
1db37894c2 Factorize some code in Dossier#serialize_value_for_export 2017-04-11 11:43:42 +02:00
gregoirenovel
ae5b4f6249 Refactor Dossier#full_data_strings_array 2017-04-11 11:39:34 +02:00
gregoirenovel
df878b9ef4 Change Dossier#convert_specific_array_values_to_string’s signature and name 
- It is always called with the data_with_champs
  argument

- Changing the signature requires a change of name
  in this case
 2017-04-11 10:29:07 +02:00
gregoirenovel
57ee3c5b3f Separate ternary operators with spaces on both sides 2017-04-10 17:55:55 +02:00
gregoirenovel
9c04d3ff93 All CSS declarations must end with a semi-colon 2017-04-10 17:55:55 +02:00
gregoirenovel
3797015908 All colons must be followed by a single space 2017-04-10 17:55:55 +02:00
gregoirenovel
97df69bcd8 In HAML files, separate arguments by a comma and a single space 2017-04-10 17:55:55 +02:00
gregoirenovel
6db4a69cb2 Use spaces inside hashes 2017-04-10 17:55:54 +02:00
gregoirenovel
aaaed328fb Remove unnecessary string outputs 2017-04-10 17:55:54 +02:00
gregoirenovel
8d9cdf8e33 Remove a useless string in the gestionnaires list 2017-04-10 17:55:54 +02:00
gregoirenovel
6cb53b5545 Move a comment to avoid a haml-lint MultilineScript warning 2017-04-10 17:55:54 +02:00
gregoirenovel
7a941d3219 Remove a useless id in _list.html.haml 2017-04-10 17:55:54 +02:00
gregoirenovel
aa255e7e2d Use HAML comments in HAML files 2017-04-10 17:55:54 +02:00
gregoirenovel
69ba92009b Separate HAML comments from the leading # by a space 2017-04-10 17:55:54 +02:00
gregoirenovel
a8d2a003c1 Do not define static class names in the attributes hash 2017-04-10 17:55:53 +02:00
gregoirenovel
4788e280f5 Fix the indentation in the drop down list template 2017-04-10 17:55:53 +02:00
gregoirenovel
2d5df47c4e Use implicit div tags in HAML files 2017-04-10 17:55:53 +02:00
gregoirenovel
7e067c2624 Static classes attribute must use the inline tag syntax 2017-04-10 17:55:53 +02:00
gregoirenovel
a3d04fe7a9 Html Ruby evaluation tags must be followed by a single space 2017-04-10 17:55:53 +02:00
gregoirenovel
e7e4e41e12 Haml Ruby evaluation tags must be followed by a space 2017-04-10 17:55:53 +02:00
gregoirenovel
3ca914aba8 Delete some environment-based conditions 
We should always try to be the closest to the
production environment
 2017-04-10 16:17:33 +02:00
Mathieu Magnin
bf0d466f4b Move export_full_generation method from Dossier to Procedure 2017-04-05 12:26:38 +02:00
Mathieu Magnin
b18c09e9fd Download dossiers button exports all dossiers except draft 2017-04-05 11:04:53 +02:00