Commit graph

5728 commits

Author SHA1 Message Date
Kara Diaby
17a471e880
Merge pull request #9939 from demarches-simplifiees/feat/9937
ETQ Super-Admin, je souhaite marquer une démarche comme modèle
2024-01-31 10:21:30 +00:00
Kara Diaby
46748091a6 Permet au Support de marquer une démarche comme modèle et de filtrer dans toutes les démarches 2024-01-31 09:30:14 +00:00
Colin Darie
88e62323b6
Merge pull request #9949 from mfo/US/fix-device-locale
correctif: ETQ usager naviguant sur le site en anglais, je m'attends a recevoir des messages d'erreur de connexion en anglais
2024-01-31 09:28:15 +00:00
Colin Darie
3ea718a3f5
Merge pull request #9664 from adullact/feature-ouidou/admin_creation_delegation_follow_commentaire
ETQ gestionnaire, j'ai un suivi des messages au sein de mes groupes
2024-01-31 08:56:29 +00:00
Martin
672b341279 bug(auth.error_message): should be i18n 2024-01-30 10:03:00 +01:00
Colin Darie
df1dd19eac
Merge pull request #9946 from colinux/fix-procedure-external-url
Tech: fix le job de vérification des liens externes des procédures lorsqu'un autre attribut est en erreur
2024-01-29 17:31:38 +00:00
seb-by-ouidou
f3cba9331d fix: improvement after review 2024-01-29 18:23:39 +01:00
seb-by-ouidou
6cd8b6d2df feat: for gestionnaire highlight card and commentaires if any unread 2024-01-29 18:23:39 +01:00
seb-by-ouidou
a5d95b2d9d fix: fix activate gestionnaire and activate administrateur 2024-01-29 18:23:39 +01:00
Colin Darie
533ce8d7ba fix(procedure-url-check): don't fail when other attribute have an error 2024-01-29 15:42:35 +01:00
Eric Leroy-Terquem
6203b1fd05
Merge pull request #9879 from demarches-simplifiees/cleaning-conditional-and-routing-code
Tech : nettoyage du code conditionnel et routage
2024-01-29 13:43:52 +00:00
mfo
77ca3dd28a
Merge pull request #9922 from mfo/US/nplus_one_in_summary
perf(TypeDeChampEditor): faster
2024-01-29 10:58:05 +00:00
Colin Darie
a582fef1e5
Merge pull request #9934 from colinux/fix-export-link-witout-file
ETQ instructeur, n'affiche pas encore de lien vers un export quand le fichier n'est pas encore disponible
2024-01-29 10:11:33 +00:00
LeSim
e12c663d21
Merge pull request #9940 from demarches-simplifiees/can_edit_again_a_token
Admin: je peux modifier le nom et les réseaux d'un jeton d'API
2024-01-29 09:21:21 +00:00
simon lehericey
5eaa957c31 can edit api_token to change networks and name 2024-01-29 10:09:55 +01:00
Colin Darie
c02171ede7
Merge pull request #9936 from colinux/badge-corrige
ETQ instructeur, je vois un badge Corrigé lorsque le dossier a été corrigé
2024-01-29 08:57:54 +00:00
Colin Darie
b64a32444c
Merge pull request #9935 from colinux/transfer-empty-no-fail
Tech: plus d'erreur lorsque l'email de transfert n'a plus de dossier associé
2024-01-29 08:43:50 +00:00
Martin
01752bc2e8 perf(ProcedureRevisionPreloader): preload revision quickly 2024-01-26 14:47:44 +01:00
Martin
ecc83edf4f wip 2024-01-26 13:43:10 +01:00
simon lehericey
97f335c36a add a cron job to send expiration notice 2024-01-26 10:18:16 +01:00
simon lehericey
6353c10955 add APIToken expiration mailer 2024-01-26 10:18:16 +01:00
simon lehericey
d909e2c8ea add various expiring scopes to APIToken 2024-01-26 10:15:37 +01:00
Martin
0e5768ec5b fixup! perf(editor): better perf to add, destroy, update, move up, move down and move with number 2024-01-26 09:45:59 +01:00
Colin Darie
50b9813b4d
Merge pull request #9932 from colinux/lock-submit-fork
Correctif: ETQ usager, je ne peux pas soumettre 2x mes modifications en parallèle
2024-01-25 11:37:56 +00:00
Colin Darie
4aa1306536
feat(transfer): make it silent in case dossier had been destroyed between queuing and processing
Co-authored-by: mfo <mfo@users.noreply.github.com>
2024-01-25 11:31:12 +01:00
simon lehericey
588e58195c move api_tokens to admin module 2024-01-25 11:27:15 +01:00
simon lehericey
49f0caba7e fix(spec): flaky test 2024-01-25 11:17:44 +01:00
simon lehericey
9a0dd45385 feat(api): add invalid ip addr error 2024-01-25 11:17:44 +01:00
simon lehericey
852eedbc50 refactor(api): create api_token with validity and network filtering 2024-01-25 11:17:44 +01:00
simon lehericey
7e8555923f feature(api): add ensure_token_is_not_expired to api_controller v1 and v2 2024-01-25 10:51:58 +01:00
simon lehericey
d8bc38bc69 feature(api): add ensure_authorized_network for api_controller v1 and v2 2024-01-25 10:51:58 +01:00
simon lehericey
6e5678d1c2 feature(api): add forbidden_network? to api_token 2024-01-25 10:51:58 +01:00
Colin Darie
8e6a1c58b2 feat(correction): badge Corrigé when a correction has been resolved
Closes #9928
2024-01-24 17:26:34 +01:00
Colin Darie
520a7c4402
fix(exports): don't try to link to an export when file is not yet attached 2024-01-24 13:36:25 +01:00
Kara Diaby
ac29cfbfdb Envoie un email à l'expert en cas de nouveau commentaire de l'usager dans la messagerie 2024-01-24 10:48:17 +00:00
Colin Darie
56f8b61866
feat(dossiers): lock submit en construction to avoid merge collisions with double submits 2024-01-24 10:58:40 +01:00
Martin
2952987ad8 refactor(spec): stop using procedure type de champs traits as :with_datetime, :with_xxx in favor of :types_de_champ_public which keeps position in check 2024-01-23 17:30:22 +01:00
mfo
15e0ed8480
Merge pull request #9927 from mfo/fix-flacky-type-de-champ-template
fix(spec.flacky): ./spec/system/administrateurs/types_de_champ_spec.rb:272 was flacky, try to fix it
2024-01-22 17:10:37 +00:00
Colin Darie
716e4bbe5d
Merge pull request #9645 from adullact/feature-ouidou/admin_creation_delegation_gestionnaire_answer_administrateur
Feature ouidou/admin creation delegation gestionnaire answer administrateur
2024-01-22 15:45:58 +00:00
Martin
2fa59076f9 fix(spec.flacky): ./spec/system/administrateurs/types_de_champ_spec.rb:272 was flacky, try to fix it 2024-01-22 15:50:38 +01:00
Martin
0f194a5e8e refactor(procedure_revision): without renumber, use types_de_champ_public factory for ordered champs 2024-01-22 14:57:04 +01:00
Martin
5c049a1c0f feat(update_draft_revision_type_de_champs_task): force to use real position otherwise have to process parent_coordinates... 2024-01-22 14:57:04 +01:00
Martin
434cd77030 poc(spec): renumber only at one point 2024-01-22 14:57:04 +01:00
Martin
a9c0d3e7e9 tech(clean): avoid useless indirection, cleanup some code complexity, rubocopify 2024-01-22 14:57:04 +01:00
Martin
4d97c5bc8a feat(move_type_de_champ): stop renumbering all procedure_revision_type_de_champ on move_type_de_champ 2024-01-22 14:57:04 +01:00
Martin
4b57ed871a feat(add_type_de_champ): stop renumbering all procedure_revision_type_de_champ 2024-01-22 14:57:04 +01:00
seb-by-ouidou
a6ca4b668e feat: answer message to administrateur as gestionnaire 2024-01-22 14:36:38 +01:00
seb-by-ouidou
8d8feedff0 fix: group "it" test 2024-01-22 14:36:38 +01:00
seb-by-ouidou
e6474f0d14 feat: US4.3.9 children management 2024-01-22 14:36:38 +01:00
seb-by-ouidou
96dd6bec52 feat: US4.3 update and delete groupe gestionnaire 2024-01-22 14:36:38 +01:00
Colin Darie
7892b54aa6 fix(discarded-dossiers): don't crash whole job when a single dossier causes an error 2024-01-17 13:15:42 +01:00
Colin Darie
1a8f839a7e
Merge pull request #9915 from colinux/fix-admin-memory-leak
Perf: remplace les `OpenStruct` par des objets plus performants
2024-01-17 08:59:01 +00:00
Colin Darie
a4db911585
perf(admin): remove 2 useless zones queries on each admin page due to navigation 2024-01-16 19:43:58 +01:00
Colin Darie
a0e64151d5
test: replace OpenStruct by model expected 2024-01-16 19:43:24 +01:00
Lisa Durand
d9b75ce0a2
Merge pull request #9882 from demarches-simplifiees/add-dossier-reference-in-transfer-email
Je veux que le numéro du dossier apparaisse dans l'email de demande de transfert
2024-01-15 15:39:09 +00:00
mfo
0328446bee
Merge pull request #9861 from demarches-simplifiees/US/move-type-de-champ-with-select
ETQ administrateur, je peux deplacer un champ via un select
2024-01-15 13:09:56 +00:00
Martin
69346ad41f tech(review): implement some pair review suggestions 2024-01-12 11:00:29 +01:00
Colin Darie
8a83fd2ce0
fix(recherche): show notification indicator for instructeurs 2024-01-12 10:09:34 +01:00
Martin
e7eee7ba72 spec(move_and_morph): add some spec and lint with rubocop/haml/eslint 2024-01-11 16:12:09 +01:00
Martin
857a1fc496 fix(select_champ_position): rewire for more robust and easier implementation which work with repetition avoiding double submit 2024-01-11 16:01:24 +01:00
Martin
11de4bdfb6 feat(types_de_champ_editor.ts): wires move_and_morph with type de champs editor [for now, the select is empty and will be synced] 2024-01-11 16:01:24 +01:00
simon lehericey
e12dbe7aad use email_merge_token in email merge 2024-01-11 11:33:38 +01:00
simon lehericey
ca08b80c3e use email_merge_token in mailer 2024-01-11 11:33:38 +01:00
simon lehericey
fca28a3ebd use email_merge_token in mail_merge_with_existing_account route 2024-01-11 11:33:38 +01:00
simon lehericey
65aa07ecbe the merge_token issued for password check can be reused for the confirmation by email route
Thus by passing the password check or the email possession check
2024-01-11 11:33:38 +01:00
seb-by-ouidou
210df8a418 feat: review test after view component upgrade 2024-01-09 13:25:04 +01:00
seb-by-ouidou
c45e2eaccc feat: write message to gestionnaires as administrateur 2024-01-09 13:25:04 +01:00
simon lehericey
f96347caad fix(spec): another way to mock current_user 2024-01-08 14:30:19 +01:00
mfo
a0248bf08b
Merge pull request #9888 from mfo/US/validate-epci-by-code
Correctif: Le noms des EPCIs changent, ce qui bloque la validation et ou demande a resaisir le champs
2024-01-08 09:56:09 +00:00
Martin
fa07c21ec3 fix(champs.epci): epci names change over time. remap when it occurs 2024-01-04 07:17:15 +01:00
mfo
9df978f6fa
Merge pull request #9887 from mfo/US/fix-fci-missing-device-callback
Correctif: ETQ usager invité, lorsque je crée mon compte via FC, je ne retrouve pas mes invitations
2024-01-04 06:15:14 +00:00
Martin
4073804b00 feat(administrateurs/types_de_champ_controller#move_and_morph): add action to move and morph fields between two coordinates 2024-01-03 11:08:53 +01:00
Martin
92730e266b fix(FranceConnect): missing after_confirmation callback, leading to invalites invitations when user france connect 2023-12-26 15:00:15 +01:00
Eric Leroy-Terquem
24563a3c18 fix(personnes impliquees): display reaffectations block only if procedure is routed 2023-12-22 10:57:53 +01:00
Eric Leroy-Terquem
547a4d95b7 chore(logic): commune and epci champs are always compute with compute_value_json 2023-12-22 10:57:53 +01:00
Colin Darie
deab400057
Merge pull request #9578 from adullact/feature-ouidou/admin_creation_delegation_administrateur_pages
Feature ouidou/admin creation delegation administrateur pages
2023-12-22 09:06:58 +00:00
mfo
c4adee6278
Merge pull request #9878 from mfo/US/fix-not-type-ej-in-api
API: cast le type de champ EJ
2023-12-22 07:20:13 +00:00
seb-by-ouidou
c253e7dd65 feat: US5.1 US5.2 administrateur in admin 2023-12-21 18:40:36 +01:00
Colin Darie
6f7d786783
Merge pull request #9880 from demarches-simplifiees/api_token_store_last_used_ips
API: stocke les ips utilisées pour accéder à l'API
2023-12-21 16:18:00 +00:00
Lisa Durand
ff284a1c96 add more info in notify transfer email 2023-12-21 16:58:33 +01:00
Martin
989a7ba787 feat(API): cast type de champ EJ in a dedicated graphql type 2023-12-21 16:21:31 +01:00
Eric Leroy-Terquem
4c82f2c9d7 fix(champ value): fix compute_value_json on departement champ 2023-12-21 16:21:08 +01:00
simon lehericey
afb6eacf57 feature(api): store any ip used 2023-12-21 16:02:11 +01:00
Colin Darie
9bdf525ff1
Merge pull request #9863 from colinux/fix-message-html-injection
Tech: échappe les tags de données utilisateur dans les modèles pour email
2023-12-21 08:50:21 +00:00
Colin Darie
29df9ad09d
Merge pull request #9751 from tchak/departement-tags
feat(champs): expose more tags and api fields on rnf, address and commune
2023-12-21 08:45:01 +00:00
Colin Darie
e17c3bd046
Merge pull request #9839 from mfo/US/fix-filter-focus-out-with-not-selected-filter
correctif : ETQ instructeurs, lorsque je sors du composant de filtrage sans choisir une option, le site renvoie une erreur
2023-12-21 08:42:12 +00:00
Colin Darie
535a54ce97
Merge pull request #9874 from demarches-simplifiees/add-email-for-tiers-when-repasser-en-instruction-ldu
[Co-construction] Envoyer un mail au bénéficiaire si le dossier repasse en instruction
2023-12-21 08:32:10 +00:00
Lisa Durand
3e872c5246 add email for tiers when repasser en instruction 2023-12-20 11:51:02 +01:00
Lisa Durand
e52bd9d6bf
Merge pull request #9855 from demarches-simplifiees/display-last-export-in-same-page-ldu
ETQ instructeur, j'ai besoin d'un accès très facile à mondernier export
2023-12-20 10:02:08 +00:00
Eric Leroy-Terquem
882d72d139 data(conditional): add a maintenance task to update conditions based on commune or epci champ 2023-12-19 17:39:40 +01:00
Eric Leroy-Terquem
e4632214fb data(conditional): add a maintenance task to update routing rules based on commune or epci champ 2023-12-19 17:39:39 +01:00
Eric Leroy-Terquem
954facdaff
Merge pull request #9798 from demarches-simplifiees/add-new-operators-to-conditional
Etq admin je peux conditionner/router avec les opérateurs "est dans mon département",  "n'est pas dans mon département",  "est dans ma région" et   "n'est pas dans ma région".
2023-12-19 16:10:59 +00:00
Lisa Durand
e6a4459633 refacto 2023-12-19 16:54:23 +01:00
Lisa Durand
f553f3c408
Merge pull request #9872 from demarches-simplifiees/add-badge-for-role-ldu
ETQ utilisateur avec plusieurs rôles, je m'y retrouve plus facilement
2023-12-19 11:01:28 +00:00
mfo
e75c4456e8
Merge pull request #9871 from mfo/US/add-pj-to-explication
ETQ administrateur, je peux ajouter une notice explicative a un champs explication
2023-12-19 10:44:03 +00:00
Lisa Durand
c767164e28 add expert in current_account and mode badge to the right 2023-12-19 11:33:48 +01:00
Lisa Durand
0286d2b6fb add profiles in flash after sign-in if multiple profile 2023-12-19 10:33:26 +01:00
Martin
37e8772eab feat(type_de_champ_editor.explication): add a Attached::One to TypeDeChamp.explication, named notice_explicative [cf, cerfa wording] 2023-12-19 09:52:27 +01:00
Colin Darie
e9ee405954
Merge pull request #9868 from colinux/blocking-pending-correction-ff
ETQ instructeur je peux de nouveau passer en correction un dossier avec corrections en attente
2023-12-18 13:29:39 +00:00
Colin Darie
1a56fe620e feat(correction): make pending corrections blocking by feature flag only 2023-12-18 14:12:45 +01:00
Lisa Durand
53f9f3cbdb add trad if export failed 2023-12-18 14:09:47 +01:00
Lisa Durand
a9ab1daf3a display alert only for instructeur who generated the export and if recent 2023-12-18 11:25:52 +01:00
simon lehericey
9bb89f7e3e fix(print): missing dossier var 2023-12-18 09:51:41 +01:00
Colin Darie
fa37c6c62b
fix(tags): escape user data tags for emails 2023-12-15 14:05:11 +01:00
Colin Darie
c0b444d747
Merge pull request #9847 from colinux/fix-style
Style: plusieurs améliorations mineures / thème sombre
2023-12-15 12:00:53 +00:00
Martin
d27e4fc693 amelioration(combobox): permet de passer des options au input[type=hidden], utilise cette option pour autosubmit uniquement un input [dans notre cas, ne soumet pas a l'input du combobox, mais a l'input hidden une fois le combobox selectionné] 2023-12-15 11:23:25 +01:00
Colin Darie
7ba13507ff
Merge pull request #9808 from colinux/remove-usager-antivirus
ETQ usager, je ne vois plus le statut "antivirus en cours" lorsque j'envoie un PJ
2023-12-14 19:53:34 +00:00
Colin Darie
9a5d908851
Merge pull request #9853 from mfo/US/fix-expert-link-to-dossiers
ETQ expert: lorsque je me connecte, je suis redirigé vers la page des avis, non pas vers la page de mes dossiers
2023-12-14 19:52:32 +00:00
Colin Darie
3b0e4e59d5
Merge pull request #9858 from colinux/fix-invite-html-injection
Tech: sanitize les messages utilisateurs dans les emails
2023-12-14 17:27:28 +00:00
Lisa Durand
569d4af6f7
Merge pull request #9706 from demarches-simplifiees/feat/9678
ETQ usager passant par un mandataire, je suis notifié des changements d'état de mon dossier par email
2023-12-14 16:57:07 +00:00
Eric Leroy-Terquem
2e547cd46f chore(routing): cannot create simple_routing with champs communes or epcis 2023-12-14 17:48:14 +01:00
Eric Leroy-Terquem
e40d1107ac chore(conditional): add not_in_departement and not_in_region operators 2023-12-14 17:48:14 +01:00
Eric Leroy-Terquem
c9676020b4 chore(conditional): add in_departement and in_region operators 2023-12-14 17:48:13 +01:00
Martin
1307e7262f amelioration(application_controller.roles): intègre aussi le role d'expert aux logs 2023-12-14 14:52:50 +01:00
Colin Darie
fd7839773b fix(email): sanitize user message 2023-12-14 12:51:56 +01:00
Martin
6def2609f1 amelioration(liens-suivis): persiste la page a laquelle il doit etre redirigé apres une connexion 2023-12-14 10:47:04 +01:00
Martin
4380fecd73 amelioration(expert.sign-in): ETQ expert, je suis redirigé vers la page listant les avis a donner ap connexion 2023-12-14 10:47:04 +01:00
Lisa Durand
2f1259709a fix email content 2023-12-14 10:01:13 +01:00
Eric Leroy-Terquem
57b6522536 data(geo): update api_geo_data take task to store region_code in departements and communes json 2023-12-14 09:36:50 +01:00
Colin Darie
c76213cb87
fix(users): don't show procedures filter when there are not enough procedures 2023-12-13 18:03:22 +01:00
Colin Darie
01d12c9bb4
Merge pull request #9840 from colinux/maintenance-task-update-tdc
ETQ superadmin je peux mettre à jour le brouillon d'une révision à partir d'un CSV
2023-12-13 10:15:41 +00:00
Colin Darie
715c800788
Merge pull request #9821 from colinux/en-attente-block-instruction
ETQ instructeur je ne peux pas passer en instruction un dossier en attente de correction
2023-12-13 10:02:32 +00:00
Kara Diaby
57dfe2b0f6 Améliorations après retours PR 2023-12-13 09:21:09 +00:00
Lisa Durand
878f58e00c add mailer test 2023-12-12 22:35:11 +00:00
Lisa Durand
43f5f4e030 fix test 2023-12-12 22:35:11 +00:00
Kara Diaby
303230dd1d Add new testss 2023-12-12 22:35:11 +00:00
Lisa Durand
d0e2f281cc fix tests 2023-12-12 22:35:11 +00:00
Lisa Durand
f6f18e9c86 send email to tiers if notification by email is set 2023-12-12 22:35:11 +00:00
krichtof
246d53fa99
Merge pull request #9754 from demarches-simplifiees/9435-transfer-dossier
En tant que superadmin, je peux transférer un dossier d'un utilistateur à un autre
2023-12-12 14:44:39 +00:00
Christophe Robillard
122a6b6f5b revoke superadmin dossier transfer 2023-12-12 15:25:39 +01:00
Colin Darie
7c38cbcab3
test: fix random failing test 2023-12-12 15:05:48 +01:00
Colin Darie
c0771ad903
fix(dossier): passe en instruction with auto-archive even with pending correction 2023-12-12 15:05:46 +01:00
Colin Darie
3d21262e89
test(declarative): clarify intention with pending correction & declarative procedure 2023-12-12 15:05:45 +01:00
Colin Darie
c26b59722d
feat(instructeur): pending correction blocks passer en instruction
Closes #9731
2023-12-12 15:05:44 +01:00
Colin Darie
f9c4846fde
Merge pull request #9571 from adullact/feature-ouidou/admin_creation_delegation_gestionnaire_page_group_administrateur_management
Feature ouidou/admin creation delegation gestionnaire page group administrateur management
2023-12-12 10:41:28 +00:00
Colin Darie
6a2e68b697 feat(admin): task removing type de champ from draft revision from a csv 2023-12-11 19:04:49 +01:00
Colin Darie
7618b8c549 feat(admin): task updating libelles, description, mandatory and positions on draft revision
Co-Authored-By: mfo <mfo@users.noreply.github.com>
2023-12-11 18:41:20 +01:00
Colin Darie
968b2cfb0a
Merge pull request #9818 from colinux/correction-remove-from-message
ETQ instructeur, ma demande de correction est supprimée (résolue) lorsque je supprime son message associé
2023-12-11 13:07:43 +00:00
mfo
b56d5199e2
Merge pull request #9820 from mfo/US/filter-dossier-with-combobox
ETQ instructeur, lorsque je veux filtrer les dossiers d'une démarche, je peux utiliser un autocomplete
2023-12-11 09:48:58 +01:00
seb-by-ouidou
8c1bc9e62f feat: batch action for repousser_expiration depuis expirant 2023-12-09 06:27:00 +01:00
seb-by-ouidou
5c80f6c3f0 feat: batch action for desarchiver 2023-12-09 06:27:00 +01:00
seb-by-ouidou
c0c2e35881 feat: batch action for restaurer 2023-12-09 06:27:00 +01:00
seb-by-ouidou
5ec95d781c feat: batch action for supprimer 2023-12-09 06:27:00 +01:00
mfo
28bbfc7b3a
Merge pull request #9800 from colinux/fix-publication-revision-errors
ETQ admin je suis prévenu si des erreurs sur la démarche empêchent la publication de révision
2023-12-08 17:14:14 +00:00
Martin
1f13000537 amelioraiton(instructeur.filtres): utilise un combobox pour rechercher le type de champs 2023-12-08 16:10:18 +01:00
Martin
a66fd42450 amelioration(estimation_delay): evite des estimations de date similaire 2023-12-07 16:47:16 +01:00
Colin Darie
accd7864ff feat(correction): deleting a comment resolves the related correction
Cf #9731
2023-12-07 15:41:50 +01:00
Colin Darie
0f1980b1c3 refactor(pj): don't poll on antivirus when submitting a pj
Closes #9733
2023-12-07 14:29:09 +01:00
Martin
f26a4bc041 amelioration(delai.traitement): revoie l'affichage du delais d'instruction
Co-authored-by: Colin Darie <colin@darie.eu>
2023-12-07 09:19:52 +01:00
Martin
474fde3380 amelioration(procedure.usual_traitement_time_for_recent_dossiers): divise en 3 groupe l'estimation de la duree de traitement 2023-12-07 09:19:52 +01:00