Commit graph

147 commits

Author SHA1 Message Date
Martin
2952987ad8 refactor(spec): stop using procedure type de champs traits as :with_datetime, :with_xxx in favor of :types_de_champ_public which keeps position in check 2024-01-23 17:30:22 +01:00
Martin
2fa59076f9 fix(spec.flacky): ./spec/system/administrateurs/types_de_champ_spec.rb:272 was flacky, try to fix it 2024-01-22 15:50:38 +01:00
Martin
69346ad41f tech(review): implement some pair review suggestions 2024-01-12 11:00:29 +01:00
Martin
e7eee7ba72 spec(move_and_morph): add some spec and lint with rubocop/haml/eslint 2024-01-11 16:12:09 +01:00
Martin
857a1fc496 fix(select_champ_position): rewire for more robust and easier implementation which work with repetition avoiding double submit 2024-01-11 16:01:24 +01:00
Colin Darie
eb42ea9a2d
refactor(admin): improve links & message of PublicationWarningComponent 2023-12-05 18:51:12 +01:00
Colin Darie
60abc6ea6e fix(admin): warn when errors block revision publication 2023-12-05 18:31:20 +01:00
Colin Darie
d70b03c969
style: replace refuse legacy icon 2023-12-04 14:07:25 +01:00
Colin Darie
adfeac02e7
style: replace new-folder icon with remix/dsfr icon 2023-12-04 14:07:17 +01:00
krichtof
fce2d8efa9
Merge pull request #9710 from demarches-simplifiees/9615-form-autosave
ETQ admin, je peux savoir quand mon formulaire a été sauvegardé pour la dernière fois
2023-11-23 23:17:14 +00:00
Christophe Robillard
9c641ccee1 remove flash success messages 2023-11-23 17:10:29 +01:00
Lisa Durand
1fa3425d4f
Merge pull request #9705 from demarches-simplifiees/setup-dark-mode-ldu
[Accessibilité] Configurer le mode "sombre"
2023-11-16 15:10:41 +00:00
Lisa Durand
b782bcdd2b
Merge pull request #9672 from demarches-simplifiees/add-confirmation-page-for-procedure-publication-ldu
[admin] Ajout d'une page de confirmation après la publication d'une procédure - mise en avant de l'URL à partager
2023-11-16 11:08:54 +00:00
Lisa Durand
373379d132 remove icon from admin dashboard and use badge - Figma 2023-11-15 19:08:56 +01:00
Lisa Durand
ac834b0c0a add confirmation page after publishing procedure for admin 2023-11-08 12:07:32 +01:00
Colin Darie
560d291bcd test: retry system tests only on CI (get error fast in local) 2023-11-06 15:15:51 +01:00
Lisa Durand
48ee575990 fix specs 2023-10-19 17:59:16 +02:00
Lisa Durand
c88e6ab75c fix specs 2023-10-17 12:25:58 +02:00
Lisa Durand
d07c8ce19f fix specs 2023-10-10 17:02:43 +02:00
Colin Darie
5e99250546 fix(admin): zones selector checkbox as dsfr 2023-09-05 11:02:29 +02:00
simon lehericey
bd78a14f62 spec: add retry to all system spec 2023-08-31 09:59:18 +02:00
Martin
7905a4e870 tech(test.flacky): essaie de rendre plus fiable un test flacky sur la configuration des champs d'un formulaire 2023-08-29 15:49:58 +02:00
Lisa Durand
62382b1209 fix tests 2023-07-18 10:59:09 +02:00
Lisa Durand
e1ece91bb3 harmonize card admin 2023-07-10 10:53:07 +02:00
Lisa Durand
9c89719a51 fix specs 2023-06-22 15:52:21 +02:00
Eric Leroy-Terquem
0164b5f008 fix tests after typos corrections 2023-06-12 15:13:25 +02:00
Lisa Durand
968f05f648
Merge pull request #9107 from demarches-simplifiees/remove-previsualisation-from-admin-procedure-creation
[Refonte page accueil demarche] Formulaire de création admin full page - plus de prévisualisation
2023-06-05 12:10:31 +00:00
Lisa Durand
4fdcce45c5 fix specs 2023-05-31 17:33:49 +02:00
simon lehericey
97aac5d588 update tests for rules based routing 2023-05-31 11:38:16 +02:00
Lisa Durand
a20ec44841
Merge pull request #9074 from demarches-simplifiees/add-more-info-on-procedure-description
[Refonte page accueil demarche] Détailler la description pour plus de clarté pour l'usager
2023-05-30 09:45:32 +00:00
Christophe Robillard
b13e77650e update default zones after admin creation 2023-05-24 17:40:00 +02:00
Lisa Durand
7340206f81 rollback - add just one new field and use actual description field 2023-05-24 11:31:24 +02:00
Lisa Durand
6274594c70 add new layout to handle new full screen design 2023-05-23 16:49:37 +02:00
Martin
ad77b9321b amelioration(formulaire-usager): groupes les champs suivant un titre de section dans une balise html de type <fieldset> de sorte a améliorer l'accessibilite de la plateforme 2023-04-20 08:22:02 +02:00
Martin
b9faa26560 amelioration(editeur-de-champs): permet de choisir un niveau de titre (de 1 à 3) pour les champs de type Champs::HeaderSectionChamp. Gère les erreurs dans le cas ou un administrateur supprimerait un HeaderSection qui casserait l'ordre des titre [ex: titre 1,2,3. et l'admin supprime le titre 1 et il reste que 2,3]. 2023-04-20 08:22:02 +02:00
simon lehericey
213d463ff4 feat(routing): small UI polish 2023-04-13 10:28:52 +02:00
Eric Leroy-Terquem
6f6bbd6ca1 feat(routing): put routing logic behind a feature flag 2023-03-30 10:52:53 +02:00
Eric Leroy-Terquem
6dfe54479d test(routing): can route from a dropdown list 2023-03-30 10:51:48 +02:00
Martin
4ac498392c bug(procedure.maj): impossible de mettre a jour une procedure avec une duree de conservation supérieur a 12 mois 2023-03-10 10:16:36 +01:00
Colin Darie
c112018ec3 fix(administrateur): tags persistence when non interacting with tags combobox 2023-03-08 11:27:31 +01:00
Martin
c45f15ff61 correctif(procedure/all.xsls): deconnecte le lien de telechargement de toutes les demarche de turbo 2023-02-15 11:26:21 +01:00
Kara Diaby
f212fa1008 Permet de cloner une démarche depuis la page toutes les démarches 2023-02-09 08:28:30 +00:00
Colin Darie
fa0f72aaba feat(procedure): hide estimated fill duration when super admin disabled it
Closes #8466
2023-02-01 11:02:55 +01:00
Martin
2be0f5aa99 amelioration(menu): extraction des menu dans un composant ruby pour ne pas dupliquer les changements aria partout ds la codebase 2023-01-26 11:13:23 +01:00
simon lehericey
9043bed3a0 refactor(procedure_presentation): add required tags 2023-01-11 14:05:17 +01:00
François Vantomme
0e3fe055e4
fix(archive): typo on flash notice 2023-01-10 17:23:48 +01:00
Martin
a4d6692bc6 accessibilite(pages-authentification): evolutions des pages de connexion/creation de compte pour respecter le DSFR et supporter une meilleure accessibilite
Update app/components/dsfr/input_component/input_component.html.haml

Co-authored-by: Colin Darie <colin@darie.eu>
2023-01-03 16:26:05 +01:00
Christophe Robillard
00536b949a fix system specs by adding zone for new procedure 2022-12-21 09:02:16 +01:00
Christophe Robillard
f4977f358b fix spec procedure_cloning
add zone to new procedure
2022-12-21 09:02:16 +01:00
Martin
2be4441a70 amelioration(attestion.et.mail): deduplique les message d'erreur, améliore les messages d'erreur, gère la pluralisation des erreurs lorsque plusieurs tags sont concernés 2022-12-19 09:28:46 +01:00
Martin
ef389eab41 amelioration(attestation.et.mail): repositionne les messages d'erreur lié à la substitution des balises a proximité du formulaire pour faciliter la comprehension. passage des champs au DSFR 2022-12-19 09:28:46 +01:00
Eric Leroy-Terquem
2645ac85f7 update wording and order in types de champ select 2022-12-16 09:30:36 +01:00
Paul Chavard
cafda4f6f0 refactor(attestation_template): move to procedure 2022-11-23 12:26:26 +01:00
simon lehericey
f532eee9f6 fix(spec): remove strange click 2022-11-22 16:41:20 +01:00
Paul Chavard
29bdd82b59 refactor(procedure): types_de_champ -> active_revision.types_de_champ_public 2022-11-17 13:54:14 +01:00
Paul Chavard
f47b39f389 fix spec 2022-11-07 13:34:58 +00:00
Paul Chavard
7de52d582a feat(conditional): remove conditional feature flag 2022-11-04 13:37:37 +00:00
Eric Leroy-Terquem
b419c48262 toggle routing when adding or deleting groupe_instructeurs 2022-11-04 12:03:43 +01:00
Eric Leroy-Terquem
09c5b9dc99 remove categories_type_de_champ feature flag 2022-11-03 14:28:27 +01:00
Martin
c7c46c9dff design(page de configuration de procedure): passage de la grille au DSFR 2022-10-27 14:00:44 +02:00
Eric Leroy-Terquem
ff2e9f0816 add feature flag 2022-10-05 09:21:08 +02:00
sebastiencarceles
b643660017 'Choix parmi une liste' becomes 'Choix unique'
closes #7374
2022-09-06 11:26:30 +02:00
Martin
549eda6fe3 feat(DSFR.breadcrumb): switch to DSFR breadcrumb style since it is part of new service UI 2022-09-06 10:09:12 +02:00
Martin
289b8f78b8 feat(Administrateur::Services#index): rework list of services 2022-08-31 14:56:00 +02:00
Martin
51680b11c2 feat(Adminstrateur::Procedures#clone): redirect to home of procedure with special info regarding procedure presentation & service 2022-08-31 14:56:00 +02:00
Martin
e35da17ce8 bug(instructeurs/archives#create): month should not be nil 2022-08-23 15:31:17 +02:00
Martin
dc524cf615 fix(spec): broken spec due to TDD and refacto on former code 2022-08-23 13:28:10 +02:00
Martin
711b2ee2e4 feat(ExportComponent): only render it when connected instructeur/administrateur is not from manager 2022-08-23 13:28:10 +02:00
Martin
25c0e91d87 feat(Administrateurs::GroupeInstructeur): ensure admin from super admin can not add an instructeur 2022-08-23 13:28:10 +02:00
Martin
d1544bc4ae feat(Administrateurs::ProcedureAdministrateurs): ensure admin from super admin can not add administrateur 2022-08-23 13:28:10 +02:00
simon lehericey
6b5f38ce74 spec 2022-08-11 14:03:04 +02:00
Paul Chavard
2d7803cd48 refactor(spec): use new procedure.types_de_champ factory 2022-08-04 12:10:32 +02:00
Paul Chavard
f48048179c fix(conditional): enable conditional per procedure 2022-08-03 09:16:10 +02:00
Martin
87af7f3261 feat(exports): implement admin export 2022-07-20 14:08:33 +02:00
simon lehericey
28a18e3912 spec: prove annotation is broken 2022-07-12 14:17:05 +02:00
Colin Darie
8c08d0295b Revert "feat(champ): customizable placeholders for text & textarea champs"
This reverts commit 9e26ee932e.

Finalement les champs génériques ne doivent pas avoir de placeholder
personnalisable, ce sera uniquement via la description.
2022-07-12 11:37:58 +02:00
simon lehericey
9bd1d97ed7 add feature flag 2022-07-12 10:44:40 +02:00
simon lehericey
e9cf41a00d add system spec 2022-07-12 10:44:40 +02:00
Paul Chavard
b8db929e62 fix(a11y): add id to drop_down_other 2022-07-12 08:43:17 +02:00
Colin Darie
9e26ee932e
feat(champ): customizable placeholders for text & textarea champs
Closes #7429
2022-07-11 17:16:20 +02:00
Martin
7fb85c97cb feat(Administrateur::ArchivesControllers): add archives #index and #create for admin 2022-07-04 14:18:46 +02:00
Martin
ea71908850 fix(ChampEditor): add missing drop_down_other for type_de_champ.drop_down_list_with_other? 2022-06-27 17:19:10 +02:00
Paul Chavard
6801b04b7b feat(type_de_champ): type_de_champ editor in stimulus/turbo 2022-06-17 11:04:09 +02:00
Kara Diaby
1f2f148464 tests 2022-06-08 14:38:17 +02:00
Pierre de La Morinerie
c1616adf8c app: remove procedure-estimated-fill-time feature-flag
The feature is now enabled for every procedure.

Ref #7338
2022-06-01 11:11:55 +02:00
Pierre de La Morinerie
c738d7d07f js: display estimated duration in champ editor 2022-05-25 21:50:49 +02:00
Pierre de La Morinerie
736ef10bb3 spec: cleanup system/types_de_champ_spec.rb 2022-05-25 21:50:49 +02:00
Martin
3737311390 feat(procedure.procedure_expires_when_termine_enabled): enable by default, allow contributor to choose the default settings of this flag using an env var during migration. ie: DEFAULT_PROCEDURE_EXPIRES_WHEN_TERMINE_ENABLED=true|false
feat(administrateurs/procedures#show): warning/alert when procedure_expires_when_termine_enabled is not true on current procedure

feat(administrateur/procedure#update): after an update redirect to procedure show: suggested by: https://ux.stackexchange.com/questions/55291/after-updating-form-should-redirect-back-to-form-itself-or-to-the-show-page-or-b and confirmed by Olivier

clean(Flipper.archive_zip_globale): no more in use, so remove all occurences

Update app/views/administrateurs/procedures/_suggest_expires_when_termine.html.haml

Co-authored-by: Pierre de La Morinerie <kemenaran@gmail.com>

Update app/views/administrateurs/procedures/_suggest_expires_when_termine.html.haml

Co-authored-by: Pierre de La Morinerie <kemenaran@gmail.com>

Update app/views/administrateurs/procedures/_suggest_expires_when_termine.html.haml

Co-authored-by: Pierre de La Morinerie <kemenaran@gmail.com>

Update spec/views/administrateurs/procedures/show.html.haml_spec.rb

Co-authored-by: Pierre de La Morinerie <kemenaran@gmail.com>

fix(review): typo, why ena?, who knows

fix(env.example.optional): add missing DEFAULT_PROCEDURE_EXPIRES_WHEN_TERMINE_ENABLED
2022-05-05 13:07:11 +02:00
Martin
3c0e3f725d feat(administrateur/procedures#publication): show dubious to administrateur
Update app/views/administrateurs/procedures/publication.html.haml

Co-authored-by: Paul Chavard <paul.chavard@beta.gouv.fr>
2022-04-27 15:13:22 +02:00
Pierre de La Morinerie
d680602c84 models: validate private types_de_champ 2022-02-01 12:37:16 +01:00
Pierre de La Morinerie
e8e37cce15 models: refactor the types_de_champ validators
Context: we want to validate public and private types_de_champ
separately.

Before we validated the whole revision (and then validators themselves
enumerated all champs, public and private).

Now we validate the actual public types_de_champ, which will let us
validate separately the private types_de_champ.
2022-02-01 12:37:16 +01:00
Martin
a9ffaf942e feat(attestation): can enable/disable attestation no matter the state of the procedure 2022-01-05 18:20:11 +01:00
Pierre de La Morinerie
b86dec8251 views: prevent procedure publication on validation error 2021-11-30 13:34:41 +01:00
Pierre de La Morinerie
9db62178d2 views: display revision errors on the procedure dashboard 2021-11-30 13:34:41 +01:00
Pierre de La Morinerie
93124195fc specs: refactor procedure_creation_spec.rb
- Improve wording of specs description
- Remove publication test (duplicate of procedure_publish_spec.rb)
2021-11-30 13:34:41 +01:00
Pierre de La Morinerie
8e69a9883b specs: avoid using french in procedure_publish_spec.rb 2021-11-30 13:34:41 +01:00
Pierre de La Morinerie
184a401182 app: rename new_administrateur to administrateurs 2021-11-30 08:49:38 +01:00