Commit graph

2247 commits

Author SHA1 Message Date
simon lehericey
92da869662
spec: Dossier.purge_discarded 2024-08-20 10:55:32 +02:00
mfo
4bf5725d6d
data(backfill): Champs::RnfChamp.value_json [±400 occurences] 2024-08-20 10:31:23 +02:00
mfo
d866309d45
feat(rnf/rna/siret): normalize address in champs.value_json 2024-08-20 10:31:23 +02:00
mfo
dba6f9b3aa
refactor(Facet): to column 🚀 2024-08-19 15:46:14 +02:00
mfo
b6464c1963
tech: use facet_id to sort fields 2024-08-19 15:30:08 +02:00
mfo
60c6c86d70
ProcedurePresentation.displayable_fields_for_select -> InstructeurFacetPickerComponent.displayable_fields_for_select 2024-08-19 15:29:59 +02:00
mfo
41ea39abb1
ProcedurePresentation.filterable_fields_options -> InstructeurFilterComponent.filterable_fields_options 2024-08-19 15:29:59 +02:00
simon lehericey
379c9fb812
procedure should provide its facets 2024-08-19 15:29:59 +02:00
simon lehericey
c5c2d5782d
lets keep it private 2024-08-19 15:29:59 +02:00
simon lehericey
772424ff5e
move field_enum to instructeur filter component 2024-08-19 15:28:36 +02:00
simon lehericey
305b8c13c7
! BREAKING : break previous filter by type_de_champ_private
simplify type_de_champ_private -> type_de_champ, fix spec, add facet_spec
2024-08-19 15:28:36 +02:00
mfo
b3cb3e974e
refactor(Facet): extract Facet from ProcedurePresentation
Co-Authored-By: LeSim <mail@simon.lehericey.net>

clean(code): no comment 🎶
2024-08-19 15:27:39 +02:00
Kara Diaby
61525b6c2b
test 2024-08-19 12:51:39 +00:00
Colin Darie
720a312b00
fix(rnf): really normalize spaces
Fix #10653
2024-08-01 18:54:50 +02:00
Paul Chavard
25d4e7dfee
fix(rnf): no crash on identifiers with spaces 2024-08-01 18:00:46 +02:00
Paul Chavard
337eaff3f0
Merge pull request #10602 from demarches-simplifiees/fix-routing-fields-list
Correctif : ouvre l‘assistant de routage à tous les types de champ conditionnables
2024-07-30 09:01:24 +00:00
Paul Chavard
b81f69580b
fix(sva/svr): fix spec with arbitrary date 2024-07-30 09:35:15 +02:00
simon lehericey
8906a59635
simplify export_template model and spec 2024-07-26 13:34:49 +02:00
simon lehericey
977cfc87ce
Add export_item type 2024-07-26 13:31:06 +02:00
simon lehericey
24109a0128
add exportables_pieces_jointes_for_all_versions and outdated to pj_list_concern 2024-07-26 13:31:06 +02:00
simon lehericey
53a48f963d
tdc: add libelle_as_filename 2024-07-26 13:31:05 +02:00
Corinne Durrmeyer
190addd317
Merge pull request #10647 from demarches-simplifiees/a11y-authentification-page
Améliore l'accessibilité de la page d'authentification
2024-07-26 09:38:18 +00:00
Paul Chavard
223317fb5a
fix(rebase): avoid errors when adding pj champs to a new revision 2024-07-25 18:29:01 +02:00
Corinne Durrmeyer
c4afbfcbf1
Update spec files 2024-07-25 12:24:25 +02:00
Lisa Durand
b820577461
create a method to extend and restore 2024-07-24 17:07:48 +02:00
Lisa Durand
94e1f048ce
fix tabs count 2024-07-24 17:07:47 +02:00
Lisa Durand
0dcdcb5643
add column hidden_by_expired_at 2024-07-24 17:07:41 +02:00
Paul Chavard
229483d16c
refactor(champ): remove type_de_champ_id and champ factories 2024-07-22 13:53:45 +02:00
Paul Chavard
d640ab8428
fix(combobox): dispatch change event on multiple combo changes 2024-07-16 15:10:45 +02:00
mfo
1cd539297f
feat(dossier.passer_en_construction!): clean up PJ for champs that are not visible [condition is false] 2024-07-15 11:28:59 +02:00
Eric Leroy-Terquem
60ff785009
refactor(type de champ): rename routable_types in simple_routable_types 2024-07-11 12:17:46 +02:00
Paul Chavard
96e49d54cd
reafctor(logic): remove tests and accept unspecified behaviour 2024-07-08 15:44:30 +02:00
mfo
75a6c8b4b6
Merge pull request #10555 from mfo/US/normalize-number-cahmp
tech: Normalisation des champs de type number/decimal pr enlever les espace blanc à la saisi
2024-07-08 07:31:29 +00:00
Paul Chavard
9f9243499c
refactor(combobox): fix specs 2024-07-05 09:36:33 +02:00
Paul Chavard
cb01f15570
refactor(champ): update champ commune 2024-07-05 09:36:33 +02:00
mfo
c50f949acd
feat(Champs::number*): normalize values by stripping spaces. 2024-07-04 09:56:23 +02:00
Colin Darie
b3ccfc16c4
Merge pull request #10547 from colinux/mandatory-by-default
ETQ admin, un nouveau champ est obligatoire par défaut
2024-07-02 14:26:29 +00:00
Colin Darie
eee6e5e651
Merge pull request #10483 from colinux/fast-tests
Tech (tests): default administrateur fixtures
2024-07-01 21:35:11 +00:00
Colin Darie
2041623ded
test: merge similar examples 2024-07-01 22:36:31 +02:00
Colin Darie
9e80962ea5
test: default administrateur as fixtures 2024-07-01 22:36:31 +02:00
Colin Darie
f40b71f450
test(type_de_champ): mandatory by default, like schema 2024-07-01 17:00:49 +02:00
Lisa Durand
159cc942f6
Merge pull request #10549 from demarches-simplifiees/new-instructeur-need-mail-confirmation-ldu
ETQ nouvel instructeur, je dois confirmer mon mail
2024-07-01 08:45:57 +00:00
Lisa Durand
75403ba949
add specs 2024-06-26 10:57:40 +02:00
mfo
cfda807b66
fix(data): decimal number having spaces are no more exportable 2024-06-25 21:17:46 +02:00
mfo
476c7df160
bug(Champs::DecimalNumberChamp.for_export): should be able to cast a number wrapped with a string having leading/trailing spaces 2024-06-25 17:05:33 +02:00
Lisa Durand
d7893b9102
instructeur need to confirm mail after invitation 2024-06-25 15:14:26 +02:00
Colin Darie
f2669fbca8
fix(attestation): fix unspecified_attestation_champs for v2 2024-06-20 14:15:06 +02:00
Colin Darie
a540f8dccb
feat(attestation): can render & attach attestations v2 2024-06-20 14:15:05 +02:00
Colin Darie
4af6957237
fix(attestation): dup keep all attributes 2024-06-20 11:08:15 +02:00
Colin Darie
c5c24c01d8
chore(attestation): procedure#attestation_template always returns the published attestation 2024-06-20 11:08:15 +02:00
mfo
8cb902821f bug(draft_types_de_champ_private.condition): condition must be validated with upper_tdcs. considering that types_de_champ_private can have a condition using a types_de_champ_public, we have to include all types_de_champs_public plus only types_de_champs_private.upper_tdcs 2024-06-11 16:05:45 +02:00
mfo
f819da8921
tech(clean): simplify implementation of eligibilite rules, code, enhance wording and test coverage 2024-06-11 09:57:36 +02:00
mfo
e3a24d53ea
tech(refactor): procedure::error_summary and dossier::ErrorsFullMessagesComponent use same behaviour to compact/expand errors 2024-06-11 09:39:20 +02:00
mfo
5644692448
feat(Logic.computable?): add computable? to know if a ineligibilite_rules set is computable 2024-06-11 09:32:53 +02:00
mfo
5de4ce889f
feat(ProcedureRevision.ineligibilites_rules): keep track of changes and show it to admin for republication 2024-06-11 09:32:53 +02:00
mfo
ab522a3e40
Merge pull request #10503 from mfo/US/fix-condition-validator-on-private-champ-using-public-tdc
Correctif: ETQ admin, je souhaite pouvoir utiliser des champs public pour conditionner une annotation privée
2024-06-10 09:33:22 +00:00
mfo
27b86f9848
fix(TypesDeChamp::ConditionValidator): allow to use types_de_champ_public on condition for types_de_champ_private 2024-06-10 11:26:01 +02:00
mfo
d2ccea700b
bug(TypesDeChamp::ConditionValidator): should allow to use types_de_champ_public on condition for types_de_champ_private 2024-06-10 09:35:29 +02:00
Kara Diaby
cb5ba455eb Fixe bug sur toutes les démarches 2024-06-05 14:13:44 +00:00
mfo
ef3ca9839b feat(procedure.validation): extract validation context: types_de_champ_public_editor, types_de_champ_private_editor and publication [combining both contextes]. validate conditions, headers_sections, regexp on type_de_champ_private too. dry validation 2024-06-04 18:25:24 +02:00
mfo
f14c88a54a clean(spec): speed, avoid using with_all_champs factory. takes too much time when not needed 2024-06-04 15:34:34 +02:00
krichtof
45814fdbfb
Merge pull request #10454 from demarches-simplifiees/9827-add-specs
corrige quelques bugs de la feature export template (renommage dans le zip)
2024-06-04 13:18:12 +00:00
Christophe Robillard
ac23d5fb41 convert date with dash for export renaming 2024-06-04 10:32:14 +02:00
Paul Chavard
68c15ba99f
feat(champ): add updated_by column 2024-06-03 18:45:16 +02:00
mfo
a278aac92f fix(spec): maj broken spec on main 2024-05-31 08:24:55 +02:00
Christophe Robillard
acf6579aa4 add missing specs to export template 2024-05-29 14:38:05 +02:00
Paul Chavard
de209954e1
Merge pull request #10466 from tchak/fix-supprimes_recemment-should-include-archived
fix(instructeur): supprimes_recemment should include archived dossiers
2024-05-29 11:09:41 +00:00
Paul Chavard
5154231ccf
fix(dossier): batch operations to termine dossier should send emails 2024-05-29 11:31:58 +02:00
Paul Chavard
b06934b8d3
fix(instructeur): supprimes_recemment should include archived dossiers 2024-05-29 11:03:46 +02:00
Christophe Robillard
06cbb65d4e spec: simplify export template factory 2024-05-28 18:25:37 +02:00
simon lehericey
fa06d17169
Feat(user): set email_verified_at when setting confirmed_at 2024-05-27 17:24:56 +02:00
simon lehericey
841c1cc845
Feat(user): verify user email during devise confirmation 2024-05-27 17:24:55 +02:00
Paul Chavard
1bca3c123b
chore(dossier): remove legacy update attributes 2024-05-27 10:33:37 +02:00
simon lehericey
d3b700326d
spec: fix 2024-05-23 10:01:29 +02:00
simon lehericey
fa7d5cfa33
fix test 2024-05-23 10:00:41 +02:00
simon lehericey
c8b3b4b45a
refactor: renaming 2024-05-23 10:00:38 +02:00
simon lehericey
6445337be7
refactor(pj_list): extract pj list in a concern and simplify 2024-05-23 10:00:38 +02:00
Christophe Robillard
aeb4bd2ff1
add original-filename tag 2024-05-23 10:00:36 +02:00
Christophe Robillard
8e8057ddd3
add some specs to export template 2024-05-23 10:00:36 +02:00
Christophe Robillard
357c07456c
generate export with export_template 2024-05-23 10:00:34 +02:00
Christophe Robillard
95c308dc51
add specific tags 2024-05-23 10:00:33 +02:00
Christophe Robillard
a248eba641
export template: set default values 2024-05-23 10:00:33 +02:00
Christophe Robillard
bbb6309b4f
procedure: add pieces_jointes_exportables_list 2024-05-23 10:00:32 +02:00
Christophe Robillard
25ab2420fe
validate export template 2024-05-23 10:00:32 +02:00
Christophe Robillard
24922605cd
add pj for export template 2024-05-23 10:00:32 +02:00
Christophe Robillard
d1c3b84ea2
add export template model 2024-05-23 10:00:32 +02:00
mfo
4ea601de79
fix(champs.pj.clone): stop cloning private piece_justificative_file when user clone his dossier 2024-05-21 09:50:27 +02:00
Colin Darie
c2b1d7aaaf
Merge pull request #10261 from colinux/ignore-search-terms-2
Tech (perf): ignore les `search_terms` colonnes pour ne plus les select à chaque query et debounce l'indexation
2024-05-21 07:07:10 +00:00
Colin Darie
3d52601155
fix(carte): gracefully ignore invalid year and kind params
Empêche d'envoyer une date invalide à PG et polluer les logs.
2024-05-16 16:58:42 +02:00
Paul Chavard
a1db089681 fix(champ): champ value formatters should check champ type 2024-05-13 17:00:46 +02:00
Colin Darie
e01f5b7993
refactor(search): index search terms only when necessary 2024-05-08 10:35:04 +02:00
Kara Diaby
3bebff1177 TEsts 2024-05-07 09:49:29 +00:00
Colin Darie
6733b2884f
feat(search): index mandataire name 2024-05-06 18:58:52 +02:00
Colin Darie
39b0327237
refactor(search): rename update search terms => index search terms 2024-05-06 18:57:39 +02:00
Colin Darie
4408824882
fix(dossier): update search terms when etablissement or individual changed 2024-05-06 18:57:03 +02:00
Colin Darie
ee465b38ff
feat(search): debounce update search terms 2024-05-06 18:57:00 +02:00
Colin Darie
5a2ddcb471
test: faster dossier clone spec by merging similar it 2024-05-06 17:16:34 +02:00
Colin Darie
2e763d5e92
perf(search): ignore search_terms columns, use raw sql instead 2024-05-06 17:16:34 +02:00
Paul Chavard
244dcfcc23 refactor(export): improuve specs 2024-04-24 13:27:20 +02:00
Paul Chavard
42336b235e chore(spec): move spec in the correct folder 2024-04-23 21:57:00 +02:00
Paul Chavard
95bb09a1f8 refactor(champs): do not depend on attributes hash key in old code 2024-04-22 18:38:59 +02:00
Paul Chavard
f4f5416dd3
Merge pull request #10328 from tchak/refactor-dossier-champ-by-stable-id-controller
refactor(champs): update champs by public_id [controllers]
2024-04-22 12:23:16 +00:00
Paul Chavard
0c7bc6b555 feat(dossier): add methods to upsert champ values 2024-04-22 13:55:01 +02:00
simon lehericey
cd808864b6
chore(spec): fix missing s in path 2024-04-22 11:59:28 +02:00
simon lehericey
9e33b1ee6d
fix: allow unsigned expert when restricted list 2024-04-19 13:03:09 +02:00
mfo
6d84c38fca
tech(deadspec): no more brouillon context on dossier validation 2024-04-17 06:27:26 +02:00
mfo
aca67a2274
tech(refactor.champs.validation): all champs validation use :validate_champ_value_or_prefill? 2024-04-17 06:27:26 +02:00
simon lehericey
981003975c
refactor: use last_sign_in_at as confirmed_at is not reliable 2024-04-16 17:58:30 +02:00
simon lehericey
d95ce505a8
feat: suggest recently added user even if its not confirmed 2024-04-16 17:58:30 +02:00
simon lehericey
8d95df2250
feat: do not suggest unconfirmed experts 2024-04-16 17:58:30 +02:00
simon lehericey
5cd780251b
refactor: mutualize email_expert logic 2024-04-16 17:58:29 +02:00
Colin Darie
71b0592b0a
Merge pull request #10336 from colinux/fix-address-without-postcode
Usager: fix champ adresse dans un TOM sans code postal dans la BAN (ex. Nouvelle-Calédonie à Nouméa)
2024-04-16 13:45:04 +00:00
Colin Darie
db65c9178e
fix(address): BAN does not return postcode for some TOM like Nouvelle-Calédonie
But we have to fallback to an empty string because API graphql / serializer
expects a non-null attribute.
2024-04-16 15:37:56 +02:00
Paul Chavard
08e127c120 chore(spec): remove test for old unused behaviour 2024-04-16 12:10:08 +02:00
Paul Chavard
ee56a7da21 refactor(champ): remove stable_id delegate to type_de_champ 2024-04-16 12:10:07 +02:00
mfo
938f5043a4
feat(champs.validation): standardize champ error messages 2024-04-12 11:39:43 +02:00
LeSim
22830fd7f6
Merge pull request #10275 from demarches-simplifiees/fix_api_entreprise_status
Tech: corrige le mécanisme de surveillance des fournisseurs d entreprise.api.gouv.fr
2024-04-08 08:08:38 +00:00
Paul Chavard
c5c671f391
Merge pull request #10234 from tchak/type-de-champ-paths
feat(champ): add paths to type_de_champ
2024-04-08 08:07:30 +00:00
Paul Chavard
80b3f0c0b3 fix(champ): no validate on hidden champs 2024-04-05 13:24:57 +02:00
simon lehericey
7b33963a67
add and use api_djepva_up? 2024-04-05 12:27:26 +02:00
simon lehericey
e994738a2e
add and use api_insee_up? 2024-04-05 12:26:44 +02:00
Paul Chavard
282ce1322c fix(stats): more accurat stats about deleted dossiers 2024-04-04 19:00:48 +02:00
Paul Chavard
38a703034e feat(champ): expose paths 2024-04-04 16:13:23 +02:00
Colin Darie
863784a1a9
test: configure default host on APP_HOST everywhere 2024-04-02 18:47:40 +02:00
simon lehericey
8405c83c12
fix: do not retry rnf bad request 2024-04-02 10:00:07 +02:00
mfo
284a10e235
fix(Champs::EngagementJuridiqueChamp): validates Champs::EngagementJuridiqueChamp respecting it's validation context. 2024-04-01 07:18:14 +02:00
mfo
d7f152f4af
fix(Champs::PhoneChamp): validates Champs::PhoneChamp respecting it's validation context. 2024-04-01 07:18:14 +02:00
mfo
374d763084
fix(Champs::IntegerNumberChamp): validates Champs::IntegerNumberChamp respecting it's validation context. 2024-04-01 07:18:13 +02:00
mfo
04f3b6a844
fix(Champs::DecimalNumberChamp): validates Champs::DecimalNumberChamp respecting it's validation context 2024-04-01 07:07:11 +02:00
Lisa Durand
65b8f6881a
Merge pull request #10143 from demarches-simplifiees/float-too-many-decimal-ldu
ETQ admin, je veux que le champ nombre décimal ne prenne que 3 chiffres après la virgule
2024-03-27 10:05:35 +00:00
Lisa Durand
a3ab6dd257 add validation on decimal max 3 digits after coma 2024-03-27 10:55:10 +01:00
Paul Chavard
6ad0b901b6 fix(champ): use public_id in views 2024-03-26 11:23:23 +01:00
Martin
015e606f50 fix(dossier.has_many.france_connect_informations): wip 2024-03-22 07:47:02 +01:00
Eric Leroy-Terquem
9139bfbf48 clean(administrateur): remove dead code 2024-03-21 14:27:53 +01:00
simon lehericey
a42f85ef05 remove useless administration_id in invite_admin and invite_administrateur! 2024-03-21 11:54:02 +01:00
mfo
086cc1537b
Merge pull request #10068 from mfo/US/user-has-many-fcis
tech(User.FranceConnect): un usager peut avoir plusieurs profils FranceConnect, pas uniquement un
2024-03-20 16:30:39 +00:00
Lisa Durand
6c5c744411
Merge pull request #10119 from demarches-simplifiees/add-explanation-when-publish-with-same-url-ldu
ETQ admin j'ai un message d'explication si j'utilise une URL déja utilisée lors de la publication d'une démarche
2024-03-20 13:21:59 +00:00
Paul Chavard
eff03aaf23 refactor(dossier): label indexes based on type_de_champ not champ 2024-03-20 09:58:47 +01:00
Paul Chavard
f21192bb06
Merge pull request #10123 from tchak/fix-multiple-champ-copies-bug
fix(champ): fix multiple champ copies bug
2024-03-18 16:46:17 +00:00
Paul Chavard
1b2315cd45 fix(champ): fix multiple champ copies bug 2024-03-18 12:13:22 +01:00
Lisa Durand
6b916493cb change wording on page stats 2024-03-18 10:39:11 +01:00
Paul Chavard
900db5624f refactor(champs): if champ not found - build it 2024-03-17 23:51:45 +01:00
Lisa Durand
e757eefd37 add message when path is already taken when publishing a procedure 2024-03-14 17:17:47 +01:00
mfo
5dda05d710
Merge pull request #10100 from mfo/US/cleanup-champs-after-passer-en-construction
fix(email_validation): allow email with specific format
2024-03-12 17:09:39 +01:00
Colin Darie
fc1c6bb412
Merge pull request #10103 from tchak/dossier-vide-from-procedure
refactor(dossier_vide): use types_de_champ instead of empty dossier
2024-03-12 15:29:24 +00:00
Colin Darie
ee92668611
Merge pull request #9930 from demarches-simplifiees/add-external-link-to-procedure
ETQ admin lorsque je clos une démarche je peux alerter les usagers et je crée une page de fermeture si la démarche n'est pas redirigée dans DS
2024-03-12 15:03:30 +00:00
Paul Chavard
aa0aea1543 refactor(dossier_vide): use types_de_champ instead of empty dossier 2024-03-12 14:23:07 +01:00
Martin
2468d528fd fix(email_validation): use truemail regexp 2024-03-12 11:29:31 +01:00
simon lehericey
2bec15b78f fix multiple error message on regexp 2024-03-11 11:41:31 +01:00
Paul Chavard
6ec7a87bcb
Merge pull request #10080 from demarches-simplifiees/add-dependent-destroy-on-contact-information
Correctif : supprime l'information de contact à la suppression du groupe instructeur
2024-03-08 12:15:27 +00:00
mfo
0013528deb
Merge pull request #10065 from mfo/US/secu-email
fix(email.validation): some nasty tests
2024-03-08 09:05:03 +00:00
Martin
9425f2cc58 fix(user.france_connect_informations): has_many, not has_one 2024-03-08 09:44:21 +01:00
Eric Leroy-Terquem
6651b36fe4 db(migration): add closing_reason and closing_details to procedure 2024-03-07 19:00:46 +01:00
Eric Leroy-Terquem
877e1f79cc fix(groupe instructeur): add a dependent destroy on contact information 2024-03-07 16:33:17 +01:00
Martin
0ea90e036e fix(email.validation): some nasty tests 2024-03-05 16:27:07 +01:00
Martin
b468da9964 bug(user.fcis): users using more than one FranceConnect identity provider can not be destroyed 2024-03-05 14:03:02 +01:00
Paul Chavard
f3a97876bd fix(champ): champs are not ordered anymore 2024-03-04 10:59:11 +01:00
Paul Chavard
8687d73a73 refactor(dossier): clone only current revision champs 2024-03-04 10:59:11 +01:00
Paul Chavard
deb19177f7 refactor(test): update tests 2024-03-04 10:59:11 +01:00
Colin Darie
dbf04c63a4
fix(flipper): don't clone features globally enabled 2024-03-03 00:13:01 +01:00
Paul Chavard
178f1a0c26 fix(test): fail on last month day 2024-02-29 15:44:42 +01:00
Colin Darie
f04420812b
fix(export): typo tier => tiers 2024-02-22 15:58:29 +01:00
Colin Darie
7143c7e8e2
Merge pull request #9995 from colinux/attestation-v2-improvements
ETQ admin, quelques améliorations sur l'éditeur v2
2024-02-22 11:30:41 +00:00
Colin Darie
3c22f4ea48
fix(attestation): always return v1 template when exists, otherwise it's a v2 2024-02-22 12:19:07 +01:00
Martin
31168f9602 perf(spec): build not create some variables, & fix specs 2024-02-21 14:44:49 +01:00
Martin
c2675dfb4d feat(export.user): add when user passthru FranceConnect or not 2024-02-21 14:44:49 +01:00
Martin
c9235c8a3d feat(export.for_tier): add to export 2024-02-21 14:44:49 +01:00
Paul Chavard
702b9dd8b3 fix(champ): do not reset data on champs without fetch_external_data 2024-02-21 08:54:08 +01:00
Colin Darie
560d50f52d fix(dropdown-multiple): a valid option starting by [ may not be a JSON value 2024-02-20 17:41:53 +01:00
Martin
ba3fda1928 bug(monavisvalidator): what any domain could be used ?! 2024-02-20 11:51:00 +01:00
Martin
8dc3103ac1 fix(champs.email): allow nil 2024-02-19 15:13:20 +01:00
Martin
1a424beb6f fix(tags): libelle with double dash, becomes double underscore. no worries it was already broken 2024-02-16 14:00:18 +01:00
Martin
0fbbe4d97c bug(tags): libelle with double dash, double dash also known as tag delimiter 2024-02-16 14:00:18 +01:00
Martin
56ed901703 tech(clean): remove dead code 2024-02-16 11:23:39 +01:00
Martin
72a3f6e89c refactor(export/archives): holds user profile asking for the archive or export 2024-02-16 11:23:38 +01:00
Martin
8488e74bbb review(suggestion): better code with reviews, normalize Champs::EmailChamp.value, simplier default strict validation activation
Co-authored-by: Colin Darie <colin@darie.eu>
2024-02-15 16:41:00 +01:00
Martin
5f77c0cd06 feat(email.validation): expand email validation to Avis, ContactInformation, Invite, DossierTransfert 2024-02-15 16:41:00 +01:00
Martin
05193e1d1e feat(User.validation): validates email when env var is present 2024-02-15 16:41:00 +01:00
Martin
25f92a7760 feat(email.validator): define a strict email validator, validates Champs::EmailChamp.value only on validation context
Co-authored-by: Paul Chavard <github@paul.chavard.net>
2024-02-15 16:41:00 +01:00
Colin Darie
a650114671
test: fix flaky match_array test 2024-02-15 11:00:53 +01:00
Colin Darie
bd3c2c070a
Merge pull request #9957 from demarches-simplifiees/finalize-rna-rnf-ldu
ETQ instructeur et consommateur API, la vue du champ RNA est harmonisée avec le champ RNF
2024-02-14 15:30:54 +00:00
Paul Chavard
93635b3516 refactor(logic): compute sub champ values 2024-02-13 11:57:31 +01:00
Lisa Durand
f09ab62620
add rna type de champ to harmonize api with rnf 2024-02-12 17:20:07 +01:00
Colin Darie
ea89c2e8dd
fix(attestation): tag commune_name from address 2024-02-12 15:08:05 +01:00
Paul Chavard
23592087ae refactor(instructeur): use precomputed timestamps 2024-02-08 18:36:04 +01:00
Colin Darie
70e92f7c6b
Merge pull request #9903 from colinux/attestation-ux
ETQ admin, je peux tester l'attestation v2
2024-02-06 08:09:53 +00:00
seb-by-ouidou
c2c54083e8
feat: display tree structure of a group 2024-02-05 09:30:24 +01:00
Colin Darie
f7484eb0e5
feat(attestation): list tags errors and substitute missing tag by libelle 2024-02-02 13:05:09 +01:00
seb-by-ouidou
46c19014f9 feat: notify administrateur and gestionnaire by email when new commentaire + for administrateur highlight card and commentaires if any unread 2024-02-02 12:52:36 +01:00
Colin Darie
443e41a6ed
style(attestation): group tags by section 2024-02-01 18:55:52 +01:00
Colin Darie
40353fee04
feat(attestation): replace tags in preview for v2 2024-02-01 18:55:50 +01:00
seb-by-ouidou
f3cba9331d fix: improvement after review 2024-01-29 18:23:39 +01:00
seb-by-ouidou
6cd8b6d2df feat: for gestionnaire highlight card and commentaires if any unread 2024-01-29 18:23:39 +01:00
Eric Leroy-Terquem
6203b1fd05
Merge pull request #9879 from demarches-simplifiees/cleaning-conditional-and-routing-code
Tech : nettoyage du code conditionnel et routage
2024-01-29 13:43:52 +00:00
mfo
77ca3dd28a
Merge pull request #9922 from mfo/US/nplus_one_in_summary
perf(TypeDeChampEditor): faster
2024-01-29 10:58:05 +00:00
Martin
01752bc2e8 perf(ProcedureRevisionPreloader): preload revision quickly 2024-01-26 14:47:44 +01:00
Martin
ecc83edf4f wip 2024-01-26 13:43:10 +01:00
simon lehericey
d909e2c8ea add various expiring scopes to APIToken 2024-01-26 10:15:37 +01:00
Martin
0e5768ec5b fixup! perf(editor): better perf to add, destroy, update, move up, move down and move with number 2024-01-26 09:45:59 +01:00
simon lehericey
49f0caba7e fix(spec): flaky test 2024-01-25 11:17:44 +01:00
simon lehericey
6e5678d1c2 feature(api): add forbidden_network? to api_token 2024-01-25 10:51:58 +01:00
Martin
2952987ad8 refactor(spec): stop using procedure type de champs traits as :with_datetime, :with_xxx in favor of :types_de_champ_public which keeps position in check 2024-01-23 17:30:22 +01:00
Colin Darie
716e4bbe5d
Merge pull request #9645 from adullact/feature-ouidou/admin_creation_delegation_gestionnaire_answer_administrateur
Feature ouidou/admin creation delegation gestionnaire answer administrateur
2024-01-22 15:45:58 +00:00
Martin
0f194a5e8e refactor(procedure_revision): without renumber, use types_de_champ_public factory for ordered champs 2024-01-22 14:57:04 +01:00
Martin
434cd77030 poc(spec): renumber only at one point 2024-01-22 14:57:04 +01:00
Martin
a9c0d3e7e9 tech(clean): avoid useless indirection, cleanup some code complexity, rubocopify 2024-01-22 14:57:04 +01:00
Martin
4d97c5bc8a feat(move_type_de_champ): stop renumbering all procedure_revision_type_de_champ on move_type_de_champ 2024-01-22 14:57:04 +01:00
Martin
4b57ed871a feat(add_type_de_champ): stop renumbering all procedure_revision_type_de_champ 2024-01-22 14:57:04 +01:00
seb-by-ouidou
a6ca4b668e feat: answer message to administrateur as gestionnaire 2024-01-22 14:36:38 +01:00
seb-by-ouidou
c45e2eaccc feat: write message to gestionnaires as administrateur 2024-01-09 13:25:04 +01:00
mfo
a0248bf08b
Merge pull request #9888 from mfo/US/validate-epci-by-code
Correctif: Le noms des EPCIs changent, ce qui bloque la validation et ou demande a resaisir le champs
2024-01-08 09:56:09 +00:00
Martin
fa07c21ec3 fix(champs.epci): epci names change over time. remap when it occurs 2024-01-04 07:17:15 +01:00
Eric Leroy-Terquem
547a4d95b7 chore(logic): commune and epci champs are always compute with compute_value_json 2023-12-22 10:57:53 +01:00
Colin Darie
6f7d786783
Merge pull request #9880 from demarches-simplifiees/api_token_store_last_used_ips
API: stocke les ips utilisées pour accéder à l'API
2023-12-21 16:18:00 +00:00
Eric Leroy-Terquem
4c82f2c9d7 fix(champ value): fix compute_value_json on departement champ 2023-12-21 16:21:08 +01:00
simon lehericey
afb6eacf57 feature(api): store any ip used 2023-12-21 16:02:11 +01:00
Colin Darie
9bdf525ff1
Merge pull request #9863 from colinux/fix-message-html-injection
Tech: échappe les tags de données utilisateur dans les modèles pour email
2023-12-21 08:50:21 +00:00
Colin Darie
29df9ad09d
Merge pull request #9751 from tchak/departement-tags
feat(champs): expose more tags and api fields on rnf, address and commune
2023-12-21 08:45:01 +00:00
Eric Leroy-Terquem
954facdaff
Merge pull request #9798 from demarches-simplifiees/add-new-operators-to-conditional
Etq admin je peux conditionner/router avec les opérateurs "est dans mon département",  "n'est pas dans mon département",  "est dans ma région" et   "n'est pas dans ma région".
2023-12-19 16:10:59 +00:00
Colin Darie
1a56fe620e feat(correction): make pending corrections blocking by feature flag only 2023-12-18 14:12:45 +01:00
Colin Darie
fa37c6c62b
fix(tags): escape user data tags for emails 2023-12-15 14:05:11 +01:00
Lisa Durand
569d4af6f7
Merge pull request #9706 from demarches-simplifiees/feat/9678
ETQ usager passant par un mandataire, je suis notifié des changements d'état de mon dossier par email
2023-12-14 16:57:07 +00:00
Eric Leroy-Terquem
e40d1107ac chore(conditional): add not_in_departement and not_in_region operators 2023-12-14 17:48:14 +01:00
Eric Leroy-Terquem
c9676020b4 chore(conditional): add in_departement and in_region operators 2023-12-14 17:48:13 +01:00
Kara Diaby
303230dd1d Add new testss 2023-12-12 22:35:11 +00:00
Colin Darie
7c38cbcab3
test: fix random failing test 2023-12-12 15:05:48 +01:00
Colin Darie
c0771ad903
fix(dossier): passe en instruction with auto-archive even with pending correction 2023-12-12 15:05:46 +01:00
Colin Darie
c26b59722d
feat(instructeur): pending correction blocks passer en instruction
Closes #9731
2023-12-12 15:05:44 +01:00
Colin Darie
f9c4846fde
Merge pull request #9571 from adullact/feature-ouidou/admin_creation_delegation_gestionnaire_page_group_administrateur_management
Feature ouidou/admin creation delegation gestionnaire page group administrateur management
2023-12-12 10:41:28 +00:00
Martin
f26a4bc041 amelioration(delai.traitement): revoie l'affichage du delais d'instruction
Co-authored-by: Colin Darie <colin@darie.eu>
2023-12-07 09:19:52 +01:00
Martin
474fde3380 amelioration(procedure.usual_traitement_time_for_recent_dossiers): divise en 3 groupe l'estimation de la duree de traitement 2023-12-07 09:19:52 +01:00
seb-by-ouidou
e34307b50c fix: fixes after review 2023-12-06 14:47:39 +01:00
seb-by-ouidou
564c3c04fa feat: US4.3.8 administrateur management 2023-12-06 14:47:39 +01:00
Christophe Robillard
961c7c5be4 fix format for motivation in notification mail 2023-12-05 18:50:50 +01:00
mfo
d90c55c29e
Merge pull request #9762 from tchak/fix-email-template
fix(email_template): less magic - less bugs !
2023-12-05 09:56:53 +00:00
mfo
dbfbaf4cea
Merge pull request #9757 from mfo/US/fix-extends-duree-conservation-dossier
correctif(expiration): etends la durée de conservation des dossiers quand la duree de conservation d'une procedure change
2023-12-04 09:18:45 +00:00
Colin Darie
42ea9ed2f3 perf(preloader): fix N+1 on non mandatory repetition blocks
We have to tell repetition.champs association has been loaded
even when it's empty.
2023-11-30 14:10:33 +01:00
Paul Chavard
3de0367ed9 fix(email_template): less magic - less bugs ! 2023-11-29 20:36:44 +00:00
Martin
57d7b385ec correctif(expiration): etends la durée de conservation des dossiers quand la duree de conservation d'une procedure change 2023-11-28 16:59:41 +01:00
Colin Darie
64400b512c
Merge pull request #9677 from govpf/feature-ouidou/clone_procedure_with_feature_flags
ETQ admin, les procédures clonées conservent les features flags
2023-11-28 08:21:02 +00:00
Paul Chavard
bfc809f96f feat(champs): expose more tags and api fields on rnf, address and commune 2023-11-27 15:33:05 +00:00
seb-by-ouidou
c4ca381bed feat: enable features on cloned procedure 2023-11-27 12:00:27 +01:00
Colin Darie
3b9285a00b
perf(procedure): description view caching 2023-11-27 11:29:20 +01:00
Colin Darie
5d747ba0c2
fix(procedure): list piece justificative in repetitions 2023-11-27 11:08:39 +01:00
mfo
78f9a2aa1e
Merge pull request #9737 from demarches-simplifiees/9670-export-rnf
En tant qu'instructeur, je peux exporter les données RNF des dossiers
2023-11-23 08:19:00 +00:00
Eric Leroy-Terquem
d92155a96a
Merge pull request #9714 from demarches-simplifiees/add-not-include-operator
ETQ admin je peux conditionner / router à partir d'un champ de type choix multiple avec l'opérateur "Ne contient pas"
2023-11-22 16:29:24 +00:00
Eric Leroy-Terquem
a54d55486c chore(routing): update routing_rule validation 2023-11-22 13:01:44 +01:00
Christophe Robillard
daa4c28af7 add data from rnf field to export 2023-11-22 12:20:05 +01:00
Paul Chavard
4842fc4d94 feat(tags): all tags should have ids 2023-11-21 13:55:25 +01:00
Colin Darie
f972d36f2f test: fix when using timestamps not yet limited by postgresql precision
Sur des colonnes dont le schema ne connait pas le niveau de précision
(créées avant rails 7), rails créé un timestamp avec la précision système
(par exemple 9 décimales sur linux) alors que pg va l'arrondir
a posteriori à 6.

Ce n'est généralement pas un problème en production,
mais se révèle dans les tests typiquement avec des objets crées
par des factories: si un test dépend de ces timestamps,
il faut récupérer la valeur limitée par pg (d'où le reload),
plutôt que celle directement issue de Time.now à la création de l'objet.

Une alternative aurait été de créer une migration pour ces colonnes pour
forcer la précision à 6 et que le schema en aurait pris connaissance:
rails limiterait la précision de lui même dès la création de l'objet.
2023-11-20 11:22:28 +01:00