Martin
2952987ad8
refactor(spec): stop using procedure type de champs traits as :with_datetime, :with_xxx in favor of :types_de_champ_public which keeps position in check
2024-01-23 17:30:22 +01:00
mfo
15e0ed8480
Merge pull request #9927 from mfo/fix-flacky-type-de-champ-template
...
fix(spec.flacky): ./spec/system/administrateurs/types_de_champ_spec.rb:272 was flacky, try to fix it
2024-01-22 17:10:37 +00:00
Colin Darie
716e4bbe5d
Merge pull request #9645 from adullact/feature-ouidou/admin_creation_delegation_gestionnaire_answer_administrateur
...
Feature ouidou/admin creation delegation gestionnaire answer administrateur
2024-01-22 15:45:58 +00:00
Martin
2fa59076f9
fix(spec.flacky): ./spec/system/administrateurs/types_de_champ_spec.rb:272 was flacky, try to fix it
2024-01-22 15:50:38 +01:00
Martin
0f194a5e8e
refactor(procedure_revision): without renumber, use types_de_champ_public factory for ordered champs
2024-01-22 14:57:04 +01:00
Martin
5c049a1c0f
feat(update_draft_revision_type_de_champs_task): force to use real position otherwise have to process parent_coordinates...
2024-01-22 14:57:04 +01:00
Martin
434cd77030
poc(spec): renumber only at one point
2024-01-22 14:57:04 +01:00
Martin
a9c0d3e7e9
tech(clean): avoid useless indirection, cleanup some code complexity, rubocopify
2024-01-22 14:57:04 +01:00
Martin
4d97c5bc8a
feat(move_type_de_champ): stop renumbering all procedure_revision_type_de_champ on move_type_de_champ
2024-01-22 14:57:04 +01:00
Martin
4b57ed871a
feat(add_type_de_champ): stop renumbering all procedure_revision_type_de_champ
2024-01-22 14:57:04 +01:00
seb-by-ouidou
a6ca4b668e
feat: answer message to administrateur as gestionnaire
2024-01-22 14:36:38 +01:00
seb-by-ouidou
8d8feedff0
fix: group "it" test
2024-01-22 14:36:38 +01:00
seb-by-ouidou
e6474f0d14
feat: US4.3.9 children management
2024-01-22 14:36:38 +01:00
seb-by-ouidou
96dd6bec52
feat: US4.3 update and delete groupe gestionnaire
2024-01-22 14:36:38 +01:00
Colin Darie
7892b54aa6
fix(discarded-dossiers): don't crash whole job when a single dossier causes an error
2024-01-17 13:15:42 +01:00
Colin Darie
1a8f839a7e
Merge pull request #9915 from colinux/fix-admin-memory-leak
...
Perf: remplace les `OpenStruct` par des objets plus performants
2024-01-17 08:59:01 +00:00
Colin Darie
a4db911585
perf(admin): remove 2 useless zones queries on each admin page due to navigation
2024-01-16 19:43:58 +01:00
Colin Darie
a0e64151d5
test: replace OpenStruct by model expected
2024-01-16 19:43:24 +01:00
Lisa Durand
d9b75ce0a2
Merge pull request #9882 from demarches-simplifiees/add-dossier-reference-in-transfer-email
...
Je veux que le numéro du dossier apparaisse dans l'email de demande de transfert
2024-01-15 15:39:09 +00:00
mfo
0328446bee
Merge pull request #9861 from demarches-simplifiees/US/move-type-de-champ-with-select
...
ETQ administrateur, je peux deplacer un champ via un select
2024-01-15 13:09:56 +00:00
Martin
69346ad41f
tech(review): implement some pair review suggestions
2024-01-12 11:00:29 +01:00
Colin Darie
8a83fd2ce0
fix(recherche): show notification indicator for instructeurs
2024-01-12 10:09:34 +01:00
Martin
e7eee7ba72
spec(move_and_morph): add some spec and lint with rubocop/haml/eslint
2024-01-11 16:12:09 +01:00
Martin
857a1fc496
fix(select_champ_position): rewire for more robust and easier implementation which work with repetition avoiding double submit
2024-01-11 16:01:24 +01:00
Martin
11de4bdfb6
feat(types_de_champ_editor.ts): wires move_and_morph with type de champs editor [for now, the select is empty and will be synced]
2024-01-11 16:01:24 +01:00
simon lehericey
e12dbe7aad
use email_merge_token in email merge
2024-01-11 11:33:38 +01:00
simon lehericey
ca08b80c3e
use email_merge_token in mailer
2024-01-11 11:33:38 +01:00
simon lehericey
fca28a3ebd
use email_merge_token in mail_merge_with_existing_account route
2024-01-11 11:33:38 +01:00
simon lehericey
65aa07ecbe
the merge_token issued for password check can be reused for the confirmation by email route
...
Thus by passing the password check or the email possession check
2024-01-11 11:33:38 +01:00
seb-by-ouidou
210df8a418
feat: review test after view component upgrade
2024-01-09 13:25:04 +01:00
seb-by-ouidou
c45e2eaccc
feat: write message to gestionnaires as administrateur
2024-01-09 13:25:04 +01:00
simon lehericey
f96347caad
fix(spec): another way to mock current_user
2024-01-08 14:30:19 +01:00
mfo
a0248bf08b
Merge pull request #9888 from mfo/US/validate-epci-by-code
...
Correctif: Le noms des EPCIs changent, ce qui bloque la validation et ou demande a resaisir le champs
2024-01-08 09:56:09 +00:00
Martin
fa07c21ec3
fix(champs.epci): epci names change over time. remap when it occurs
2024-01-04 07:17:15 +01:00
mfo
9df978f6fa
Merge pull request #9887 from mfo/US/fix-fci-missing-device-callback
...
Correctif: ETQ usager invité, lorsque je crée mon compte via FC, je ne retrouve pas mes invitations
2024-01-04 06:15:14 +00:00
Martin
4073804b00
feat(administrateurs/types_de_champ_controller#move_and_morph): add action to move and morph fields between two coordinates
2024-01-03 11:08:53 +01:00
Martin
92730e266b
fix(FranceConnect): missing after_confirmation callback, leading to invalites invitations when user france connect
2023-12-26 15:00:15 +01:00
Eric Leroy-Terquem
24563a3c18
fix(personnes impliquees): display reaffectations block only if procedure is routed
2023-12-22 10:57:53 +01:00
Eric Leroy-Terquem
547a4d95b7
chore(logic): commune and epci champs are always compute with compute_value_json
2023-12-22 10:57:53 +01:00
Colin Darie
deab400057
Merge pull request #9578 from adullact/feature-ouidou/admin_creation_delegation_administrateur_pages
...
Feature ouidou/admin creation delegation administrateur pages
2023-12-22 09:06:58 +00:00
mfo
c4adee6278
Merge pull request #9878 from mfo/US/fix-not-type-ej-in-api
...
API: cast le type de champ EJ
2023-12-22 07:20:13 +00:00
seb-by-ouidou
c253e7dd65
feat: US5.1 US5.2 administrateur in admin
2023-12-21 18:40:36 +01:00
Colin Darie
6f7d786783
Merge pull request #9880 from demarches-simplifiees/api_token_store_last_used_ips
...
API: stocke les ips utilisées pour accéder à l'API
2023-12-21 16:18:00 +00:00
Lisa Durand
ff284a1c96
add more info in notify transfer email
2023-12-21 16:58:33 +01:00
Martin
989a7ba787
feat(API): cast type de champ EJ in a dedicated graphql type
2023-12-21 16:21:31 +01:00
Eric Leroy-Terquem
4c82f2c9d7
fix(champ value): fix compute_value_json on departement champ
2023-12-21 16:21:08 +01:00
simon lehericey
afb6eacf57
feature(api): store any ip used
2023-12-21 16:02:11 +01:00
Colin Darie
9bdf525ff1
Merge pull request #9863 from colinux/fix-message-html-injection
...
Tech: échappe les tags de données utilisateur dans les modèles pour email
2023-12-21 08:50:21 +00:00
Colin Darie
29df9ad09d
Merge pull request #9751 from tchak/departement-tags
...
feat(champs): expose more tags and api fields on rnf, address and commune
2023-12-21 08:45:01 +00:00
Colin Darie
e17c3bd046
Merge pull request #9839 from mfo/US/fix-filter-focus-out-with-not-selected-filter
...
correctif : ETQ instructeurs, lorsque je sors du composant de filtrage sans choisir une option, le site renvoie une erreur
2023-12-21 08:42:12 +00:00
Colin Darie
535a54ce97
Merge pull request #9874 from demarches-simplifiees/add-email-for-tiers-when-repasser-en-instruction-ldu
...
[Co-construction] Envoyer un mail au bénéficiaire si le dossier repasse en instruction
2023-12-21 08:32:10 +00:00
Lisa Durand
3e872c5246
add email for tiers when repasser en instruction
2023-12-20 11:51:02 +01:00
Lisa Durand
e52bd9d6bf
Merge pull request #9855 from demarches-simplifiees/display-last-export-in-same-page-ldu
...
ETQ instructeur, j'ai besoin d'un accès très facile à mondernier export
2023-12-20 10:02:08 +00:00
Eric Leroy-Terquem
882d72d139
data(conditional): add a maintenance task to update conditions based on commune or epci champ
2023-12-19 17:39:40 +01:00
Eric Leroy-Terquem
e4632214fb
data(conditional): add a maintenance task to update routing rules based on commune or epci champ
2023-12-19 17:39:39 +01:00
Eric Leroy-Terquem
954facdaff
Merge pull request #9798 from demarches-simplifiees/add-new-operators-to-conditional
...
Etq admin je peux conditionner/router avec les opérateurs "est dans mon département", "n'est pas dans mon département", "est dans ma région" et "n'est pas dans ma région".
2023-12-19 16:10:59 +00:00
Lisa Durand
e6a4459633
refacto
2023-12-19 16:54:23 +01:00
Lisa Durand
f553f3c408
Merge pull request #9872 from demarches-simplifiees/add-badge-for-role-ldu
...
ETQ utilisateur avec plusieurs rôles, je m'y retrouve plus facilement
2023-12-19 11:01:28 +00:00
mfo
e75c4456e8
Merge pull request #9871 from mfo/US/add-pj-to-explication
...
ETQ administrateur, je peux ajouter une notice explicative a un champs explication
2023-12-19 10:44:03 +00:00
Lisa Durand
c767164e28
add expert in current_account and mode badge to the right
2023-12-19 11:33:48 +01:00
Lisa Durand
0286d2b6fb
add profiles in flash after sign-in if multiple profile
2023-12-19 10:33:26 +01:00
Martin
37e8772eab
feat(type_de_champ_editor.explication): add a Attached::One to TypeDeChamp.explication, named notice_explicative [cf, cerfa wording]
2023-12-19 09:52:27 +01:00
Colin Darie
e9ee405954
Merge pull request #9868 from colinux/blocking-pending-correction-ff
...
ETQ instructeur je peux de nouveau passer en correction un dossier avec corrections en attente
2023-12-18 13:29:39 +00:00
Colin Darie
1a56fe620e
feat(correction): make pending corrections blocking by feature flag only
2023-12-18 14:12:45 +01:00
Lisa Durand
53f9f3cbdb
add trad if export failed
2023-12-18 14:09:47 +01:00
Lisa Durand
a9ab1daf3a
display alert only for instructeur who generated the export and if recent
2023-12-18 11:25:52 +01:00
simon lehericey
9bb89f7e3e
fix(print): missing dossier var
2023-12-18 09:51:41 +01:00
Colin Darie
fa37c6c62b
fix(tags): escape user data tags for emails
2023-12-15 14:05:11 +01:00
Colin Darie
c0b444d747
Merge pull request #9847 from colinux/fix-style
...
Style: plusieurs améliorations mineures / thème sombre
2023-12-15 12:00:53 +00:00
Martin
d27e4fc693
amelioration(combobox): permet de passer des options au input[type=hidden], utilise cette option pour autosubmit uniquement un input [dans notre cas, ne soumet pas a l'input du combobox, mais a l'input hidden une fois le combobox selectionné]
2023-12-15 11:23:25 +01:00
Colin Darie
7ba13507ff
Merge pull request #9808 from colinux/remove-usager-antivirus
...
ETQ usager, je ne vois plus le statut "antivirus en cours" lorsque j'envoie un PJ
2023-12-14 19:53:34 +00:00
Colin Darie
9a5d908851
Merge pull request #9853 from mfo/US/fix-expert-link-to-dossiers
...
ETQ expert: lorsque je me connecte, je suis redirigé vers la page des avis, non pas vers la page de mes dossiers
2023-12-14 19:52:32 +00:00
Colin Darie
3b0e4e59d5
Merge pull request #9858 from colinux/fix-invite-html-injection
...
Tech: sanitize les messages utilisateurs dans les emails
2023-12-14 17:27:28 +00:00
Lisa Durand
569d4af6f7
Merge pull request #9706 from demarches-simplifiees/feat/9678
...
ETQ usager passant par un mandataire, je suis notifié des changements d'état de mon dossier par email
2023-12-14 16:57:07 +00:00
Eric Leroy-Terquem
2e547cd46f
chore(routing): cannot create simple_routing with champs communes or epcis
2023-12-14 17:48:14 +01:00
Eric Leroy-Terquem
e40d1107ac
chore(conditional): add not_in_departement and not_in_region operators
2023-12-14 17:48:14 +01:00
Eric Leroy-Terquem
c9676020b4
chore(conditional): add in_departement and in_region operators
2023-12-14 17:48:13 +01:00
Martin
1307e7262f
amelioration(application_controller.roles): intègre aussi le role d'expert aux logs
2023-12-14 14:52:50 +01:00
Colin Darie
fd7839773b
fix(email): sanitize user message
2023-12-14 12:51:56 +01:00
Martin
6def2609f1
amelioration(liens-suivis): persiste la page a laquelle il doit etre redirigé apres une connexion
2023-12-14 10:47:04 +01:00
Martin
4380fecd73
amelioration(expert.sign-in): ETQ expert, je suis redirigé vers la page listant les avis a donner ap connexion
2023-12-14 10:47:04 +01:00
Lisa Durand
2f1259709a
fix email content
2023-12-14 10:01:13 +01:00
Eric Leroy-Terquem
57b6522536
data(geo): update api_geo_data take task to store region_code in departements and communes json
2023-12-14 09:36:50 +01:00
Colin Darie
c76213cb87
fix(users): don't show procedures filter when there are not enough procedures
2023-12-13 18:03:22 +01:00
Colin Darie
01d12c9bb4
Merge pull request #9840 from colinux/maintenance-task-update-tdc
...
ETQ superadmin je peux mettre à jour le brouillon d'une révision à partir d'un CSV
2023-12-13 10:15:41 +00:00
Colin Darie
715c800788
Merge pull request #9821 from colinux/en-attente-block-instruction
...
ETQ instructeur je ne peux pas passer en instruction un dossier en attente de correction
2023-12-13 10:02:32 +00:00
Kara Diaby
57dfe2b0f6
Améliorations après retours PR
2023-12-13 09:21:09 +00:00
Lisa Durand
878f58e00c
add mailer test
2023-12-12 22:35:11 +00:00
Lisa Durand
43f5f4e030
fix test
2023-12-12 22:35:11 +00:00
Kara Diaby
303230dd1d
Add new testss
2023-12-12 22:35:11 +00:00
Lisa Durand
d0e2f281cc
fix tests
2023-12-12 22:35:11 +00:00
Lisa Durand
f6f18e9c86
send email to tiers if notification by email is set
2023-12-12 22:35:11 +00:00
krichtof
246d53fa99
Merge pull request #9754 from demarches-simplifiees/9435-transfer-dossier
...
En tant que superadmin, je peux transférer un dossier d'un utilistateur à un autre
2023-12-12 14:44:39 +00:00
Christophe Robillard
122a6b6f5b
revoke superadmin dossier transfer
2023-12-12 15:25:39 +01:00
Colin Darie
7c38cbcab3
test: fix random failing test
2023-12-12 15:05:48 +01:00
Colin Darie
c0771ad903
fix(dossier): passe en instruction with auto-archive even with pending correction
2023-12-12 15:05:46 +01:00
Colin Darie
3d21262e89
test(declarative): clarify intention with pending correction & declarative procedure
2023-12-12 15:05:45 +01:00
Colin Darie
c26b59722d
feat(instructeur): pending correction blocks passer en instruction
...
Closes #9731
2023-12-12 15:05:44 +01:00
Colin Darie
f9c4846fde
Merge pull request #9571 from adullact/feature-ouidou/admin_creation_delegation_gestionnaire_page_group_administrateur_management
...
Feature ouidou/admin creation delegation gestionnaire page group administrateur management
2023-12-12 10:41:28 +00:00
Colin Darie
6a2e68b697
feat(admin): task removing type de champ from draft revision from a csv
2023-12-11 19:04:49 +01:00
