8709153973
Nix internally differentiates between lambdas and primops, but their type in the nix expression language is the same (lambda). The implementation of builtins.functionArgs only checks if the given expression is of type tLambda and fails if the type is tPrimop or tPrimopApp which are also functions. This most notably breaks lib.generators.toPretty when called on a builtin making for example yants fail if a primop is typechecked and an error message is generated. This fix generates an empty set for primops like for plain lambdas and is based upstream commit b2748c6e99239ff6803ba0da76c362790c8be192. Additionally we add to two tests: * eval-okay-functionargs now includes a few test cases checking that builtins.functionArgs always returns an empty set for builtins and also works as expected for normal functions. * eval-okay-types now also checks if builtins are functions. Future work would be to make builtins.functionArgs work as users would expect for builtins like builtins.fetchurl, builtins.fetchGit etc. which take a set as an argument. These currently don't register as formal arguments, but it would be an usability improvement at least if they did. See also https://github.com/NixOS/nix/pull/3626#issuecomment-698546704 Change-Id: I2bf4cb80d44a4b72ade13d3e0dbd7dfb1d049f32 Reviewed-on: https://cl.tvl.fyi/c/depot/+/2477 Tested-by: BuildkiteCI Reviewed-by: Profpatsch <mail@profpatsch.de> Reviewed-by: glittershark <grfn@gws.fyi> |
||
|---|---|---|
| .. | ||
| abseil_cpp | ||
| alsi | ||
| apereo-cas | ||
| bat_syntaxes | ||
| bufbuild | ||
| cgit | ||
| cpp/googleapis | ||
| emacs | ||
| farmhash | ||
| ffmpeg | ||
| gerrit | ||
| gerrit_plugins | ||
| git | ||
| git-bug | ||
| gitignoreSource | ||
| glog | ||
| gopkgs | ||
| grpc | ||
| gtest | ||
| haskell-language-server | ||
| irccat | ||
| kernelPatches/trx40_usb_audio | ||
| lieer | ||
| lisp | ||
| naersk | ||
| nix | ||
| nixery | ||
| nixpkgs-exposed | ||
| notmuch | ||
| nsfv | ||
| openldap | ||
| protobuf | ||
| python/broadlink | ||
| rapidcheck | ||
| rr | ||
| smtprelay | ||
| telega | ||
| terraform-gcp | ||
| default.nix | ||
| README.md | ||
Third-Party Code
Code under this folder is one of the following:
-
Externally developed dependencies which have been imported ("vendored") into this repository. These dependencies come with their own licenses and whatever else.
-
Code that is developed inside of this repository, but released to an external repository via Copybara.