No description
Find a file
sterni 8709153973 fix(tvix/libexpr): backport fix for functionArgs failing on primops
Nix internally differentiates between lambdas and primops, but their
type in the nix expression language is the same (lambda). The
implementation of builtins.functionArgs only checks if the given
expression is of type tLambda and fails if the type is tPrimop or
tPrimopApp which are also functions. This most notably breaks
lib.generators.toPretty when called on a builtin making for example
yants fail if a primop is typechecked and an error message is
generated.

This fix generates an empty set for primops like for plain lambdas
and is based upstream commit b2748c6e99239ff6803ba0da76c362790c8be192.

Additionally we add to two tests:

* eval-okay-functionargs now includes a few test cases checking that
  builtins.functionArgs always returns an empty set for builtins and
  also works as expected for normal functions.
* eval-okay-types now also checks if builtins are functions.

Future work would be to make builtins.functionArgs work as users would
expect for builtins like builtins.fetchurl, builtins.fetchGit etc. which
take a set as an argument. These currently don't register as formal
arguments, but it would be an usability improvement at least if they
did.

See also https://github.com/NixOS/nix/pull/3626#issuecomment-698546704

Change-Id: I2bf4cb80d44a4b72ade13d3e0dbd7dfb1d049f32
Reviewed-on: https://cl.tvl.fyi/c/depot/+/2477
Tested-by: BuildkiteCI
Reviewed-by: Profpatsch <mail@profpatsch.de>
Reviewed-by: glittershark <grfn@gws.fyi>
2021-02-02 10:52:33 +00:00
bin chore(tazjin/aoc2019): Move out of //fun 2020-12-01 12:55:59 +00:00
docs feat(todolist): use static slapd user data for knownUsers 2021-01-18 23:18:55 +00:00
fun chore(tazjin/aoc2019): Move out of //fun 2020-12-01 12:55:59 +00:00
lisp feat(klatre): support offsets in format-dottime 2021-01-25 20:09:21 +00:00
net chore(net): Remove mushroom 2020-08-26 22:21:10 +00:00
nix feat(nix): add nix.tag, a way of discriminating via tagged unions 2021-01-30 15:41:08 +00:00
ops fix(ops/piplines/static-pipeline): add --show-trace to nix-build 2021-01-30 09:02:09 +00:00
overrides chore(writeElispBin): Move from //overrides to //nix 2020-12-01 12:55:59 +00:00
third_party fix(tvix/libexpr): backport fix for functionArgs failing on primops 2021-02-02 10:52:33 +00:00
tools feat(gerrit-update): Add helper script for updating Gerrit schema 2020-11-29 11:50:58 +00:00
users feat(users/Profpatsch): add die_* helpers for semantic exit errors 2021-01-31 16:06:25 +00:00
web fix(panettone): handle missing DNs when looking up displaynames 2021-01-29 17:38:41 +00:00
.envrc chore: Unfuck NIX_PATH in the .envrc 2020-06-15 16:50:44 +00:00
.git-blame-ignore-revs chore: Add an ignoreRevsFile for git blame 2020-05-19 22:18:53 +01:00
.gitignore chore(gitignore): Ignore garbage/ folder 2019-12-20 20:05:40 +00:00
.hgignore chore(hgignore): ignore .git for hg 2020-06-14 18:23:13 +00:00
.mailmap chore(mailmap): add my name to mailmap 2020-07-18 18:15:05 +00:00
.rgignore chore: Only exclude //third_party/git from ripgrep 2020-05-17 23:58:22 +01:00
.rustfmt.toml feat: Add rustfmt configuration for the whole depot 2020-08-02 21:57:35 +00:00
buf.yaml feat(buf.yaml): add protobuf linter config 2020-07-17 20:01:29 +00:00
default.nix feat(ci): Add subtarget support for builds 2020-08-31 23:14:11 +00:00
LICENSE chore: Keep project root under MIT license 2019-06-28 22:56:48 +01:00
OWNERS feat: Configure OWNERS file for the depot root 2020-06-14 15:41:55 +00:00
README.md docs: Update README for the repository itself 2020-08-17 21:52:58 +00:00
RULES docs: Add the RULE 2020-08-06 00:23:13 +00:00

depot

Build status

This repository is the monorepo for the community around tazjin's virus lounge, containing our personal tools and infrastructure. Everything in here is built using Nix.

A large portion of the software here is very self-referential, meaning that it exists to sustain the operation of the repository. This is the case because we partially see this as an experiment in tooling for monorepos.

If you've ended up here and have no idea who I am, feel free to follow me on Twitter.

Highlights

Services

  • Source code is available primarily through Sourcegraph on cs.tvl.fyi, where it is searchable and even semantically indexed. A lower-tech view of the repository is also available via cgit on code.tvl.fyi.

    The repository can be cloned using git from https://cl.tvl.fyi/depot.

  • All code in the depot, with the exception of code that is checked in to individual //users folders, needs to be reviewed. We use Gerrit on cl.tvl.fyi for this.

  • Issues are tracked via our own issue tracker on b.tvl.fyi. Its source code lives at //web/panettone/.

  • Smaller todo-list entries which do not warrant a separate issue are listed at todo.tvl.fyi.

  • We use Buildkite for CI. Recent builds are listed on tvl.fyi/builds and pipelines are configured dynamically via //ops/pipelines.

All services that we host are deployed on NixOS machines that we manage. Their configuration is tracked in //ops/nixos.

Nix

  • //third_party/nix contains Tvix, our fork of the Nix package manager
  • //nix/readTree contains the Nix code which automatically registers projects in our Nix attribute hierarchy based on their in-tree location
  • //nix/yants contains Yet Another Nix Type System, which we use for a variety of things throughout the repository
  • //nix/buildGo implements a Nix library that can build Go software in the style of Bazel's rules_go. Go programs in this repository are built using this library.
  • //nix/buildLisp implements a Nix library that can build Common Lisp software. Currently only SBCL is supported. Lisp programs in this repository are built using this library.

We have a variety of other tools and libraries in the //nix folder which may be of interest.

Packages / Libraries

  • //net/alcoholic_jwt contains an easy-to-use JWT-validation library for Rust
  • //net/crimp contains a high-level HTTP client using cURL for Rust
  • //tools/emacs-pkgs contains various useful Emacs libraries, for example:
    • dottime.el provides dottime in the Emacs modeline
    • nix-util.el provides editing utilities for Nix files
    • term-switcher.el is an ivy-function for switching between vterm buffers
    • tvl.el provides helper functions for interacting with the TVL monorepo
  • //lisp/klatre provides a grab-bag utility library for Common Lisp

User packages

Contributors to the repository have user directories under //users, which can be used for personal or experimental code that does not require review.

Some examples:

  • //users/tazjin/homepage && //users/tazjin/blog: A Nix-based static site generator which generates the web page and Atom feed for tazj.in
  • //users/tazjin/finito: A persistent finite-state machine library for Rust.
  • //users/glittershark/xanthous: A (WIP) TUI RPG, written in Haskell.
  • //users/tazjin/emacs: tazjin's Emacs & EXWM configuration

Licensing

Unless otherwise stated in a subdirectory, all code is licensed under the MIT license. See LICENSE for details.

Contributing

If you'd like to contribute to any of the tools in here, please check out the contribution guidelines and our code of conduct.