mdebray/tvl-depot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

docs(docs/REVIEWS): explain disadvantages of patch submission

Browse source 
There's been some patch submissions gone wrong recently, and piling up
in Gerrit. Describe a bit more why patch submission via email is less
convenient for both sides.

Change-Id: I9dfb5e912511a8b5b828f443c25d5cf36ec5acea
Reviewed-on: https://cl.tvl.fyi/c/depot/+/9089
Tested-by: BuildkiteCI
Autosubmit: flokli <flokli@flokli.de>
Reviewed-by: tazjin <tazjin@tvl.su>
Reviewed-by: raitobezarius <tvl@lahfa.xyz>
This commit is contained in:
Florian Klink 2023-08-19 13:17:02 +02:00 committed by clbot
parent 778bd6894b
commit 387a743944
1 changed files with 15 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
docs/REVIEWS.md
View file

@ -138,9 +138,22 @@ instance, follow these instructions:
5. Submit the commit via email (see below). 5. Submit the commit via email (see below).
## Submitting changes via email ## Submitting changes via email
Please keep in mind this process is more complicated and requires more work from
both sides:
You can submit a patch via email to `depot@tvl.su` and it will be - Someone needs to relay potential comments from Gerrit to you, you won't get
added to Gerrit by a contributor. emails from Gerrit.
- Uploading new revisions needs to be done by the person sending it to Gerrit
on your behalf.
- If you decide to get a Gerrit account later on, existing CLs need to be
abandoned and recreated (as CLs can't change Owner).
This causing earlier reviews do be more disconnected, causing more churn.
We provide local accounts and do SSO with various third-parties, so getting the
account should usually be low-friction.
If you still decide differently, you can submit a patch via email to
`depot@tvl.su` and it will be added to Gerrit by a contributor.
Create an appropriate commit locally and send it us using either of these options: Create an appropriate commit locally and send it us using either of these options: