From 387a743944d72978db2d1c4f449cbbce76b7835f Mon Sep 17 00:00:00 2001 From: Florian Klink Date: Sat, 19 Aug 2023 13:17:02 +0200 Subject: [PATCH] docs(docs/REVIEWS): explain disadvantages of patch submission There's been some patch submissions gone wrong recently, and piling up in Gerrit. Describe a bit more why patch submission via email is less convenient for both sides. Change-Id: I9dfb5e912511a8b5b828f443c25d5cf36ec5acea Reviewed-on: https://cl.tvl.fyi/c/depot/+/9089 Tested-by: BuildkiteCI Autosubmit: flokli Reviewed-by: tazjin Reviewed-by: raitobezarius --- docs/REVIEWS.md | 17 +++++++++++++++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/docs/REVIEWS.md b/docs/REVIEWS.md index 930a15c8e..63d6b2c52 100644 --- a/docs/REVIEWS.md +++ b/docs/REVIEWS.md @@ -138,9 +138,22 @@ instance, follow these instructions: 5. Submit the commit via email (see below). ## Submitting changes via email +Please keep in mind this process is more complicated and requires more work from +both sides: -You can submit a patch via email to `depot@tvl.su` and it will be -added to Gerrit by a contributor. + - Someone needs to relay potential comments from Gerrit to you, you won't get + emails from Gerrit. + - Uploading new revisions needs to be done by the person sending it to Gerrit + on your behalf. + - If you decide to get a Gerrit account later on, existing CLs need to be + abandoned and recreated (as CLs can't change Owner). + This causing earlier reviews do be more disconnected, causing more churn. + +We provide local accounts and do SSO with various third-parties, so getting the +account should usually be low-friction. + +If you still decide differently, you can submit a patch via email to +`depot@tvl.su` and it will be added to Gerrit by a contributor. Create an appropriate commit locally and send it us using either of these options: