catvayor lbailly
  • Joined on 2023-12-04
lbailly approved DGNum/colmena#14 2025-02-21 23:05:36 +01:00
add node aliases, optimized node eval

LGTM @rlahfa

lbailly commented on pull request DGNum/colmena#14 2025-02-21 22:11:46 +01:00
add node aliases, optimized node eval

in src/nix/hive/options.nix you should add

aliases = lib.mkOption {
  description = ''
    A list of aliases for the node.

    Can be used to select a node with another name.
lbailly commented on pull request DGNum/colmena#14 2025-02-21 22:08:27 +01:00
add node aliases, optimized node eval

no

lbailly commented on pull request DGNum/colmena#14 2025-02-21 22:03:28 +01:00
add node aliases, optimized node eval
lbailly commented on pull request DGNum/colmena#14 2025-02-21 21:59:45 +01:00
add node aliases, optimized node eval

Forgot to write the final comment: it just need to make aliases optional, to avoid the error

error:
       … while evaluating attribute 'ap01'

       … while evaluating attribute…
lbailly suggested changes for DGNum/colmena#14 2025-02-21 21:55:09 +01:00
add node aliases, optimized node eval
lbailly commented on pull request DGNum/colmena#14 2025-02-21 21:55:09 +01:00
add node aliases, optimized node eval

You can remove

lbailly commented on pull request DGNum/colmena#14 2025-02-21 21:55:09 +01:00
add node aliases, optimized node eval

they look good to me, no ?

lbailly commented on pull request DGNum/colmena#14 2025-02-21 21:39:05 +01:00
add node aliases, optimized node eval

I don't think it's necessary to change this, this over-engineering won't weight much and will make future development cleaner (if the invariant was invalidated for example).

lbailly pushed to main at lbailly/vxlan-router 2025-02-21 16:42:59 +01:00
70b06cb6ef feat: gateway
lbailly pushed to main at lbailly/vxlan-router 2025-02-21 16:26:47 +01:00
a4f6aa00de feat: gateway
lbailly pushed to main at lbailly/vxlan-router 2025-02-21 16:25:59 +01:00
50982af12d feat: gateway
lbailly commented on pull request DGNum/colmena#14 2025-02-21 10:56:45 +01:00
add node aliases, optimized node eval

(In syntactic analysis, !a&a is trivial, but require a semantic analysis, which I don't think we want)

lbailly commented on pull request DGNum/colmena#14 2025-02-21 10:47:48 +01:00
add node aliases, optimized node eval

Currently, the only trivial filter is Empty as it's not possible to build trivial Union or Inter (trivial = size < 2), nor to have an Empty in a leaf of a more complex filter.

lbailly commented on pull request DGNum/colmena#14 2025-02-19 23:50:15 +01:00
add node aliases, optimized node eval

This assert fails in the case of empty filter (which should matches all nodes)

lbailly commented on pull request DGNum/colmena#14 2025-02-19 23:38:20 +01:00
add node aliases, optimized node eval

It feels weird that we allow a node to have an alias being the name of another, like a and b, with b.aliases = [ "a" ], in which case colmena apply --on a applies both nodes. Idk if we…

lbailly approved DGNum/colmena#14 2025-02-19 23:31:36 +01:00
add node aliases, optimized node eval

It needs some cleanup, but looks good to me.

lbailly commented on pull request DGNum/colmena#14 2025-02-19 23:31:36 +01:00
add node aliases, optimized node eval

Should be None as we only queried tags ?

lbailly commented on pull request DGNum/colmena#14 2025-02-19 23:31:36 +01:00
add node aliases, optimized node eval

missing space between the 2 {} in inherit (attrs) {}{}; (when both are required).

lbailly pushed to main at lbailly/vxlan-router 2025-02-19 16:31:37 +01:00
4ffe38221b feat: wip! wip! gateway