cst1/openstreetmap-website
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
8438 commits 4 branches 1 tag 499 MiB
Commit graph

1108 commits

Author SHA1 Message Date
Andy Allan
18c25b620b Create a fresh user when requesting non-existent traces. 2017-03-09 14:50:02 +00:00
Andy Allan
f2479a8656 Use user factory for message model tests. 2017-03-09 11:52:31 +00:00
Andy Allan
c6c514fce7 Take the user from the node or changeset, rather than referring to the fixture. 2017-03-09 11:29:43 +00:00
Andy Allan
4736586355 Use user factory for note model test. 2017-03-09 11:06:07 +00:00
Andy Allan
8a6956eb22 Use user factory for oauth_token model test. 2017-03-09 11:04:29 +00:00
Andy Allan
5e78831d5c Use user factory for user_preference model tests. 2017-03-09 10:57:57 +00:00
Andy Allan
2267f44954 Use user factory for trace model tests. 2017-03-09 10:53:11 +00:00
Andy Allan
2b06961ce3 Use user factory for trace_controller tests 2017-03-09 10:13:18 +00:00
Tom Hughes
d86380e7b5 Fix accidental change in comments 2017-03-06 18:01:26 +00:00
Andy Allan
d007956865 Use user factory for swf_controller tests. 2017-03-06 17:28:06 +00:00
Andy Allan
1d9e12b330 Use user factory for message_controller tests. 2017-03-06 17:25:55 +00:00
Andy Allan
f1397f4700 Use user factory for user_roles_controller tests. 2017-03-06 16:55:05 +00:00
Andy Allan
4bcd13a024 Use users factory for user_preferences_controller tests. 2017-03-05 16:47:40 +00:00
Andy Allan
02f7fb96e5 Use users factory for user_blocks_controller tests. 2017-03-05 16:34:59 +00:00
Andy Allan
912da4fc1e Use users factory for redactions_controller tests. 2017-03-05 16:34:36 +00:00
Han Chao
49a7921ec8 Use local api to export map.osm 
Closes #1282
 2017-03-05 10:37:25 +00:00
Tom Hughes
f8f7cc4628 Update to rails 4.2.8 2017-02-23 21:18:57 +00:00
Andy Allan
6335891a4c User factories for browse, oauth_clients and site controller tests. 2017-02-23 14:13:09 +00:00
Andy Allan
a3618d2b5f User factory associations for all factories. 2017-02-22 18:51:45 +00:00
Tom Hughes
1a5161a9c8 Remove a few unnecessary attributes from moderator users 2017-02-22 18:30:47 +00:00
Andy Allan
91f3339b6a Make all factory-generated users 'normal' 
The use of create(:normal_user) makes the tests needlessly harder to
understand and reason about, particularly when we start using
associations in the factories.
 2017-02-22 18:26:03 +00:00
Tom Hughes
bbd24879fd Merge remote-tracking branch 'openstreetmap/pull/1458' 2017-02-22 17:55:37 +00:00
Tom Hughes
df24950854 Merge remote-tracking branch 'openstreetmap/pull/1457' 2017-02-22 12:28:13 +00:00
Andy Allan
f4835594b6 Convert notes_controller tests to user factories. 2017-02-22 11:33:50 +00:00
Andy Allan
c84a371d97 Revert changes where the user is a query parameter 2017-02-22 11:07:43 +00:00
Andy Allan
8bd98b5da8 Refactor api_controller tests to avoid users fixtures. 2017-02-22 11:03:39 +00:00
Andy Allan
38a3e4ba2b Refactor amf_controller tests to avoid users fixtures 
In all honesty I wouldn't be surprised if there are some semi-hidden
dependencies on the user fixtures here, given the number of magic numbers
all over the place. But this commit takes care of the explicit
dependencies for now.
 2017-02-22 10:30:53 +00:00
Andy Allan
7d9d496da2 Pass the user object, rather than the id, for sessions. 
This simplifies the code slightly.
 2017-02-22 09:57:18 +00:00
Tom Hughes
1dc2ff7d57 Merge remote-tracking branch 'openstreetmap/pull/1449' 2017-02-21 17:05:39 +00:00
Andy Allan
737a325f2e Refactor diary entry tests to use User factory 2017-02-19 16:43:32 +00:00
Tom Hughes
9b52542e52 Use simple string matches for user_blocks_helper tests 
Testing against the translations is not something we do anywhere
else is and is dangerously close to testing the helper against
itself which is a bit pointless.
 2017-02-19 11:50:01 +00:00
Tom Hughes
9c926c6c71 Use the factory to create user blocks 2017-02-19 11:42:38 +00:00
Simon Poole
325cd12c24 Make rupocop happy and correct placement of include 2017-02-19 12:35:02 +01:00
Simon Poole
455e906afa Improve wording and add test 2017-02-19 11:59:34 +01:00
Tom Hughes
e23541c20f Allow a POST with no arguments to trace#edit to fetch the form 2017-02-13 10:09:43 +00:00
Tom Hughes
92fe7a8506 Only create diary entries for POST requests 2017-02-09 21:07:18 +00:00
Tom Hughes
349862f1b7 Test that GET on message#new can't send a message 2017-02-09 20:39:03 +00:00
Tom Hughes
f435fce007 Link GPX fixture files instead of stubbing 2017-02-05 17:26:31 +00:00
Tom Hughes
71c2fc671f Cleanup double comment markers 2017-02-05 17:25:54 +00:00
Tom Hughes
0814b4096c Merge remote-tracking branch 'openstreetmap/pull/1347' into master 2017-02-05 16:02:20 +00:00
Tom Hughes
c7dc3ee722 Use .first in place of [0] 2017-02-05 13:57:25 +00:00
Tom Hughes
c57d2b29fc Merge remote-tracking branch 'openstreetmap/pull/1401' 2017-02-05 13:50:07 +00:00
Tom Hughes
7793cd27ab Merge remote-tracking branch 'openstreetmap/pull/1423' 2017-02-02 17:21:41 +00:00
Andy Allan
1041ead253 Convert the test_users_nearby to user factories. 2017-02-02 13:52:26 +00:00
Andy Allan
3b26ff0c40 Use factory for user language tests 2017-02-02 13:33:15 +00:00
Andy Allan
b83271de92 Refactor the friend_users test, and remove the tests which duplicate the (renamed) test_friends_with above. 2017-02-02 13:24:46 +00:00
Andy Allan
f96c563c10 Convert test_friend_with to use factories, and use alice/bob/charlie for easier understanding. 2017-02-02 13:20:51 +00:00
Andy Allan
584748fe0a User factory for uniqueness tests 2017-02-02 13:09:39 +00:00
Andy Allan
df6469c76b Convert class method tests to use User factory. 
Also improve the tests by being explicit about which results should
be returned, rather than just hoping that the fixtures cover all
possibilities.
 2017-02-02 13:05:43 +00:00
Andy Allan
0bd2e9ea8c Add status traits to user factory. 2017-02-02 12:55:32 +00:00