Commit graph

108 commits

Author SHA1 Message Date
Tom Hughes
b92a2de9ec Use changeset and user caches in Changeset#download 2013-04-01 14:18:21 +01:00
Saman Bemel-Benrud
a36f3558dd Site cleanup
I set out to do a quick and dirty typography overhaul to make things
more consistent and a bit cleaner, but I kept running into things I
didn't like, so this lead me down something of a rabbit hole of design
tweaks to the OSM site.

Goals here are to have better content hierarchy, better vertical
rhythm, more consistent UI, cleaner markup with less tables, all while
keeping the basics pretty much intact. There are a lot of things I
didn't touch even though they need to be updated (lots of tables where
stuff shouldn't be tables, mostly).

Basic overview of changes:

I added a new persistent header that helps segment pages. It's now
a lot easier to know what you're looking at. The header has a page
title, a description, plus a submenu of actions.

There is now a pattern of 20px/10px margins and padding for more
rhythm and breathing room throughout the site.

I know there are other problems here or things I've missed - would
love another set of eyes to look over this! I am still getting comfortable
working on the site - it's my first time ever digging into a ruby or rails
so I'm not familiar with the templating language yet.
2013-01-14 21:27:08 +00:00
John Firebaugh
e73ab4049f Remove unused assign of @bbox which is no longer used 2012-10-05 15:21:09 +01:00
Tom Hughes
6bafc93435 Error in a changeset feed is requested for a non-existent user 2012-05-01 20:40:59 +01:00
Matt Amos
e01a309970 Added test for changeset/download hiding redacted elements 2012-04-05 13:49:53 +01:00
Tom Hughes
a9824dbc2e Use one "no_such_user" view everywhere 2012-03-21 21:47:09 +00:00
Tom Hughes
8d52069b00 Avoid double render error 2012-02-19 11:04:59 +00:00
Mikel Maron
d878db0a9b Add some more social features
Add a view showing changesets by nearby users, and views showing
diary entries by friends and nearby users.
2012-01-07 11:54:07 +00:00
Tom Hughes
99d901c2ec Display the right title for friends' changesets 2011-12-16 08:29:19 +00:00
Tom Hughes
9545ca4ff3 Force a login to see your friends' changesets 2011-12-16 08:27:57 +00:00
Tom Hughes
8dd6f9f52f Fix double render error 2011-12-16 08:25:59 +00:00
Tom Hughes
78db9e72bb Convert friend changeset selection to use Arel queries 2011-12-15 21:47:43 +00:00
Tom Hughes
9d94d41376 Detabify 2011-12-15 21:26:51 +00:00
Mikel Maron
ce829bcc7c Add support for viewing a list of your friends' changesets 2011-12-15 21:25:27 +00:00
Tom Hughes
ebf597971f Removed bogus attempt to look up the previous version
This lookup wasn't actually doing what the comment said it was doing
and I don't see any reason to output the previous details of the object
for a delete action.
2011-12-10 16:24:57 +00:00
Tom Hughes
db616d347a Add feed action to relevant filters 2011-11-22 12:19:41 +00:00
Tom Hughes
be8164cf15 Generate correct URLs for changeset feeds 2011-11-19 12:42:37 +00:00
Tom Hughes
9c28a626cb Stop the API changeset query accepting min_lon etc 2011-11-14 09:42:57 +00:00
Peter Gray
95d899786a Refactor bounding box code
Moved duplicated code into the BoundingBox class, and pass around
BoundingBox objects instead of lists of bounds.
2011-11-14 09:42:57 +00:00
Tom Hughes
071c3581e9 Disable CSRF token verification for API methods 2011-11-14 09:42:55 +00:00
Tom Hughes
fc25c3d412 Rename all ID columns that aren't unique
Having a table with a column called ID that is only part of the
primary key really doesn't work as rails likes to treat ID as a
special name so it becomes impossible to assign to it or read it.
2011-11-14 09:42:52 +00:00
Tom Hughes
8ae5d94b2f Update some more queries to use AREL in place of deprecated methods 2011-11-14 09:42:51 +00:00
Tom Hughes
226c41be69 Update ActiveRecord queries to use arel 2011-11-14 09:42:44 +00:00
Tom Hughes
423f5ffbc2 Use config.filter_parameters instead of filter_parameter_logging 2011-11-14 09:42:43 +00:00
Tom Hughes
e5c80c80ad Use num_changes to detect empty changesets instead of the bbox 2011-07-12 15:55:17 +01:00
Mikel Maron
48929e8781 Add a map to the changeset list page
Add a map to the changeset list page, with a bounding box for each
changeset and highighting when the mouse is placed over either a box
on the map or a row of the table.
2011-05-01 22:55:28 +01:00
Matt Amos
f3ff36418b Fixed bug in changeset queries
The 'or' condition needed to be bracketed within larger 'and' expression.
2011-03-15 13:56:55 +00:00
Tom Hughes
2adcfc1a72 Don't allow paging of the changeset atom feed
Make any request for a changeset feed with a page argument redirect
to the version with no page argument and ensure that any RSS links on
the HTML version of the changeset list don't have a page argument.
2010-08-09 13:47:21 +01:00
Tom Hughes
0e40a4f1c4 Make changeset browser show an error when the database is offline 2010-06-27 14:42:47 +01:00
Tom Hughes
cf682f49b3 Add a timeout to the change list pages 2010-05-21 20:21:41 +01:00
Tom Hughes
b3ce6fdeec Convert lat and lon values to integers
Make sure the lat and lon values in changeset bounding box queries
are integers or Postgres will refuse to use the index.
2010-05-21 19:51:30 +01:00
Tom Hughes
97c2406ae4 Fix user visibility check 2010-05-06 21:52:27 +01:00
Matt Amos
b3f4637a42 Fixed copy-n-paste bug in querying for closed changesets and added a test for it. 2009-12-26 21:29:43 +00:00
Frederik Ramm
1fb6325630 fix half-baked comment. this needs way more thought before it is... um ;-) 2009-12-15 22:56:37 +00:00
Shaun McDonald
43a28065b1 Change the way that the changeset parsing is done, so that it is in line with the nodes/ways/relations and gives much nicer error messages. Adding some tests too to back up those changes. 2009-12-06 02:13:30 +00:00
Tom Hughes
261a93fbbc Replace the existing pagination of changesets in the browser with a
simple next/previous pagination that avoids the need to count the total
number of matches.
2009-11-18 20:21:54 +00:00
Matt Amos
16b79f9964 Added a :display_name option for the changesets query code. 2009-10-12 10:12:12 +00:00
Matt Amos
0d5be22cb5 Merging 16820:16891 from trunk. 2009-08-06 16:24:39 +00:00
Tom Hughes
e477f68a6c Render the links using partial so we can do the appropriate rendering
for HTML and Atom versions and hopefully get the escaping right in the
feed. Closes #2135.
2009-08-05 23:39:24 +00:00
Matt Amos
05e2120273 Merged 16488:16743 from trunk. 2009-07-31 10:42:06 +00:00
Tom Hughes
4afacf3410 Fix the changeset feed to put the description in as raw HTML so we
can include links instead of having to create a separate link free
version of it.
2009-07-30 11:25:33 +00:00
Ævar Arnfjörð Bjarmason
b06b6c2ce9 Atom readers (Firefox/Liferea) don't like when we embed XHTML anchors
in the description. So adjust the code that creates the changeset
browser title/description to emit a XHTML and plaintext version with
the HTML and Atom output can use, respectively.

Also:

 * Split up @title into @title and @heading as elsewhere
 * Turn the username on the user / user+bbox browser into a link to the userpage
 * Say "Changesets" instead of "Recent changes". Unlike Wikipedia the changes on OSM aren't guaranteed to be recent, they're just going to be the latest
2009-07-29 18:44:51 +00:00
Tom Hughes
64fb530581 Merge 16110:16487 from trunk. 2009-07-14 08:03:24 +00:00
Matt Amos
b8f6dbd403 Adding initial version of the OAuth token authentication method. This adds basic OAuth support for registering apps, getting and revoking keys, etc... The tokens come with 6 separate permissions bits; read/write user preferences, write diaries, write API and read/write GPS traces. Needs more tests. 2009-06-22 16:54:37 +00:00
Tom Hughes
edaddbedae Merge 15722:15806 from head and adjust new views to rails 2 style names. 2009-06-09 21:50:37 +00:00
Tom Hughes
3578506797 Add a title to the changeset lists. Closes #1938. 2009-06-08 20:10:09 +00:00
Tom Hughes
9df991e343 Marge all the changeset list methods together into one. 2009-06-07 16:59:58 +00:00
Tom Hughes
396d8ce313 Use some rails magic to avoid having to duplicate all the changeset
list controller methods for the RSS feeds.
2009-06-07 11:24:11 +00:00
Tom Hughes
e1cb17faa6 Back out the changeset RSS stuff from the head for now. 2009-06-07 08:03:07 +00:00
Ævar Arnfjörð Bjarmason
e9ab43cd30 The list_bbox_rss won't work at all without a bbox. Thow an error when it's not supplied 2009-06-07 03:06:09 +00:00