Fixed copy-n-paste bug in querying for closed changesets and added a test for it.

This commit is contained in:
Matt Amos 2009-12-26 21:29:43 +00:00
parent 056651375d
commit b3f4637a42
2 changed files with 5 additions and 1 deletions

View file

@ -427,7 +427,7 @@ private
# query changesets which are closed
# ('closed at' time has passed or changes limit is hit)
def conditions_closed(closed)
return closed.nil? ? nil : ['closed_at < ? and num_changes > ?',
return closed.nil? ? nil : ['closed_at < ? or num_changes > ?',
Time.now.getutc, Changeset::MAX_ELEMENTS]
end

View file

@ -1382,6 +1382,10 @@ EOF
get :query, :open => 'true'
assert_response :success, "can't get changesets by open-ness"
assert_changesets [1,2,4]
get :query, :closed => 'true'
assert_response :success, "can't get changesets by closed-ness"
assert_changesets [3,5,6,7]
end
##