Matt Amos
|
aeaf2d2d20
|
Added missing version to the pure rails AMF controller. More stringent tests on whichways.
|
2008-12-10 14:31:07 +00:00 |
|
Matt Amos
|
3ed9ac21b5
|
Some fixes to the rails part of the AMF controller and associated test.
|
2008-12-10 13:23:21 +00:00 |
|
Shaun McDonald
|
b7335940e2
|
Some improvements for the XML parsing, as there are somethings that we don't need, like timestamp and visibility, thus hopefully bringing a speedup in the xml parsing. Some more AMF controller fixes, plenty more to go though.
|
2008-12-09 18:44:11 +00:00 |
|
Shaun McDonald
|
67157f69f3
|
count -> size for compatibility with ruby 1.8.6
|
2008-12-08 15:47:29 +00:00 |
|
Shaun McDonald
|
59c69a642f
|
the user id may be negative, so that osmosis can create changesets for users that are anonymous, which it uses a negative id for, as a special id.
|
2008-12-08 15:32:29 +00:00 |
|
Shaun McDonald
|
2e41c35479
|
Adding the ability to see the min/max lat/lon for a changeset in the data browser. Adding file for the nice message that should show when a user is missing in the message controller.
|
2008-12-08 15:30:19 +00:00 |
|
Shaun McDonald
|
c0b4c1b905
|
Adding some amf create poi tests. Minor bugfix tweaks to the amf controller
|
2008-12-08 14:22:34 +00:00 |
|
Shaun McDonald
|
ec97c63e5c
|
Fix for the refactoring commited yesterday, based on review by Dave Stubbs
|
2008-12-05 11:08:58 +00:00 |
|
Shaun McDonald
|
e9527b363d
|
Refactoring the amf controller, and all models so that save_with_history! is now private. Everyone should use create_with_history, delete_with_history, and update_from instead. Also gets the amf controller to do version checks in the node/way/relation models. Needs checked. This breaks Potlatch until #1376 is fixed.
|
2008-12-04 17:30:17 +00:00 |
|
Shaun McDonald
|
d9c6758ee6
|
turning the session off for the changeset controller, to come in line with the other api controllers
|
2008-12-04 14:36:21 +00:00 |
|
Matt Amos
|
40adafa698
|
Adding missing fixtures to test helper.
|
2008-12-03 18:24:00 +00:00 |
|
Shaun McDonald
|
1a7ab3570c
|
Deal with active record not found exceptions when creating message. Some tidying of html. For some reason in rails 2.1.2 having a comment at the end of a line, in the view, means that the closing tag needs to be on the next line.
|
2008-12-03 12:56:02 +00:00 |
|
Shaun McDonald
|
073c866032
|
adding link to download the full changeset xml
|
2008-12-02 18:44:50 +00:00 |
|
Shaun McDonald
|
bbbf256986
|
Actually set the instance var when closing the changeset
|
2008-12-01 18:47:03 +00:00 |
|
Shaun McDonald
|
e989b1a880
|
ensure that uploads that don't supply a lat and lon for a node. Adding related test and fixing other tests.
|
2008-12-01 18:32:54 +00:00 |
|
Shaun McDonald
|
6e98e324e5
|
better handling of duplicate tags. Extra validation in the tests.
|
2008-11-28 17:38:23 +00:00 |
|
Matt Amos
|
c3785ff278
|
Changed duplicate tags test to test the correct code path - was previously failing in libxml, rather than the duplicate tags check.
|
2008-11-28 12:33:18 +00:00 |
|
Shaun McDonald
|
2ed84e26cd
|
Adding pagination to the changesets, thus allowing you to browe large changesets, without MySQL complaining about memory. Probably needs some fine tuning. You currently can only page one of nodes, ways, and relations, without manually setting the relations. Fixing deprection notice for the classic_pagination plugin.
|
2008-11-27 17:06:43 +00:00 |
|
Matt Amos
|
89bd962ff0
|
Adding test to check that users can't update changesets that they don't own.
|
2008-11-26 15:03:50 +00:00 |
|
Matt Amos
|
299b671522
|
Moved transaction boundary to cover used-by tests on deletion so that the database can help prevent race conditions.
|
2008-11-26 14:49:56 +00:00 |
|
Matt Amos
|
1ffb5c1502
|
Moved changeset consistency checks to library code.
|
2008-11-26 12:56:42 +00:00 |
|
Shaun McDonald
|
a4e5e8437f
|
Renaming the include action to expand_bbox in the changeset controller.
|
2008-11-26 11:36:10 +00:00 |
|
Shaun McDonald
|
8348493ccb
|
Some improvements to the error messages that are returned by the api.
|
2008-11-25 18:59:35 +00:00 |
|
Shaun McDonald
|
1375095343
|
More model validations. Fixing one test.
|
2008-11-25 17:23:47 +00:00 |
|
Richard Fairhurst
|
ecefee485b
|
various fixes/enhancements, including a couple to the 0.5 version
|
2008-11-25 00:15:30 +00:00 |
|
Shaun McDonald
|
0ff1214f86
|
Make the role in relations optional, with a test to make sure it is. Also start moving the errors reading the xml to exceptions, thus making it possible to give meaningful error messages, when bad xml is sent (More work is required on this including doing the same for nodes and ways). With the latest gems update it seems that the lib xml handling was broken, using the newer method. Adding the content type for the exceptions.
|
2008-11-24 18:55:24 +00:00 |
|
Harry Wood
|
152cb13a02
|
cosmetic tweaks to diary interface. icon for new entries link
|
2008-11-24 00:40:04 +00:00 |
|
Matt Amos
|
783528830a
|
Fixed bug in changeset idle timeout. Fixed another with a spurious require.
|
2008-11-21 12:53:09 +00:00 |
|
Shaun McDonald
|
e2c0e51e45
|
Closes #1350 through updating amf_controller to use the newer closed_at method of determining whether a changeset is closed. Richard please check the rest of the amf controller for more things that may reference the open field that is no longer available. Use is_open? to determine if a changeset is open. Fix indentation in amf controller. Fix minor bug in the links to changesets in the data brower.
|
2008-11-20 21:23:44 +00:00 |
|
Shaun McDonald
|
d6b4b8c8a1
|
Changeset tag unit tests
|
2008-11-19 18:00:52 +00:00 |
|
Shaun McDonald
|
ffbc4d5cb2
|
More tag validations, and finishing the node/way/relation tests.
|
2008-11-19 17:23:15 +00:00 |
|
Shaun McDonald
|
55d511bf21
|
Remember whether the user set the public checkbox on GPX upload as a user preference. Closes #827
|
2008-11-18 20:22:09 +00:00 |
|
Shaun McDonald
|
b7b2b502cf
|
Relation Tag testing. Also sort the belong_to/has_many for user/changeset/old_way.
|
2008-11-18 18:50:24 +00:00 |
|
Shaun McDonald
|
96dfe22fb0
|
Validations on the way tags, with unit tests
|
2008-11-18 16:21:32 +00:00 |
|
Shaun McDonald
|
1818679416
|
Make the dates and times that the server deals with UTC. This is probably required for changeset, as they could auto close instantly when the clocks go forward by one hour.
|
2008-11-17 19:11:54 +00:00 |
|
Matt Amos
|
a90be5e69a
|
Migration to add close-time to changesets. This replaces the boolean 'open' attribute. Added checks to ensure that the maximum lifetime and number of changes in a changeset are enforced. Added some tests.
|
2008-11-17 19:00:01 +00:00 |
|
Shaun McDonald
|
9a4ea6bfd0
|
Adding validations for the length of node tags, and the presence of the id (and version). More tests, including some boiler plate tests.
|
2008-11-17 18:53:09 +00:00 |
|
Matt Amos
|
495bd7f1f0
|
Made user input parsing more robust in changeset query method. Added tests.
|
2008-11-17 15:30:46 +00:00 |
|
Shaun McDonald
|
5254f79c08
|
Verify that the key and value isn't getting mixed up by having them different. verify the error message is the same when returning the user conflict on closing changeset test.
|
2008-11-17 15:00:19 +00:00 |
|
Matt Amos
|
28839fd150
|
Fixed some bugs in changeset query code. Added more test cases.
|
2008-11-17 14:32:15 +00:00 |
|
Matt Amos
|
519d402cb2
|
Added tests for changeset close method.
|
2008-11-17 11:59:42 +00:00 |
|
Matt Amos
|
98b15bef45
|
Implemented changeset tags updating via the update method.
|
2008-11-17 11:45:50 +00:00 |
|
Matt Amos
|
e57e2c497c
|
Altered tests on AMF controller so that they give failures instead of errors. Return format seems to have changed, so someone who knows more about AMF controller should have a look.
|
2008-11-17 11:12:48 +00:00 |
|
Richard Fairhurst
|
6690a9a09b
|
changeset comments and a couple of other small fixes
|
2008-11-16 13:30:02 +00:00 |
|
Shaun McDonald
|
d74e2196a0
|
Freezing composite primary key so that we can apply TomH's patch to it, and that way Potlatch will work in Rails mode without a problem. Please test.
|
2008-11-15 01:11:27 +00:00 |
|
Richard Fairhurst
|
0a57413d3e
|
finished Rails-friendly amf_controller. Note that this requires Tom's patched composite_primary_keys to work unless you tell Potlatch to use SQL reads
|
2008-11-14 17:36:38 +00:00 |
|
Shaun McDonald
|
6bca4b66d1
|
More unit test stubs
|
2008-11-14 17:28:16 +00:00 |
|
Shaun McDonald
|
57e2d5a8f5
|
Unit tests work again. Fixed the set fixture class that I should. Adding 2 length checks to the user preference controller.
|
2008-11-14 16:26:56 +00:00 |
|
Shaun McDonald
|
c8b70c1c72
|
Adding some more unit test stubs that need filling out. Adding changeset tags fixture. Indentation fix in way model.
|
2008-11-14 02:06:04 +00:00 |
|
Shaun McDonald
|
bdd5c317a7
|
Adding some more diary entry tests. Making the RSS feed links more portable, by using the SERVER_URL constant. Fixing the validation for the length of the language of diary entries until the i18n branch is integrated.
|
2008-11-13 17:20:40 +00:00 |
|