Andy Allan
79bd1777ab
Fully internationalise the issues and reports interfaces.
2018-01-22 11:57:08 +00:00
Andy Allan
ae44879213
Merge branch 'master' into moderation
2018-01-21 11:20:19 +00:00
Andy Allan
3a386f185c
Reopen issues if necessary when creating a report.
2018-01-21 11:18:24 +00:00
Tom Hughes
be86e4824f
Convert various URLs to https
2018-01-08 20:18:21 +00:00
Tom Hughes
c658e84535
Fix tests that only worked if object 400 didn't exist
2017-12-19 17:43:53 +00:00
mmd-osm
e21c967fdd
Revoking administrator role on current user should fail
...
Fixes #1697
Closes #1701
2017-12-19 17:31:34 +00:00
mmd-osm
2c7f2b117b
Remove extra blank line
2017-12-16 14:06:21 +01:00
mmd-osm
7a396e9dc9
Fix for failing test cases
2017-12-16 13:51:02 +01:00
Andy Allan
63992d83bd
Store the report category.
2017-12-13 16:02:55 +00:00
Andy Allan
875e588348
Show issues based on all the users roles
...
Previously you were prevented from seeing moderator issues if you
were also an administrator.
2017-12-06 18:56:27 +00:00
Andy Allan
8dc8479e12
Re-enable issue reassigning.
2017-12-06 18:01:51 +00:00
Andy Allan
0df788d742
Rename 'issue_type' to 'assigned_role', set defaults in the model and test.
2017-12-06 17:15:11 +00:00
Tom Hughes
b77406ff38
Use decoded strings when parsing XML responses from geocoders
...
Fixes #1690
2017-11-29 23:07:19 +00:00
Tom Hughes
2ef803b9df
Update rack-test and patch test issues
2017-11-29 20:35:17 +00:00
Andy Allan
ca032e0b44
Convert issue search tests to system tests
2017-11-29 18:58:51 +00:00
Andy Allan
9ce00608a4
Remove the test around missing report_type, since we're not currently requiring that.
2017-11-29 18:04:31 +00:00
Andy Allan
f0bcdae908
Put the expected value first in assert_equal
2017-11-29 18:02:26 +00:00
Andy Allan
1766c3216f
Move controller tests for new reports into seperate file, and adapt to new form structure.
2017-11-29 17:59:42 +00:00
Andy Allan
8e859b0f1d
Index page no longer redirects when there's no issues.
2017-11-29 17:37:29 +00:00
Andy Allan
a09e3f3fe0
Move and amend the issue comment controller tests.
2017-11-29 17:28:37 +00:00
Andy Allan
9f65820336
Rubocop fixes.
2017-11-29 16:48:01 +00:00
Andy Allan
f5228657fe
Refactor factories to use FactoryBot
2017-11-29 12:33:23 +00:00
Andy Allan
3115fd41b1
Remove minitest-rails-capybara and convert feature tests to system tests
2017-11-29 12:33:03 +00:00
Andy Allan
effb1b7f41
Merge branch 'master' into moderation
2017-11-29 12:18:39 +00:00
Andy Allan
1b181d4c1d
Put specific page titles at the start
...
The makes the shortened titles commonly shown on browser tabs more
useful.
2017-11-22 14:57:26 +00:00
Andy Allan
cb87f02642
Merge branch 'pull/843' into titles
2017-11-22 14:42:16 +00:00
Tom Hughes
9e929de530
Add framework for system tests
2017-11-15 19:14:31 +00:00
Tom Hughes
b6b9d543ac
Fix rubocop warnings
2017-10-29 19:43:02 +00:00
Tom Hughes
b2fa947502
Replace factory_girl with factory_bot
2017-10-29 19:29:30 +00:00
Tom Hughes
1c77d2432e
Avoid using rinku's auto_link helper
...
It's currently broken (https://github.com/vmg/rinku/issues/70 ) and
in case our own linkify has some additional customisations.
2017-10-27 19:45:32 +01:00
Tom Hughes
f02c753cc4
Use send_data for GPX traces intead of monkey patching send_file
2017-10-09 20:38:08 +01:00
Tom Hughes
8379b65174
Improve user_image_url test
...
Use a user that actually has an image and updated the expect
output to match that.
2017-10-09 19:10:32 +01:00
Tom Hughes
8dae890a76
Fix rubocop warnings
2017-10-05 19:18:38 +01:00
Tom Hughes
6209a9be78
Drop geocoder.us from search engines
...
Fixes #1633
2017-09-25 22:52:03 +01:00
Andy Allan
8cf16fe78b
Create an IssueCommentsController for managing IssueComments
2017-09-13 16:19:16 +01:00
Andy Allan
c00c515d9d
Ensure report details are not blank.
2017-09-06 18:17:54 +01:00
Andy Allan
4ff6027926
Check that the flag is not show when not logged in
2017-09-06 11:31:21 +01:00
Andy Allan
2b617b766a
Add a basic feature test for reporting diary entries.
2017-09-06 11:26:32 +01:00
Tom Hughes
f1faffd4d1
Merge remote-tracking branch 'upstream/pull/1614'
2017-08-30 21:09:32 +01:00
Andy Allan
c647aa3d4d
Refactor the from_xml methods to act on existing trace objects.
...
Setting the new tags with the = operator takes care of removing the
old ones, and is the same approach as taken by the tagstring= method.
Fixes #1600
2017-08-18 10:09:50 +01:00
Andy Allan
e9324ad681
Add failing test demonstrating tag duplication when updating traces via the API.
2017-08-17 19:03:50 +01:00
Tom Hughes
a70898be6d
Make sure we show errors correctly when resetting a password
2017-08-11 17:45:57 +01:00
Tom Hughes
85b0098b1c
Make sure the account form is POSTed
...
Fixes #1601
2017-08-02 15:32:13 +01:00
Andy Allan
e31376e28d
Merge branch 'master' into moderation
2017-08-02 12:12:57 +01:00
Tom Hughes
f258af223b
Fix user settings form
...
Fixes #1601
2017-08-01 19:25:07 +01:00
Tom Hughes
8c513beec6
Update rack-cors and fix tests for changes in behaviour
2017-07-31 21:55:01 +01:00
Tom Hughes
2c9c427587
Convert @user to current_user in helpers
2017-07-27 19:27:17 +01:00
Tom Hughes
4874219ab8
Mark account suspended flash message as HTML safe
...
Fixes #1590
2017-07-19 00:31:03 +01:00
Andy Allan
6fe5d42100
Standardise on basic_authorization without the parentheses
2017-07-12 14:36:17 +01:00
Andy Allan
506c0b5f0d
Set the reported_user in a callback
...
This avoids passing around the reported_user via forms. There was no
validation anywhere that the reported_user corresponded to the object
being reported. This approach removes those worries too.
2017-07-12 13:36:48 +01:00
