Tom Hughes
dbf0147d21
Remove unused function
2020-05-05 19:20:21 +01:00
Tom Hughes
f898cecb5c
Refactor map_controller_test
2020-05-05 19:19:43 +01:00
Tom Hughes
6f342c7616
Switch oauth integration tests to use new shared helper
2020-05-05 18:04:48 +01:00
Tom Hughes
7e1a4b6884
Refactor changeset comments API controller tests
2020-05-05 18:04:48 +01:00
Tom Hughes
c18e39cc05
Add helper methods for making OAuth signed requests
2020-05-05 18:04:48 +01:00
Tom Hughes
749ca5d5a0
Refactor the AMF controller API tests
2020-05-05 17:45:46 +01:00
Andy Allan
2e3522a2f6
Refactor changesets_controller_test
...
Introduces some route names which need to be unique from the non-api versions
2020-04-29 17:42:08 +02:00
Andy Allan
e765a6691b
Refactor more controller tests
2020-04-29 17:28:42 +02:00
Tom Hughes
f7d95e2ef9
Refactor traces controller tests
2020-04-28 19:44:00 +01:00
Tom Hughes
f75eb6fe9e
Refactor more controller tests
2020-04-27 22:24:28 +01:00
Tom Hughes
8979c597e3
Refactor more controller tests
2020-04-26 22:56:18 +01:00
Tom Hughes
03cde71a5e
Refactor more controller tests
2020-04-26 20:33:06 +01:00
Tom Hughes
cca1ce59f4
Merge remote-tracking branch 'upstream/pull/2598'
2020-04-22 16:43:14 +01:00
Andy Allan
506731031d
Refactor some more controller tests
2020-04-22 16:45:16 +02:00
Tom Hughes
8773ec6e57
Switch to using selenium for system tests
2020-04-22 13:51:37 +01:00
Tom Hughes
c51786d10b
Merge remote-tracking branch 'upstream/pull/2596'
2020-04-22 13:44:17 +01:00
Tom Hughes
359d76c8f0
Redirect to the error page for non-existent issues
2020-04-22 12:37:56 +01:00
Andy Allan
1aa5a54419
Refactor site controller tests to inherit from ActionDispatch::IntegrationTest
...
This is the modern way of writing controller tests, since it uses the
rails middleware (among other things) and leads to more realistic tests.
Refs #2563
2020-04-22 11:09:13 +02:00
Tom Hughes
ef147d479e
Fix new rubocop warnings
2020-04-19 19:06:07 +01:00
Tom Hughes
7a1615bc55
Fix rubocop-minitest warnings
2020-04-15 19:07:13 +01:00
Andy Allan
a219df24ca
Ensure that urls are only valid if the entire string is a url
...
This replaces our homegrown regexps (that didn't quite work) with
ruby built-in regexps, and uses the termination anchor to ensure
that the entire string, not just the first part, is validated.
2020-04-01 17:53:37 +02:00
Tom Hughes
e47c11c644
Merge remote-tracking branch 'upstream/pull/2577'
2020-04-01 11:56:27 +01:00
Andy Allan
055a976051
Remove custom table styling
...
This removes the custom table styling code, and move to using bootstrap table styling for almost all remaining tables.
2020-04-01 12:29:01 +02:00
Tom Hughes
0e902b5424
Set QT_QPA_PLATFORM=offscreen for Ubuntu etc
...
Fixes #2569
2020-03-25 17:04:44 +00:00
Tom Hughes
e693063fa5
Make linkify return an HTML safe result for unsafe inputs
...
Fixes #2567
2020-03-22 12:59:39 +00:00
Andy Allan
1cb0767e3d
Copy trace fixture files, rather than symlinking
...
Since we are using tmpdirs in order to enable parallel testing, we
can go the full hog and drop the fakefs too and just copy all the
files directly into the tmpdir. If a test makes changes (e.g.
changing the icon file during an import) the copy in the tmpdir is
thrown away at the end of the test anyway.
2020-03-18 15:35:55 +01:00
Andy Allan
0e612ea99a
Remove unused directories
2020-03-18 15:04:18 +01:00
Andy Allan
6bd6cbd203
Enable parallel tests
2020-03-18 15:04:18 +01:00
Andy Allan
979a474c68
Use unique test directories for each trace test
...
This allows tests to be run in parallel, since it avoids deleting
some of the symlinks that other tests expect to be there.
2020-03-18 15:04:18 +01:00
Andy Allan
8407c0dd98
Use the settings for the destination of the gpx fixture symlinks
...
This lets us change the settings values and have the fixtures appear
in the right place.
2020-03-18 14:58:48 +01:00
Andy Allan
5fdada204c
Use bootstrap table striping to replace hand-cycled table stripes
...
This cuts down on the complexity of having to use the `cycle` function
and makes the templates easier to read. CSS-based striping has been
around for many years.
The CSS is in order to keep our custom colour for striped tables.
2020-03-18 12:14:24 +01:00
Tom Hughes
06122fc090
Enforce restrictions on issue visibility properly
2020-03-01 19:20:18 +00:00
Andy Allan
93da959699
Merge pull request #2542 from boubascript/master
...
Show mailto: links for email values in browse
2020-02-26 17:09:27 +01:00
Andy Allan
73c95847a6
Merge pull request #2485 from mmd-osm/patch/json2
...
JSON output nodes, ways, relations, map
2020-02-26 15:55:48 +01:00
Boubacar
5d7b09e3bd
change validation to accept only single email values
2020-02-19 23:44:40 -05:00
Boubacar
c42722d57d
Add email link helper to create mailto: links for email values in objects
2020-02-16 21:46:48 -05:00
Andreas Geyer-Schulz
f6f23ed0ee
Fix typo: change 'noreferer' to 'noreferrer'
...
as the correct rel attribute in external links.
2020-01-25 20:10:23 +01:00
mmd-osm
3159c3c3f7
JSON: return HTTP 406 for unsupported formats
2020-01-22 22:33:30 +01:00
mmd-osm
b556b054d1
JSON: added clarification for non-supported Accept header formats
2020-01-22 17:38:28 +01:00
Andy Allan
a3795cddbb
Move the search results to use list-group-flush
2020-01-16 12:39:13 +01:00
Andy Allan
f885cfe0f5
Rename form-row to standard-form-row to avoid clashing with a bootstrap class
2020-01-15 17:16:11 +01:00
Tom Hughes
e72acaca9b
Merge remote-tracking branch 'upstream/pull/2495'
2020-01-15 10:11:30 +00:00
mmd-osm
03ca0b2c69
Added Accept header unit tests
2020-01-12 17:46:11 +01:00
mmd-osm
91b31f03de
Added unit tests
2020-01-08 19:57:21 +01:00
Andy Allan
9643e3393d
Update tests to ensure referer is working
...
This reinstates the form tests in the controller test, but uses
the system tests to actually click the button and make sure that
it works
2020-01-08 18:26:57 +01:00
Andy Allan
8a774e7519
Use a post link to logout
...
This avoids needing to access the session id, which is currently
only working with the memcache store.
The fallback page is preserved for anyone who wants to logout without
using javascript.
Refs #2488
2020-01-08 14:03:05 +01:00
Tom Hughes
473da378b7
Remove fallback to hostip.info
...
We haven't used hostip.info in production for years, except
for when we did so by accident, leading to a two hour partial
outage when it went down.
2020-01-06 19:14:12 +00:00
mmd-osm
b54333fa6d
Unify lat/lon formatting for json output
2020-01-02 14:52:53 +01:00
Tom Hughes
2f1705db7c
Test language specific versions of about and copyright pages
2019-12-30 22:52:31 +00:00
Tom Hughes
bb2c5677df
Add some missing route tests for the site controller
2019-12-30 22:37:24 +00:00