Tom Hughes
8030e7b5d6
Enable some more eslint checks
2019-04-06 17:27:17 +01:00
Tom Hughes
9256397e46
Exclude generated i18n files from eslint checks
2019-04-06 17:16:59 +01:00
Tom Hughes
eb7678145a
Use double quotes consistently in javascript code
2019-04-06 15:59:34 +01:00
Tom Hughes
87127d41e9
Enable some more eslint rules from iD rules
2019-04-06 15:48:51 +01:00
translatewiki.net
07aa5ade67
Localisation updates from https://translatewiki.net .
2019-04-04 20:15:40 +02:00
Tom Hughes
f68cee0f4e
Fix queuing of trace imports for API uploads
...
Fixes #2200
2019-04-03 21:53:16 +01:00
Tom Hughes
670603e927
Merge remote-tracking branch 'upstream/pull/2196'
2019-04-03 19:06:18 +01:00
Tom Hughes
1f13321a60
Fix issues found by eslint
2019-04-01 22:03:39 +01:00
Tom Hughes
62dff6ab7f
Replace jshint with eslint
2019-04-01 22:03:39 +01:00
translatewiki.net
aed17d1b16
Localisation updates from https://translatewiki.net .
2019-04-01 20:44:00 +02:00
Tom Hughes
2fb4497c6c
Use erb-lint to prohibit inline scripting
2019-03-31 19:45:03 +01:00
Tom Hughes
79bda7a8ed
Format closed_at correctly in changeset API responses
...
Fixes #2195
2019-03-30 15:40:08 +00:00
translatewiki.net
2954691be3
Localisation updates from https://translatewiki.net .
2019-03-28 19:41:23 +01:00
Tom Hughes
af69f58c7a
Fix dependencies
2019-03-28 09:35:12 +00:00
Tom Hughes
ac2d598f2f
Update to rails 5.2.3
2019-03-28 08:50:49 +00:00
Tom Hughes
9e759dc030
Expect CORS preflight responses to not have a content type
...
https://github.com/cyu/rack-cors/pull/180
2019-03-28 08:45:58 +00:00
Tom Hughes
671c041f7d
Update bundle
2019-03-28 08:37:52 +00:00
Tom Hughes
0c79686f3c
Merge remote-tracking branch 'upstream/pull/2190'
2019-03-28 08:24:04 +00:00
Tom Hughes
7ce40eeb38
erblint: use consistent spacing in HTML tags
2019-03-28 00:30:48 +00:00
Tom Hughes
49da87fb6d
erblint: remove leading blank lines
2019-03-28 00:29:04 +00:00
Tom Hughes
89341ce266
erblint: avoid dynamic find_by methods
2019-03-27 19:14:16 +00:00
Tom Hughes
9f931ca1e3
erblint: add rel=noopener to links that open in a new tab
2019-03-27 19:11:49 +00:00
Tom Hughes
1d97fd25b7
erblint: use conditional assignment
2019-03-27 18:59:52 +00:00
Tom Hughes
6afa132b84
erblint: use word arrays
2019-03-27 18:57:04 +00:00
Tom Hughes
ecd81eadbe
erblint: use parentheses for nested function calls
2019-03-27 18:55:48 +00:00
Tom Hughes
40141993f7
erblint: use symbols as procs
2019-03-27 18:54:16 +00:00
Tom Hughes
70f571fbcf
erblint: avoid negated if conditions
2019-03-27 18:49:01 +00:00
Tom Hughes
7cd7354673
erblint: prefer symbolic logical operators over and/or/not
2019-03-27 18:47:51 +00:00
Tom Hughes
dbbbd62ef1
Merge remote-tracking branch 'upstream/pull/2192'
2019-03-27 18:19:08 +00:00
Tom Hughes
69b952ae78
Merge remote-tracking branch 'upstream/pull/2191'
2019-03-27 18:10:09 +00:00
Andy Allan
7b057545c0
Disentangle the api abilities from the web abilities
...
This will allow us to rename api actions without causing permissions headaches. The choice of
abilities files is made by inheriting from either api_controller or application_controller.
Also rename capabilities to api_capabilites, for consistency.
2019-03-27 18:07:29 +01:00
Andy Allan
22c1be4db7
Set image dimensions in order to avoid a reflow after the page is drawn by the browser
2019-03-27 18:05:44 +01:00
Andy Allan
a5f4124681
Refactor notes#mine to simplify code
2019-03-27 18:04:44 +01:00
Tom Hughes
3af16f6337
erblint: fix remaining single quoted strings
2019-03-27 16:15:19 +00:00
Tom Hughes
50091893d4
Merge remote-tracking branch 'upstream/pull/2189'
2019-03-27 12:07:11 +00:00
Andy Allan
c44d689b31
Use trace jobs by default
2019-03-27 11:50:45 +01:00
Tom Hughes
3b237dc3da
Merge remote-tracking branch 'upstream/pull/2188'
2019-03-27 10:43:23 +00:00
Andy Allan
d5d3975181
Use the trace jobs for creating and destroy traces via the API
2019-03-27 11:40:50 +01:00
Tom Hughes
cebb05a3ba
Merge remote-tracking branch 'upstream/pull/2187'
2019-03-27 10:38:46 +00:00
Andy Allan
0e09252840
Check validity token in changesets controller
...
It makes no difference today, but prevents problems in future if
methods accepting post requests are added to this controller in future.
2019-03-27 11:24:31 +01:00
Andy Allan
3834ed45e6
erblint: avoid parentheses for method calls with no arguments
2019-03-27 10:59:10 +01:00
Andy Allan
6d0100b91d
erblint: prefer double quoted strings
2019-03-27 10:57:00 +01:00
Andy Allan
e22266f8c4
Exclude most views from string literal checks
...
This allows us to work through them slowly, while preventing errors
from creeping into directories that already pass.
2019-03-27 10:42:16 +01:00
Andy Allan
74b91c0e3e
erblint: Add or remove curly braces around hash parameters as required
2019-03-27 10:30:48 +01:00
Andy Allan
040c0184a4
erblint: use hash rocket syntax
2019-03-27 10:03:56 +01:00
Tom Hughes
c82fdf8e0f
Merge remote-tracking branch 'upstream/pull/2168'
2019-03-26 21:11:51 +00:00
Tom Hughes
71c5cb21c5
Exclude files in the vendor directory from erb-lint rubocop checks
2019-03-26 20:52:43 +00:00
Tom Hughes
4adc6680ee
Fix capitalisation of div tag
2019-03-26 20:52:43 +00:00
Andy Allan
227e1b134d
Update coding style section of the contribution guide to describe our use of rubocop and erblint
2019-03-26 20:52:43 +00:00
Andy Allan
ce8c388deb
Add erblint to travis
2019-03-26 20:52:43 +00:00
