Commit graph

880 commits

Author SHA1 Message Date
Tom Hughes
1f2ac59d1d Fix new rubocop warnings 2018-03-26 19:00:03 +01:00
Andy Allan
ee1a8637d3 Convert issue status to an enum 2018-03-21 12:05:08 +08:00
Andy Allan
9f84c6f46e Use user_path links. Fixes #1785 2018-03-21 11:33:45 +08:00
Andy Allan
facce9d0bb Refactor set_default_assigned_role to be more easily read. 2018-03-14 17:35:58 +08:00
Andy Allan
5310c7000c Remove cascading deletes, add another foreign key, and switch index around. 2018-03-14 16:15:39 +08:00
Andy Allan
3e5a4a14df Ensure reports have an issue id and a user id 2018-03-14 15:36:46 +08:00
Andy Allan
5e7abf67fb Remove nonsense has_one relationship 2018-03-14 15:20:04 +08:00
Andy Allan
e85110957a Remove vandalism as an option for reporting notes. 2018-03-14 12:51:22 +08:00
Tom Hughes
276859d0c9 Validate user location is sensible 2018-03-04 10:53:14 +00:00
Tom Hughes
9361478e74 Use home_tile to find nearby users 2018-03-04 09:59:24 +00:00
Tom Hughes
f1e9dcc66a Add an indexed home_tile column to the user table 2018-03-04 09:59:23 +00:00
Andy Allan
a20e28809f Merge branch 'master' into moderation 2018-02-28 15:55:28 +08:00
Andy Allan
424b6ef1cf Merge branch 'master' into moderation 2018-02-28 15:46:25 +08:00
Andy Allan
3006ce9713 Remove reporting of changesets 2018-02-28 14:39:40 +08:00
Andy Allan
80a241f798 Allow reporting of anonymous notes 2018-02-28 14:26:40 +08:00
Tom Hughes
81241b3083 Exclude hidden diary entries and comments from spam scoring 2018-02-26 22:35:06 +00:00
mmd-osm
cea403dce0 Remove BBOX expansion performance optimization
Closes #1749
Fixes #1742
2018-02-14 17:23:06 +00:00
Tom Hughes
5d03c3899f Use configured server protocol for links in e-mail notifications
Closes #1341
2018-02-05 21:01:36 +00:00
Tom Hughes
a83030dab7 Fix new rubocop warnings 2018-01-22 18:55:45 +00:00
Andy Allan
ae44879213 Merge branch 'master' into moderation 2018-01-21 11:20:19 +00:00
Tom Hughes
be86e4824f Convert various URLs to https 2018-01-08 20:18:21 +00:00
Andy Allan
e0faf68437 Remove new issue notifications for now
This can be re-implemented later.
2017-12-13 16:29:46 +00:00
Andy Allan
63992d83bd Store the report category. 2017-12-13 16:02:55 +00:00
Andy Allan
8dc8479e12 Re-enable issue reassigning. 2017-12-06 18:01:51 +00:00
Andy Allan
cbe707b33e Validate the assigned role, and remove the :type activrecord enum 2017-12-06 17:15:11 +00:00
Andy Allan
0df788d742 Rename 'issue_type' to 'assigned_role', set defaults in the model and test. 2017-12-06 17:15:11 +00:00
Tom Hughes
2c52c91b39 Make changeset#query preload users, tags and comments 2017-12-04 07:54:19 +00:00
Andy Allan
1956ab5913 Use a simple user_id for tables with one owning user
This is the standard way of naming in rails, and it avoids having
to tell rails which models are actually required.
2017-11-29 16:23:13 +00:00
Andy Allan
1d24228a3b Combine migrations into one
This makes it easier to review, rather than having a PR with migrations that
correct each other.
2017-11-29 16:13:32 +00:00
Andy Allan
2dd8f09395 Remove the reassign column from issue_comments
Reassigning is an effect of a controller action, not something that
should be stored in the database like this.
2017-11-29 16:05:12 +00:00
Andy Allan
fc0096289d Annotate models. 2017-11-29 12:34:04 +00:00
Andy Allan
effb1b7f41 Merge branch 'master' into moderation 2017-11-29 12:18:39 +00:00
Andy Allan
15b104f4ff Merge branch 'p' of https://github.com/jfirebaugh/openstreetmap-website into jfirebaugh-p
Refs #139
2017-11-22 10:47:18 +00:00
Tom Hughes
b6b9d543ac Fix rubocop warnings 2017-10-29 19:43:02 +00:00
Andy Allan
b2a8df0bd7 Add annotate gem and associated rake task. Annotate models. 2017-10-22 22:18:26 +01:00
Tom Hughes
8dae890a76 Fix rubocop warnings 2017-10-05 19:18:38 +01:00
Andy Allan
33c43ab0af Ensure that issue comments have associated issues and users. 2017-09-13 15:01:36 +01:00
Andy Allan
c00c515d9d Ensure report details are not blank. 2017-09-06 18:17:54 +01:00
Andy Allan
948fd8c8fa Use reports_count so that counter_cache works automatically. 2017-09-06 17:57:54 +01:00
Andy Allan
b4be5596f5 Rename xml processing methods with an update_ prefix
They behave differently from the other from_xml methods on other models.
2017-08-30 11:40:54 +01:00
Andy Allan
c647aa3d4d Refactor the from_xml methods to act on existing trace objects.
Setting the new tags with the = operator takes care of removing the
old ones, and is the same approach as taken by the tagstring= method.

Fixes #1600
2017-08-18 10:09:50 +01:00
Andy Allan
506c0b5f0d Set the reported_user in a callback
This avoids passing around the reported_user via forms. There was no
validation anywhere that the reported_user corresponded to the object
being reported. This approach removes those worries too.
2017-07-12 13:36:48 +01:00
Andy Allan
65e1dbb4a6 Rubocop autofixes. 2017-07-12 11:49:23 +01:00
Andy Allan
99df5f6179 Rename association to reported_user, for clarity 2017-07-12 11:44:05 +01:00
Andy Allan
dbd88d893f Merge branch 'master' into moderation 2017-07-12 10:16:11 +01:00
Andy Allan
396f2e28dd Rework coordinates to avoid scientific formatting of small numbers. Fixes #1509 2017-06-23 14:03:57 +01:00
Tom Hughes
fb4ea1a02a Add explicit primary key declaration for changeset subscriptions
This table has a composite primary key and although we don't really
rely on that at all rails 5.0 warns about itif you don't explcitly
declare it in order to trigger the CPK extension.
2017-06-06 22:42:25 +01:00
Tom Hughes
9b89d4eefe Remove conditions from delete_all
Passing conditions directory to delete_all is deprecated
in rails 5.0 so use a separate where instead.
2017-06-02 16:33:48 +01:00
Tom Hughes
5b33f3f8e3 Fix rubocop warnings 2017-06-02 00:08:30 +01:00
Andy Allan
4fb775d6d5 Format latitudes and longitudes as %7f in XML output
This matches the double formatting in XML from cgimap. Fixes #341.
2017-03-30 14:30:54 +01:00