Commit graph

2682 commits

Author SHA1 Message Date
Andy Allan
e0faf68437 Remove new issue notifications for now
This can be re-implemented later.
2017-12-13 16:29:46 +00:00
Andy Allan
63992d83bd Store the report category. 2017-12-13 16:02:55 +00:00
Andy Allan
875e588348 Show issues based on all the users roles
Previously you were prevented from seeing moderator issues if you
were also an administrator.
2017-12-06 18:56:27 +00:00
Andy Allan
8dc8479e12 Re-enable issue reassigning. 2017-12-06 18:01:51 +00:00
Andy Allan
c40ad9de02 Remove the hardcoded pixel width for columns. 2017-12-06 15:26:40 +00:00
Andy Allan
3276063fcf Remove column sorting
It's not tested, not working, and so it can come later in a separate PR.
2017-11-29 17:28:09 +00:00
Andy Allan
546d13c25f Remove the reassign boolean display 2017-11-29 16:47:36 +00:00
Andy Allan
effb1b7f41 Merge branch 'master' into moderation 2017-11-29 12:18:39 +00:00
Tom Hughes
a3519348c6 Remove inline javascript from user settings page 2017-11-24 16:20:50 +00:00
Andy Allan
1b181d4c1d Put specific page titles at the start
The makes the shortened titles commonly shown on browser tabs more
useful.
2017-11-22 14:57:26 +00:00
Tom Hughes
1c77d2432e Avoid using rinku's auto_link helper
It's currently broken (https://github.com/vmg/rinku/issues/70) and
in case our own linkify has some additional customisations.
2017-10-27 19:45:32 +01:00
Tom Hughes
0b0ff1bcc5 Remove reference to large screen stylesheet
The separate large screen stylesheet was removed in 4dceacdeb but
we are still referencing it on Internet Explorer.
2017-10-09 13:47:48 +01:00
Tom Hughes
6e0ca57e2f Fix typo that means fe0f4543c1 has never worked 2017-10-09 08:39:14 +01:00
Andy Allan
dd619fbe73 Remove some more of the structured-details stuff 2017-09-13 16:20:22 +01:00
Andy Allan
8cf16fe78b Create an IssueCommentsController for managing IssueComments 2017-09-13 16:19:16 +01:00
Andy Allan
f0e3a41726 Fix parameter spacing 2017-09-13 16:16:33 +01:00
Andy Allan
7ffec2eb38 Rework the 'issues not found' notice slightly.
Previously it would go into a redirect loop if there were no issues
in the database.
2017-09-13 16:12:36 +01:00
Andy Allan
659270dafe The link is to the list of issues, not of reports, and there's no need for it to be bold. 2017-09-13 16:02:15 +01:00
Wille Marcel
a402e811da Add padding between the last diary post and the pagination links
Closes #1634
2017-09-08 16:50:09 +01:00
Andy Allan
d7612f42d0 Refactor creating a new report to use a ReportsController
It's really a report that the user is creating, the issue is created indirectly. Similar
refactoring will be required for issue comments.
2017-09-06 18:06:21 +01:00
Andy Allan
948fd8c8fa Use reports_count so that counter_cache works automatically. 2017-09-06 17:57:54 +01:00
Tom Hughes
a70898be6d Make sure we show errors correctly when resetting a password 2017-08-11 17:45:57 +01:00
Tom Hughes
85b0098b1c Make sure the account form is POSTed
Fixes #1601
2017-08-02 15:32:13 +01:00
Tom Hughes
bc10bc8758 Merge remote-tracking branch 'upstream/pull/1603' 2017-08-02 15:02:39 +01:00
Andy Allan
980422533d Avoid passing the current_user.id when commenting
Doing so doesn't appear to be necessary, and it opens up a spoofing
hole if it's actually used.
2017-08-02 14:58:03 +01:00
Andy Allan
389095df1c Remove unused user save template.
This template isn't used, since all the controller methods redirect
to other views.
2017-08-02 14:48:04 +01:00
Andy Allan
3e4255eb2c Use current_user instead of @user. 2017-08-02 12:21:51 +01:00
Andy Allan
e31376e28d Merge branch 'master' into moderation 2017-08-02 12:12:57 +01:00
Tom Hughes
f258af223b Fix user settings form
Fixes #1601
2017-08-01 19:25:07 +01:00
Tom Hughes
24fc94944b Change user forms to use current user instead of @user 2017-07-27 19:40:20 +01:00
Andy Allan
c819bec8b7 Use a current_user helper for accessing the logged in user in all views. 2017-07-27 10:07:51 +01:00
Andy Allan
9c1c696141 Remove indirection. 2017-07-12 13:42:39 +01:00
Andy Allan
506c0b5f0d Set the reported_user in a callback
This avoids passing around the reported_user via forms. There was no
validation anywhere that the reported_user corresponded to the object
being reported. This approach removes those worries too.
2017-07-12 13:36:48 +01:00
Andy Allan
99df5f6179 Rename association to reported_user, for clarity 2017-07-12 11:44:05 +01:00
Andy Allan
dbd88d893f Merge branch 'master' into moderation 2017-07-12 10:16:11 +01:00
Andy Allan
d56b1400bc Whitespace fixes. 2017-07-05 15:17:02 +01:00
Andy Allan
cbf71f04c2 Hide contributor terms details, unless the user hasn't agreed
It's no longer important to show when users agreed to the contributor terms.
For users that haven't agreed, we still show their status on their profile.

Logic was also re-written to avoid lots of `if not` things, and tests added.
2017-07-05 12:39:52 +01:00
Tom Hughes
5d740d8733 Don't disable search submission buttons on form submission 2017-06-30 10:01:22 +01:00
Tom Hughes
fe1e28b4f4 Fix more parameter sanitisation issues and add tests 2017-06-29 20:52:57 +01:00
Tom Hughes
117f0e8226 Sanitize parameters for various paged views 2017-06-29 10:55:53 +01:00
Tom Hughes
3893fd72a9 Fix some tests for changes in rails 5 2017-06-27 08:26:44 +01:00
Andy Allan
396f2e28dd Rework coordinates to avoid scientific formatting of small numbers. Fixes #1509 2017-06-23 14:03:57 +01:00
Tom Hughes
3b2d1886eb Make delete button translatable 2017-06-03 12:04:00 +01:00
Hamel Desai
fa7b3022a8 Add delete button to message view
Fixes #1504
Closes #1557
2017-06-02 20:31:59 +01:00
Tom Hughes
80d27a7fae Sanitise parameters used in URL generation 2017-06-02 20:27:07 +01:00
Tom Hughes
4ef7b2c651 Remove duplicate size specification for user image
Either the size or the width and height can be passed but passing
both doesn't make any sense and in rails 5.0 will error.
2017-06-02 20:27:07 +01:00
Tom Hughes
3a16b68368 Use POST when editing GPX trace details
Fixes #1533
2017-05-01 16:56:02 +01:00
daganzdaanda
8b68acec3e Move list of containing relations to top of browse views
Moves the list of containing relations to above the list of
members for ways and relations - nodes have no equivalent list
so no change is needed there.

Fixes #794
Closes #1501
2017-04-24 20:25:22 +01:00
Matt Amos
c7391595d8 Credit the whole of UCL, rather than just the Bartlett / VR centre. 2017-04-22 11:47:12 +01:00
Herve Saint-Amand
2ae479e3f3 Fix indentation in email template
The plain text templates had nice indentation in the source however that
got reflected in the output, which was visibly and needlessly indented.

Closes #1512
2017-04-08 16:36:40 +01:00