Commit graph

2254 commits

Author SHA1 Message Date
Tom Hughes
f047f86c1d Preserve lat and lon values as entered for reverse searches 2024-07-12 12:04:16 +01:00
Tom Hughes
63f0b9257d Don't try and change the HTTP client user agent
Because we only create the client once we can't override the
server URL for a test to change the user agent as we don't know
which test will create it.
2024-07-10 19:17:09 +01:00
Tom Hughes
6a426a920e Merge remote-tracking branch 'upstream/pull/4974' 2024-07-10 18:33:54 +01:00
Anton Khorev
382e773793 Test Nominatim.describe_location 2024-07-10 17:41:56 +03:00
Anton Khorev
38bfb33c02 Remove single-use OpenID logo helper 2024-07-10 13:50:39 +03:00
Anton Khorev
088a78d83c Remove .d-block classes from auth buttons
Unnecessary on flex items.
2024-07-09 17:51:50 +03:00
Anton Khorev
bacca516f0 Use flex gap instead of margins on auth buttons 2024-07-08 17:28:36 +03:00
nertc
676aef5be6 Order of comments in changeset comments feeds 2024-07-05 19:00:15 +04:00
Tom Hughes
87422e56f9 Merge remote-tracking branch 'upstream/pull/4949' 2024-07-04 18:54:03 +01:00
nertc
c66851f474 Share button unusable on a cell phone 2024-07-04 18:09:48 +04:00
Anton Khorev
81ac29fad8 Change auth provider logo alt texts to indicate that these are logos 2024-07-03 10:53:25 +03:00
nertc
4b593412c2 Accept coordinates with a slash in search 2024-07-02 23:48:55 +04:00
Anton Khorev
adabf84fe6 Set i18n locale before writing "report a problem" on embed page 2024-06-30 04:51:43 +03:00
Tom Hughes
b03eb84bb6 Only the sender of a message should be able to mark it as read/unread 2024-06-29 00:14:42 +01:00
Tom Hughes
5cc0b26bba Merge remote-tracking branch 'upstream/pull/4916' 2024-06-27 17:56:13 +01:00
Tom Hughes
24d535237c Merge remote-tracking branch 'upstream/pull/4917' 2024-06-27 17:47:16 +01:00
Emin Kocan
3dc76a9bc0 style auth buttons using .btn & .btn-light classes 2024-06-27 14:55:28 +02:00
Andy Allan
7f3cb3c624
Merge pull request #4610 from AntonKhorev/no-old-note-api
Remove old note api endpoints
2024-06-26 14:17:39 +01:00
Tom Hughes
271384e683 Simplify handling of geocoder URLs
This avoids having to build them in multiple places and also
ensures we link to what was actually searched rather than some
random string from the locale file.
2024-06-25 17:57:38 +01:00
Tom Hughes
ddc252016a Merge remote-tracking branch 'upstream/pull/4895' 2024-06-25 17:42:52 +01:00
Anton Khorev
06820acc4b Discard fragments from wikimedia_commons tag values 2024-06-22 21:48:42 +03:00
Emin Kocan
b057c7ae5a Arrange button sizes to default size of 36px
As discussed in #4773 there was not any clarification as why auth button sizes were reduced so 36px is now accepted as default. This commit addresses that comment/issue.
2024-06-21 12:08:58 +02:00
Anton Khorev
9f3ac8f5ce Url-encode wikimedia_commons tag values 2024-06-20 22:13:28 +03:00
Nenad Vujicic
839d203d51 Added link to nominatim results in searching results
Fixes #3205. Added caching of nominatim URL query parameters in sources global variable (as parameters parameter) in GeocoderController#search for both direct and reverse geocoding. In app/views/geocoder/search.html.erb added displaying cached URL as forwarding link when clicked on "OpenStreetMap Nominatim" label. Updated GeocoderControllerTest to check only name (latlng, osm_nominatim, osm_nominatim_reverse) parameter of new sources variable.
2024-06-19 15:44:56 +02:00
Andy Allan
d00a0667bc
Merge pull request #4887 from AntonKhorev/full-encode-wikipedia-value
Fully encode wikipedia tag values
2024-06-19 14:41:38 +01:00
Tom Hughes
505dcde52a Add tests for API changeset size limits 2024-06-19 00:46:35 +01:00
Tom Hughes
61c5011813 Update tests to avoid triggering changeset size limits 2024-06-19 00:46:35 +01:00
Tom Hughes
2d09b9408b Merge remote-tracking branch 'upstream/pull/4891' 2024-06-17 17:22:38 +01:00
Anton Khorev
a128b4f585 Move diary comments hide/unhide actions to comments controller 2024-06-17 18:16:31 +03:00
Anton Khorev
b97834f1fd Use default og:image if Addressable::URI fails 2024-06-15 15:57:10 +03:00
Anton Khorev
c03649355a Join and normalize og:image url using Addressable
Avoids failing on urls that are not strictly rfc2396 URIs.
2024-06-15 15:06:07 +03:00
Anton Khorev
6624beff11 Move diary comments index action to comments controller 2024-06-10 16:32:53 +03:00
Anton Khorev
ebaae09797 Fully encode wikipedia tag values 2024-06-08 15:59:30 +03:00
Anton Khorev
24c138ac8d Ensure that Open Graph image url is absolute 2024-06-06 18:01:23 +03:00
Anton Khorev
a73e20cd5c Set Open Graph image to first image for diary entries 2024-06-06 17:28:57 +03:00
Anton Khorev
c7353c9ac1 Add image method to get first image from rich text 2024-06-06 17:09:21 +03:00
Anton Khorev
5add2d7e1d Reload only changeset element subpages 2024-06-03 14:16:09 +03:00
Anton Khorev
b072c2935f Add titles to changeset element page links 2024-06-03 14:07:23 +03:00
Anton Khorev
5a22464224 Don't include language prefix in wikipedia links 2024-06-01 04:56:57 +03:00
Tom Hughes
15e86708f1 Merge remote-tracking branch 'upstream/pull/4847' 2024-05-30 16:20:54 +01:00
Milan Cvetkovic
15623aa35a Social sign-in: avoid re-authorization in users_controller#create
It does not add any additional guards against malicious users:

Malicious user may attempt to invoke `POST /users/new` with bogus
values for `auth_provider` and `auth_uid` resulting
with a new account to which user would have a way to login, other than
sending a password reset request.

In some cases, re-authorization would introduce additional
"Please login to your social account", or "Are you sure you want to be logged in"
popup triggered by identity provider.

This PR removes the re-authorization request from `POST /users/new` in authorization flow.
2024-05-30 05:43:45 +00:00
Andy Allan
0bbfe922ea Test the versions and capabilities api in various statuses
These both need to keep working, even when the rest of the api is
unavailable, since that's how we communicate that status with the
api clients.
2024-05-29 14:51:47 +01:00
Tom Hughes
514836a497 Merge remote-tracking branch 'upstream/pull/4795' 2024-05-19 19:21:45 +01:00
Hidde Wieringa
036c87b355
OpenID connect icons to SVG
re-add whitespace

trigger CI

revert size attribute
2024-05-16 21:16:28 +02:00
Tom Hughes
334c856021 Test unicode values in user preference keys and values 2024-05-16 17:51:33 +01:00
Andy Allan
ffda8d7ac5
Merge pull request #4680 from tomhughes/validate-page-numbers
Add parameter validation to pagination
2024-05-15 17:43:04 +01:00
Anton Khorev
822466c6c6 Add warnings when creating notes anonymously 2024-05-14 19:42:59 +03:00
Anton Khorev
d9e650fde1 Use inline svgs for user role icons 2024-05-07 15:51:23 +03:00
Tom Hughes
0b18937384 Merge remote-tracking branch 'upstream/pull/4757' 2024-05-06 11:15:12 +01:00
Anton Khorev
f418d0bbb4 Simplify message paths in tests 2024-05-06 12:37:57 +03:00