cst1/openstreetmap-website
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge pull request #4887 from AntonKhorev/full-encode-wikipedia-value

Browse source 
Fully encode wikipedia tag values
This commit is contained in:
Andy Allan 2024-06-19 14:41:38 +01:00 • committed by GitHub
commit d00a0667bc
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 16 additions and 17 deletions
Download patch file Download diff file Expand all files Collapse all files

12
test/helpers/browse_tags_helper_test.rb
View file

@ -198,17 +198,21 @@ class BrowseTagsHelperTest < ActionView::TestCase
assert_equal "de:Test", link[:title]
link = wikipedia_link("wikipedia", "de:Englischer Garten (München)#Japanisches Teehaus")
assert_equal "https://de.wikipedia.org/wiki/Englischer Garten (München)?uselang=en#Japanisches_Teehaus", link[:url]
assert_equal "https://de.wikipedia.org/wiki/Englischer_Garten_%28M%C3%BCnchen%29?uselang=en#Japanisches_Teehaus", link[:url]
assert_equal "de:Englischer Garten (München)#Japanisches Teehaus", link[:title]
link = wikipedia_link("wikipedia", "de:Alte Brücke (Heidelberg)#Brückenaffe")
assert_equal "https://de.wikipedia.org/wiki/Alte Brücke (Heidelberg)?uselang=en#Br%C3%BCckenaffe", link[:url]
assert_equal "https://de.wikipedia.org/wiki/Alte_Br%C3%BCcke_%28Heidelberg%29?uselang=en#Br%C3%BCckenaffe", link[:url]
assert_equal "de:Alte Brücke (Heidelberg)#Brückenaffe", link[:title]
link = wikipedia_link("wikipedia", "de:Liste der Baudenkmäler in Eichstätt#Brückenstraße 1, Ehemaliges Bauernhaus")
assert_equal "https://de.wikipedia.org/wiki/Liste der Baudenkmäler in Eichstätt?uselang=en#Br%C3%BCckenstra%C3%9Fe_1%2C_Ehemaliges_Bauernhaus", link[:url]
assert_equal "https://de.wikipedia.org/wiki/Liste_der_Baudenkm%C3%A4ler_in_Eichst%C3%A4tt?uselang=en#Br%C3%BCckenstra%C3%9Fe_1%2C_Ehemaliges_Bauernhaus", link[:url]
assert_equal "de:Liste der Baudenkmäler in Eichstätt#Brückenstraße 1, Ehemaliges Bauernhaus", link[:title]
link = wikipedia_link("wikipedia", "en:Are Years What? (for Marianne Moore)")
assert_equal "https://en.wikipedia.org/wiki/Are_Years_What%3F_%28for_Marianne_Moore%29?uselang=en", link[:url]
assert_equal "en:Are Years What? (for Marianne Moore)", link[:title]
I18n.with_locale "pt-BR" do
link = wikipedia_link("wikipedia", "zh-classical:Test#Section")
assert_equal "https://zh-classical.wikipedia.org/wiki/Test?uselang=pt-BR#Section", link[:url]
@ -216,7 +220,7 @@ class BrowseTagsHelperTest < ActionView::TestCase
end
link = wikipedia_link("subject:wikipedia", "en:Catherine McAuley")
assert_equal "https://en.wikipedia.org/wiki/Catherine McAuley?uselang=en", link[:url]
assert_equal "https://en.wikipedia.org/wiki/Catherine_McAuley?uselang=en", link[:url]
assert_equal "en:Catherine McAuley", link[:title]
link = wikipedia_link("foo", "Test")