Commit graph

144 commits

Author SHA1 Message Date
Tom Hughes
9b52542e52 Use simple string matches for user_blocks_helper tests
Testing against the translations is not something we do anywhere
else is and is dangerously close to testing the helper against
itself which is a bit pointless.
2017-02-19 11:50:01 +00:00
Tom Hughes
9c926c6c71 Use the factory to create user blocks 2017-02-19 11:42:38 +00:00
Simon Poole
325cd12c24 Make rupocop happy and correct placement of include 2017-02-19 12:35:02 +01:00
Simon Poole
455e906afa Improve wording and add test 2017-02-19 11:59:34 +01:00
Tom Hughes
970e1a99d7 Merge remote-tracking branch 'openstreetmap/pull/1367' 2016-12-18 16:29:33 +00:00
Tom Hughes
c8f26592a7 Fix rubocop warnings 2016-12-02 22:01:40 +00:00
Andy Allan
3026af170a Replace fixtures with factory for node_tags 2016-10-30 18:28:01 +01:00
Andy Allan
acb7f44069 Replace fixtures with a factory for old_node_tags
Also includes a slight simplification of the old_node_tags tests.
2016-10-30 15:36:33 +01:00
Tom Hughes
224252fd83 Add test for formatting of multi-value wikidata links 2016-08-16 19:27:40 +01:00
Florian Schäfer
3251cdf5d6 Added fixes for rubocop complaints 2016-07-14 15:22:52 +02:00
Florian M. Schäfer
10cde3bb92 Link the prefixed wikidata-tags to wikidata.org
With this commit, the prefixed wikidata-tags get linked to the
corresponding wikidata.org-page in the current interface-language.

Multiple semicolon-separated wikidata-IDs are shown as multiple
semicolon-separated links to wikidata.

This commit contains also some tests for those links.
2016-07-14 15:22:52 +02:00
Simon Legner
6f144e8b7d Show ref of object when no name is present 2016-03-09 18:47:54 +00:00
Aditya Prakash
80c46f54d4 Create new translation string for deleted user 2016-02-15 22:37:54 +05:30
Aditya Prakash
341f6cd9fe Do not hyperlink profiles of deleted users 2016-02-15 20:47:53 +05:30
Tom Hughes
03356be588 Use correct title in og:title for pages with no title
Fixes #1098
2015-12-07 15:54:06 +00:00
Holger Jeromin
37a4fc6dd1 Add srcset to img tags inside picture elements
Some browsers (in particular Safari on iOS) don't support picture
yet but do support srcset on the img tag.
2015-09-15 08:48:50 +01:00
Tom Hughes
d377e8b4f2 Use picture elements to render some more graphics as SVG 2015-09-13 22:42:12 +01:00
Tom Hughes
ca213b873f More improvements to mediawiki fragment escaping
It turns out that the PHP urlencode encodes more characters than
the ruby URI.encode does by default, so specify our own characters
to encode based on http://php.net/manual/en/function.urlencode.php
with the extra exclusion of colon, which the mediawiki code reverses
after the encoding is done.

Fixes #967
2015-05-15 15:34:12 +01:00
Tom Hughes
b40353b9b0 Escape fragment identifiers in wikipedia URLs
Fixes #967
2015-05-14 20:34:25 +01:00
Tom Hughes
2af0840ff3 Fix style issues found by new rubocop version 2015-04-14 09:38:24 +01:00
Tom Hughes
e2aef40437 URI encode the X-Page-Title header
Browsers's are inconsistent in how they interpret the encoding
of a response header in an XHR request, so URI encode it so that
it simple ASCII we can then decode it again in the browser.
2015-03-17 18:49:39 +00:00
Tom Hughes
5ab7591d9c Reset locale after tests which change it finish 2015-02-28 07:38:12 +00:00
Tom Hughes
d4d1527a92 Fix rubocop warnings 2015-02-27 07:08:55 +00:00
Tom Hughes
f04211b172 Improve test coverage 2015-02-27 00:40:37 +00:00
Tom Hughes
8e404f3a46 Fix some more rubocop style issues 2015-02-20 20:39:52 +00:00
Tom Hughes
dc2a2c8ebd Standardise on double quoted strings 2015-02-20 19:47:26 +00:00
Tom Hughes
baf10cd392 Fix rubocop lint issues 2015-02-20 08:56:16 +00:00
Tom Hughes
ef7f3d800c Fix most auto-correctable rubocop issues 2015-02-20 08:56:16 +00:00
Tom Hughes
34e3e51456 Cleanup trailing whitespace 2015-02-20 08:56:16 +00:00
Tom Hughes
25337c0b04 Use assert_dom_equal to compare HTML text 2015-01-10 15:59:09 +00:00
Tom Hughes
3058135d9a Update to rails 4.1.9 2015-01-08 10:06:22 +00:00
Dan Stowell
da7ed512a8 Page titles: put specific page title at the start not the end 2014-11-23 22:21:57 +00:00
Florian M. Schäfer
f8fccbf8be Let test_note_event pass in timezones other than +00:00 2014-07-24 22:27:16 +01:00
Tom Hughes
c53db246f6 Merge branch 'rails41' 2014-07-21 08:53:44 +01:00
Florian M. Schäfer
212e7153d8 Added tests for wikidata links in the browse helper 2014-07-20 15:03:28 +01:00
Tom Hughes
b13018cc96 Make sure we restore I18n.locale when tests complete 2014-07-04 19:24:25 +01:00
Tom Hughes
aa00e6b81e Decode entities in the title
They will get reencoded (if necessary) when they are output. Fixes #764.
2014-06-18 09:29:17 +01:00
Štefan Baebler
75e07dc5b8 Added telephone links into tag detail browser
International phone numbers become links using the official URI scheme
as per http://tools.ietf.org/html/rfc3966.

It is not limited to key=phone, so it can be used in other keys as well.
2014-06-15 09:31:04 +01:00
Tom Hughes
85e61568da Try harder to find a name in the right language 2014-05-24 12:52:09 +01:00
Tom Hughes
e010a326a8 Wrap the ID in <bdi> tags for RTL locales 2014-05-19 00:29:08 +01:00
Tom Hughes
5da273027f Isolate object names from the database with a <bdi> tag
Fixes #743
2014-05-18 17:24:38 +01:00
Tom Hughes
d65e019823 Add more helper tests 2014-03-05 22:54:59 +00:00
Tom Hughes
0de7fdb4df Add more tests for BrowseHelper 2014-03-01 16:02:06 +00:00
Tom Hughes
109dcfff19 Add tests for BrowseHelper#wikipedia_link 2014-03-01 00:25:33 +00:00