Andy Allan
38ad8fbc36
Use login_path instead of explicit controller and actions
...
This makes future refactoring easier.
2021-03-10 14:31:55 +00:00
Tom Hughes
0ff89c31e4
Remove both Potlatch versions
...
Fixes #2622
2021-01-05 21:18:45 +00:00
Tom Hughes
ea59d95f4a
Fix some new rubocop warnings
2020-08-06 22:27:30 +01:00
Andy Allan
1aa5a54419
Refactor site controller tests to inherit from ActionDispatch::IntegrationTest
...
This is the modern way of writing controller tests, since it uses the
rails middleware (among other things) and leads to more realistic tests.
Refs #2563
2020-04-22 11:09:13 +02:00
Tom Hughes
473da378b7
Remove fallback to hostip.info
...
We haven't used hostip.info in production for years, except
for when we did so by accident, leading to a two hour partial
outage when it went down.
2020-01-06 19:14:12 +00:00
Tom Hughes
2f1705db7c
Test language specific versions of about and copyright pages
2019-12-30 22:52:31 +00:00
Tom Hughes
bb2c5677df
Add some missing route tests for the site controller
2019-12-30 22:37:24 +00:00
Tom Hughes
ac6a872a48
Avoid errors when /edit is called on an invalid object
2019-12-16 21:23:09 +00:00
Tom Hughes
9153fd3559
Fix link in error page when a user has public edits disabled
2019-12-12 18:50:30 +00:00
Tom Hughes
e219916dcb
When overriding setup make sure to call the superclass
2019-09-05 21:24:20 +01:00
Andy Allan
d102c9aaf4
Move all settings to settings.yml
...
We leave the STATUS setting alone, since it's required before rails
boots. The test-specific settings now live in config/settings/test.yml
2019-03-13 18:06:23 +01:00
Andy Allan
3ec67ea2d3
Rename user_controller to users_controller
2018-10-03 15:31:10 +02:00
Tom Hughes
03408b6294
Update get/post etc to remove use of deprecated syntax
2017-06-27 08:26:44 +01:00
Tom Hughes
2357118c46
Avoid using format as a URL parameter name
...
This prevents rails confusing it with the builtin format
parameter derived from the URL extension.
2017-06-03 12:08:35 +01:00
Andy Allan
5d0ea28796
Remove the api_fixtures helper
...
This is no longer required, as the tests no longer use fixtures.
2017-06-01 10:59:48 +01:00
Andy Allan
938786e1ee
Refactor various controller tests to use factories.
2017-05-31 14:35:35 +01:00
Andy Allan
df721bc653
Convert more node fixtures to factories
2017-03-31 10:51:18 +01:00
Andy Allan
6335891a4c
User factories for browse, oauth_clients and site controller tests.
2017-02-23 14:13:09 +00:00
Andy Allan
7d9d496da2
Pass the user object, rather than the id, for sessions.
...
This simplifies the code slightly.
2017-02-22 09:57:18 +00:00
Tom Hughes
0814b4096c
Merge remote-tracking branch 'openstreetmap/pull/1347' into master
2017-02-05 16:02:20 +00:00
Andy Allan
8a6e8ae128
Convert client applications fixtures into a factory
...
Closes #1415
2017-01-26 18:03:51 +00:00
Tom Hughes
8eca904388
Rename stub_signup_requests to stub_hostip_requests
2016-11-09 20:36:09 +00:00
Andy Allan
7cc1cc618d
Extract the hostip.info stubbing into a common method.
...
There doesn't appear to be any before(:suite) equivalent for Minitest
so this is the least-surprising way to do this.
2016-11-09 16:00:47 +00:00
Andy Allan
d3d6e9902c
Stub out requests to hostip.info during tests
...
These are detecting the correct locale for showing terms during signup
2016-10-30 10:28:46 +01:00
Andy Allan
15689af6bf
Replace trace-related fixtures with factories.
...
The mocking and stubbing in the controller tests is
unfortunate, but the models interact directly with the filesystem
using the trace id so that's hard to control any other way.
2016-10-29 16:23:04 +02:00
Tom Hughes
c2e12ed77d
Add a note_with_comments factory
2016-10-10 15:08:11 +01:00
Andy Allan
886dc00ad4
Update site_controller_test to use note and note_comment factories.
2016-10-06 09:04:06 +01:00
Bryan Housel
98e2884f77
Remove test for iD and Internet Explorer
2015-12-10 18:48:22 -08:00
Tom Hughes
c9d35839be
Fix new rubocopy warnings
2015-08-18 20:57:14 +01:00
Tom Hughes
35be112092
Yet more tests...
2015-03-08 19:55:45 +00:00
Tom Hughes
93fb360a08
Add a few more tests
2015-03-07 00:50:35 +00:00
Tom Hughes
21d60e359a
Tests!
2015-03-04 21:49:43 +00:00
Tom Hughes
dc2a2c8ebd
Standardise on double quoted strings
2015-02-20 19:47:26 +00:00
Tom Hughes
ef7f3d800c
Fix most auto-correctable rubocop issues
2015-02-20 08:56:16 +00:00
Tom Hughes
c9e9ef1a89
Rewrite layer parameters in shortlinks correctly
...
Fixes #762
2014-06-17 21:15:36 +01:00
Tom Hughes
98184dfb9c
Reorganise tests to match modern rails test layout
2014-02-26 00:13:19 +00:00
