Extract the hostip.info stubbing into a common method.

There doesn't appear to be any before(:suite) equivalent for Minitest
so this is the least-surprising way to do this.
This commit is contained in:
Andy Allan 2016-11-09 16:00:47 +00:00
parent 4d73706ff3
commit 7cc1cc618d
7 changed files with 12 additions and 6 deletions

View file

@ -9,7 +9,7 @@ class SiteControllerTest < ActionController::TestCase
Object.const_set("ID_KEY", client_applications(:oauth_web_app).key)
Object.const_set("POTLATCH2_KEY", client_applications(:oauth_web_app).key)
stub_request(:get, "http://api.hostip.info/country.php?ip=0.0.0.0")
stub_signup_requests
end
##

View file

@ -4,7 +4,7 @@ class UserControllerTest < ActionController::TestCase
api_fixtures
setup do
stub_request(:get, "http://api.hostip.info/country.php?ip=0.0.0.0")
stub_signup_requests
end
##

View file

@ -7,7 +7,7 @@ class OAuthTest < ActionDispatch::IntegrationTest
include OAuth::Helper
setup do
stub_request(:get, "http://api.hostip.info/country.php?ip=127.0.0.1")
stub_signup_requests
end
def test_oauth10_web_app

View file

@ -5,7 +5,7 @@ class PageLocaleTest < ActionDispatch::IntegrationTest
def setup
I18n.locale = "en"
stub_request(:get, "http://api.hostip.info/country.php?ip=127.0.0.1")
stub_signup_requests
end
def teardown

View file

@ -4,7 +4,7 @@ class UserRolesTest < ActionDispatch::IntegrationTest
fixtures :users, :user_roles
setup do
stub_request(:get, "http://api.hostip.info/country.php?ip=127.0.0.1")
stub_signup_requests
end
test "grant" do

View file

@ -4,7 +4,7 @@ class UserTermsSeenTest < ActionDispatch::IntegrationTest
fixtures :users
setup do
stub_request(:get, "http://api.hostip.info/country.php?ip=127.0.0.1")
stub_signup_requests
end
def test_api_blocked

View file

@ -174,5 +174,11 @@ module ActiveSupport
url = "https://www.gravatar.com/avatar/#{hash}?d=404"
stub_request(:get, url).and_return(:status => status, :body => body)
end
def stub_signup_requests
# Controller tests and integration tests use different IPs
stub_request(:get, "http://api.hostip.info/country.php?ip=0.0.0.0")
stub_request(:get, "http://api.hostip.info/country.php?ip=127.0.0.1")
end
end
end