Commit graph

1707 commits

Author SHA1 Message Date
Thomas Wood
22292debda Data browser changes, make links more user friendly, displaying name tag where possible.
Changes to models ok'd (and suggested as temporary solution) by TomH
References #1777
2009-05-02 00:26:37 +00:00
Tom Hughes
5b0e72ec71 Get rid of foreign_class specification which is no longer needed. 2009-05-01 23:20:53 +00:00
Thomas Wood
026d7775d2 Fix indentation fail 2009-05-01 21:01:02 +00:00
Thomas Wood
38d8f178f6 Fix AMF controller failing tests due to changed error messages. 2009-05-01 20:49:51 +00:00
Shaun McDonald
d5a6efca7f a fix for the relation controller test 2009-05-01 10:29:19 +00:00
Tom Hughes
329b6faf91 Use association names with :joins instead of writing the SQL for the
join by hand.
2009-04-30 23:45:55 +00:00
Matt Amos
264b92bd9f Fixed bad coding practice in test. 2009-04-30 18:12:23 +00:00
Matt Amos
9cd381037a Fixed indeterminacy in test. 2009-04-30 18:09:54 +00:00
Matt Amos
5fe85e39a4 Fix failing test case. 2009-04-30 17:37:18 +00:00
Shaun McDonald
44c5248c1a couple of fixes to the changeset upload delete 2009-04-30 17:25:53 +00:00
Shaun McDonald
34381e56b7 give a id when a way is a member of a relation 2009-04-30 16:50:20 +00:00
Shaun McDonald
33d32bf737 We don't need an extra method for the amf controller for saving nodes, just catch the exception and do nothing with that exception. 2009-04-30 15:16:15 +00:00
Tom Hughes
088b4ae1e2 Do the statistics generation in a transaction. 2009-04-30 07:54:26 +00:00
Thomas Wood
2861236f60 Fix another error reporting bug similar to previous, again on printing RelationMember.id rather than RelationMember.relation.id 2009-04-30 07:10:57 +00:00
Thomas Wood
bb3108cb99 Fix grammar/referred relation id in precondition failed error.
From: "Precondition failed: The relation 5 is a used in relation 4,0."
To: "Precondition failed: The relation 5 is used in relation 4."
2009-04-30 06:52:14 +00:00
Thomas Wood
6a2fda5a99 Fix html: closing <a> tag. 2009-04-30 06:50:51 +00:00
Richard Fairhurst
41f85fb77d Potlatch 0.11a 2009-04-30 01:23:50 +00:00
Tom Hughes
5c734eb7ae Use :joins instead of :include to pull in the changesets - this does an
inner join instead of a left outer join (which is fine as all objects should
have a changeset) and more importantly stops rails generating a subquery
that doesn't work.
2009-04-29 23:45:54 +00:00
Shaun McDonald
db17af19bb fix more of the tests, particularly changeset controller. Needed more fixtures to fix them. The last failing changeset controller test needs some more work on the fixtures. 2009-04-29 22:25:49 +00:00
Shaun McDonald
dcca3ab0e9 More changeset test improvements. Another fixture was required for one of the tests 2009-04-29 17:29:58 +00:00
Matt Amos
3e9b6845d3 Fixed 'raw' raises by converting them to the appropriate OSM::APIError type. Made the error messages for placeholder fixing more informative. Added tests for these. 2009-04-29 10:07:35 +00:00
Tom Hughes
9acc6d3288 Eager load node and way details when processing a map call. 2009-04-28 16:26:06 +00:00
Tom Hughes
6d1c010213 Use the alias for the conditions as well... 2009-04-28 16:25:37 +00:00
Tom Hughes
074e5b0a11 Use an alias for current_relation_members to avoid clashing with
any attempt to eager load it.
2009-04-28 16:15:02 +00:00
Tom Hughes
4de6006567 Eager load nodes and node tags for the way when doing a getway call. 2009-04-28 15:55:54 +00:00
Tom Hughes
bcbbf1944b Don't bother running GC as it doesn't seem to get as much memory back
anyway plus the run_gc! method in the fastcgi dispatcher is a disaster
as it disables GC completely except for when it is forced by making a
call to the run_gc! method.
2009-04-28 14:07:51 +00:00
Tom Hughes
bf31791f65 Add a changeset cache to stop us looking up the same changeset over
and over again when processing a map call.
2009-04-28 13:40:30 +00:00
Tom Hughes
7ee10192eb Cope with sessions which don't exist. 2009-04-28 12:08:47 +00:00
Tom Hughes
c20f55045d Reject any AMF request which is not a POST request. 2009-04-28 11:14:15 +00:00
Tom Hughes
42359afa7e Fix session plugin work with the new ruby pg driver for postgresql. 2009-04-28 10:57:25 +00:00
Tom Hughes
04d0f45845 Remove debugging statement. 2009-04-28 09:00:01 +00:00
Tom Hughes
6f0b3ccbcd Don't log the contents of the changeset. 2009-04-28 08:59:33 +00:00
Thomas Wood
38c8e3e37e Quick fix to reference relation rather than relation_member when linking to the relation, not sure when the bug was introduced. Tests still need to be written for the browse controller.
Closes #1764
2009-04-27 21:26:23 +00:00
Thomas Wood
600d5b3a46 Further clarify descriptive texts regarding public editing. 2009-04-27 18:23:43 +00:00
Shaun McDonald
f47ba4fb23 Fix the node and relation tests from when the users with data public=false were disallowed from editing. Needed extra fixtures. 2009-04-27 11:57:58 +00:00
Shaun McDonald
0b6d9ce877 Improve the node/way/relation already deleted error message, and get rid bug in way model with missing new in exception 2009-04-27 11:49:56 +00:00
Tom Hughes
a7ea614dd0 Finish removing old request counting logic. 2009-04-26 23:27:40 +00:00
Tom Hughes
72b05157ae Remove old code to exit after 10000 requests as the memory limit code
should do a better job of controlling things.
2009-04-26 23:14:20 +00:00
Tom Hughes
85b3f7ffbc Tidy up. 2009-04-26 23:13:06 +00:00
Shaun McDonald
10fdeb2021 Make node update work with the new require data public to edit policy. Added convenience testing method for the require data public. Add 2 new fixtures that are owned by the public user. 2009-04-26 22:46:41 +00:00
Shaun McDonald
788e817e4a Make the report_error function support any http status code for added flexibility. 2009-04-26 21:11:31 +00:00
Shaun McDonald
b7596f7fbc Fix typo of missing .new for some of the errors. Tests are useful. 2009-04-26 20:56:58 +00:00
Richard Fairhurst
36660a3e45 move relations mapping out of way/node objects, so we don't need horrible expensive getrelations any more 2009-04-26 18:26:48 +00:00
Tom Hughes
e3d20bd607 Run GC if we hit the memory limit, and only restart if we are still too big. 2009-04-26 17:01:59 +00:00
Tom Hughes
1bd3710134 Increase the hard memory limit and set a lower soft limit that does a
clean restart between requests.
2009-04-26 16:56:40 +00:00
Tom Hughes
aadb91861a Do a GC run every 10 requests. 2009-04-26 11:28:55 +00:00
Tom Hughes
83aa2655f5 Null descriptions are not allowed. 2009-04-25 22:26:56 +00:00
Matt Amos
eed6fdf7db Fixed bug in exception creation. 2009-04-25 15:20:48 +00:00
Richard Fairhurst
0f1f4c29be ibid 2009-04-24 20:40:48 +00:00
Richard Fairhurst
2acdfd7132 a couple of minor revert fixes 2009-04-24 20:12:43 +00:00