Andy Allan
f18baae22e
Refactor login/logout into sessions controller
...
Certain controller methods are shared with oauth-based logins, and these have been
moved to a concern.
2021-03-24 11:32:46 +00:00
Tom Hughes
2d3972249c
Fix some rubocop todos
2020-08-02 19:38:58 +01:00
Tom Hughes
473da378b7
Remove fallback to hostip.info
...
We haven't used hostip.info in production for years, except
for when we did so by accident, leading to a two hour partial
outage when it went down.
2020-01-06 19:14:12 +00:00
Andy Allan
d102c9aaf4
Move all settings to settings.yml
...
We leave the STATUS setting alone, since it's required before rails
boots. The test-specific settings now live in config/settings/test.yml
2019-03-13 18:06:23 +01:00
Andy Allan
35a2d66e19
Remove require_terms_agreed configuration option
...
This has been set to true for 6 years in production. Refs #2097
As per other user settings, we set the terms as seen by default for tests,
and we can override that when necessary for specific tests.
2019-02-06 15:50:57 +01:00
Andy Allan
3795da4014
Remove the require_terms_seen configuration option
...
This option has been set to 'true' for over six years in production.
Refs #2097
2019-02-06 14:54:56 +01:00
Andy Allan
3ec67ea2d3
Rename user_controller to users_controller
2018-10-03 15:31:10 +02:00
Tom Hughes
cb3c4ec09b
Update for rubocop 0.54.0
2018-05-17 19:39:25 +01:00
Tom Hughes
a83030dab7
Fix new rubocop warnings
2018-01-22 18:55:45 +00:00
Tom Hughes
03408b6294
Update get/post etc to remove use of deprecated syntax
2017-06-27 08:26:44 +01:00
Tom Hughes
07673278f1
Remove deprecated get_via_direct and post_via_redirect methods
2017-06-06 00:03:39 +01:00
Andy Allan
a6a1a6baa5
Use user factory for user_terms_seen integration test.
2017-03-15 15:53:47 +00:00
Tom Hughes
8eca904388
Rename stub_signup_requests to stub_hostip_requests
2016-11-09 20:36:09 +00:00
Tom Hughes
5c9f1310b0
Convert more 'setup do' to 'def setup' for consistency
2016-11-09 20:33:55 +00:00
Andy Allan
7cc1cc618d
Extract the hostip.info stubbing into a common method.
...
There doesn't appear to be any before(:suite) equivalent for Minitest
so this is the least-surprising way to do this.
2016-11-09 16:00:47 +00:00
Andy Allan
d3d6e9902c
Stub out requests to hostip.info during tests
...
These are detecting the correct locale for showing terms during signup
2016-10-30 10:28:46 +01:00
Tom Hughes
4607ac2d30
More work on user tests
2015-03-09 00:58:38 +00:00
Tom Hughes
21d60e359a
Tests!
2015-03-04 21:49:43 +00:00
Tom Hughes
a6b84a0294
Fix more rubocop style issues
2015-02-24 23:12:02 +00:00
Tom Hughes
dc2a2c8ebd
Standardise on double quoted strings
2015-02-20 19:47:26 +00:00
Tom Hughes
ef7f3d800c
Fix most auto-correctable rubocop issues
2015-02-20 08:56:16 +00:00
Tom Hughes
34e3e51456
Cleanup trailing whitespace
2015-02-20 08:56:16 +00:00
Tom Hughes
98184dfb9c
Reorganise tests to match modern rails test layout
2014-02-26 00:13:19 +00:00
Tom Hughes
25720e3ee3
Make sure the "terms seen" tests actually run
2013-09-29 15:43:16 +01:00
Tom Hughes
d8399d3e18
IntegrationTest is now in ActionDispatch not ActionController
2013-09-21 11:35:46 +01:00
Tom Hughes
ef820ade46
Fix some incorrect tests that relied on the default routes
2012-03-09 20:16:18 +00:00
Tom Hughes
d9ba5ff31f
Update tests for changes to login form
2011-09-24 15:13:40 +01:00
Matt Amos
3700b534e4
Change the test for whether the CTs have been seen to use the
...
user preferences API call rather than user details, as that one
is no longer blocked.
2011-05-01 02:34:38 +01:00
Matt Amos
c21aa5933a
Added flash notice for CTs decline
...
Also ensured that CTs are either accepted or declined and cannot
be inadvertently bypassed.
2011-04-18 00:29:15 +01:00
Tom Hughes
452879ee03
Don't run the user terms tests unless REQUIRE_TERMS_SEEN is set
2011-04-03 13:46:16 +01:00
Matt Amos
8b12abd5bb
Phase 2 CTs implementation and tests, with config parameter
2011-04-03 13:46:16 +01:00