Convert tests using OAuth 1 tokens to use OAuth 2 tokens

This commit is contained in:
Tom Hughes 2024-07-24 19:11:12 +01:00
parent 083c37fead
commit 1a7d68ccbc
4 changed files with 24 additions and 22 deletions

View file

@ -303,11 +303,11 @@ module Api
# But writing oauth tests is hard, and so it's easier to put in a controller test.)
def test_api_write_and_terms_agreed_via_token
user = create(:user, :terms_agreed => nil)
token = create(:access_token, :user => user, :allow_write_api => true)
token = create(:oauth_access_token, :resource_owner_id => user.id, :scopes => %w[write_api])
changeset = create(:changeset, :closed)
assert_difference "ChangesetComment.count", 0 do
signed_post changeset_comment_path(:id => changeset), :params => { :text => "This is a comment" }, :oauth => { :token => token }
post changeset_comment_path(:id => changeset), :params => { :text => "This is a comment" }, :headers => bearer_authorization_header(token.token)
end
assert_response :forbidden
@ -316,7 +316,7 @@ module Api
user.save!
assert_difference "ChangesetComment.count", 1 do
signed_post changeset_comment_path(:id => changeset), :params => { :text => "This is a comment" }, :oauth => { :token => token }
post changeset_comment_path(:id => changeset), :params => { :text => "This is a comment" }, :headers => bearer_authorization_header(token.token)
end
assert_response :success
end

View file

@ -252,10 +252,10 @@ module Api
# read preferences
def test_show_using_token
user = create(:user)
token = create(:access_token, :user => user, :allow_read_prefs => true)
token = create(:oauth_access_token, :resource_owner_id => user.id, :scopes => %w[read_prefs])
create(:user_preference, :user => user, :k => "key", :v => "value")
signed_get user_preference_path(:preference_key => "key"), :oauth => { :token => token }
get user_preference_path(:preference_key => "key"), :headers => bearer_authorization_header(token.token)
assert_response :success
end
@ -264,10 +264,10 @@ module Api
# by other methods.
def test_show_using_token_fail
user = create(:user)
token = create(:access_token, :user => user, :allow_read_prefs => false)
token = create(:oauth_access_token, :resource_owner_id => user.id)
create(:user_preference, :user => user, :k => "key", :v => "value")
signed_get user_preference_path(:preference_key => "key"), :oauth => { :token => token }
get user_preference_path(:preference_key => "key"), :headers => bearer_authorization_header(token.token)
assert_response :forbidden
end
end