improve syntax for accessing service outputs

This commit is contained in:
Daniel Barlow 2022-10-02 16:35:55 +01:00
parent 2d7bb6b2fa
commit e9f04931fa
5 changed files with 22 additions and 20 deletions

View file

@ -10,10 +10,11 @@ test -n "$contents" && for d in $contents; do
mkdir -p $out/${name}/contents.d mkdir -p $out/${name}/contents.d
touch $out/${name}/contents.d/$d touch $out/${name}/contents.d/$d
done done
test -n "$run" && (echo -e "#!$shell\n$run" > $out/${name}/run) test -n "$run" && (echo -e "$run" > $out/${name}/run)
test -n "${notificationFd}" && (echo ${notificationFd} > $out/${name}/notification-fd) test -n "${notificationFd}" && (echo ${notificationFd} > $out/${name}/notification-fd)
test -n "$up" && (echo -e "#!$shell\n$up" > $out/${name}/up) test -n "$up" && (echo -e "$up" > $out/${name}/up)
test -n "$down" && (echo -e "#!$shell\n$down" > $out/${name}/down) test -n "$down" && (echo -e "$down" > $out/${name}/down)
( cd $out && ln -s /run/service-state/${name} ./.outputs )
for i in $out/${name}/{down,up,run} ; do test -f $i && chmod +x $i; done for i in $out/${name}/{down,up,run} ; do test -f $i && chmod +x $i; done
true true
# (echo $out/${name} && cd $out/${name} && find . -ls) # (echo $out/${name} && cd $out/${name} && find . -ls)

View file

@ -4,12 +4,16 @@
, lib , lib
, busybox , busybox
, callPackage , callPackage
, writeAshScript , writeScript
}: }:
let let
inherit (builtins) concatStringsSep; inherit (builtins) concatStringsSep;
output = service: name: "/run/service-state/${service.name}/${name}"; output = service: name: "/run/service-state/${service.name}/${name}";
serviceScript = commands : ''
#!${busybox}/bin/sh
output() { cat $1/.outputs/$2; }
${commands}
'';
service = { service = {
name name
, serviceType , serviceType
@ -21,14 +25,12 @@ let
, dependencies ? [] , dependencies ? []
, contents ? [] , contents ? []
} @ args: stdenvNoCC.mkDerivation { } @ args: stdenvNoCC.mkDerivation {
# stdenvNoCC is to avoid generating derivations with names # we use stdenvNoCC to avoid generating derivations with names
# like foo.service-mips-linux-musl # like foo.service-mips-linux-musl
inherit name serviceType; inherit name serviceType up down run;
inherit run up down;
buildInputs = dependencies ++ contents; buildInputs = dependencies ++ contents;
dependencies = builtins.map (d: d.name) dependencies; dependencies = builtins.map (d: d.name) dependencies;
contents = builtins.map (d: d.name) contents; contents = builtins.map (d: d.name) contents;
shell = "${busybox}/bin/sh";
notificationFd = notification-fd; notificationFd = notification-fd;
builder = ./builder.sh; builder = ./builder.sh;
}; };
@ -41,6 +43,7 @@ let
, dependencies ? [] , dependencies ? []
} @ args: service (args //{ } @ args: service (args //{
serviceType = "longrun"; serviceType = "longrun";
run = serviceScript run;
}); });
oneshot = { oneshot = {
name name
@ -51,8 +54,8 @@ let
, ... , ...
} @ args : service (args // { } @ args : service (args // {
serviceType = "oneshot"; serviceType = "oneshot";
up = writeAshScript "${name}-up" {} up; up = writeScript "${name}-up" (serviceScript up);
down = writeAshScript "${name}-down" {} down; down= writeScript "${name}-down" (serviceScript down);
}); });
bundle = { bundle = {
name name

View file

@ -41,7 +41,7 @@ in rec {
services.defaultroute4 = route { services.defaultroute4 = route {
name = "defautlrote"; name = "defautlrote";
via = "$(cat ${output services.pppoe "address"})"; via = "$(output ${services.pppoe} address)";
target = "default"; target = "default";
dependencies = [ services.pppoe ]; dependencies = [ services.pppoe ];
}; };
@ -49,7 +49,7 @@ in rec {
services.packet_forwarding = services.packet_forwarding =
let let
iface = services.pppoe; iface = services.pppoe;
filename = "/proc/sys/net/ipv4/conf/$(cat ${output iface "ifname"})/forwarding"; filename = "/proc/sys/net/ipv4/conf/$(output ${iface} ifname)/forwarding";
in oneshot { in oneshot {
name = "let-the-ip-flow"; name = "let-the-ip-flow";
up = "echo 1 > ${filename}"; up = "echo 1 > ${filename}";

View file

@ -1,7 +1,7 @@
{ config, pkgs, ... } : { config, pkgs, ... } :
let let
inherit (pkgs.liminix.networking) interface address udhcpc odhcpc route; inherit (pkgs.liminix.networking) interface address udhcpc odhcpc route;
inherit (pkgs.liminix.services) oneshot longrun bundle target output; inherit (pkgs.liminix.services) oneshot longrun bundle target;
in rec { in rec {
services.loopback = services.loopback =
let iface = interface { type = "loopback"; device = "lo";}; let iface = interface { type = "loopback"; device = "lo";};
@ -21,11 +21,9 @@ in rec {
in odhcpc iface { uid = "e7"; }; in odhcpc iface { uid = "e7"; };
services.ntp = longrun { services.ntp = longrun {
# the simplest approach at the consumer end is to require the
# producer to create a file per output variable.
name = "ntp"; name = "ntp";
run = let inherit (services) dhcpv4 dhcpv6; run = let inherit (services) dhcpv4 dhcpv6;
in "${pkgs.ntp}/bin/ntpd $(cat ${output dhcpv4 "ntp_servers"}) $(cat ${output dhcpv6 "NTP_IP"})"; in "${pkgs.ntp}/bin/ntpd $(output ${dhcpv4} ntp_servers) $(output ${dhcpv6} NTP_IP})";
# I don't think it's possible to standardise the file names # I don't think it's possible to standardise the file names
# generally, as different services have different outputs, but it # generally, as different services have different outputs, but it
@ -42,7 +40,7 @@ in rec {
services.defaultroute4 = route { services.defaultroute4 = route {
name = "defautlrote"; name = "defautlrote";
via = "$(cat ${output services.dhcpv4 "address"})"; via = "$(output ${services.dhcpv4} address)";
target = "default"; target = "default";
dependencies = [ services.dhcpv4 ]; dependencies = [ services.dhcpv4 ];
}; };
@ -50,7 +48,7 @@ in rec {
services.packet_forwarding = services.packet_forwarding =
let let
iface = services.dhcpv4; iface = services.dhcpv4;
filename = "/proc/sys/net/ipv4/conf/$(cat ${output iface "ifname"})/forwarding"; filename = "/proc/sys/net/ipv4/conf/$(output ${iface} ifname)/forwarding";
in oneshot { in oneshot {
name = "let-the-ip-flow"; name = "let-the-ip-flow";
up = "echo 1 > ${filename}"; up = "echo 1 > ${filename}";

View file

@ -1,7 +1,7 @@
{ config, pkgs, lib, ... } : { config, pkgs, lib, ... } :
let let
inherit (pkgs.liminix.networking) interface address hostapd route dnsmasq; inherit (pkgs.liminix.networking) interface address hostapd route dnsmasq;
inherit (pkgs.liminix.services) oneshot longrun bundle target output; inherit (pkgs.liminix.services) oneshot longrun bundle target;
in rec { in rec {
services.loopback = services.loopback =
let iface = interface { type = "loopback"; device = "lo";}; let iface = interface { type = "loopback"; device = "lo";};