DGNum/thurned
7
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

feat(network): add network configuration actions #1

Merged
thubrecht merged 2 commits from network-config into main 2025-09-01 11:14:10 +02:00
Conversation 3 Commits 2 Files changed 2 +16 -15
lbailly commented 2025-08-31 14:16:47 +02:00
Member
Copy link

(need tests)

(need tests)
lbailly force-pushed network-config from a73e029420 to 4e601a39cf 2025-08-31 15:37:49 +02:00 Compare
lbailly force-pushed network-config from 4e601a39cf to 6ad9d3dcc8 2025-08-31 15:47:18 +02:00 Compare
lbailly force-pushed network-config from 6ad9d3dcc8 to c647ad647b 2025-08-31 15:47:53 +02:00 Compare
thubrecht requested changes 2025-08-31 15:55:20 +02:00
Dismissed
src/thurned/network.py Outdated
@ -29,1 +19,3 @@
pass
with NDB() as ndb:
for room in site_rooms:
vlan = data.get(room, None)
thubrecht commented 2025-08-31 15:48:37 +02:00
Owner
Copy link

vlan = data.get(room), par défaut get renvoie None

`vlan = data.get(room)`, par défaut `get` renvoie `None`
lbailly marked this conversation as resolved
src/thurned/network.py Outdated
@ -30,0 +28,4 @@
room_intf.set(
"master", ndb.interfaces["br-user-{}".format(vlan)]["index"]
)
room_intf.commit()
thubrecht commented 2025-08-31 15:55:00 +02:00
Owner
Copy link
room_interface = ndb.interfaces["vlan-r-{}".format(room)]
room_interface.set(
    "master",
    ndb.interfaces["br-user-{}".format(vlan)]["index"] if vlan is not None else 0,
)
room_interface.commit()
```python room_interface = ndb.interfaces["vlan-r-{}".format(room)] room_interface.set( "master", ndb.interfaces["br-user-{}".format(vlan)]["index"] if vlan is not None else 0, ) room_interface.commit() ```
thubrecht commented 2025-08-31 21:21:02 +02:00
Owner
Copy link

D'ailleurs, on peut faire .set(master=...) qui est mieux imo

D'ailleurs, on peut faire `.set(master=...)` qui est mieux imo
lbailly marked this conversation as resolved
mdebray reviewed 2025-08-31 17:33:24 +02:00
src/thurned/network.py Outdated
@ -30,0 +25,4 @@
room_intf.commit()
else:
room_intf = ndb.interfaces["vlan-r-{}".format(room)]
room_intf.set(
mdebray commented 2025-08-31 17:33:24 +02:00
Owner
Copy link

Je pose une question d'ignorant mais de set le bridge plusieurs fois ça fera des noop si il n'y a rien à changer ?

En particulier ce serait bête de couper le reseau toutes les heures.

Merci pour ton taf incroyable sinon !!!

Je pose une question d'ignorant mais de set le bridge plusieurs fois ça fera des noop si il n'y a rien à changer ? En particulier ce serait bête de couper le reseau toutes les heures. Merci pour ton taf incroyable sinon !!!
thubrecht commented 2025-08-31 21:25:29 +02:00
Owner
Copy link

Après avoir lu le code normalement si le bridge est déjà set correctement pyroute2 ne fera pas de commande

Après avoir lu le code normalement si le bridge est déjà set correctement `pyroute2` ne fera pas de commande
lbailly commented 2025-09-01 11:07:51 +02:00
Author
Member
Copy link

j'avous j'avais pas check, mais je me suis dit que même s'il fesait une commande, linux la transformerais probablement en noop.

j'avous j'avais pas check, mais je me suis dit que même s'il fesait une commande, linux la transformerais probablement en noop.
lbailly marked this conversation as resolved
lbailly force-pushed network-config from c647ad647b to 32aed852e9 2025-09-01 11:12:16 +02:00 Compare
thubrecht approved these changes 2025-09-01 11:13:57 +02:00
thubrecht force-pushed network-config from 32aed852e9 to f7115c9354 2025-09-01 11:14:02 +02:00 Compare
Sign in to join this conversation.
Reviewers
No reviewers
thubrecht
Labels
Clear labels
  
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
wontfix

This won't be fixed

No labels
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: DGNum/thurned#1
No description provided.
Delete branch "network-config"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?