be python3.4 compatible #19

2019-08-06T18:15:39+02:00

Solvik commented

2019-08-06 18:15:39 +02:00

(Migrated from github.com)

No description provided.

ramnes (Migrated from github.com) reviewed 2019-08-07 01:34:52 +02:00

ramnes (Migrated from github.com) left a comment

return dict(
    self._parse_ethtool_output(),
    **self._parse_ethtool_module_output()
)

would be a closer implementation of the previous one here.

But it seems to me that you don't need to create a new dictionnary in the first place, and that here you could very well go with something simpler like:

output = self._parse_ethtool_output()
output.update(self._parse_ethtool_module_output())
return output

Now I'm just saying something because you asked my review but frankly it's not a big deal, all those ways work. 😉

```python return dict( self._parse_ethtool_output(), **self._parse_ethtool_module_output() ) ``` would be a closer implementation of the previous one here. But it seems to me that you don't need to create a new dictionnary in the first place, and that here you could very well go with something simpler like: ```python output = self._parse_ethtool_output() output.update(self._parse_ethtool_module_output()) return output ``` Now I'm just saying something because you asked my review but frankly it's not a big deal, all those ways work. :wink:

ramnes (Migrated from github.com) reviewed 2019-08-08 12:10:42 +02:00

netbox_agent/ethtool.py

					
				@ -22,0 +24,4 @@

				    z.update(y)

				    return z

ramnes (Migrated from github.com) commented

2019-08-08 12:10:42 +02:00

You forgot to remove this apparently.

Sign in to join this conversation.

No reviewers

No labels

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: DGNum/netbox-agent#19

Rows
Columns