DGNum/infrastructure
11
6
Fork 2
Code Issues 20 Pull requests 13 Projects 1 Releases Packages Wiki Activity Actions

feat(vault01): Add user vlans #93

Merged
thubrecht merged 1 commit from :main into main 2024-04-16 09:49:03 +02:00
Conversation 0 Commits 1 Files changed 1 +16 -1
lbailly commented 2024-04-15 09:58:56 +02:00
Member
Copy link

Only the first 300 vlans are activated, 850 make it crash

Only the first 300 vlans are activated, 850 make it crash
thubrecht reviewed 2024-04-15 10:13:20 +02:00
machines/vault01/networking.nix Outdated
@ -38,0 +46,4 @@
name = "vlan-user-${builtins.toString vlan}";
value = {
Id = vlan;
address = [ "10.0.${builtins.toString prefix24nb}.${builtins.toString (prefix29nb + 1)}/29" ];
thubrecht commented 2024-04-15 10:09:11 +02:00
Owner
Copy link

Pourquoi pas mettre le +1 directement dans le calcul de prefix29nb ?

Pourquoi pas mettre le +1 directement dans le calcul de prefix29nb ?
lbailly commented 2024-04-15 22:53:13 +02:00
Author
Member
Copy link

Je trouvais ça plus sensé sémantiquement : 10.0.${builtins.toString prefix24nb}.${builtins.toString prefix29nb} c'est l'adresse du réseau, avec le +1 c'est notre adresse, et si on vient à en avoir besoin, +7 c'est le broadcast

Je peut changer si tu préfères

Je trouvais ça plus sensé sémantiquement : `10.0.${builtins.toString prefix24nb}.${builtins.toString prefix29nb}` c'est l'adresse du réseau, avec le +1 c'est notre adresse, et si on vient à en avoir besoin, +7 c'est le broadcast Je peut changer si tu préfères
thubrecht commented 2024-04-16 09:39:25 +02:00
Owner
Copy link

Non, ça me va

Non, ça me va
lbailly force-pushed main from 8a7f275e92 to 04c553b162 2024-04-15 23:01:44 +02:00 Compare
thubrecht force-pushed main from 04c553b162 to 01c2505491 2024-04-16 09:40:48 +02:00 Compare
thubrecht merged commit 01c2505491 into main 2024-04-16 09:49:03 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
awaiting
awaiting-author
Awaiting for the author interaction (e.g. QA/confirmation/final merge)

  
awaiting
awaiting-reviewer
Awaiting for a privileged reviewer to approve this PR

  
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
wontfix

This won't be fixed

No labels
awaiting
awaiting-author
awaiting
awaiting-reviewer
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: DGNum/infrastructure#93
No description provided.
Delete branch ":main"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?