fix(netconf): init dgn-vlans module and remove vlans.<name>.vlan-id-list as it's very limitated #724
ecoppens
mdebray
Labels
No labels
awaiting
awaiting-author
awaiting
awaiting-reviewer
bot
deployed
Silenced alert
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
DGNum/infrastructure!724
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "no-id-list"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
a224024d4bdc33b6f99edc33b6f99e2f1af81e8a2f1af81e8a3e2e527b52727398e8209fd98ebe349fd98ebe34b266cb02c9WIP: fix(netconf): init dgn-vlans module and remove vlans.<name>.vlan-id-list as it's very limitatedto fix(netconf): init dgn-vlans module and remove vlans.<name>.vlan-id-list as it's very limitated@ -78,3 +38,1 @@Incompatible with vlans.${name}.id.'';};On fera un revert si on veut revert, imo on del plutôt que de comment (juste garde un comment en disant que les listes ne semblent pas marcher d'après le JTAC)
t'es un mec malin toi
@ -107,3 +107,1 @@id-list = concatStringsSep "" (map (vlan: "<vlan-id-list>${toString vlan}</vlan-id-list>") config.id-list);# id-list = concatStringsSep "" (same
b266cb02c94a5a6a180fJe pense c'est pas la peine d'implem maintenant vu que on est pas sûr que ce soit le pb. Mais cette review est là pour le futur
@ -86,3 +91,4 @@);description = ''Vlans that can be used on this interface.Only one ID should be here for "access" mode of operation.Ajouter un description un peu plus claire ici
@ -0,0 +89,4 @@};config.vlans =mapAttrs (_: singleAttr "id") named// mapFuse (vlan: { "unnamed-${toString vlan}".id = vlan; }) (pk pas ${nom-du-vlan}-${id}, j'ai pas trop réfléchi à comment implem proprement mais c'est une idée
Est-ce qu'on continue ça ou on drop car vraisemblablement pas la solutions au bug ?
on drop mais quand on aura la solution au bug
View command line instructions
Checkout
From your project repository, check out a new branch and test the changes.