DGNum/infrastructure
10
5
Fork 3
Code Issues 34 Pull requests 26 Projects 1 Releases Packages Wiki Activity Actions

feat(bmc): add BMC IPs to DNS and nginx #560

Open
ecoppens wants to merge 4 commits from feature/add-bmc-ips into main
pull from: feature/add-bmc-ips
merge into: DGNum:main
Conversation 4 Commits 4 Files changed 7 +70 -7
ecoppens commented 2025-07-22 12:46:04 +02:00
Owner
Copy link
No description provided.
ecoppens force-pushed feature/add-bmc-ips from 17dd1a0289 to d44d37ff70 2025-07-22 18:05:19 +02:00 Compare
ecoppens force-pushed feature/add-bmc-ips from 9e8d69f4a3 to 5685a54b56 2025-07-22 18:28:28 +02:00 Compare
lbailly requested changes 2025-07-22 18:58:44 +02:00
Dismissed
lbailly left a comment
Member
Copy link

Idéalement faudrait pouvoir représenter les ups et pdu qui sont pas dans l'infra, mais en second temps je pense.
Je connais pas les dns challenge LE, si c'est pas trop compliqué a setup se serait pas mal pour le nginx, sinon second temps aussi

Idéalement faudrait pouvoir représenter les ups et pdu qui sont pas dans l'infra, mais en second temps je pense. Je connais pas les dns challenge LE, si c'est pas trop compliqué a setup se serait pas mal pour le nginx, sinon second temps aussi
meta/dns.nix Outdated
@ -288,0 +301,4 @@
}
) nixosNodes)
// {
proxy.subdomains = mapAttrs' (
lbailly commented 2025-07-22 18:51:55 +02:00
Member
Copy link

On veut pas plutôt avoir proxy.${host}.${site}.bmc.internal plutôt que ${host}.${site}.proxy.bmc.internal ?

On veut pas plutôt avoir `proxy.${host}.${site}.bmc.internal` plutôt que `${host}.${site}.proxy.bmc.internal` ?
👍 1
ecoppens marked this conversation as resolved
meta/dns.nix Outdated
@ -288,0 +305,4 @@
host:
{ site, ... }:
nameValuePair "${host}.${site}" {
A = optional (meta.network.${host}.bmcIp != null) meta.network.vault01.netbirdIp;
lbailly commented 2025-07-22 18:53:00 +02:00
Member
Copy link

CNAME = vault01.truc.infra plutôt

`CNAME = vault01.truc.infra` plutôt
ecoppens commented 2025-07-22 19:08:25 +02:00
Author
Owner
Copy link

on veut passer par le VPN, donc ça nécessite que je crée un vpn.internal.dgnum.eu (sauf si on utilise les xxx.dgnum)

on veut passer par le VPN, donc ça nécessite que je crée un `vpn.internal.dgnum.eu` (sauf si on utilise les `xxx.dgnum`)
ecoppens commented 2025-07-22 19:19:27 +02:00
Author
Owner
Copy link

je viens de voir en lisant la zone que y'avait des private.xxx.yyy.infra.dgnum.eu. qui correspondent à ça, je modifie

je viens de voir en lisant la zone que y'avait des `private.xxx.yyy.infra.dgnum.eu.` qui correspondent à ça, je modifie
ecoppens marked this conversation as resolved
ecoppens force-pushed feature/add-bmc-ips from 5685a54b56 to 0ae45ecf94 2025-07-22 19:13:36 +02:00 Compare
ecoppens force-pushed feature/add-bmc-ips from 0ae45ecf94 to 8e51d03440 2025-07-22 19:14:27 +02:00 Compare
ecoppens commented 2025-07-22 19:16:15 +02:00
Author
Owner
Copy link

@lbailly wrote in #560 (comment):

Idéalement faudrait pouvoir représenter les ups et pdu qui sont pas dans l'infra, mais en second temps je pense.

Je suis d'accord avec toi, je pense que ça sera pas trop difficile à intégrer (suffit juste d'avoir des noeuds avec des bmcIp)

Je connais pas les dns challenge LE, si c'est pas trop compliqué a setup se serait pas mal pour le nginx, sinon second temps aussi

Encore une fois je suis d'accord, je sais juste pas comment setup (et j'ai été traumatisé par qq à la DINUM qui a pris 4 semaines pour setup ça (mais bon...))

@lbailly wrote in https://git.dgnum.eu/DGNum/infrastructure/pulls/560#issuecomment-16625: > Idéalement faudrait pouvoir représenter les ups et pdu qui sont pas dans l'infra, mais en second temps je pense. Je suis d'accord avec toi, je pense que ça sera pas trop difficile à intégrer (suffit juste d'avoir des noeuds avec des bmcIp) > Je connais pas les dns challenge LE, si c'est pas trop compliqué a setup se serait pas mal pour le nginx, sinon second temps aussi Encore une fois je suis d'accord, je sais juste pas comment setup (et j'ai été traumatisé par qq à la DINUM qui a pris 4 semaines pour setup ça (mais bon...))
ecoppens force-pushed feature/add-bmc-ips from 8e51d03440 to 30d7981a7c 2025-07-22 19:18:04 +02:00 Compare
ecoppens force-pushed feature/add-bmc-ips from 30d7981a7c to e6a9c075bb 2025-07-22 19:22:05 +02:00 Compare
lbailly approved these changes 2025-07-22 19:48:16 +02:00
Dismissed
requested review from thubrecht 2025-07-22 19:48:28 +02:00
lbailly commented 2025-07-22 19:56:22 +02:00
Member
Copy link

Acme dns a pas l'air trop dur, mais à Tom de voir vu que c'est lui le dns

Acme dns a pas l'air trop dur, mais à Tom de voir vu que c'est lui le dns
ecoppens changed title from WIP: feat(bmc): add BMC IPs to DNS and nginx to feat(bmc): add BMC IPs to DNS and nginx 2025-07-25 13:25:24 +02:00
ecoppens force-pushed feature/add-bmc-ips from d940d70956 to 480ea3e6e6 2025-07-25 13:25:29 +02:00 Compare
ecoppens dismissed lbailly's review 2025-07-25 13:25:29 +02:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

All checks were successful
Check meta / check_meta (push) Successful in 14s
Required
Details
Check meta / check_dns (push) Successful in 15s
Required
Details
Check meta / check_meta (pull_request) Successful in 14s
Required
Details
Check meta / check_dns (pull_request) Successful in 15s
Required
Details
Check workflows / check_workflows (pull_request) Successful in 17s
Required
Details
Run pre-commit on all files / pre-commit (push) Successful in 25s
Required
Details
Run pre-commit on all files / pre-commit (pull_request) Successful in 30s
Required
Details
Build all the nodes / Jaccess01 (pull_request) Successful in 21s
Required
Details
Build all the nodes / Jaccess04 (pull_request) Successful in 21s
Required
Details
Build all the nodes / ap01 (pull_request) Successful in 35s
Required
Details
Build all the nodes / bridge01 (pull_request) Successful in 44s
Required
Details
Build all the nodes / build01 (pull_request) Successful in 44s
Required
Details
Build all the nodes / cof02 (pull_request) Successful in 47s
Required
Details
Build all the nodes / geo01 (pull_request) Successful in 44s
Required
Details
Build all the nodes / geo02 (pull_request) Successful in 42s
Required
Details
Build all the nodes / compute01 (pull_request) Successful in 1m13s
Required
Details
Build all the nodes / hypervisor01 (pull_request) Successful in 49s
Required
Details
Build all the nodes / hypervisor02 (pull_request) Successful in 46s
Required
Details
Build all the nodes / hypervisor03 (pull_request) Successful in 43s
Required
Details
Build all the nodes / netcore01 (pull_request) Successful in 20s
Required
Details
Build all the nodes / iso (pull_request) Successful in 51s
Required
Details
Build all the nodes / netcore02 (pull_request) Successful in 21s
Required
Details
Build all the nodes / lab-router01 (pull_request) Successful in 43s
Required
Details
Build all the nodes / krz01 (pull_request) Successful in 1m5s
Required
Details
Build all the nodes / rescue01 (pull_request) Successful in 54s
Required
Details
Build all the nodes / tower01 (pull_request) Successful in 45s
Required
Details
Build all the nodes / storage01 (pull_request) Successful in 48s
Required
Details
Build all the nodes / vault01 (pull_request) Successful in 54s
Required
Details
Build the shell / build-shell (pull_request) Successful in 22s
Required
Details
Build all the nodes / web02 (pull_request) Successful in 44s
Required
Details
Build all the nodes / web01 (pull_request) Successful in 1m2s
Required
Details
Build all the nodes / web03 (pull_request) Successful in 49s
Required
Details
Build all the nodes / zulip01 (pull_request) Successful in 43s
Required
Details
This pull request has changes conflicting with the target branch.
  • machines/nixos/vault01/_configuration.nix
  • meta/nodes/netconf.nix
  • meta/nodes/nixos.nix
  • meta/options.nix
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin feature/add-bmc-ips:feature/add-bmc-ips
git switch feature/add-bmc-ips
Sign in to join this conversation.
Reviewers
No reviewers
thubrecht
Labels
Clear labels   
awaiting
awaiting-author
Awaiting for the author interaction (e.g. QA/confirmation/final merge)

  
awaiting
awaiting-reviewer
Awaiting for a privileged reviewer to approve this PR

  
bot

Pull Request opened by a bot

  
deployed

This PR is currently deployed on the infra

  
Silenced alert

This is a known and silenced alert.

  
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
wontfix

This won't be fixed

No labels
awaiting
awaiting-author
awaiting
awaiting-reviewer
bot
deployed
Silenced alert
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: DGNum/infrastructure#560
No description provided.
Delete branch "feature/add-bmc-ips"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?