zulip #463

Open
mdebray wants to merge 58 commits from zulip into main
Owner
No description provided.
feat(zulip): init module
Some checks failed
Check meta / check_dns (pull_request) Successful in 14s
Check meta / check_meta (pull_request) Successful in 16s
Check workflows / check_workflows (pull_request) Failing after 17s
Build all the nodes / Jaccess01 (pull_request) Successful in 21s
Build all the nodes / Jaccess04 (pull_request) Successful in 23s
Run pre-commit on all files / pre-commit (pull_request) Successful in 29s
Build all the nodes / ap01 (pull_request) Successful in 38s
Build all the nodes / bridge01 (pull_request) Successful in 50s
Build all the nodes / netcore02 (pull_request) Successful in 27s
Build all the nodes / netcore01 (pull_request) Successful in 29s
Build all the nodes / zulip02 (pull_request) Failing after 21s
Build all the nodes / build01 (pull_request) Successful in 1m0s
Build all the nodes / geo01 (pull_request) Successful in 51s
Build all the nodes / cof02 (pull_request) Successful in 56s
Build all the nodes / geo02 (pull_request) Successful in 55s
Build all the nodes / hypervisor01 (pull_request) Successful in 55s
Build all the nodes / hypervisor02 (pull_request) Successful in 54s
Build all the nodes / hypervisor03 (pull_request) Successful in 50s
Build the shell / build-shell (pull_request) Successful in 23s
Build all the nodes / lab-router01 (pull_request) Successful in 53s
Build all the nodes / compute01 (pull_request) Successful in 1m27s
Build all the nodes / iso (pull_request) Successful in 1m15s
Build all the nodes / web02 (pull_request) Successful in 1m8s
Build all the nodes / tower01 (pull_request) Successful in 1m9s
Build all the nodes / web03 (pull_request) Successful in 1m12s
Build all the nodes / vault01 (pull_request) Successful in 1m18s
Build all the nodes / rescue01 (pull_request) Successful in 1m20s
Build all the nodes / web01 (pull_request) Successful in 1m20s
Build all the nodes / storage01 (pull_request) Successful in 1m45s
Build all the nodes / krz01 (pull_request) Successful in 1m54s
929c74fdbe
Author
Owner

Depends on #526

Depends on https://git.dgnum.eu/DGNum/infrastructure/pulls/526
lbailly left a comment
Member

Pour commencer, j'ai pas encore check le module

Pour commencer, j'ai pas encore check le module
@ -0,0 +63,4 @@
+) -> Any: ...
+@overload
+def get_secret_json(key: str, default_value: Any, development_only: bool = False) -> Any: ...
+def get_secret_json(
Member

triple overload ?

triple overload ?
Author
Owner

J'ai copié collé une autre fonction de upstream. Je trouve ça bien de follow les conventions de upstream

J'ai copié collé une autre fonction de upstream. Je trouve ça bien de follow les conventions de upstream
lbailly marked this conversation as resolved
@ -0,0 +94,4 @@
- print("Mobile Push Notification Service registration successfully transferred.")
+ print("Success! Here are the received credentials:")
+ print(f"Org id: {org_id!r}")
+ print(f"Org id: {org_key!r}")
Member

f"Org key: {org_key!r}"

`f"Org key: {org_key!r}"`
mdebray marked this conversation as resolved
@ -0,0 +15,4 @@
let
python =
(python312.override {
packageOverrides = lib.composeManyExtensions [
Member

composeManyExtensions sert pas si tu as qu'un overlay

`composeManyExtensions` sert pas si tu as qu'un overlay
mdebray marked this conversation as resolved
@ -0,0 +1,21 @@
# SPDX-FileCopyrightText: 2025 Maurice Debray <maurice.debray@dgnum.eu>
Member

ce fichier n'est importé nul part, et ça logique est intégré dans pkgs/overlay.nix.

ce fichier n'est importé nul part, et ça logique est intégré dans `pkgs/overlay.nix`.
mdebray marked this conversation as resolved
@ -0,0 +48,4 @@
];
preBuild = ''
ls -lah
Member

reste de debug ig, je pense qu'on peut del

reste de debug ig, je pense qu'on peut del
mdebray marked this conversation as resolved
requested reviews from lbailly, thubrecht 2025-07-08 16:48:59 +02:00
lbailly left a comment
Member

Il y a un peu de nitpick j'avoue

Il y a un peu de nitpick j'avoue
@ -0,0 +1,54 @@
<!--
Member

C'est à jour et toujours d'actualité ?

C'est à jour et toujours d'actualité ?
mdebray marked this conversation as resolved
@ -0,0 +7,4 @@
cfg = config.services.zulip;
in
{
config = lib.mkIf cfg.enable {
Member

Même pour les petit fichier comme celui là, je serai d'avis de quand même faire inherit (lib) mkIf

Même pour les petit fichier comme celui là, je serai d'avis de quand même faire `inherit (lib) mkIf`
mdebray marked this conversation as resolved
@ -0,0 +6,4 @@
./nginx.nix
./camo.nix
./memcached.nix
./nginx.nix
Member

nginx.nix est importé deux fois

`nginx.nix` est importé deux fois
mdebray marked this conversation as resolved
@ -0,0 +11,4 @@
./rabbitmq.nix
./redis.nix
./zulip.nix
];
Member

Ordre alphabétique si c'est pas dérangeant

Ordre alphabétique si c'est pas dérangeant
mdebray marked this conversation as resolved
@ -0,0 +1,78 @@
# SPDX-FileCopyrightText: 2025 Maurice Debray <maurice.debray@dgnum.eu>
Member

Je maîtrise pas du tout NixOsTest, mais se serai peut-être bien de call ce fichier quelque part, par ex en CI

Je maîtrise pas du tout NixOsTest, mais se serai peut-être bien de call ce fichier quelque part, par ex en CI
Author
Owner

Je propose de laisser ça à une followup. De toute façon le check est pas assez fort imo

Je propose de laisser ça à une followup. De toute façon le check est pas assez fort imo
mdebray marked this conversation as resolved
@ -0,0 +15,4 @@
mkOption
mkEnableOption
mkPackageOption
;
Member

De manière générale, nos autres modules font

inherit (lib.types)
  attrsOf
  bool
  ...
;

si on peut garder une certaine unité là dessus je pense que c'est pas mal

De manière générale, nos autres modules font ```nix inherit (lib.types) attrsOf bool ... ; ``` si on peut garder une certaine unité là dessus je pense que c'est pas mal
mdebray marked this conversation as resolved
@ -0,0 +16,4 @@
mkEnableOption
mkPackageOption
;
inherit (builtins) toString;
Member

il me semble pas que se soit utile de faire ça pour toString.

il me semble pas que se soit utile de faire ça pour `toString`.
mdebray marked this conversation as resolved
@ -0,0 +41,4 @@
types.attrsOf valueType;
generate =
name: value:
pkgs.callPackage (
Member

opinion perso, mais je trouve ça bizarre de faire un callPackage pour ça, juste fait intervenir pkgs ?

opinion perso, mais je trouve ça bizarre de faire un `callPackage` pour ça, juste fait intervenir `pkgs` ?
mdebray marked this conversation as resolved
@ -0,0 +54,4 @@
black
];
value = builtins.toJSON value;
pythonGen = ''
Member

Alors, c'est ptet moi qui a trop tendance à éviter d'utiliser des outils externe, mais j'ai l'impression que ce script se réécrit très bien avec un concatMapAttrsStringSep d'une fonction pas trop complexe

Alors, c'est ptet moi qui a trop tendance à éviter d'utiliser des outils externe, mais j'ai l'impression que ce script se réécrit très bien avec un `concatMapAttrsStringSep` d'une fonction pas trop complexe
Author
Owner

won't fix (discuté irl)

won't fix (discuté irl)
mdebray marked this conversation as resolved
@ -0,0 +121,4 @@
]
++ lib.optional (cfg.orgKeyFile != null) "zulip_org_key:${cfg.orgKeyFile}"
++ lib.optional (cfg.orgIdFile != null) "zulip_org_id:${cfg.orgIdFile}"
++ lib.mapAttrsToList (key: path: "${key}:${path}") cfg.extraSecrets;
Member

tu peut rajouter optional et mapAttrsToList au inherit (lib) du début.

tu peut rajouter `optional` et `mapAttrsToList` au `inherit (lib)` du début.
mdebray marked this conversation as resolved
@ -0,0 +145,4 @@
};
uwsgiPackage = mkOption {
type = types.package;
default = pkgs.uwsgi.override {
Member

Pour ce genre de type d'option, un defaultText produit une doc moins foireuse.

Pour ce genre de type d'option, un `defaultText` produit une doc moins foireuse.
mdebray marked this conversation as resolved
@ -0,0 +302,4 @@
};
config = lib.mkIf cfg.enable {
services.zulip = {
zulipSettings = {
Member

tu peux pas mettre default = { }; dans la déclaration de l'option ?

tu peux pas mettre `default = { };` dans la déclaration de l'option ?
mdebray marked this conversation as resolved
@ -0,0 +354,4 @@
serviceConfig = {
User = "zulip";
Group = "zulip";
ExecStartPre = lib.getExe zulipInit;
Member

comme un peu plus haut, getExe dans le inherit (lib)

comme un peu plus haut, `getExe` dans le `inherit (lib)`
mdebray marked this conversation as resolved
@ -0,0 +392,4 @@
inherit LoadCredential;
# TODO: Hardening
};
Member

tu peux factoriser une bonne partie des options de serviceConfig, genre User, Group, inherit LoadCredential, WorkingDirectory...

tu peux factoriser une bonne partie des options de `serviceConfig`, genre `User`, `Group`, `inherit LoadCredential`, `WorkingDirectory`...
mdebray marked this conversation as resolved
feat(zulip): add giphy
Some checks failed
Check workflows / check_workflows (pull_request) Successful in 17s
Build all the nodes / Jaccess01 (pull_request) Successful in 24s
Build all the nodes / Jaccess04 (pull_request) Successful in 24s
Run pre-commit on all files / pre-commit (push) Failing after 28s
Run pre-commit on all files / pre-commit (pull_request) Failing after 34s
Build all the nodes / ap01 (pull_request) Successful in 38s
Build all the nodes / bridge01 (pull_request) Successful in 51s
Build all the nodes / geo02 (pull_request) Successful in 1m2s
Build all the nodes / geo01 (pull_request) Successful in 1m3s
Build all the nodes / hypervisor01 (pull_request) Successful in 1m2s
Build all the nodes / build01 (pull_request) Successful in 1m4s
Build all the nodes / cof02 (pull_request) Successful in 1m7s
Build all the nodes / netcore01 (pull_request) Successful in 29s
Build all the nodes / hypervisor02 (pull_request) Successful in 56s
Build all the nodes / compute01 (pull_request) Successful in 1m12s
Build all the nodes / hypervisor03 (pull_request) Successful in 58s
Build all the nodes / netcore02 (pull_request) Successful in 28s
Build all the nodes / lab-router01 (pull_request) Successful in 55s
Build all the nodes / iso (pull_request) Successful in 1m4s
Build all the nodes / rescue01 (pull_request) Failing after 28s
Build all the nodes / storage01 (pull_request) Failing after 27s
Build all the nodes / zulip01 (pull_request) Failing after 26s
Build the shell / build-shell (pull_request) Successful in 25s
Build all the nodes / krz01 (pull_request) Successful in 1m22s
Build all the nodes / tower01 (pull_request) Successful in 48s
Build all the nodes / web02 (pull_request) Successful in 53s
Build all the nodes / vault01 (pull_request) Successful in 1m2s
Build all the nodes / web03 (pull_request) Successful in 59s
Build all the nodes / web01 (pull_request) Successful in 1m7s
Build all the nodes / external01 (pull_request) Failing after 2m59s
267bacabb4
Signed-off-by: Ryan Lahfa <ryan@dgnum.eu>
chore(zulip): Update readme
Some checks failed
Build all the nodes / Paccess14 (pull_request) Successful in 22s
Build all the nodes / ap01 (pull_request) Successful in 37s
Build all the nodes / build01 (pull_request) Successful in 51s
Build all the nodes / bridge01 (pull_request) Successful in 53s
Build all the nodes / geo01 (pull_request) Successful in 55s
Build all the nodes / cof02 (pull_request) Successful in 58s
Build all the nodes / geo02 (pull_request) Successful in 1m0s
Build all the nodes / hypervisor01 (pull_request) Successful in 1m1s
Build all the nodes / hypervisor02 (pull_request) Successful in 1m1s
Build all the nodes / compute01 (pull_request) Successful in 1m9s
Build all the nodes / hypervisor03 (pull_request) Successful in 59s
Build all the nodes / iso (pull_request) Successful in 58s
Build all the nodes / external01 (pull_request) Failing after 1m14s
Build all the nodes / netcore01 (pull_request) Successful in 22s
Build all the nodes / netcore02 (pull_request) Successful in 23s
Build all the nodes / netcore03 (pull_request) Successful in 21s
Build all the nodes / netcore04 (pull_request) Successful in 22s
Build all the nodes / krz01 (pull_request) Successful in 1m11s
Build all the nodes / lab-router01 (pull_request) Successful in 48s
Build all the nodes / storage01 (pull_request) Successful in 48s
Build all the nodes / tower01 (pull_request) Successful in 46s
Build all the nodes / rescue01 (pull_request) Successful in 57s
Build the shell / build-shell (pull_request) Successful in 22s
Build all the nodes / web02 (pull_request) Successful in 47s
Build all the nodes / zulip01 (pull_request) Successful in 48s
Build all the nodes / web03 (pull_request) Successful in 54s
Build all the nodes / web01 (pull_request) Successful in 1m27s
Build all the nodes / vault01 (pull_request) Successful in 1m38s
Build all the nodes / vault02 (pull_request) Successful in 1m43s
Build all the nodes / vault03 (pull_request) Successful in 1m43s
195b34d086
requested review from lbailly 2025-09-12 17:09:25 +02:00
lbailly left a comment
Member

à peu près que du styling

à peu près que du styling
@ -0,0 +16,4 @@
];
extraConfig = {
# Disable monitoring
Member

Le comment est mal placé, et se serai pas mal d'avoir du monitoring

Le comment est mal placé, et se serai pas mal d'avoir du monitoring
mdebray marked this conversation as resolved
@ -12,11 +12,15 @@ lib.extra.mkConfig {
enabledServices = [
# List of services to enable
# "zulip"
Member

faudrait pas juste kill la vm ?

faudrait pas juste kill la vm ?
mdebray marked this conversation as resolved
meta/network.nix Outdated
@ -98,0 +112,4 @@
}
];
gateways = [ "2001:41d0:305:2100::1" ];
DHCP = "ipv4";
Member

on fait du DHCP avec ip fixe ?

on fait du DHCP avec ip fixe ?
Owner

ça peut être le cas pour retrieve les autres informations via DHCP (par exemple la gateway)...
mais bon on peut ajouter la gateway à la main puisqu'elle risque de ne pas changer

ça peut être le cas pour retrieve les autres informations via DHCP (par exemple la gateway)... mais bon on peut ajouter la gateway à la main puisqu'elle risque de ne pas changer
Author
Owner

Je sais plus exactement mais c'est grossomodo le setup par défaut traduit en nix iirc mais je me trompe peut-être

Je sais plus exactement mais c'est grossomodo le setup par défaut traduit en nix iirc mais je me trompe peut-être
meta/network.nix Outdated
@ -98,0 +117,4 @@
};
};
hostId = "22297231";
netbirdIp = null;
Member

dans external01/_configuration, tu as activé netbird

dans external01/_configuration, tu as activé netbird
mdebray marked this conversation as resolved
@ -150,0 +146,4 @@
recommendedOptimisation = lib.mkDefault true;
recommendedProxySettings = lib.mkDefault true;
recommendedTlsSettings = lib.mkDefault true;
recommendedZstdSettings = lib.mkDefault true;
Member

Tu peux ajouter mkDefault dans le inherit au début

Tu peux ajouter mkDefault dans le inherit au début
mdebray marked this conversation as resolved
@ -0,0 +22,4 @@
};
systemd.services.postgresql.postStart = lib.mkAfter ''
# $PSQL -tAc "SELECT 1 FROM information_schema.schemata WHERE schema_name='zulip'" zulip | grep -q 1 || $PSQL -tAc 'CREATE SCHEMA zulip AUTHORIZATION zulip;' zulip
Member

Si ça sert plus on peu suppr la modif du postStart

Si ça sert plus on peu suppr la modif du postStart
mdebray marked this conversation as resolved
@ -0,0 +314,4 @@
description = "Extra secrets to pass to zulip. These secrets will be passed to the python processes through loadcredentials. One can access them using `get_secret` function from `zproject.config` module";
};
};
config = lib.mkIf cfg.enable {
Member

le mkIf peut aller dans le inherit au début

le mkIf peut aller dans le inherit au début
mdebray marked this conversation as resolved
@ -0,0 +386,4 @@
};
};
}) queues)
++ lib.singleton {
Member

singleton aussi

singleton aussi
mdebray marked this conversation as resolved
pkgs/overlay.nix Outdated
@ -3,1 +3,4 @@
# SPDX-License-Identifier: EUPL-1.2
{
sources ? import ../lon.nix,
}:
Member

Si on fait que le rajouter l'argument, c'est qu'il sert à rien

Si on fait que le rajouter l'argument, c'est qu'il sert à rien
mdebray marked this conversation as resolved
fix(zulip/alertmanager): Add padding for bullet lists to display nicely; change default topic
Some checks failed
Run pre-commit on all files / pre-commit (pull_request) Failing after 36s
Build all the nodes / bridge01 (pull_request) Successful in 43s
Build all the nodes / optic-loop (pull_request) Successful in 24s
Build all the nodes / build01 (pull_request) Successful in 45s
Build all the nodes / hypervisor11 (pull_request) Successful in 50s
Build all the nodes / geo02 (pull_request) Successful in 51s
Build all the nodes / sw-Jourdan (pull_request) Successful in 25s
Build all the nodes / sw-Montrouge (pull_request) Successful in 25s
Build all the nodes / sw-Pantheon (pull_request) Successful in 26s
Build all the nodes / hypervisor02 (pull_request) Successful in 1m0s
Build all the nodes / geo01 (pull_request) Successful in 1m1s
Build all the nodes / hypervisor03 (pull_request) Successful in 1m0s
Build all the nodes / hypervisor01 (pull_request) Successful in 1m1s
Build all the nodes / cof02 (pull_request) Successful in 1m8s
Build all the nodes / hypervisor13 (pull_request) Successful in 52s
Build all the nodes / compute01 (pull_request) Successful in 1m10s
Build all the nodes / hypervisor12 (pull_request) Successful in 58s
Build all the nodes / lab-router01 (pull_request) Successful in 54s
Build all the nodes / iso (pull_request) Successful in 56s
Build all the nodes / storage01 (pull_request) Successful in 55s
Build all the nodes / rescue01 (pull_request) Successful in 59s
Build all the nodes / krz01 (pull_request) Successful in 1m2s
Build all the nodes / tower01 (pull_request) Successful in 41s
Build the shell / build-shell (pull_request) Successful in 26s
Build all the nodes / web02 (pull_request) Successful in 38s
Build all the nodes / web03 (pull_request) Successful in 46s
Build all the nodes / vault01 (pull_request) Successful in 1m54s
Build all the nodes / vault02 (pull_request) Successful in 1m56s
Build all the nodes / vault03 (pull_request) Successful in 1m54s
Build all the nodes / web01 (pull_request) Successful in 1m56s
3610cd86d7
fix(DONOTMERGE): ci debug
Some checks failed
Build all the nodes / bridge01 (pull_request) Successful in 44s
Build all the nodes / sw-Jourdan (pull_request) Successful in 25s
Build all the nodes / sw-Montrouge (pull_request) Successful in 26s
Build all the nodes / sw-Pantheon (pull_request) Successful in 27s
Build all the nodes / geo02 (pull_request) Successful in 59s
Build all the nodes / hypervisor01 (pull_request) Successful in 59s
Build all the nodes / build01 (pull_request) Successful in 1m3s
Build all the nodes / hypervisor13 (pull_request) Successful in 1m5s
Build all the nodes / hypervisor11 (pull_request) Successful in 1m5s
Build all the nodes / hypervisor12 (pull_request) Successful in 1m5s
Build all the nodes / geo01 (pull_request) Successful in 1m11s
Build all the nodes / cof02 (pull_request) Successful in 1m13s
Build all the nodes / external01 (pull_request) Failing after 1m14s
Build all the nodes / compute01 (pull_request) Successful in 1m16s
Build all the nodes / lab-router01 (pull_request) Successful in 1m15s
Build all the nodes / hypervisor02 (pull_request) Successful in 1m17s
Build all the nodes / hypervisor03 (pull_request) Successful in 1m16s
DEBUG / debugci (pull_request) Failing after 15s
Build all the nodes / iso (pull_request) Successful in 1m21s
Build all the nodes / storage01 (pull_request) Successful in 1m6s
Build all the nodes / krz01 (pull_request) Successful in 1m23s
Build all the nodes / tower01 (pull_request) Successful in 54s
Build the shell / build-shell (pull_request) Successful in 28s
Build all the nodes / rescue01 (pull_request) Successful in 1m26s
Build all the nodes / web02 (pull_request) Successful in 40s
Build all the nodes / vault01 (pull_request) Successful in 1m28s
Build all the nodes / web03 (pull_request) Successful in 1m12s
Build all the nodes / web01 (pull_request) Successful in 1m29s
Build all the nodes / vault03 (pull_request) Successful in 1m32s
Build all the nodes / vault02 (pull_request) Successful in 1m36s
793032b6b3
feat(pkgs/zulip-server): Remove unnecessary dependency pin
Some checks failed
Show derivation diffs / geo01 (pull_request) Successful in 1m12s
Show derivation diffs / optic-loop (pull_request) Successful in 29s
Show derivation diffs / cof02 (pull_request) Successful in 1m17s
Build all the nodes / krz01 (pull_request) Successful in 1m23s
Show derivation diffs / sw-Jourdan (pull_request) Successful in 38s
Build all the nodes / web03 (pull_request) Successful in 1m6s
Show derivation diffs / sw-Montrouge (pull_request) Successful in 39s
Build all the nodes / vault01 (pull_request) Successful in 1m29s
Build all the nodes / vault03 (pull_request) Successful in 1m31s
Show derivation diffs / sw-Pantheon (pull_request) Successful in 40s
Build all the nodes / vault02 (pull_request) Successful in 1m31s
Build all the nodes / web01 (pull_request) Successful in 1m25s
Show derivation diffs / geo02 (pull_request) Successful in 1m12s
Run pre-commit on all files / pre-commit (pull_request) Successful in 41s
Show derivation diffs / lab-router01 (pull_request) Successful in 1m14s
Show derivation diffs / compute01 (pull_request) Successful in 2m1s
Show derivation diffs / storage01 (pull_request) Successful in 1m17s
Show derivation diffs / hypervisors1 (pull_request) Successful in 1m31s
Show derivation diffs / tower01 (pull_request) Successful in 1m16s
Show derivation diffs / iso (pull_request) Successful in 1m36s
Show derivation diffs / web02 (pull_request) Successful in 1m12s
Show derivation diffs / hypervisors0 (pull_request) Successful in 1m42s
Show derivation diffs / rescue01 (pull_request) Successful in 1m40s
Show derivation diffs / web03 (pull_request) Successful in 1m22s
Show derivation diffs / krz01 (pull_request) Successful in 1m59s
Show derivation diffs / web01 (pull_request) Successful in 1m52s
Show derivation diffs / vault03 (pull_request) Successful in 2m3s
Show derivation diffs / vault02 (pull_request) Successful in 2m10s
Show derivation diffs / vault01 (pull_request) Successful in 2m19s
Build all the nodes / external01 (pull_request) Failing after 7m38s
df71af713c
feat(zulip): Rotate logs
All checks were successful
Show derivation diffs / sw-Jourdan (pull_request) Successful in 27s
Build all the nodes / sw-Jourdan (pull_request) Successful in 24s
Show derivation diffs / hypervisors1 (pull_request) Successful in 1m16s
Build all the nodes / krz01 (pull_request) Successful in 1m6s
Build all the nodes / sw-Montrouge (pull_request) Successful in 23s
Show derivation diffs / iso (pull_request) Successful in 1m7s
Build all the nodes / sw-Pantheon (pull_request) Successful in 25s
Build all the nodes / rescue01 (pull_request) Successful in 53s
Show derivation diffs / sw-Montrouge (pull_request) Successful in 27s
Build all the nodes / storage01 (pull_request) Successful in 44s
Build all the nodes / tower01 (pull_request) Successful in 41s
Show derivation diffs / sw-Pantheon (pull_request) Successful in 29s
Show derivation diffs / storage01 (pull_request) Successful in 55s
Show derivation diffs / krz01 (pull_request) Successful in 1m38s
Show derivation diffs / rescue01 (pull_request) Successful in 1m16s
Build the shell / build-shell (pull_request) Successful in 24s
Show derivation diffs / tower01 (pull_request) Successful in 54s
Build all the nodes / web02 (pull_request) Successful in 41s
Build all the nodes / web01 (pull_request) Successful in 1m0s
Build all the nodes / web03 (pull_request) Successful in 48s
Run pre-commit on all files / pre-commit (pull_request) Successful in 30s
Show derivation diffs / web02 (pull_request) Successful in 52s
Build all the nodes / vault01 (pull_request) Successful in 1m31s
Build all the nodes / vault03 (pull_request) Successful in 1m31s
Build all the nodes / vault02 (pull_request) Successful in 1m34s
Show derivation diffs / web03 (pull_request) Successful in 1m1s
Show derivation diffs / web01 (pull_request) Successful in 1m29s
Show derivation diffs / vault01 (pull_request) Successful in 2m21s
Show derivation diffs / vault03 (pull_request) Successful in 2m16s
Show derivation diffs / vault02 (pull_request) Successful in 2m30s
88757933bc
lon: update nixos-unstable
Some checks failed
Build all the nodes / rescue01 (pull_request) Successful in 3m42s
Build all the nodes / vault01 (pull_request) Successful in 3m42s
Build all the nodes / storage01 (pull_request) Successful in 3m42s
Build all the nodes / build01 (pull_request) Successful in 3m44s
Build all the nodes / vault03 (pull_request) Successful in 3m42s
Build the shell / build-shell (pull_request) Successful in 2m24s
Build all the nodes / vault02 (pull_request) Successful in 3m43s
Show derivation diffs / krz01 (pull_request) Failing after 1m26s
Show derivation diffs / rescue01 (pull_request) Successful in 1m33s
Run pre-commit on all files / pre-commit (pull_request) Failing after 29s
Show derivation diffs / web03 (pull_request) Failing after 13m55s
Show derivation diffs / web02 (pull_request) Failing after 13m56s
Show derivation diffs / web01 (pull_request) Failing after 13m56s
Show derivation diffs / vault03 (pull_request) Failing after 14m1s
Show derivation diffs / vault02 (pull_request) Failing after 14m19s
Show derivation diffs / vault01 (pull_request) Failing after 14m49s
Show derivation diffs / tower01 (pull_request) Failing after 14m51s
Show derivation diffs / sw-Pantheon (pull_request) Failing after 14m53s
Show derivation diffs / sw-Montrouge (pull_request) Failing after 14m53s
Show derivation diffs / sw-Jourdan (pull_request) Failing after 14m56s
Show derivation diffs / storage01 (pull_request) Failing after 14m58s
Show derivation diffs / optic-loop (pull_request) Failing after 15m1s
Show derivation diffs / hypervisors1 (pull_request) Failing after 15m3s
Show derivation diffs / hypervisors0 (pull_request) Failing after 15m18s
Show derivation diffs / geo01 (pull_request) Failing after 17m24s
Show derivation diffs / compute01 (pull_request) Failing after 17m25s
Show derivation diffs / cof02 (pull_request) Failing after 17m26s
Show derivation diffs / build01 (pull_request) Failing after 17m26s
Show derivation diffs / bridge01 (pull_request) Failing after 17m26s
Show derivation diffs / ap01 (pull_request) Failing after 17m26s
eec026c187
All checks were successful
Check meta / check_dns (pull_request) Successful in 17s
Required
Details
Check meta / check_meta (pull_request) Successful in 20s
Required
Details
Check workflows / check_workflows (pull_request) Successful in 21s
Required
Details
Show derivation diffs / external01 (pull_request) Successful in 30s
Run pre-commit on all files / pre-commit (push) Successful in 34s
Required
Details
Build all the nodes / optic-loop (pull_request) Successful in 32s
Required
Details
Build all the nodes / sw-Jourdan (pull_request) Successful in 35s
Required
Details
Build all the nodes / sw-Montrouge (pull_request) Successful in 36s
Required
Details
Build all the nodes / sw-Pantheon (pull_request) Successful in 36s
Required
Details
Build all the nodes / ap01 (pull_request) Successful in 40s
Required
Details
Build all the nodes / cof02 (pull_request) Successful in 49s
Required
Details
Build all the nodes / bridge01 (pull_request) Successful in 49s
Required
Details
Build all the nodes / geo01 (pull_request) Successful in 48s
Required
Details
Build all the nodes / lab-router01 (pull_request) Successful in 48s
Required
Details
Build all the nodes / geo02 (pull_request) Successful in 50s
Required
Details
Build all the nodes / build01 (pull_request) Successful in 51s
Required
Details
Build all the nodes / tower01 (pull_request) Successful in 50s
Required
Details
Build all the nodes / storage01 (pull_request) Successful in 52s
Required
Details
Show derivation diffs / ap01 (pull_request) Successful in 53s
Build all the nodes / external01 (pull_request) Successful in 58s
Required
Details
Build all the nodes / hypervisors0 (pull_request) Successful in 1m0s
Required
Details
Build all the nodes / iso (pull_request) Successful in 1m0s
Required
Details
Build the shell / build-shell (pull_request) Successful in 28s
Required
Details
Build all the nodes / hypervisors1 (pull_request) Successful in 1m2s
Required
Details
Build all the nodes / rescue01 (pull_request) Successful in 1m2s
Required
Details
Show derivation diffs / bridge01 (pull_request) Successful in 1m6s
Show derivation diffs / geo01 (pull_request) Successful in 1m7s
Build all the nodes / compute01 (pull_request) Successful in 1m9s
Required
Details
Show derivation diffs / build01 (pull_request) Successful in 1m9s
Build all the nodes / web02 (pull_request) Successful in 48s
Required
Details
Show derivation diffs / cof02 (pull_request) Successful in 1m10s
Build all the nodes / krz01 (pull_request) Successful in 1m14s
Required
Details
Show derivation diffs / optic-loop (pull_request) Successful in 29s
Show derivation diffs / sw-Jourdan (pull_request) Successful in 31s
Show derivation diffs / sw-Montrouge (pull_request) Successful in 30s
Build all the nodes / web03 (pull_request) Successful in 51s
Required
Details
Build all the nodes / vault02 (pull_request) Successful in 1m25s
Required
Details
Show derivation diffs / sw-Pantheon (pull_request) Successful in 34s
Build all the nodes / vault01 (pull_request) Successful in 1m25s
Required
Details
Build all the nodes / web01 (pull_request) Successful in 1m9s
Required
Details
Show derivation diffs / geo02 (pull_request) Successful in 1m0s
Run pre-commit on all files / pre-commit (pull_request) Successful in 30s
Required
Details
Build all the nodes / vault03 (pull_request) Successful in 1m22s
Required
Details
Show derivation diffs / compute01 (pull_request) Successful in 1m42s
Show derivation diffs / lab-router01 (pull_request) Successful in 56s
Show derivation diffs / storage01 (pull_request) Successful in 59s
Show derivation diffs / hypervisors1 (pull_request) Successful in 1m13s
Show derivation diffs / hypervisors0 (pull_request) Successful in 1m14s
Show derivation diffs / iso (pull_request) Successful in 1m13s
Show derivation diffs / tower01 (pull_request) Successful in 53s
Show derivation diffs / web02 (pull_request) Successful in 56s
Show derivation diffs / rescue01 (pull_request) Successful in 1m19s
Show derivation diffs / krz01 (pull_request) Successful in 1m32s
Show derivation diffs / web03 (pull_request) Successful in 1m6s
Show derivation diffs / web01 (pull_request) Successful in 1m23s
Show derivation diffs / vault01 (pull_request) Successful in 2m6s
Show derivation diffs / vault03 (pull_request) Successful in 2m9s
Show derivation diffs / vault02 (pull_request) Successful in 2m22s
This pull request has changes requested by an official reviewer.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin zulip:zulip
git switch zulip
Sign in to join this conversation.
No description provided.