DGNum/infrastructure
9
6
Fork 3
Code Issues 31 Pull requests 32 Projects 1 Releases Packages Wiki Activity Actions

meta-isp #295

Open
thubrecht wants to merge 2 commits from meta-isp into main
pull from: meta-isp
merge into: DGNum:main
Conversation 1 Commits 2 Files changed 7 +524 -380
thubrecht commented 2025-02-07 19:07:38 +01:00
Owner
Copy link
No description provided.
requested review from lbailly 2025-02-07 22:06:02 +01:00
lbailly requested changes 2025-02-10 16:03:52 +01:00
lbailly left a comment
Member
Copy link

Je pense qu'on veut aussi une notion de "groupe de vlans", on aurait par exemples les groupes

  • "vlan users" (comme déjà existant dans la config des switch)
  • "link isp" qui aurait les vlan users, le vlan admin et admin-ap

ce qui permettrait d'y faire référence de manière groupé facilement.

Je pense qu'on veut aussi une notion de "groupe de vlans", on aurait par exemples les groupes - "vlan users" (comme déjà existant dans la config des switch) - "link isp" qui aurait les vlan users, le vlan admin et admin-ap ce qui permettrait d'y faire référence de manière groupé facilement.
machines/nixos/vault01/networking.nix Outdated
@ -162,4 +38,1 @@
'';
readOnly = true;
};
config = {
lbailly commented 2025-02-10 15:58:23 +01:00
Member
Copy link

Si on retire l'option (ce qui est le but), on peut retirer ce config =

Si on retire l'option (ce qui est le but), on peut retirer ce `config =`
lbailly marked this conversation as resolved
meta/isp/module.nix Outdated
@ -0,0 +43,4 @@
description = ''
Settings for the configuration of networkd.
'';
};
lbailly commented 2025-02-10 15:57:21 +01:00
Member
Copy link

Je suis très peu convaincu de l'idée de mettre de la configuration systemd-networkd dans le meta, surtout pour des choses type MTU, adresses ou DHCP.
Notamment, il faudrait garantir que c'est utilisé à un unique endroit, ce qui me parait peu scallable, sans apporter beaucoup au meta, vu qu'on est sensé déjà avoir mis toute les informations pertinente dans les autres fields.

Je suis très peu convaincu de l'idée de mettre de la configuration systemd-networkd dans le meta, surtout pour des choses type MTU, adresses ou DHCP. Notamment, il faudrait garantir que c'est utilisé à un unique endroit, ce qui me parait peu scallable, sans apporter beaucoup au meta, vu qu'on est sensé déjà avoir mis toute les informations pertinente dans les autres fields.
lbailly force-pushed meta-isp from 1e5447753c to 92890e2228 2025-03-02 18:03:15 +01:00 Compare
lbailly force-pushed meta-isp from f6f83548be to 65feb71c0f 2025-03-13 17:41:22 +01:00 Compare
All checks were successful
Run pre-commit on all files / pre-commit (push) Successful in 27s
Required
Details
Check meta / check_dns (pull_request) Successful in 16s
Required
Details
Check meta / check_meta (pull_request) Successful in 16s
Required
Details
Check workflows / check_workflows (pull_request) Successful in 18s
Required
Details
Build all the nodes / ap01 (pull_request) Successful in 31s
Required
Details
Build all the nodes / netaccess01 (pull_request) Successful in 21s
Required
Details
Build all the nodes / netcore01 (pull_request) Successful in 23s
Required
Details
Build all the nodes / netcore02 (pull_request) Successful in 23s
Required
Details
Build all the nodes / geo01 (pull_request) Successful in 1m25s
Required
Details
Build the shell / build-shell (pull_request) Successful in 31s
Required
Details
Build all the nodes / bridge01 (pull_request) Successful in 2m11s
Required
Details
Build all the nodes / cof02 (pull_request) Successful in 2m16s
Required
Details
Build all the nodes / build01 (pull_request) Successful in 2m28s
Required
Details
Build all the nodes / hypervisor03 (pull_request) Successful in 2m18s
Required
Details
Run pre-commit on all files / pre-commit (pull_request) Successful in 35s
Required
Details
Build all the nodes / hypervisor02 (pull_request) Successful in 2m26s
Required
Details
Build all the nodes / geo02 (pull_request) Successful in 2m33s
Required
Details
Build all the nodes / hypervisor01 (pull_request) Successful in 2m31s
Required
Details
Build all the nodes / compute01 (pull_request) Successful in 3m11s
Required
Details
Build all the nodes / vault01 (pull_request) Successful in 2m9s
Required
Details
Build all the nodes / tower01 (pull_request) Successful in 2m11s
Required
Details
Build all the nodes / web03 (pull_request) Successful in 1m59s
Required
Details
Build all the nodes / storage01 (pull_request) Successful in 2m25s
Required
Details
Build all the nodes / rescue01 (pull_request) Successful in 2m28s
Required
Details
Build all the nodes / web02 (pull_request) Successful in 2m15s
Required
Details
Build all the nodes / web01 (pull_request) Successful in 2m47s
Required
Details
This pull request has changes conflicting with the target branch.
  • machines/nixos/vault01/k-radius/default.nix
  • machines/nixos/vault01/networking.nix
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin meta-isp:meta-isp
git checkout meta-isp
Sign in to join this conversation.
Reviewers
No reviewers
lbailly
Labels
Clear labels   
awaiting
awaiting-author
Awaiting for the author interaction (e.g. QA/confirmation/final merge)

  
awaiting
awaiting-reviewer
Awaiting for a privileged reviewer to approve this PR

  
bot

Pull Request opened by a bot

  
deployed

This PR is currently deployed on the infra

  
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
wontfix

This won't be fixed

No labels
awaiting
awaiting-author
awaiting
awaiting-reviewer
bot
deployed
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: DGNum/infrastructure#295
No description provided.
Delete branch "meta-isp"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?