DGNum/infrastructure
11
6
Fork 2
Code Issues 19 Pull requests 10 Projects 1 Releases Packages Wiki Activity Actions

feat(reuse): Switch to an action rather than a git hook, to be less cumbersome #262

Closed
thubrecht wants to merge 1 commit from reuse into main
pull from: reuse
merge into: DGNum:main
Conversation 4 Commits 1 Files changed 3 +42 -6
thubrecht commented 2025-01-16 14:29:25 +01:00
Owner
Copy link

Fixes #232

Fixes #232
thubrecht added 1 commit 2025-01-16 14:29:25 +01:00
feat(reuse): Switch to an action rather than a git hook, to be less cumbersome
Some checks failed
Check workflows / check_workflows (push) Successful in 16s
Details
Check meta / check_meta (pull_request) Successful in 15s
Details
Check workflows / check_workflows (pull_request) Successful in 16s
Details
Check meta / check_dns (pull_request) Successful in 19s
Details
Build all the nodes / netcore02 (pull_request) Successful in 28s
Details
Build all the nodes / ap01 (pull_request) Successful in 32s
Details
Build the shell / build-shell (pull_request) Successful in 21s
Details
Run pre-commit on all files / pre-commit (push) Failing after 15s
Details
Run pre-commit on all files / pre-commit (pull_request) Failing after 39s
Details
Build all the nodes / bridge01 (pull_request) Successful in 1m53s
Details
Build all the nodes / hypervisor02 (pull_request) Successful in 1m54s
Details
Build all the nodes / web03 (pull_request) Successful in 1m48s
Details
Build all the nodes / web02 (pull_request) Successful in 2m2s
Details
Build all the nodes / hypervisor03 (pull_request) Successful in 3m13s
Details
Build all the nodes / build01 (pull_request) Successful in 3m26s
Details
Build all the nodes / tower01 (pull_request) Successful in 3m19s
Details
Build all the nodes / hypervisor01 (pull_request) Successful in 3m32s
Details
Build all the nodes / geo01 (pull_request) Successful in 3m35s
Details
Build all the nodes / geo02 (pull_request) Successful in 3m36s
Details
Build all the nodes / vault01 (pull_request) Successful in 3m28s
Details
Build all the nodes / rescue01 (pull_request) Successful in 3m53s
Details
Build all the nodes / storage01 (pull_request) Successful in 4m0s
Details
Build all the nodes / compute01 (pull_request) Successful in 4m12s
Details
Build all the nodes / web01 (pull_request) Successful in 4m26s
Details
6aa457c8e3
thubrecht force-pushed reuse from 6aa457c8e3 to 44997e3b2c 2025-01-16 14:33:57 +01:00 Compare
mdebray was assigned by thubrecht 2025-01-16 14:35:23 +01:00
thubrecht force-pushed reuse from 44997e3b2c to 23ee7907e2 2025-01-16 14:36:13 +01:00 Compare
mdebray commented 2025-01-16 15:19:50 +01:00
Owner
Copy link

imho pas sûr que ce soit la meilleure chose. On risque de se retrouver avec beaucoup de commit de fix pour comply

imho pas sûr que ce soit la meilleure chose. On risque de se retrouver avec beaucoup de commit de fix pour comply
thubrecht commented 2025-01-16 15:49:18 +01:00
Author
Owner
Copy link

imho pas sûr que ce soit la meilleure chose. On risque de se retrouver avec beaucoup de commit de fix pour comply

Du coup pour résoudre ton pb, il faut que tu rajoutes ton répertoire de scripts custom dans le .gitignore

> imho pas sûr que ce soit la meilleure chose. On risque de se retrouver avec beaucoup de commit de fix pour comply Du coup pour résoudre ton pb, il faut que tu rajoutes ton répertoire de scripts custom dans le .gitignore
mdebray commented 2025-01-21 10:07:06 +01:00
Owner
Copy link

imho pas sûr que ce soit la meilleure chose. On risque de se retrouver avec beaucoup de commit de fix pour comply

Du coup pour résoudre ton pb, il faut que tu rajoutes ton répertoire de scripts custom dans le .gitignore

On peut pas demander au hook de s’exécuter dans un tmpdir qui correspond à ce qui va être effectivement poussé ?

> > imho pas sûr que ce soit la meilleure chose. On risque de se retrouver avec beaucoup de commit de fix pour comply > > Du coup pour résoudre ton pb, il faut que tu rajoutes ton répertoire de scripts custom dans le .gitignore On peut pas demander au hook de s’exécuter dans un tmpdir qui correspond à ce qui va être effectivement poussé ?
mdebray commented 2025-01-23 09:45:49 +01:00
Owner
Copy link

Je suis d'avis de fermer cette PR. DGNum/nix-reuse#1 est une meilleure solution

Je suis d'avis de fermer cette PR. https://git.dgnum.eu/DGNum/nix-reuse/pulls/1 est une meilleure solution
thubrecht closed this pull request 2025-02-05 16:09:12 +01:00
All checks were successful
Check meta / check_dns (pull_request) Successful in 16s
Required
Details
Check meta / check_meta (pull_request) Successful in 16s
Required
Details
Check workflows / check_workflows (pull_request) Successful in 17s
Required
Details
Build all the nodes / ap01 (pull_request) Successful in 30s
Required
Details
Build all the nodes / netcore02 (pull_request) Successful in 19s
Required
Details
Build all the nodes / build01 (pull_request) Successful in 1m52s
Required
Details
REUSE lint / pre-commit (pull_request) Successful in 16s
Details
Build the shell / build-shell (pull_request) Successful in 27s
Required
Details
Run pre-commit on all files / pre-commit (pull_request) Successful in 22s
Required
Details
Build all the nodes / hypervisor03 (pull_request) Successful in 1m42s
Required
Details
Check workflows / check_workflows (push) Successful in 16s
Required
Details
REUSE lint / pre-commit (push) Successful in 16s
Details
Build all the nodes / rescue01 (pull_request) Successful in 1m51s
Required
Details
Run pre-commit on all files / pre-commit (push) Successful in 38s
Required
Details
Build all the nodes / compute01 (pull_request) Successful in 2m51s
Required
Details
Build all the nodes / web02 (pull_request) Successful in 1m51s
Required
Details
Build all the nodes / web03 (pull_request) Successful in 1m48s
Required
Details
Build all the nodes / bridge01 (pull_request) Successful in 3m32s
Required
Details
Build all the nodes / geo02 (pull_request) Successful in 3m22s
Required
Details
Build all the nodes / geo01 (pull_request) Successful in 3m24s
Required
Details
Build all the nodes / hypervisor02 (pull_request) Successful in 3m23s
Required
Details
Build all the nodes / hypervisor01 (pull_request) Successful in 3m26s
Required
Details
Build all the nodes / storage01 (pull_request) Successful in 2m52s
Required
Details
Build all the nodes / tower01 (pull_request) Successful in 3m1s
Required
Details
Build all the nodes / vault01 (pull_request) Successful in 2m51s
Required
Details
Build all the nodes / web01 (pull_request) Successful in 3m32s
Required
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
awaiting
awaiting-author
Awaiting for the author interaction (e.g. QA/confirmation/final merge)

  
awaiting
awaiting-reviewer
Awaiting for a privileged reviewer to approve this PR

  
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
wontfix

This won't be fixed

No labels
awaiting
awaiting-author
awaiting
awaiting-reviewer
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
mdebray
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: DGNum/infrastructure#262
No description provided.
Delete branch "reuse"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?