feat(compute01/search): init search.infra #199

Open
lbailly wants to merge 3 commits from search-infra into main
Member
No description provided.
lbailly added 3 commits 2024-12-21 12:03:24 +01:00
feat(compute01/search): init search.infra
Some checks failed
Run pre-commit on all files / pre-commit (push) Failing after 34s
Check meta / check_meta (pull_request) Successful in 20s
Check workflows / check_workflows (pull_request) Successful in 30s
Check meta / check_dns (pull_request) Successful in 30s
Build all the nodes / ap01 (pull_request) Successful in 1m10s
Build all the nodes / bridge01 (pull_request) Successful in 2m0s
Build all the nodes / hypervisor01 (pull_request) Successful in 2m14s
Build all the nodes / geo01 (pull_request) Successful in 2m24s
Build all the nodes / geo02 (pull_request) Successful in 2m15s
Build all the nodes / hypervisor02 (pull_request) Successful in 1m37s
Build all the nodes / netcore02 (pull_request) Successful in 38s
Build all the nodes / hypervisor03 (pull_request) Successful in 1m40s
Build all the nodes / vault01 (pull_request) Successful in 2m0s
Build all the nodes / storage01 (pull_request) Successful in 2m10s
Build all the nodes / rescue01 (pull_request) Successful in 2m14s
Build all the nodes / web02 (pull_request) Successful in 1m35s
Run pre-commit on all files / pre-commit (pull_request) Failing after 37s
Build all the nodes / web01 (pull_request) Successful in 2m26s
Build all the nodes / compute01 (pull_request) Successful in 5m56s
Build all the nodes / web03 (pull_request) Successful in 1m38s
cf2044c4b9
lbailly reviewed 2024-12-21 17:23:11 +01:00
default.nix Outdated
@ -117,0 +137,4 @@
"machines/nixos/compute01/search/static-data/images/favicon.ico"
"machines/nixos/compute01/search/static-data/images/favicon.png"
];
license = "Reserved"; # FIXME: doesn't exist
Author
Member

@thubrecht si tu sait ce qu'on peut mettre ici, on pourra merge

@thubrecht si tu sait ce qu'on peut mettre ici, on pourra merge
lbailly added 1 commit 2024-12-21 17:45:51 +01:00
fix(license): all rights reserved
All checks were successful
Check meta / check_dns (pull_request) Successful in 18s
Check meta / check_meta (pull_request) Successful in 20s
Check workflows / check_workflows (pull_request) Successful in 26s
Run pre-commit on all files / pre-commit (push) Successful in 58s
Build all the nodes / ap01 (pull_request) Successful in 1m31s
Build all the nodes / bridge01 (pull_request) Successful in 1m57s
Build all the nodes / geo02 (pull_request) Successful in 1m59s
Build all the nodes / geo01 (pull_request) Successful in 2m13s
Build all the nodes / hypervisor01 (pull_request) Successful in 1m48s
Build all the nodes / netcore02 (pull_request) Successful in 32s
Build all the nodes / hypervisor02 (pull_request) Successful in 1m49s
Build all the nodes / hypervisor03 (pull_request) Successful in 1m40s
Build all the nodes / rescue01 (pull_request) Successful in 2m3s
Build all the nodes / vault01 (pull_request) Successful in 1m53s
Build all the nodes / storage01 (pull_request) Successful in 2m26s
Build all the nodes / compute01 (pull_request) Successful in 4m57s
Build all the nodes / web02 (pull_request) Successful in 1m47s
Run pre-commit on all files / pre-commit (pull_request) Successful in 42s
Build all the nodes / web01 (pull_request) Successful in 2m20s
Build all the nodes / web03 (pull_request) Successful in 1m36s
8bfbf09fd4
lbailly requested review from thubrecht 2024-12-21 17:47:28 +01:00
mdebray reviewed 2024-12-22 00:17:39 +01:00
@ -0,0 +1,75 @@
# SPDX-FileCopyrightText: 2024 Lubin Bailly <lubin.bailly@dgnum.eu>
Owner

Pareil dans /modules (cf ci-dessous)

Pareil dans `/modules` (cf ci-dessous)
lbailly marked this conversation as resolved
@ -0,0 +1,192 @@
# SPDX-FileCopyrightText: 2024 Lubin Bailly <lubin.bailly@dgnum.eu>
Owner

On veut pas mettre ce module dans /modules/nixos ?

On veut pas mettre ce module dans `/modules/nixos` ?
Author
Member

on peut si on veut, je sais pas trop comment on décide de si on le fait ou pas...
je remarque qu'on ne le fait pas pour :

ptet que à terme se serai pas mal de tout bouger

on peut si on veut, je sais pas trop comment on décide de si on le fait ou pas... je remarque qu'on ne le fait pas pour : - [compute01/ds-fr](https://git.dgnum.eu/DGNum/infrastructure/src/branch/main/machines/nixos/compute01/ds-fr) - [compute01/librenms](https://git.dgnum.eu/DGNum/infrastructure/src/branch/main/machines/nixos/compute01/librenms) - [compute01/satosa](https://git.dgnum.eu/DGNum/infrastructure/src/branch/main/machines/nixos/compute01/satosa) - [vault01/k-radius](https://git.dgnum.eu/DGNum/infrastructure/src/branch/main/machines/nixos/vault01/k-radius) - [web01/linkal](https://git.dgnum.eu/DGNum/infrastructure/src/branch/main/machines/nixos/web01/linkal) - [web01/wordpress](https://git.dgnum.eu/DGNum/infrastructure/src/branch/main/machines/nixos/web01/wordpress) ptet que à terme se serai pas mal de tout bouger
lbailly marked this conversation as resolved
lbailly added 1 commit 2024-12-22 01:05:29 +01:00
refactor(extranix): move module declaration and give descriptions
All checks were successful
Check meta / check_dns (pull_request) Successful in 18s
Check meta / check_meta (pull_request) Successful in 26s
Check workflows / check_workflows (pull_request) Successful in 26s
Run pre-commit on all files / pre-commit (push) Successful in 45s
Build all the nodes / ap01 (pull_request) Successful in 1m4s
Build all the nodes / bridge01 (pull_request) Successful in 1m39s
Build all the nodes / geo01 (pull_request) Successful in 1m42s
Build all the nodes / geo02 (pull_request) Successful in 1m37s
Build all the nodes / hypervisor01 (pull_request) Successful in 1m36s
Build all the nodes / netcore02 (pull_request) Successful in 28s
Build all the nodes / hypervisor02 (pull_request) Successful in 1m28s
Build all the nodes / compute01 (pull_request) Successful in 3m10s
Build all the nodes / hypervisor03 (pull_request) Successful in 1m42s
Build all the nodes / rescue01 (pull_request) Successful in 2m3s
Build all the nodes / storage01 (pull_request) Successful in 2m4s
Build all the nodes / vault01 (pull_request) Successful in 1m57s
Build all the nodes / web02 (pull_request) Successful in 1m40s
Run pre-commit on all files / pre-commit (pull_request) Successful in 42s
Build all the nodes / web01 (pull_request) Successful in 2m20s
Build all the nodes / web03 (pull_request) Successful in 1m36s
9e9c2a4fcf
Owner

Nitpick: tu peux renommer search/default.nix en search.nix éventuellement et refaire un peu ton historique si tu veux mais pour moi on est bon

Nitpick: tu peux renommer `search/default.nix` en `search.nix` éventuellement et refaire un peu ton historique si tu veux mais pour moi on est bon
mdebray approved these changes 2024-12-22 11:57:17 +01:00
lbailly force-pushed search-infra from 9e9c2a4fcf to a6b9a4488a 2024-12-22 12:11:09 +01:00 Compare
Author
Member

tu peux renommer search/default.nix en search.nix éventuellement

je suis moyen chaud, le dossier search contient aussi des fichier statique qui sont relatif à ça uniquement

> tu peux renommer `search/default.nix` en `search.nix` éventuellement je suis moyen chaud, le dossier search contient aussi des fichier statique qui sont relatif à ça uniquement
Owner

tu peux renommer search/default.nix en search.nix éventuellement

je suis moyen chaud, le dossier search contient aussi des fichier statique qui sont relatif à ça uniquement

Ah oui désolé. Oublie ducoup

> > tu peux renommer `search/default.nix` en `search.nix` éventuellement > > je suis moyen chaud, le dossier search contient aussi des fichier statique qui sont relatif à ça uniquement Ah oui désolé. Oublie ducoup
thubrecht requested changes 2024-12-22 17:01:56 +01:00
@ -0,0 +1 @@
All rights reserved, unless other license granted.
Owner

Juste all rights reserved

Juste all rights reserved
@ -0,0 +21,4 @@
enable = true;
modules = {
"netconf" = {
paths = [
Owner

mkImports = root: builtins.map (mkImport root);

lib.extra.mkImports est mieux

https://git.dgnum.eu/DGNum/infrastructure/src/commit/383911d6198bfda2ed7d84a1a2c1483338ce2dbe/lib/nix-lib/default.nix#L135 lib.extra.mkImports est mieux
@ -0,0 +28,4 @@
];
path-translations = [
{
base = "${hive-root}";
Owner

Pas besoin d'interpoler, hive-root suffit

Pas besoin d'interpoler, hive-root suffit
@ -0,0 +33,4 @@
}
];
};
"infra DGNum" =
Owner

DGNum Infrastructure

DGNum Infrastructure
@ -0,0 +9,4 @@
...
}:
let
inherit (lib)
Owner

Ce serait bien de trier la liste

Ce serait bien de trier la liste
@ -0,0 +55,4 @@
translations = map (
{ base, url }:
{
url = "${url}${if hasSuffix "/" url then "" else "/"}";
Owner

optionalString

optionalString
@ -0,0 +73,4 @@
++ [
(throw (
"${fullPath} is not in any base path of ${module-name}. Base paths are "
+ concatStringsSep "\n" (map ({ base, ... }: base) translations)
Owner

concatMapStringsSep

concatMapStringsSep
@ -0,0 +182,4 @@
};
};
in
types.attrsOf (types.submodule module-mod);
Owner

Si module-mod est utilisé juste ici, ça sert pas à grand chose de le définir dans un let, et il vaut mieux l'inline. Pareil pour path-mod

Si module-mod est utilisé juste ici, ça sert pas à grand chose de le définir dans un let, et il vaut mieux l'inline. Pareil pour path-mod
All checks were successful
Check meta / check_dns (pull_request) Successful in 19s
Required
Details
Check meta / check_meta (pull_request) Successful in 22s
Required
Details
Check workflows / check_workflows (pull_request) Successful in 29s
Required
Details
Build all the nodes / ap01 (pull_request) Successful in 1m19s
Required
Details
Build all the nodes / bridge01 (pull_request) Successful in 1m52s
Required
Details
Build all the nodes / geo01 (pull_request) Successful in 1m59s
Required
Details
Build all the nodes / geo02 (pull_request) Successful in 1m55s
Required
Details
Build all the nodes / netcore02 (pull_request) Successful in 30s
Required
Details
Build all the nodes / hypervisor01 (pull_request) Successful in 1m52s
Required
Details
Build all the nodes / hypervisor02 (pull_request) Successful in 1m38s
Required
Details
Build all the nodes / compute01 (pull_request) Successful in 3m1s
Required
Details
Build all the nodes / hypervisor03 (pull_request) Successful in 1m43s
Required
Details
Build all the nodes / rescue01 (pull_request) Successful in 2m8s
Required
Details
Build all the nodes / vault01 (pull_request) Successful in 2m4s
Required
Details
Build all the nodes / storage01 (pull_request) Successful in 2m8s
Required
Details
Build all the nodes / web02 (pull_request) Successful in 1m45s
Required
Details
Run pre-commit on all files / pre-commit (pull_request) Successful in 35s
Required
Details
Run pre-commit on all files / pre-commit (push) Successful in 40s
Required
Details
Build all the nodes / web01 (pull_request) Successful in 2m30s
Required
Details
Build all the nodes / web03 (pull_request) Successful in 1m43s
Required
Details
This pull request has changes requested by an official reviewer.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin search-infra:search-infra
git checkout search-infra
Sign in to join this conversation.
No description provided.